Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: swap stage prompts in atomically during prompt-replace migrations
[._.]/ Adam Eivy009d14ebda3c
diff --git a/scripts/migrations/_lib.js b/scripts/migrations/_lib.jsindex 35e1bd93f6..47715512dc 100644--- a/scripts/migrations/_lib.js+++ b/scripts/migrations/_lib.js@@ -129,13 +129,19 @@ const splitReadJsonTolerant = async (path) => {// truncated record would forever load as null. rename() is atomic within one// filesystem, and tmp sits in the same dir as its target, so the swap is safe.// Also used by the provider-seed family, where a truncated `data/providers.json`-// would cost the user every stored apiKey and provider customization.-export const writeJsonAtomic = async (path, value) => {+// would cost the user every stored apiKey and provider customization, and by+// the prompt-replace family: a half-written stage prompt hashes as neither the+// accepted-old nor the shipped body, so the next pass would classify it as+// user-customized and leave the truncated prompt in place forever.+export const writeTextAtomic = async (path, content) => {const tmp = `${path}.tmp-${process.pid}`;- await writeFile(tmp, JSON.stringify(value, null, 2) + '\n');+ await writeFile(tmp, content);await rename(tmp, path);};+export const writeJsonAtomic = (path, value) =>+ writeTextAtomic(path, JSON.stringify(value, null, 2) + '\n');+// Reserved keys a legacy `map`-shape doc can carry as own properties (JSON.parse// surfaces a literal `"__proto__"` key as an own property). They pass a typical// `idPattern`, so a map split must drop them explicitly rather than write a@@ -470,7 +476,7 @@ export async function applyPromptReplaceMigration({const counts = { updated: 0, alreadyCurrent: 0, skipped: 0, created: 0, retired: 0 };for (const plan of plans) {if (plan.unlink) await unlink(plan.unlink);- if (plan.write) await writeFile(plan.write.path, plan.write.content);+ if (plan.write) await writeTextAtomic(plan.write.path, plan.write.content);if (plan.warn) console.warn(plan.warn);if (plan.log) console.log(plan.log);if (plan.counter) counts[plan.counter]++;@@ -563,9 +569,9 @@ export async function readLayoutsDoc({ rootDir, label }) {return { ok: true, doc, path };}-/** Persist a layouts doc with the canonical 2-space indentation. */+/** Persist a layouts doc with the canonical 2-space indentation (no trailing newline, matching the store). */export async function writeLayoutsDoc(path, doc) {- await writeFile(path, JSON.stringify(doc, null, 2));+ await writeTextAtomic(path, JSON.stringify(doc, null, 2));}/**@@ -812,7 +818,7 @@ export function makeBrainSeedMigration({ logTag, entityType, seedIds, seedLabel,continue;}await mkdir(join(perRecordDir, id), { recursive: true });- await writeFile(recordPath, JSON.stringify(seedRecords[id], null, 2) + '\n');+ await writeJsonAtomic(recordPath, seedRecords[id]);added += 1;}@@ -833,7 +839,7 @@ export function makeBrainSeedMigration({ logTag, entityType, seedIds, seedLabel,live.records[id] = seedRecords[id];legacyAdded += 1;}- if (legacyAdded > 0) await writeFile(legacyPath, JSON.stringify(live, null, 2) + '\n');+ if (legacyAdded > 0) await writeJsonAtomic(legacyPath, live);}if (added === 0 && legacyAdded === 0) {diff --git a/scripts/migrations/_lib.test.js b/scripts/migrations/_lib.test.jsindex d8fe47ee45..e95ec669d4 100644--- a/scripts/migrations/_lib.test.js+++ b/scripts/migrations/_lib.test.js@@ -17,7 +17,7 @@* frozen migrations being rewritten to consume it.*/import { describe, it, expect, beforeEach, afterEach } from 'vitest';-import { mkdtempSync, rmSync, writeFileSync, readFileSync, mkdirSync, existsSync } from 'fs';+import { mkdtempSync, rmSync, writeFileSync, readFileSync, readdirSync, mkdirSync, existsSync, statSync } from 'fs';import { tmpdir } from 'os';import { join } from 'path';@@ -146,6 +146,26 @@ describe('applyPromptReplaceMigration opt-ins', () => {expect(readFileSync(join(stagesDir, 'pipeline-c.md'), 'utf-8')).toBe(BODY_CUSTOM);});+ it('replaces an updated prompt by temp-file rename rather than truncating it in place', async () => {+ // A crash mid-write of an in-place `writeFile` leaves a half-written+ // prompt whose hash matches neither table, so the next pass would call+ // it "customized" and keep the truncated body forever. A rename swap+ // lands a fresh inode, so the pre-existing file either survives whole or+ // is replaced whole — observable as an inode change with no temp file+ // left behind.+ const target = join(stagesDir, 'pipeline-a.md');+ writeFileSync(target, BODY_OLD);+ writeFileSync(join(sampleDir, 'pipeline-a.md'), BODY_NEW);+ const inodeBefore = statSync(target).ino;++ const result = await applyPromptReplaceMigration({ rootDir, ...multiOpts });++ expect(result.updated).toBe(1);+ expect(readFileSync(target, 'utf-8')).toBe(BODY_NEW);+ expect(statSync(target).ino).not.toBe(inodeBefore);+ expect(readdirSync(stagesDir)).toEqual(['pipeline-a.md']);+ });+it('updates every file when all are at the accepted-old hash', async () => {for (const name of NAMES) {writeFileSync(join(stagesDir, name), BODY_OLD);