Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: don't pass the attempt index as the Chrome startup timeout (#12475)

[._.]/ Adam Eivy029ed9476919
diff --git a/server/services/htmlComposition/testBrowserCleanup.js b/server/services/htmlComposition/testBrowserCleanup.js
index 184a1daa75..fa5b1e9e8b 100644
--- a/server/services/htmlComposition/testBrowserCleanup.js
+++ b/server/services/htmlComposition/testBrowserCleanup.js
@@ -329,7 +329,7 @@ export async function _startTestChromeWithRetry({ launch, discard, onProc = () =
const proc = launch(attempt);
onProc(proc);
try {
- return await wait(proc, attempt);
+ return await wait(proc);
} catch (error) {
if (attempt + 1 >= attempts || !/^Test Chrome did not start within/.test(error?.message)) throw error;
await discard(proc);
diff --git a/server/services/htmlComposition/testBrowserCleanup.test.js b/server/services/htmlComposition/testBrowserCleanup.test.js
index 6b073e89db..665f357936 100644
--- a/server/services/htmlComposition/testBrowserCleanup.test.js
+++ b/server/services/htmlComposition/testBrowserCleanup.test.js
@@ -903,7 +903,7 @@ describe('test Chrome startup retry', () => {
it('retries a startup timeout once on a fresh child and discards the abandoned one', async () => {
const procs = [];
const discard = vi.fn(async () => {});
- const wait = vi.fn(async (proc, attempt) => { if (attempt === 0) throw timeout(); return 'ws://127.0.0.1:1/devtools/browser/example'; });
+ const wait = vi.fn(async proc => { if (proc.attempt === 0) throw timeout(); return 'ws://127.0.0.1:1/devtools/browser/example'; });
const ws = await _startTestChromeWithRetry({ launch: attempt => ({ attempt }), onProc: proc => procs.push(proc), wait, discard });
expect(ws).toBe('ws://127.0.0.1:1/devtools/browser/example');
expect(procs).toEqual([{ attempt: 0 }, { attempt: 1 }]);