Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Give offset-only shots live-preview timing too (#11406)

Adam Eivy067a6c5f9e86
diff --git a/server/services/musicVideo/documentRender.js b/server/services/musicVideo/documentRender.js
index 3dc2adef4e..2a3813eda2 100644
--- a/server/services/musicVideo/documentRender.js
+++ b/server/services/musicVideo/documentRender.js
@@ -162,7 +162,7 @@ export async function resolveSceneMedia(project, { history = [], probe = async (
ext,
inSec: round3(originalIn),
outSec: originalOut == null ? null : round3(originalOut),
- ...(retime ? { timing: { rate, leadSec: round3(leadSec), startSec: round3(sourceIn) } } : {}),
+ ...(retime || sourceIn !== originalIn ? { timing: { rate, leadSec: round3(leadSec), startSec: round3(sourceIn) } } : {}),
fps: finite(measured.fps),
width: finite(measured.width),
height: finite(measured.height),
diff --git a/server/services/musicVideo/documentRender.test.js b/server/services/musicVideo/documentRender.test.js
index f3466df5e5..b7ec079ef4 100644
--- a/server/services/musicVideo/documentRender.test.js
+++ b/server/services/musicVideo/documentRender.test.js
@@ -171,6 +171,15 @@ describe('composition document staging', () => {
expect(raw.get('a').timing).toBeUndefined();
});
+ it('gives the live preview timing for an offset-only shot', async () => {
+ const { project } = await fixture();
+ Object.assign(project.scenes[0], { offsetFrames: 12 });
+ Object.assign(project.scenes[3], { offsetFrames: -6 });
+ const raw = await resolveSceneMedia(project, { history: JSON.parse(await readFile(join(PATHS.data, 'video-history.json'), 'utf8')) });
+ expect(raw.get('a').timing).toEqual({ rate: 1, leadSec: 0, startSec: 0.5 });
+ expect(raw.get(project.scenes[3].sceneId).timing).toEqual({ rate: 1, leadSec: 0, startSec: 0.25 });
+ });
+
it('fails before opening the page and cleans scratch when shot retiming fails', async () => {
const { project, plan } = await fixture();
project.scenes[0].speedFps = 24;