Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: preserve GitHub account trust settings on edit (#13236)

Adam Eivy16d7e488d84b
diff --git a/client/src/components/github/GitHubAccountsTab.jsx b/client/src/components/github/GitHubAccountsTab.jsx
index c2a32a9f9b..555ffa8aad 100644
--- a/client/src/components/github/GitHubAccountsTab.jsx
+++ b/client/src/components/github/GitHubAccountsTab.jsx
@@ -54,8 +54,8 @@ const payloadFromForm = (form) => ({
login: form.login.trim() || null,
label: form.label.trim(),
trust: form.trust,
- allowedProviders: form.trust === 'private' && form.allowedProviders.length ? form.allowedProviders : null,
- allowAgents: form.trust === 'private' && form.allowAgents,
+ allowedProviders: form.allowedProviders.length ? form.allowedProviders : null,
+ allowAgents: form.allowAgents,
trustInstanceUsers: isEnterpriseHost(form.host) && form.trustInstanceUsers,
});
diff --git a/client/src/pages/GitHub.test.jsx b/client/src/pages/GitHub.test.jsx
index 1e7a5e9b17..c7d39d0550 100644
--- a/client/src/pages/GitHub.test.jsx
+++ b/client/src/pages/GitHub.test.jsx
@@ -347,6 +347,27 @@ describe('GitHub accounts tab', () => {
await waitFor(() => expect(mock.updateGitHubAccount).toHaveBeenCalledWith('github-com', expect.objectContaining({ trust: 'private', allowAgents: true })));
});
+ it('preserves agent access when editing a Public account label', async () => {
+ mock.getGitHubAccounts.mockResolvedValue([{ ...IMPLICIT, allowAgents: true }]);
+ mock.updateGitHubAccount.mockImplementation(async (id, body) => ({ ...IMPLICIT, ...body, id }));
+ renderAccounts();
+ fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
+ fireEvent.change(screen.getByPlaceholderText('Shown on the account card'), { target: { value: 'Work account' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+ await waitFor(() => expect(mock.updateGitHubAccount).toHaveBeenCalledWith('github-com', expect.objectContaining({ trust: 'public', label: 'Work account', allowAgents: true })));
+ });
+
+ it('preserves provider access across Private, Public, and Private trust edits', async () => {
+ mock.getGitHubAccounts.mockResolvedValue([{ ...IMPLICIT, trust: 'private', allowedProviders: ['cloud-api'] }]);
+ mock.updateGitHubAccount.mockImplementation(async (id, body) => ({ ...IMPLICIT, ...body, id }));
+ renderAccounts();
+ fireEvent.click(await screen.findByRole('button', { name: 'Edit' }));
+ fireEvent.change(screen.getByLabelText('Trust'), { target: { value: 'public' } });
+ fireEvent.change(screen.getByLabelText('Trust'), { target: { value: 'private' } });
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
+ await waitFor(() => expect(mock.updateGitHubAccount).toHaveBeenCalledWith('github-com', expect.objectContaining({ trust: 'private', allowedProviders: ['cloud-api'] })));
+ });
+
it('lists each account with its trust level and live sign-in state', async () => {
renderAccounts();
expect(await screen.findByText('Signed in')).toBeTruthy();