Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix([issue-12656]): separate a stalled composition load from a silent renderer

[._.]/ Adam Eivy18e60e18317b
diff --git a/server/services/htmlComposition/browser.js b/server/services/htmlComposition/browser.js
index 25717d1a86..3623a499ab 100644
--- a/server/services/htmlComposition/browser.js
+++ b/server/services/htmlComposition/browser.js
@@ -67,6 +67,9 @@ const LIFECYCLE_EVENTS = new Set([
'Target.detachedFromTarget', 'Target.targetCrashed', 'Target.targetDestroyed', 'Inspector.detached', 'Inspector.targetCrashed',
]);
+// Under the 30s per-command timer; see the document-load wait in connectComposition.
+const DOCUMENT_LOAD_DEADLINE_MS = 27000;
+
// One browser-level socket owns a disposable context and its hidden target.
// Disconnect/abort rejects pending commands; disposeOnDetach covers crashes.
// `bytes=a-b` / `bytes=a-` / `bytes=-n` against `size`; null when absent or unsatisfiable.
@@ -435,7 +438,18 @@ async function connectComposition(assets, {
phase = 'navigate';
const navigation = await send('Page.navigate', { url: `${ORIGIN}/index.html` });
if (navigation.errorText) throw new Error(`Composition navigation failed: ${navigation.errorText}`);
- await evaluate(`new Promise(resolve => document.readyState === 'complete' ? resolve() : addEventListener('load', resolve, { once: true }))`, 'document load');
+ phase = 'document-load';
+ // The page-side deadline sits under the 30s command timer so the two
+ // failures separate (#12656): a command timeout means the renderer stopped
+ // answering (host starvation or a hung target); this stall means the page
+ // answered but its load event never came, which is a lifecycle fault.
+ const loaded = await evaluate(`new Promise(resolve => {
+ if (document.readyState === 'complete') return resolve('loaded');
+ addEventListener('load', () => resolve('loaded'), { once: true });
+ setTimeout(() => resolve('stalled:' + document.readyState), ${DOCUMENT_LOAD_DEADLINE_MS});
+ })`, 'document load');
+ if (loaded !== 'loaded') throw new Error(`Composition document load stalled: ${loaded.slice('stalled:'.length)} after ${DOCUMENT_LOAD_DEADLINE_MS}ms while the page stayed responsive (${commandFacts(sinceStart())})`);
+ phase = 'font-readiness';
await evaluate('document.fonts.ready.then(() => true)', 'font readiness');
phase = 'ready';
return { evaluate, send, close, check: () => { signal?.throwIfAborted(); if (failure) throw failure; } };
diff --git a/server/services/htmlComposition/browser.setupDiagnostics.test.js b/server/services/htmlComposition/browser.setupDiagnostics.test.js
index 303faedd8c..2563400c69 100644
--- a/server/services/htmlComposition/browser.setupDiagnostics.test.js
+++ b/server/services/htmlComposition/browser.setupDiagnostics.test.js
@@ -31,7 +31,7 @@ const REPLIES = {
};
// Answers browser-level setup, then leaves `stallOn` pending forever.
-function scriptedTransport(stallOn) {
+function scriptedTransport(stallOn, replies = {}) {
const emitter = new EventEmitter();
let stalled;
owner.sent = new Promise(resolve => { stalled = resolve; });
@@ -41,7 +41,7 @@ function scriptedTransport(stallOn) {
callback?.();
const { id, method } = JSON.parse(text);
if (method === stallOn) return stalled();
- setImmediate(() => emitter.emit('message', Buffer.from(JSON.stringify({ id, result: REPLIES[method] ?? {} }))));
+ setImmediate(() => emitter.emit('message', Buffer.from(JSON.stringify({ id, result: replies[method] ?? REPLIES[method] ?? {} }))));
},
terminate() { this.readyState = 3; },
on: emitter.on.bind(emitter),
@@ -78,4 +78,35 @@ describe('composition CDP setup timeout evidence', () => {
expect(error.message).not.toContain('session-example');
expect(owner.order).toEqual(['facts', 'close']);
});
+
+ // Starvation vs a missed lifecycle event (#12656): the two must not read alike.
+ async function openStagedComposition(name, transport) {
+ const directory = `compositions/${name}`;
+ await mkdir(join(PATHS.data, directory), { recursive: true });
+ await writeFile(join(PATHS.data, directory, 'index.html'), '<html><body></body></html>');
+ owner.transport = transport;
+ return { directory };
+ }
+
+ it('names document-load when the renderer stops answering the load wait', async () => {
+ const { directory } = await openStagedComposition('load-silent', scriptedTransport('Runtime.evaluate'));
+ vi.useFakeTimers({ toFake: ['setTimeout', 'clearTimeout'] });
+
+ const opened = openComposition(directory, { ownedBrowser: true }).catch(error => error);
+ await owner.sent;
+ await vi.advanceTimersByTimeAsync(30000);
+ const error = await opened;
+
+ expect(error.message).toMatch(/^Composition document load failed after \d+ms: Browser command timed out: Runtime\.evaluate \(/);
+ expect(error.message).toContain('phase=document-load');
+ });
+
+ it('reports a load that never completed while the page stayed responsive as a stall, not a command timeout', async () => {
+ const { directory } = await openStagedComposition('load-stalled', scriptedTransport(null, { 'Runtime.evaluate': { result: { value: 'stalled:loading' } } }));
+
+ const error = await openComposition(directory, { ownedBrowser: true }).catch(failure => failure);
+
+ expect(error.message).toMatch(/^Composition document load stalled: loading after \d+ms while the page stayed responsive \(phase=document-load,/);
+ expect(error.message).not.toContain('Browser command timed out');
+ });
});