Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: make Add Peer controls 44px touch targets on phones (#13118)

Adam Eivy21520833c240
diff --git a/client/src/pages/Instances.jsx b/client/src/pages/Instances.jsx
index b84af4a9d3..82046261c2 100644
--- a/client/src/pages/Instances.jsx
+++ b/client/src/pages/Instances.jsx
@@ -306,7 +306,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
aria-pressed={mode === 'classic'}
disabled={adding || serveBusy}
onClick={() => setMode('classic')}
- className={`text-xs px-2.5 py-1 rounded border transition-colors ${mode === 'classic' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
+ className={`text-xs px-2.5 py-1 min-h-11 rounded border transition-colors ${mode === 'classic' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
>
Host / port
</button>
@@ -315,7 +315,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
aria-pressed={mode === 'tailcat'}
disabled={adding || serveBusy}
onClick={() => setMode('tailcat')}
- className={`text-xs px-2.5 py-1 rounded border transition-colors ${mode === 'tailcat' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
+ className={`text-xs px-2.5 py-1 min-h-11 rounded border transition-colors ${mode === 'tailcat' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
>
Tailcat
</button>
@@ -327,7 +327,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
aria-pressed={dialDirection === 'dial-them'}
disabled={adding || serveBusy}
onClick={() => setDialDirection('dial-them')}
- className={`text-xs px-2.5 py-1 rounded border transition-colors ${dialDirection === 'dial-them' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
+ className={`text-xs px-2.5 py-1 min-h-11 rounded border transition-colors ${dialDirection === 'dial-them' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
>
Dial them
</button>
@@ -336,7 +336,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
aria-pressed={dialDirection === 'they-dial-us'}
disabled={adding || serveBusy}
onClick={() => setDialDirection('they-dial-us')}
- className={`text-xs px-2.5 py-1 rounded border transition-colors ${dialDirection === 'they-dial-us' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
+ className={`text-xs px-2.5 py-1 min-h-11 rounded border transition-colors ${dialDirection === 'they-dial-us' ? 'border-port-accent text-white bg-port-accent/20' : 'border-port-border text-gray-500 hover:text-gray-300'}`}
>
They dial us
</button>
@@ -351,23 +351,23 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
onChange={e => setTcAddress(e.target.value)}
placeholder="tcEXAMPLE…"
required
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[200px] font-mono"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[200px] font-mono"
/>
<input type="number" aria-label="Remote Tailcat port" min="1" max="65535" required
value={tailcatRemotePort} onChange={(event) => setTailcatRemotePort(event.target.value)}
title="Use the port shown beside the remote serve address; older manually served peers may use 5555"
- className="w-24 bg-port-bg border border-port-border rounded px-3 py-2 text-sm" />
+ className="w-24 bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm" />
<input
aria-label="Peer name"
value={name}
onChange={e => setName(e.target.value)}
placeholder="Name (optional)"
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
/>
<button
type="submit"
disabled={adding || !canSubmit}
- className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 rounded text-sm font-medium transition-colors"
+ className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 min-h-11 rounded text-sm font-medium transition-colors"
>
{adding ? 'Connecting...' : 'Add via tailcat'}
</button>
@@ -386,7 +386,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
type="button"
disabled={serveBusy || serveStatus?.live}
onClick={ensureOurServe}
- className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 rounded text-sm font-medium transition-colors"
+ className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 min-h-11 rounded text-sm font-medium transition-colors"
>
{serveBusy ? 'Starting...' : (serveStatus?.live ? 'Serve running' : 'Start serve')}
</button>
@@ -404,7 +404,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
placeholder="100.64.x.x"
pattern="^((25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}(25[0-5]|2[0-4]\d|[01]?\d\d?)$"
required
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[140px]"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[140px]"
/>
<input
aria-label="Peer port"
@@ -414,19 +414,19 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
type="number"
min="1"
max="65535"
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent w-20"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent w-20"
/>
<input
aria-label="Peer name"
value={name}
onChange={e => setName(e.target.value)}
placeholder="Name (optional)"
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
/>
<button
type="submit"
disabled={adding || !canSubmit}
- className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 rounded text-sm font-medium transition-colors"
+ className="bg-port-accent hover:bg-port-accent/80 disabled:opacity-50 text-white px-4 py-2 min-h-11 rounded text-sm font-medium transition-colors"
>
{adding ? 'Adding...' : 'Add'}
</button>
@@ -434,7 +434,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
)}
{mode === 'tailcat' && dialDirection === 'dial-them' && (
<>
- <label htmlFor="tailcat-https" className="flex items-center gap-2 text-sm text-gray-400 mt-3">
+ <label htmlFor="tailcat-https" className="flex items-center gap-2 min-h-11 text-sm text-gray-400 mt-3">
<input id="tailcat-https" type="checkbox" checked={tailcatHttps}
onChange={e => setTailcatHttps(e.target.checked)} disabled={adding} />
Remote PortOS uses HTTPS
@@ -451,7 +451,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
<button
type="button"
onClick={() => setShowAuth(v => !v)}
- className="inline-flex items-center gap-1 text-[11px] text-gray-500 hover:text-gray-300 transition-colors"
+ className="inline-flex items-center gap-1 min-h-11 text-[11px] text-gray-500 hover:text-gray-300 transition-colors"
>
<Lock size={11} />
{showAuth ? 'Hide credentials' : 'Add credentials (peer behind an auth proxy)'}
@@ -464,7 +464,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
onChange={e => setUsername(e.target.value)}
placeholder="Username (optional)"
autoComplete="off"
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
/>
<input
aria-label="Peer password"
@@ -473,7 +473,7 @@ export function AddPeerForm({ onAdd, addressRef, drawer }) {
placeholder="Password"
type="password"
autoComplete="new-password"
- className="bg-port-bg border border-port-border rounded px-3 py-2 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
+ className="bg-port-bg border border-port-border rounded px-3 py-2 min-h-11 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent flex-1 min-w-[120px]"
/>
</div>
)}
diff --git a/client/src/pages/Instances.test.jsx b/client/src/pages/Instances.test.jsx
index 133845a93e..074b7e8720 100644
--- a/client/src/pages/Instances.test.jsx
+++ b/client/src/pages/Instances.test.jsx
@@ -119,6 +119,38 @@ describe('AddPeerForm tailcat path', () => {
});
});
+// Regression: on a phone the mode toggles, fields, disclosure and submit measured
+// 17-38px high. jsdom has no layout, so pin the 44px touch floor (`min-h-11`) on
+// every interactive control in each mode instead of a pixel measurement.
+describe('AddPeerForm touch targets', () => {
+ beforeEach(() => {
+ vi.clearAllMocks();
+ getTailcatServe.mockResolvedValue({
+ enabled: false, status: 'stopped', live: false, localPort: 5555,
+ keyName: 'portos-api', tcAddress: null, tcAddressRedacted: null, hasAddress: false,
+ });
+ });
+
+ it.each([
+ ['classic host/port', () => {}],
+ ['tailcat dial them', () => fireEvent.click(screen.getByRole('button', { name: 'Tailcat' }))],
+ ['tailcat they dial us', () => {
+ fireEvent.click(screen.getByRole('button', { name: 'Tailcat' }));
+ fireEvent.click(screen.getByRole('button', { name: 'They dial us' }));
+ }],
+ ])('gives every interactive Add Peer control a 44px touch height in %s mode', async (_label, selectMode) => {
+ const { container } = render(<AddPeerForm onAdd={() => {}} />);
+ selectMode();
+ fireEvent.click(screen.getByRole('button', { name: /Add credentials|Hide credentials/ }));
+ await waitFor(() => expect(getTailcatServe).toHaveBeenCalled());
+ const controls = [...container.querySelectorAll('form button, form input:not([type="checkbox"]), form label')];
+ expect(controls.length).toBeGreaterThan(0);
+ for (const control of controls) {
+ expect(control.className, control.outerHTML.slice(0, 120)).toMatch(/\bmin-h-11\b/);
+ }
+ });
+});
+
describe('AddPeerForm dial direction', () => {
beforeEach(() => {
vi.clearAllMocks();