Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: consolidate duplicate configure buttons on schedule task cards (#10934)
Adam Eivy22391579e1cb
diff --git a/client/src/components/cos/tabs/schedule/AppTaskCard.jsx b/client/src/components/cos/tabs/schedule/AppTaskCard.jsxindex 41b485f1ad..d28876d412 100644--- a/client/src/components/cos/tabs/schedule/AppTaskCard.jsx+++ b/client/src/components/cos/tabs/schedule/AppTaskCard.jsx@@ -48,9 +48,12 @@ export default function AppTaskCard({ taskType, config, apps, onTrigger, onConfi{/* `flex flex-col items-stretch` is load-bearing: a stretched <button> centers itscontent box vertically, which floats a short card's body to the middle of thecard and breaks the top alignment across a row. */}+ {/* The card body is the single configure affordance (a native button, so it stays+ keyboard-operable). The app-scoped variant also exposes its expanded state here. */}<buttontype="button"onClick={() => onConfigure(taskType)}+ aria-expanded={appContext ? appContext.expanded : undefined}className="flex-1 flex flex-col items-stretch gap-3 text-left p-4 rounded-t-lg hover:bg-port-card/60 transition-colors"><TaskHeader taskType={taskType} config={displayConfig} orderStep={orderStep} />@@ -121,14 +124,10 @@ export default function AppTaskCard({ taskType, config, apps, onTrigger, onConfi{/* Quick model pins — the drawer's Global defaults, inline */}{!appContext && userInvokable && onUpdate && (stageCount > 0 ? (- <button- type="button"- onClick={() => onConfigure(taskType)}- className="flex items-center gap-1.5 px-4 py-2.5 text-xs text-left text-gray-500 border-t border-port-border hover:text-gray-300 transition-colors"- >+ <div className="flex items-center gap-1.5 px-4 py-2.5 text-xs text-gray-500 border-t border-port-border"><GitMerge size={12} className="shrink-0" />- Provider/model is set per stage ({stageCount}) — configure- </button>+ Provider/model is set per stage ({stageCount})+ </div>) : (<TaskModelQuickControls pins={pins} providers={providers} loading={!providersLoaded} />))}@@ -145,16 +144,18 @@ export default function AppTaskCard({ taskType, config, apps, onTrigger, onConfiprogrammatic={config.programmatic}disabledReason={appContext?.saving ? SAVING_TITLE : appContext && !appContext.enabled ? 'Enable this task for this app first' : improvementDisabled ? IMPROVEMENT_DISABLED_TITLE : (pins.saving ? SAVING_TITLE : '')}/>- <button- type="button"- onClick={() => onConfigure(taskType)}- aria-expanded={appContext?.expanded}- aria-label={appContext ? `${appContext.expanded ? 'Hide' : 'Show'} provider and model options for ${taskType}` : undefined}- className="ml-auto flex items-center gap-1.5 px-3 py-1.5 text-sm rounded text-gray-300 hover:text-white hover:bg-port-border/50 transition-colors"- >- <SlidersHorizontal size={13} />- Configure- </button>+ {appContext && (+ <button+ type="button"+ onClick={() => onConfigure(taskType)}+ aria-expanded={appContext.expanded}+ aria-label={`${appContext.expanded ? 'Hide' : 'Show'} provider and model options for ${taskType}`}+ className="ml-auto flex items-center gap-1.5 px-3 py-1.5 text-sm rounded text-gray-300 hover:text-white hover:bg-port-border/50 transition-colors"+ >+ <SlidersHorizontal size={13} />+ Configure+ </button>+ )}</>) : (<span className="text-xs text-port-warning/80" title={invocationDescription}>diff --git a/client/src/components/cos/tabs/schedule/AppTaskCard.test.jsx b/client/src/components/cos/tabs/schedule/AppTaskCard.test.jsxindex 7fb24d19a4..2278677f9a 100644--- a/client/src/components/cos/tabs/schedule/AppTaskCard.test.jsx+++ b/client/src/components/cos/tabs/schedule/AppTaskCard.test.jsx@@ -145,8 +145,15 @@ describe('AppTaskCard', () => {it('fires a global on-demand run when the task has no managed apps', () => {const { onTrigger, onConfigure } = renderCard();fireEvent.click(screen.getByRole('button', { name: /Run Now/i }));- fireEvent.click(screen.getByRole('button', { name: /Configure/ }));expect(onTrigger).toHaveBeenCalledWith('code-review');+ expect(onConfigure).not.toHaveBeenCalled();+ });++ it('opens the drawer from the card body, which is the only configure control', () => {+ const { onConfigure } = renderCard();+ expect(screen.queryByRole('button', { name: /Configure/ })).not.toBeInTheDocument();+ // The body is a native button, so it stays keyboard-operable.+ fireEvent.click(screen.getByText('App coverage').closest('button'));expect(onConfigure).toHaveBeenCalledWith('code-review');});@@ -290,12 +297,14 @@ describe('AppTaskCard', () => {await waitFor(() => expect(screen.getByLabelText('Model').value).toBe('opus'));});- it('points pipeline tasks at the drawer instead of a card-level pin', () => {+ it('shows pipeline stage count as text and leaves configuring to the card body', () => {const { onConfigure } = renderCardWithPins({taskMetadata: { pipeline: { stages: [{ name: 'plan' }, { name: 'build' }] } },});expect(screen.queryByLabelText('Provider')).toBeNull();- fireEvent.click(screen.getByRole('button', { name: /set per stage \(2\)/ }));+ expect(screen.getByText('Provider/model is set per stage (2)')).toBeTruthy();+ expect(screen.queryByRole('button', { name: /per stage/ })).toBeNull();+ fireEvent.click(screen.getByText('App coverage').closest('button'));expect(onConfigure).toHaveBeenCalledWith('code-review');});});