Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: verify retry ownership during recovered outcome finalization

Adam Eivy2696148f70d2
diff --git a/server/services/agentFinalization.retireDeadAgent.test.js b/server/services/agentFinalization.retireDeadAgent.test.js
index d624057ae2..fccaa38b9c 100644
--- a/server/services/agentFinalization.retireDeadAgent.test.js
+++ b/server/services/agentFinalization.retireDeadAgent.test.js
@@ -38,7 +38,8 @@ vi.mock('./taskTypeHooks.js', () => ({
// output-hook suite which forces null to isolate its own dispatch cases.
resolveTaskHookType: vi.fn(task => task?.metadata?.analysisType || task?.metadata?.taskAnalysisType || task?.taskType || null),
}));
-vi.mock('./agentErrorAnalysis.js', () => ({ resolveFailedTaskUpdate: vi.fn(), resolveTypeFailureSignal: vi.fn() }));
+vi.mock('./agentErrorAnalysis.js', async importOriginal => ({ ...(await importOriginal()), resolveFailedTaskUpdate: vi.fn(), resolveTypeFailureSignal: vi.fn() }));
+vi.mock('./agentWorktreeCleanup.js', () => ({ releaseRetryHold: vi.fn(async () => ({})) }));
vi.mock('./agentCompletion.js', () => ({ processAgentCompletion: vi.fn(async () => null) }));
vi.mock('./investigationTaskProducer.js', () => ({
investigationCircuitOpen: vi.fn(() => false),
@@ -55,6 +56,7 @@ vi.mock('./codeReview.js', async (importOriginal) => ({
getGoalFidelityConfig: vi.fn(async () => null),
}));
+import { releaseRetryHold } from './agentWorktreeCleanup.js';
import { completeAgent } from './cosAgentLifecycle.js';
import { updateTask } from './cosTaskStore.js';
import { mkdtemp, writeFile, rm } from 'node:fs/promises';
@@ -109,20 +111,21 @@ describe('retireDeadAgent (#8440)', () => {
});
});
- it.each(['blocked', 'incomplete'])('preserves a recovered %s sentinel and parks its task before removing evidence', async status => {
+ it.each(['blocked', 'incomplete'])('preserves a recovered %s sentinel and holds its retry until evidence is removed', async status => {
const workspacePath = await mkdtemp(join(tmpdir(), 'recovered-outcome-'));
const taskOutcome = { status, reason: 'Invented prerequisite remains unmet.' };
const order = [];
updateTask.mockImplementationOnce(async () => { order.push('task'); return {}; });
removeCompletionSentinel.mockImplementationOnce(async () => { order.push('remove'); });
+ releaseRetryHold.mockImplementationOnce(async () => { order.push('release'); });
try {
await writeFile(join(workspacePath, '.agent-done-agent-dead'), JSON.stringify({ taskOutcome }));
const result = await retireDeadAgent({ agent: { ...AGENT, metadata: { workspacePath, runId: 'run-1' } },
task: TASK, success: true, exitCode: 0, duration: 100 });
expect(result).toEqual({ success: false, taskOutcome, deliveryHeld: true });
expect(completeAgent).toHaveBeenCalledWith(AGENT.id, expect.objectContaining({ success: false, executionSuccess: true, taskOutcome }));
- expect(updateTask).toHaveBeenCalledWith(TASK.id, expect.objectContaining({ status: 'blocked', metadata: expect.objectContaining({ taskOutcome }) }), 'user');
- expect(order).toEqual(['task', 'remove']);
+ expect(updateTask).toHaveBeenCalledWith(TASK.id, expect.objectContaining({ status: 'in_progress', metadata: expect.objectContaining({ taskOutcome, retryPendingCleanup: AGENT.id, failureCount: 1 }) }), 'user');
+ expect(order).toEqual(['task', 'remove', 'release']);
} finally { await rm(workspacePath, { recursive: true, force: true }); }
});