Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix([issue-12536]): keep unobserved command closure unavailable

[._.]/ Adam Eivy299c3b7855b2
diff --git a/scripts/run-ci-tests.js b/scripts/run-ci-tests.js
index c13f2045c5..7f22f0a0ee 100644
--- a/scripts/run-ci-tests.js
+++ b/scripts/run-ci-tests.js
@@ -322,6 +322,7 @@ function runNpmWithReport(scope, script, extraArgs, reportPath, env, abortSignal
// A spawn error also emits close. Settle only there, after the pipes close.
child.on('error', (error) => { spawnError = error; });
let childExit = null;
+ let childClose = null;
child.on('exit', (code, signal) => { childExit = { code, signal }; });
const finish = (code, signal) => {
if (settled) return;
@@ -338,7 +339,7 @@ function runNpmWithReport(scope, script, extraArgs, reportPath, env, abortSignal
abortSignal?.removeEventListener('abort', onAbort);
const status = interrupted ? (interrupted === 'SIGINT' ? 130 : 143) : code ?? 1;
persistTestDiagnostic(invocationPath, { ...invocation, completed: !cleanupUnverified, status, signal: signal ?? interrupted ?? null,
- childExit, childClose: { code, signal } });
+ childExit, childClose });
if (status !== 0) {
console.error(`Test launcher exited: code=${code}, signal=${signal ?? 'none'}${interrupted ? `, interrupted=${interrupted}` : ''}`);
console.error(structuredFailureDiagnostics(reportPath, runReportPath));
@@ -349,7 +350,10 @@ function runNpmWithReport(scope, script, extraArgs, reportPath, env, abortSignal
resolve({ status, output, ...(interrupted ? { interrupted } : {}), ...(spawnError ? { error: spawnError } : {}),
...(cleanupUnverified ? { cleanupUnverified: true } : {}) });
};
- child.on('close', finish);
+ child.on('close', (code, signal) => {
+ childClose = { code, signal };
+ finish(code, signal);
+ });
});
}
diff --git a/scripts/run-ci-tests.test.js b/scripts/run-ci-tests.test.js
index 10c843012c..11847d9df7 100644
--- a/scripts/run-ci-tests.test.js
+++ b/scripts/run-ci-tests.test.js
@@ -721,7 +721,7 @@ describe('report launcher subprocess lifecycle (#9804)', () => {
expect(result.error.message).toContain('cleanup unverified');
expect(result.diagnosticsPath).toBe(join(host, readdirSync(host)[0]));
expect(JSON.parse(readFileSync(join(result.diagnosticsPath, 'invocation.json'), 'utf8')))
- .toMatchObject({ completed: false, status: 143, signal: 'SIGTERM' });
+ .toMatchObject({ completed: false, status: 143, signal: 'SIGTERM', childExit: null, childClose: null });
expect(errors).toHaveBeenCalledWith(expect.stringContaining(result.diagnosticsPath));
} finally {
vi.useRealTimers();