Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: log agent directory removal failures in deleteAgent (#11446)
[._.]/ Adam Eivy309194d09404
diff --git a/server/services/cosAgentLifecycle.js b/server/services/cosAgentLifecycle.jsindex 7ee3fff95a..2f64f7bb5c 100644--- a/server/services/cosAgentLifecycle.js+++ b/server/services/cosAgentLifecycle.js@@ -808,7 +808,7 @@ export async function deleteAgent(agentId) {try { await saveAgentIndex(); }catch (err) { if (inIndex) idx.set(agentId, previousDate); throw err; }if (existsSync(agentDir)) {- await rm(agentDir, { recursive: true }).catch(() => {});+ await rm(agentDir, { recursive: true }).catch(err => console.error(`❌ Failed to remove agent ${agentId} directory: ${err.message}`));}cosEvents.emit('agents:changed', { action: 'deleted', agentId });diff --git a/server/services/cosAgentLifecycle.test.js b/server/services/cosAgentLifecycle.test.jsindex 90a7b7a55a..623e536d0b 100644--- a/server/services/cosAgentLifecycle.test.js+++ b/server/services/cosAgentLifecycle.test.js@@ -32,7 +32,7 @@ vi.mock('./domainUsage.js', () => ({// archive's cross-filesystem fallback AND a failure partway through its copy.// Scoped to paths inside a `YYYY-MM-DD` bucket so the flat-dir writes that// precede the move still succeed. Off for every other test in this file.-const fsFailures = vi.hoisted(() => ({ dateBucketWritesFail: false }));+const fsFailures = vi.hoisted(() => ({ dateBucketWritesFail: false, rmFailsFor: null }));vi.mock('fs/promises', async (importOriginal) => {const actual = await importOriginal();@@ -47,6 +47,14 @@ vi.mock('fs/promises', async (importOriginal) => {if (failsFor(to)) throw Object.assign(new Error('EXDEV: cross-device link'), { code: 'EXDEV' });return actual.rename(from, to, ...rest);},+ // Opt-in: rm of any path containing `fsFailures.rmFailsFor` rejects (EBUSY),+ // so deleteAgent's directory cleanup failure can be observed.+ rm: async (target, ...rest) => {+ if (fsFailures.rmFailsFor && String(target).includes(fsFailures.rmFailsFor)) {+ throw Object.assign(new Error('EBUSY: resource busy or locked'), { code: 'EBUSY' });+ }+ return actual.rm(target, ...rest);+ },// The archive fallback copies with `cp`; the destination dir is created// before the failure so the rollback has a half-copied target to remove.cp: async (from, to, ...rest) => {@@ -64,7 +72,7 @@ vi.mock('./cosRunnerClient.js', () => ({requestSecurityScanViaRunner: vi.fn(),}));-import { getAgent, getAgentPrompt, createAgentOutputBatcher, completeAgent, updateAgent, registerAgent, cleanupZombieAgents, filterLiveAgentIds, readAgentRecordOrUnreadable, AGENT_RECORD_UNREADABLE, AGENT_OUTPUT_TAIL_LINES } from './cosAgentLifecycle.js';+import { getAgent, getAgentPrompt, createAgentOutputBatcher, completeAgent, updateAgent, registerAgent, cleanupZombieAgents, filterLiveAgentIds, readAgentRecordOrUnreadable, deleteAgent, AGENT_RECORD_UNREADABLE, AGENT_OUTPUT_TAIL_LINES } from './cosAgentLifecycle.js';import { saveState, loadState, readAgentsStateForSafetyCheck } from './cosState.js';import { recordDomainUsage } from './domainUsage.js';import { cosEvents } from './cosEvents.js';@@ -842,3 +850,32 @@ describe('cleanupZombieAgents — runner listing is not proof of life', () => {expect(mockCosState.state.agents['agent-stale'].result.error).toMatch(/terminated unexpectedly/);});});++describe('deleteAgent directory cleanup (#11446)', () => {+ beforeEach(async () => {+ await rm(mockCosState.agentsDir, { recursive: true, force: true });+ await mkdir(mockCosState.agentsDir, { recursive: true });+ mockCosState.state = { agents: {} };+ });++ afterEach(async () => {+ fsFailures.rmFailsFor = null;+ await rm(mockCosState.agentsDir, { recursive: true, force: true });+ });++ it('logs the agentId and error when removing the agent directory fails, and still drops the record', async () => {+ const agentId = 'agent-rm-busy';+ await mkdir(join(mockCosState.agentsDir, agentId), { recursive: true });+ mockCosState.state.agents[agentId] = { id: agentId };+ fsFailures.rmFailsFor = agentId;+ const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});+ try {+ const result = await deleteAgent(agentId);+ expect(result).toEqual({ success: true, agentId });+ expect(mockCosState.state.agents[agentId]).toBeUndefined();+ expect(errorSpy).toHaveBeenCalledWith(expect.stringMatching(/^❌ .*agent-rm-busy.*EBUSY/));+ } finally {+ errorSpy.mockRestore();+ }+ });+});