Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: make Brain digest and weekly review opt-in and arm post-listen (#11759)
[._.]/ Adam Eivy3510784b5e48
diff --git a/client/src/components/brain/tabs/ConfigTab.jsx b/client/src/components/brain/tabs/ConfigTab.jsxindex 1dc87a627e..e4060fa205 100644--- a/client/src/components/brain/tabs/ConfigTab.jsx+++ b/client/src/components/brain/tabs/ConfigTab.jsx@@ -35,6 +35,7 @@ export default function ConfigTab({ onRefresh }) {const [selectedProvider, setSelectedProvider] = useState('');const [selectedModel, setSelectedModel] = useState('');const [confidenceThreshold, setConfidenceThreshold] = useState(0.6);+ const [scheduledReviewsEnabled, setScheduledReviewsEnabled] = useState(false);const [dailyDigestTime, setDailyDigestTime] = useState('09:00');const [weeklyReviewDay, setWeeklyReviewDay] = useState('sunday');const [weeklyReviewTime, setWeeklyReviewTime] = useState('16:00');@@ -66,6 +67,7 @@ export default function ConfigTab({ onRefresh }) {setSelectedProvider(settingsData.defaultProvider || '');setSelectedModel(settingsData.defaultModel || '');setConfidenceThreshold(settingsData.confidenceThreshold ?? 0.6);+ setScheduledReviewsEnabled(settingsData.scheduledReviewsEnabled === true);setDailyDigestTime(settingsData.dailyDigestTime || '09:00');setWeeklyReviewDay(settingsData.weeklyReviewDay || 'sunday');setWeeklyReviewTime(settingsData.weeklyReviewTime || '16:00');@@ -158,6 +160,7 @@ export default function ConfigTab({ onRefresh }) {defaultProvider: selectedProvider,defaultModel: selectedModel,confidenceThreshold: parseFloat(confidenceThreshold),+ scheduledReviewsEnabled,dailyDigestTime,weeklyReviewDay,weeklyReviewTime@@ -189,6 +192,7 @@ export default function ConfigTab({ onRefresh }) {selectedProvider !== settings.defaultProvider ||selectedModel !== settings.defaultModel ||parseFloat(confidenceThreshold) !== settings.confidenceThreshold ||+ scheduledReviewsEnabled !== (settings.scheduledReviewsEnabled === true) ||dailyDigestTime !== settings.dailyDigestTime ||weeklyReviewDay !== settings.weeklyReviewDay ||weeklyReviewTime !== settings.weeklyReviewTime@@ -392,6 +396,26 @@ export default function ConfigTab({ onRefresh }) {</div><div className="space-y-4">+ <div>+ <label htmlFor="scheduledReviewsEnabled" className="flex items-center gap-2 text-sm font-medium text-gray-300">+ <input+ id="scheduledReviewsEnabled"+ type="checkbox"+ checked={scheduledReviewsEnabled}+ onChange={(e) => setScheduledReviewsEnabled(e.target.checked)}+ className="w-4 h-4"+ />+ Run daily digest and weekly review automatically+ </label>+ <p className="mt-1 text-xs text-gray-500">+ Off by default. When on, scheduled runs (and one catch-up after a restart) call{' '}+ <span className="text-gray-300">{selectedProvider || 'no provider selected'}</span>+ {' / '}+ <span className="text-gray-300">{selectedModel || 'no model selected'}</span>+ {' '}(Default Provider and Model above).+ </p>+ </div>+{/* Daily Digest Time */}<div><label htmlFor="digestTime" className="block text-sm font-medium text-gray-300 mb-2">diff --git a/client/src/components/brain/tabs/ConfigTab.test.jsx b/client/src/components/brain/tabs/ConfigTab.test.jsxindex 71823e3ef1..1e28dfa716 100644--- a/client/src/components/brain/tabs/ConfigTab.test.jsx+++ b/client/src/components/brain/tabs/ConfigTab.test.jsx@@ -35,6 +35,22 @@ beforeEach(() => {api.getEmbeddingStatus.mockResolvedValue(null);});+describe('brain ConfigTab scheduled reviews opt-in', () => {+ it('names the provider/model and persists the toggle', async () => {+ api.getBrainSettings.mockResolvedValue({ defaultProvider: 'local', defaultModel: 'llama3.2:latest', confidenceThreshold: 0.6, scheduledReviewsEnabled: false });+ api.updateBrainSettings.mockResolvedValue({ scheduledReviewsEnabled: true });+ render(<ConfigTab />);++ const toggle = await screen.findByLabelText(/Run daily digest and weekly review automatically/);+ expect(toggle).not.toBeChecked();+ expect(screen.getByText('llama3.2:latest', { selector: 'span' })).toBeInTheDocument();+ await userEvent.click(toggle);+ await userEvent.click(screen.getByRole('button', { name: /^Save/ }));++ expect(api.updateBrainSettings).toHaveBeenCalledWith(expect.objectContaining({ scheduledReviewsEnabled: true }), { silent: true });+ });+});+describe('brain ConfigTab provider pickers', () => {it('seeds the provider default into the classification model on a provider change', async () => {render(<ConfigTab />);diff --git a/scripts/migrations/427-brain-scheduled-reviews-optin.js b/scripts/migrations/427-brain-scheduled-reviews-optin.jsnew file mode 100644index 0000000000..7430f6245e--- /dev/null+++ b/scripts/migrations/427-brain-scheduled-reviews-optin.js@@ -0,0 +1,40 @@+/**+ * Brain digests/reviews now require the `scheduledReviewsEnabled` opt-in.+ * Derives it from the install's own records: enabled only where at least one+ * stored digest or weekly review proves the user has been running them.+ * Gates on the presence of that input (never the absence of the output), so it+ * ships no data.reference seed.+ */+import { readFile } from 'node:fs/promises';+import { join } from 'node:path';+import { writeJsonAtomic } from './_lib.js';++const hasRecords = async (path) => {+ const raw = await readFile(path, 'utf8').catch(err => {+ if (err.code === 'ENOENT') return '';+ throw err;+ });+ return raw.trim().length > 0;+};++export default {+ async up({ rootDir }) {+ const dir = join(rootDir, 'data', 'brain');+ const ran = (await hasRecords(join(dir, 'digests.jsonl'))) || (await hasRecords(join(dir, 'reviews.jsonl')));+ if (!ran) return { enabled: false };++ const metaPath = join(dir, 'meta.json');+ const raw = await readFile(metaPath, 'utf8').catch(err => {+ if (err.code === 'ENOENT') return null;+ throw err;+ });+ let meta = {};+ if (raw !== null) {+ try { meta = JSON.parse(raw); } catch { return { enabled: false, skipped: 'unreadable meta.json' }; }+ if (!meta || typeof meta !== 'object' || Array.isArray(meta)) return { enabled: false, skipped: 'unexpected meta.json' };+ }+ if (typeof meta.scheduledReviewsEnabled === 'boolean') return { enabled: meta.scheduledReviewsEnabled };+ await writeJsonAtomic(metaPath, { ...meta, scheduledReviewsEnabled: true });+ return { enabled: true };+ }+};diff --git a/scripts/migrations/427-brain-scheduled-reviews-optin.test.js b/scripts/migrations/427-brain-scheduled-reviews-optin.test.jsnew file mode 100644index 0000000000..749e265329--- /dev/null+++ b/scripts/migrations/427-brain-scheduled-reviews-optin.test.js@@ -0,0 +1,45 @@+import { mkdtemp, mkdir, readFile, writeFile, rm } from 'node:fs/promises';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { afterEach, beforeEach, describe, expect, it } from 'vitest';+import migration from './427-brain-scheduled-reviews-optin.js';++let rootDir;+let dir;+beforeEach(async () => {+ rootDir = await mkdtemp(join(tmpdir(), 'portos-brain-optin-'));+ dir = join(rootDir, 'data', 'brain');+ await mkdir(dir, { recursive: true });+});+afterEach(() => rm(rootDir, { recursive: true, force: true }));++const readMeta = async () => JSON.parse(await readFile(join(dir, 'meta.json'), 'utf8'));++describe('427 brain scheduled-reviews opt-in', () => {+ it('enables, preserving settings, when a stored digest exists', async () => {+ await writeFile(join(dir, 'meta.json'), JSON.stringify({ dailyDigestTime: '07:30' }));+ await writeFile(join(dir, 'digests.jsonl'), '{"id":"d1"}\n');+ expect(await migration.up({ rootDir })).toEqual({ enabled: true });+ expect(await readMeta()).toEqual({ dailyDigestTime: '07:30', scheduledReviewsEnabled: true });+ });++ it('enables when only a weekly review exists, even with no meta.json', async () => {+ await writeFile(join(dir, 'reviews.jsonl'), '{"id":"r1"}\n');+ expect(await migration.up({ rootDir })).toEqual({ enabled: true });+ expect(await readMeta()).toEqual({ scheduledReviewsEnabled: true });+ });++ it('leaves meta untouched when no digest or review is stored', async () => {+ await writeFile(join(dir, 'meta.json'), JSON.stringify({ dailyDigestTime: '07:30' }));+ await writeFile(join(dir, 'digests.jsonl'), '');+ expect(await migration.up({ rootDir })).toEqual({ enabled: false });+ expect(await readMeta()).toEqual({ dailyDigestTime: '07:30' });+ });++ it('never overrides an explicit user choice', async () => {+ await writeFile(join(dir, 'meta.json'), JSON.stringify({ scheduledReviewsEnabled: false }));+ await writeFile(join(dir, 'digests.jsonl'), '{"id":"d1"}\n');+ expect(await migration.up({ rootDir })).toEqual({ enabled: false });+ expect(await readMeta()).toEqual({ scheduledReviewsEnabled: false });+ });+});diff --git a/server/lib/brainValidation.js b/server/lib/brainValidation.jsindex a74502701b..64bb4231a5 100644--- a/server/lib/brainValidation.js+++ b/server/lib/brainValidation.js@@ -152,6 +152,7 @@ export const brainSettingsSchema = z.object({weeklyReviewDay: z.enum(['sunday', 'monday', 'tuesday', 'wednesday', 'thursday', 'friday', 'saturday']).default('sunday'),defaultProvider: z.string().default('lmstudio'),defaultModel: z.string().default('gptoss-20b'),+ scheduledReviewsEnabled: z.boolean().default(false),lastDailyDigest: z.string().datetime().optional(),lastWeeklyReview: z.string().datetime().optional()});diff --git a/server/services/bootstrap.js b/server/services/bootstrap.jsindex 32816a5c6b..adf06fb4a8 100644--- a/server/services/bootstrap.js+++ b/server/services/bootstrap.js@@ -483,8 +483,6 @@ const startBackgroundServices = ({ spawnerReady, io, httpsEnabled, port }) => {// QR play sessions and tears down the ones past their TTL, making no AI// provider call, so it is safe under AGENTS.md's "No cold-bootstrap LLM calls".startHostedSessionSweep({ io });- // Initialize brain scheduler for daily digests and weekly reviews- startBrainScheduler();// Initialize activity-digest scheduler — OFF by default; drafts daily-log// auto-summaries from the Human Activity timeline only when the user enables it// (Settings → Daily Log → Activity Digest). Silent + no LLM calls until then.@@ -1021,7 +1019,11 @@ export const runBootSequence = ({ io, httpServer, localHttpServer, httpsEnabled,.then(({ restoreServe }) => restoreServe()).catch((err) => logBootstrapFailure('⚠️ tailcat serve restore failed', err, console.warn));},- initSyncOrchestrator+ initSyncOrchestrator,+ // Brain digests/reviews call an AI provider, so the scheduler arms only+ // once the server is listening and only acts when the user opted in+ // (`scheduledReviewsEnabled`).+ startBrainScheduler}, 'postListen', isSmokeBoot())))}, 'postRoute', isSmokeBoot()));diff --git a/server/services/bootstrapSequence.js b/server/services/bootstrapSequence.jsindex bf2b4331b7..40d236ba0b 100644--- a/server/services/bootstrapSequence.js+++ b/server/services/bootstrapSequence.js@@ -50,7 +50,7 @@ export const SMOKE_BOOT_DISABLED_STEPS = Object.freeze({'initSharing','recoverCreativeDirectorProjects']),- postListen: Object.freeze(['relayUnloggedBrainRecords', 'startPolling', 'initSyncOrchestrator'])+ postListen: Object.freeze(['relayUnloggedBrainRecords', 'startPolling', 'initSyncOrchestrator', 'startBrainScheduler'])});/**@@ -429,7 +429,8 @@ export const runPostListenSequence = ({backfillOriginInstanceId,relayUnloggedBrainRecords,startPolling,- initSyncOrchestrator+ initSyncOrchestrator,+ startBrainScheduler}) => {announceListening();setupProcessErrorHandlers();@@ -438,6 +439,7 @@ export const runPostListenSequence = ({bestEffort(relayUnloggedBrainRecords(), logFailure('Brain relay sweep failed'));startPolling();initSyncOrchestrator();+ startBrainScheduler();}),logFailure('Post-startup init failed'));diff --git a/server/services/bootstrapSequence.test.js b/server/services/bootstrapSequence.test.jsindex 6426e57253..57e5efedd0 100644--- a/server/services/bootstrapSequence.test.js+++ b/server/services/bootstrapSequence.test.js@@ -872,6 +872,7 @@ describe('runPostListenSequence — inside the listen callback', () => {relayUnloggedBrainRecords: step('relayUnloggedBrainRecords', () => Promise.resolve(0)),startPolling: step('startPolling'),initSyncOrchestrator: step('initSyncOrchestrator'),+ startBrainScheduler: step('startBrainScheduler'),...overrides};};@@ -885,7 +886,8 @@ describe('runPostListenSequence — inside the listen callback', () => {'backfillOriginInstanceId','relayUnloggedBrainRecords','startPolling',- 'initSyncOrchestrator'+ 'initSyncOrchestrator',+ 'startBrainScheduler']);});diff --git a/server/services/brainScheduler.js b/server/services/brainScheduler.jsindex cc95317833..b956e3456e 100644--- a/server/services/brainScheduler.js+++ b/server/services/brainScheduler.js@@ -24,6 +24,11 @@ let lastWeeklyFailure = null;let dailyRunning = false;let weeklyRunning = false;+// At most one catch-up per type per boot (a failed catch-up is not retried+// until the next restart; the in-memory cooldown alone resets on restart).+let dailyCatchUpAttempted = false;+let weeklyCatchUpAttempted = false;+// Day name to number mappingconst DAY_MAP = {sunday: 0,@@ -75,7 +80,7 @@ function isInCooldown(lastFailure, now) {*/function isDailyDigestMissed(settings, now) {// Don't re-trigger while already running- if (dailyRunning) return false;+ if (dailyRunning || dailyCatchUpAttempted) return false;// Respect cooldown after failureif (isInCooldown(lastDailyFailure, now)) return false;@@ -101,7 +106,7 @@ function isDailyDigestMissed(settings, now) {*/function isWeeklyReviewMissed(settings, now) {// Don't re-trigger while already running- if (weeklyRunning) return false;+ if (weeklyRunning || weeklyCatchUpAttempted) return false;// Respect cooldown after failureif (isInCooldown(lastWeeklyFailure, now)) return false;@@ -127,11 +132,15 @@ async function checkSchedule() {if (lastCheckTime === currentMinute) return;lastCheckTime = currentMinute;+ // Digests and reviews call an AI provider: run only when the user opted in.+ if (settings.scheduledReviewsEnabled !== true) return;+// Check for daily digestif (!dailyRunning && (isDailyDigestTime(settings, now) || isDailyDigestMissed(settings, now))) {const isCatchUp = !isDailyDigestTime(settings, now);console.log(`🧠 Scheduler: Running ${isCatchUp ? 'missed ' : ''}daily digest${isCatchUp ? ' (catch-up)' : ''}...`);dailyRunning = true;+ if (isCatchUp) dailyCatchUpAttempted = true;runDailyDigest().catch(err => {lastDailyFailure = new Date();@@ -145,6 +154,7 @@ async function checkSchedule() {const isCatchUp = !isWeeklyReviewTime(settings, now);console.log(`🧠 Scheduler: Running ${isCatchUp ? 'missed ' : ''}weekly review${isCatchUp ? ' (catch-up)' : ''}...`);weeklyRunning = true;+ if (isCatchUp) weeklyCatchUpAttempted = true;runWeeklyReview().catch(err => {lastWeeklyFailure = new Date();diff --git a/server/services/brainScheduler.test.js b/server/services/brainScheduler.test.jsnew file mode 100644index 0000000000..113e47e0f9--- /dev/null+++ b/server/services/brainScheduler.test.js@@ -0,0 +1,53 @@+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';++const loadMeta = vi.hoisted(() => vi.fn());+const runDailyDigest = vi.hoisted(() => vi.fn());+const runWeeklyReview = vi.hoisted(() => vi.fn());+vi.mock('./brainStorage.js', () => ({ loadMeta }));+vi.mock('./brain.js', () => ({ runDailyDigest, runWeeklyReview }));++const flush = () => vi.advanceTimersByTimeAsync(0);++describe('brainScheduler opt-in', () => {+ let startBrainScheduler;+ beforeEach(async () => {+ vi.resetModules();+ vi.useFakeTimers();+ vi.setSystemTime(new Date(2026, 9, 17, 12, 0, 0));+ vi.spyOn(console, 'log').mockImplementation(() => {});+ vi.spyOn(console, 'error').mockImplementation(() => {});+ runDailyDigest.mockReset().mockResolvedValue({});+ runWeeklyReview.mockReset().mockResolvedValue({});+ ({ startBrainScheduler } = await import('./brainScheduler.js'));+ });+ afterEach(() => { vi.useRealTimers(); vi.restoreAllMocks(); });++ const meta = (extra = {}) => ({+ dailyDigestTime: '00:00', weeklyReviewTime: '00:00', weeklyReviewDay: 'sunday',+ lastDailyDigest: null, lastWeeklyReview: null, ...extra+ });++ it('makes no provider call at start or at the digest time while disabled', async () => {+ loadMeta.mockResolvedValue(meta());+ startBrainScheduler();+ await flush();+ vi.setSystemTime(new Date(2026, 9, 18, 0, 0, 0));+ await vi.advanceTimersByTimeAsync(60000);+ expect(runDailyDigest).not.toHaveBeenCalled();+ expect(runWeeklyReview).not.toHaveBeenCalled();+ });++ it('catches up a missed digest and review once per boot when enabled, without retrying after failure', async () => {+ loadMeta.mockResolvedValue(meta({ scheduledReviewsEnabled: true }));+ runDailyDigest.mockRejectedValue(new Error('provider down'));+ startBrainScheduler();+ await flush();+ expect(runDailyDigest).toHaveBeenCalledTimes(1);+ expect(runWeeklyReview).toHaveBeenCalledTimes(1);++ // Past the 30 minute cooldown: still no second catch-up this boot.+ for (let i = 0; i < 40; i++) await vi.advanceTimersByTimeAsync(60000);+ expect(runDailyDigest).toHaveBeenCalledTimes(1);+ expect(runWeeklyReview).toHaveBeenCalledTimes(1);+ });+});diff --git a/server/services/brainStorage.js b/server/services/brainStorage.jsindex be4ff6079f..ba143fd5fe 100644--- a/server/services/brainStorage.js+++ b/server/services/brainStorage.js@@ -169,6 +169,8 @@ const DEFAULT_META = {weeklyReviewDay: 'sunday',defaultProvider: 'lmstudio',defaultModel: 'gptoss-20b',+ // Opt-in: digests/reviews call an AI provider, so nothing runs until enabled.+ scheduledReviewsEnabled: false,lastDailyDigest: null,lastWeeklyReview: null};