Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Let a Board shot leave its camera blank on the Plan check (#11543)

[._.]/3712f1e3a186
diff --git a/client/src/components/musicVideo/ProductionReviewPanel.test.jsx b/client/src/components/musicVideo/ProductionReviewPanel.test.jsx
index 623004ecb1..5fa3b9e068 100644
--- a/client/src/components/musicVideo/ProductionReviewPanel.test.jsx
+++ b/client/src/components/musicVideo/ProductionReviewPanel.test.jsx
@@ -354,7 +354,7 @@ describe('Approval problems with unsaved edits', () => {
const board = { ...project, composition: { mode: 'concat' }, scenes: [{ sceneId: 's-a', label: 'Verse', startSec: 0, endSec: 4 }, { sceneId: 's-b', label: 'Chorus', startSec: 3.5, endSec: 8 }] };
review.readiness.storyboard = { approved: false,
problems: ['Storyboard shots must cover the master without unintended gaps or overlaps.', 'Complete timing, action, staging, camera and transition for Chorus.'],
- coverage: [{ sceneId: 's-b', issue: 'overlap', startSec: 3.5, endSec: 4 }], incompleteShots: [{ sceneId: 's-b', missing: ['camera'] }] };
+ coverage: [{ sceneId: 's-b', issue: 'overlap', startSec: 3.5, endSec: 4 }], incompleteShots: [{ sceneId: 's-b', missing: ['staging'] }] };
const onNavigate = vi.fn();
render(<ProductionReviewPanel project={board} review={review} onOpenArtifact={vi.fn()} stage="storyboard" onNavigate={onNavigate} />);
expect(screen.getByText('Finish these 2 items on the Plan step first:')).toBeTruthy();
diff --git a/client/src/pages/MusicVideo.test.jsx b/client/src/pages/MusicVideo.test.jsx
index c0bd58ac31..e7117c33c0 100644
--- a/client/src/pages/MusicVideo.test.jsx
+++ b/client/src/pages/MusicVideo.test.jsx
@@ -3461,13 +3461,13 @@ describe('stage checklist and project options', () => {
productionReadiness: { readyForProduction: false, basis: {}, art: { approved: true, problems: [] },
storyboard: { approved: false, problems: ['Storyboard shots must cover the master without unintended gaps or overlaps.', 'Complete timing, action, staging, camera and transition for Singer.'],
coverage: [{ sceneId: 's-b', issue: 'gap', startSec: 4, endSec: 4.5 }],
- incompleteShots: [{ sceneId: 's-b', missing: ['camera'] }] }, proof: { approved: false, problems: [] } } };
+ incompleteShots: [{ sceneId: 's-b', missing: ['staging'] }] }, proof: { approved: false, problems: [] } } };
await openProject(project, 'board');
const checklist = screen.getByRole('region', { name: 'What this step needs' });
expect(within(checklist).getByRole('list', { name: 'Shot coverage shots' })).toHaveTextContent('Shot 2Gap of 0.50 s before this shot, 0:04.00–0:04.50');
expect(checklist).not.toHaveTextContent('without unintended gaps');
const details = within(checklist).getByRole('list', { name: 'Shot details shots' });
- expect(details).toHaveTextContent('Shot 2Missing camera');
+ expect(details).toHaveTextContent('Shot 2Missing staging');
expect(checklist).not.toHaveTextContent('1 shot missing timing');
fireEvent.click(within(details).getByRole('button', { name: 'Shot 2' }));
await waitFor(() => expect(document.getElementById('scene-s-b')).toBeTruthy());
diff --git a/server/services/musicVideo/productionReview.js b/server/services/musicVideo/productionReview.js
index b6f37f61b4..8d0be28dac 100644
--- a/server/services/musicVideo/productionReview.js
+++ b/server/services/musicVideo/productionReview.js
@@ -678,7 +678,10 @@ export function productionReadiness(project) {
const shot = documentShots ? scene : draft.storyboard?.find(s => s.sceneId === scene.sceneId) || boardShotFromScene(project, scene);
const missing = !(Number.isFinite(scene.startSec) && scene.endSec > scene.startSec) ? ['timing']
: scene.endSec > duration ? ['an end inside the song'] : [];
- missing.push(...['action', 'staging', 'camera', 'transition'].filter(key => !text(shot?.[key])));
+ // A Board shot with no camera note is a valid choice (a cutaway rendered from its start frame plays
+ // whatever motion its clip has); camera variety stays advice. Document shots spell out every field.
+ missing.push(...(documentShots ? ['action', 'staging', 'camera', 'transition'] : ['action', 'staging', 'transition'])
+ .filter(key => !text(shot?.[key])));
if (missing.length) {
boardProblems.push(`Complete timing, action, staging, camera and transition for ${scene.label || 'each shot'}.`);
incompleteShots.push({ sceneId: scene.sceneId, missing });
diff --git a/server/services/musicVideo/productionReview.storyboard.test.js b/server/services/musicVideo/productionReview.storyboard.test.js
index 2988158d7c..9d4ad818f0 100644
--- a/server/services/musicVideo/productionReview.storyboard.test.js
+++ b/server/services/musicVideo/productionReview.storyboard.test.js
@@ -45,7 +45,7 @@ describe('storyboard readiness after verified lyric timing', () => {
});
it('keeps a director-edited draft shot over the derived row', () => {
- const edited = { sceneId: 's1', lyricCueIds: ['c1'], action: 'She laughs', staging: 'Close-up', camera: '', transition: 'Cut' };
+ const edited = { sceneId: 's1', lyricCueIds: ['c1'], action: 'She laughs', staging: '', camera: 'Close-up', transition: 'Cut' };
const { storyboard } = productionReadiness(project({ draftShots: [edited] }));
expect(storyboard.shots[0]).toEqual(edited);
expect(storyboard.problems).toContain('Complete timing, action, staging, camera and transition for Verse.');
@@ -306,6 +306,15 @@ describe('storyboard rows stay bound to the shots on the board', () => {
});
describe('naming the shots behind Shot coverage and Shot details', () => {
+ // Uniquely catches a cutaway with no camera note blocking the board it was locked on.
+ it('lets a Board shot leave its camera blank', () => {
+ const planned = project({ draftShots: [{ sceneId: 's1', lyricCueIds: ['c1'], action: 'She looks up', staging: 'Desk', camera: '', transition: 'Cut' }] });
+ const bare = { ...planned, castAndSets: { status: 'approved', direction: { world: {} } } };
+ const { storyboard } = productionReadiness(bare);
+ expect(storyboard.incompleteShots).toEqual([]);
+ expect(storyboard.problems.filter((p) => SHOT_PROBLEM.test(p))).toEqual([]);
+ });
+
// Uniquely catches the coverage and details checks failing a board without saying which shot to fix.
it('names the shot at each gap, overlap and song-end mismatch, and what each incomplete shot is missing', () => {
const base = project();