Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: show a single create action on empty Sprites, Storyboards, Feature Agents, Tribe and X pages (#13007) (#13048)
[._.]/3a8a87a0f304
diff --git a/client/src/components/sprites/NewSpritePanel.jsx b/client/src/components/sprites/NewSpritePanel.jsxindex e81768fb8a..b6fd5d48cd 100644--- a/client/src/components/sprites/NewSpritePanel.jsx+++ b/client/src/components/sprites/NewSpritePanel.jsx@@ -6,7 +6,8 @@* can refresh the library and navigate into it.** Open/closed is controlled by the page so the library's empty state can offer- * "create your first sprite" as its call to action.+ * "create your first sprite" as its call to action; `showTrigger={false}` hides+ * the header button then so the empty state holds the only create control.*/import { useState } from 'react';@@ -16,7 +17,7 @@ import { createSpriteRecord } from '../../services/apiSprites.js';import { useAsyncAction } from '../../hooks/useAsyncAction.js';import { NEW_SPRITE_KINDS } from '../../lib/spriteRecordGroups.js';-export default function NewSpritePanel({ onCreated, open, onOpenChange }) {+export default function NewSpritePanel({ onCreated, open, onOpenChange, showTrigger = true }) {const [name, setName] = useState('');const [id, setId] = useState('');const [kind, setKind] = useState('character');@@ -36,12 +37,14 @@ export default function NewSpritePanel({ onCreated, open, onOpenChange }) {return (<>- <button- onClick={() => onOpenChange(true)}- className="flex items-center gap-2 px-3 py-1.5 bg-port-card border border-port-border hover:border-port-accent text-gray-300 rounded text-sm"- >- <Plus className="w-4 h-4" /> New Sprite- </button>+ {showTrigger && (+ <button+ onClick={() => onOpenChange(true)}+ className="flex items-center gap-2 px-3 py-1.5 bg-port-card border border-port-border hover:border-port-accent text-gray-300 rounded text-sm"+ >+ <Plus className="w-4 h-4" /> New Sprite+ </button>+ )}<Modal open={open} onClose={() => onOpenChange(false)} size="sm" ariaLabel="New sprite" closeOnBackdrop={false}><div className="bg-port-card border border-port-border rounded-lg p-4 space-y-3"><div className="flex items-center justify-between">diff --git a/client/src/pages/FeatureAgents.jsx b/client/src/pages/FeatureAgents.jsxindex 24fcb6e248..c75474c540 100644--- a/client/src/pages/FeatureAgents.jsx+++ b/client/src/pages/FeatureAgents.jsx@@ -12,12 +12,15 @@ import { formatCount } from '../utils/formatters';export default function FeatureAgents() {const [agents, setAgents] = useState([]);const [loading, setLoading] = useState(true);+ // Only a successful zero-record read counts as empty; a failed read keeps the header action.+ const [loadFailed, setLoadFailed] = useState(false);const fetchAgents = useCallback(() => {api.getFeatureAgents().then(data => {setAgents(data || []);+ setLoadFailed(false);setLoading(false);- }).catch(() => setLoading(false));+ }).catch(() => { setLoadFailed(true); setLoading(false); });}, []);useEffect(() => {@@ -95,12 +98,14 @@ export default function FeatureAgents() {><RefreshCw size={16} /></button>- <Link- to="/feature-agents/create"- className="flex items-center gap-2 px-3 py-2 bg-port-accent text-white rounded-lg text-sm font-medium hover:bg-port-accent/80 transition-colors"- >- <Plus size={16} /> New Agent- </Link>+ {(loading || loadFailed || agents.length > 0) && (+ <Link+ to="/feature-agents/create"+ className="flex items-center gap-2 px-3 py-2 bg-port-accent text-white rounded-lg text-sm font-medium hover:bg-port-accent/80 transition-colors"+ >+ <Plus size={16} /> New Agent+ </Link>+ )}</>}/>diff --git a/client/src/pages/FeatureAgents.test.jsx b/client/src/pages/FeatureAgents.test.jsxnew file mode 100644index 0000000000..cad39ac2ff--- /dev/null+++ b/client/src/pages/FeatureAgents.test.jsx@@ -0,0 +1,41 @@+import { afterEach, describe, expect, it, vi } from 'vitest';+import { cleanup, render, screen } from '@testing-library/react';+import { MemoryRouter } from 'react-router';++vi.mock('../services/api', () => ({ getFeatureAgents: vi.fn() }));+vi.mock('../services/socket', () => ({ default: { on: vi.fn(), off: vi.fn() } }));+vi.mock('../components/feature-agents/FeatureAgentCard', () => ({+ default: ({ agent }) => <div>{agent.name}</div>,+}));++import FeatureAgents from './FeatureAgents';+import { getFeatureAgents } from '../services/api';++const renderPage = () => render(<MemoryRouter><FeatureAgents /></MemoryRouter>);++afterEach(cleanup);++describe('FeatureAgents create actions', () => {+ it('shows the empty-state link as the only create control for an empty list', async () => {+ getFeatureAgents.mockResolvedValue([]);+ renderPage();+ expect(await screen.findByText('No Feature Agents')).toBeInTheDocument();+ expect(screen.getByRole('link', { name: /Create Feature Agent/ })).toBeInTheDocument();+ expect(screen.queryByRole('link', { name: /New Agent/ })).toBeNull();+ });++ it('keeps the header New Agent action while loading, after a failed read, and with agents', async () => {+ getFeatureAgents.mockRejectedValueOnce(new Error('503'));+ const failed = renderPage();+ expect(screen.getByRole('link', { name: /New Agent/ })).toBeInTheDocument();+ await screen.findByText('No Feature Agents');+ expect(screen.getByRole('link', { name: /New Agent/ })).toBeInTheDocument();+ failed.unmount();++ getFeatureAgents.mockResolvedValue([{ id: 'a1', name: 'Example Agent', status: 'active' }]);+ renderPage();+ expect(await screen.findByText('Example Agent')).toBeInTheDocument();+ expect(screen.getByRole('link', { name: /New Agent/ })).toBeInTheDocument();+ expect(screen.queryByRole('link', { name: /Create Feature Agent/ })).toBeNull();+ });+});diff --git a/client/src/pages/Sprites.jsx b/client/src/pages/Sprites.jsxindex 752a260e44..799e64d473 100644--- a/client/src/pages/Sprites.jsx+++ b/client/src/pages/Sprites.jsx@@ -469,6 +469,7 @@ export default function Sprites() {</button><NewSpritePanelopen={newSpriteOpen}+ showTrigger={!(recordsState === 'ready' && records.length === 0)}onOpenChange={setNewSpriteOpen}onCreated={(record) => { refresh(); navigate(`/sprites/${record.id}`); }}/>diff --git a/client/src/pages/Sprites.test.jsx b/client/src/pages/Sprites.test.jsxindex eea5ec6428..2d43b2e5f1 100644--- a/client/src/pages/Sprites.test.jsx+++ b/client/src/pages/Sprites.test.jsx@@ -34,7 +34,9 @@ vi.mock('../components/sprites/AssetCollection.jsx', () => ({ default: () => nulvi.mock('../components/sprites/SpriteCatalog.jsx', () => ({ default: () => null }));vi.mock('../components/sprites/SpriteDetailHeader.jsx', () => ({ default: ({ record }) => <h2>{record.name}</h2> }));vi.mock('../components/sprites/ImportPanel.jsx', () => ({ default: () => null }));-vi.mock('../components/sprites/NewSpritePanel.jsx', () => ({ default: () => null }));+vi.mock('../components/sprites/NewSpritePanel.jsx', () => ({+ default: ({ showTrigger = true }) => (showTrigger ? <button type="button">New Sprite</button> : null),+}));vi.mock('../components/sprites/SpriteSearch.jsx', () => ({ default: () => null }));import Sprites from './Sprites.jsx';@@ -128,5 +130,23 @@ describe('persisted sprite events in the rendered page', () => {});expect(screen.queryByRole('alert')).not.toBeInTheDocument();expect(screen.getByText('No sprites yet')).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'New Sprite' })).not.toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'Create your first sprite' })).toBeInTheDocument();+ });++ it('keeps the header New Sprite action while loading, after a failed read, and with records', async () => {+ listSpriteRecords.mockRejectedValueOnce(new Error('503'));+ const { unmount } = render(<MemoryRouter initialEntries={['/sprites']}><Routes><Route path="/sprites" element={<Page />} /></Routes></MemoryRouter>);+ expect(screen.getByRole('button', { name: 'New Sprite' })).toBeInTheDocument();+ await act(async () => {});+ expect(screen.getByRole('alert')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'New Sprite' })).toBeInTheDocument();+ unmount();++ listSpriteRecords.mockResolvedValueOnce([{ id: 'example-sprite', kind: 'character', name: 'Example' }]);+ render(<MemoryRouter initialEntries={['/sprites']}><Routes><Route path="/sprites" element={<Page />} /></Routes></MemoryRouter>);+ await act(async () => {});+ expect(screen.getByRole('button', { name: 'New Sprite' })).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'Create your first sprite' })).not.toBeInTheDocument();});});diff --git a/client/src/pages/Storyboards.jsx b/client/src/pages/Storyboards.jsxindex bebd31ccb3..922c8f283e 100644--- a/client/src/pages/Storyboards.jsx+++ b/client/src/pages/Storyboards.jsx@@ -94,7 +94,7 @@ export default function Storyboards() {return (<div className="flex h-full min-h-0 flex-col">- <PageHeader icon={LayoutPanelLeft} title="Storyboards" subtitle="Plan story beats and panels before the song or the edit." actions={newButton} />+ <PageHeader icon={LayoutPanelLeft} title="Storyboards" subtitle="Plan story beats and panels before the song or the edit." actions={state === 'ready' && boards.length === 0 ? null : newButton} /><div className="flex-1 min-h-0 overflow-auto p-3 sm:p-4">{state === 'error' ? (<ListLoadError what="storyboards" error={error} onRetry={retry} />diff --git a/client/src/pages/Storyboards.test.jsx b/client/src/pages/Storyboards.test.jsxnew file mode 100644index 0000000000..177b302141--- /dev/null+++ b/client/src/pages/Storyboards.test.jsx@@ -0,0 +1,41 @@+import { afterEach, describe, expect, it, vi } from 'vitest';+import { cleanup, render, screen } from '@testing-library/react';+import { MemoryRouter } from 'react-router';++vi.mock('../services/api', () => ({+ listStoryboards: vi.fn(),+ createStoryboard: vi.fn(),+ deleteStoryboard: vi.fn(),+}));++import Storyboards from './Storyboards';+import { listStoryboards } from '../services/api';++const renderPage = () => render(<MemoryRouter><Storyboards /></MemoryRouter>);++afterEach(cleanup);++describe('Storyboards create actions', () => {+ it('shows the empty-state button as the only create control for an empty list', async () => {+ listStoryboards.mockResolvedValue([]);+ renderPage();+ expect(await screen.findByText('No storyboards yet')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'New storyboard' })).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /^New$/ })).toBeNull();+ });++ it('keeps the header New action while loading, after a failed read, and with boards', async () => {+ listStoryboards.mockRejectedValueOnce(new Error('503'));+ const failed = renderPage();+ expect(screen.getByRole('button', { name: /^New$/ })).toBeInTheDocument();+ expect(await screen.findByRole('alert')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: /^New$/ })).toBeInTheDocument();+ failed.unmount();++ listStoryboards.mockResolvedValue([{ id: 'sb-1', name: 'Example Board', panelCount: 0 }]);+ renderPage();+ expect(await screen.findByText('Example Board')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: /^New$/ })).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'New storyboard' })).toBeNull();+ });+});diff --git a/client/src/pages/Tribe.jsx b/client/src/pages/Tribe.jsxindex ac982c7f48..d18c799d26 100644--- a/client/src/pages/Tribe.jsx+++ b/client/src/pages/Tribe.jsx@@ -243,15 +243,17 @@ function ContactForm({ draft, onChange, onSave, onDelete, onNew, isExisting, sav<Edit3 size={18} className="text-port-accent shrink-0" aria-hidden="true" /><h2 className="text-sm font-semibold text-white truncate">{isExisting ? 'Relationship' : 'New Relationship'}</h2></div>- <button- type="button"- onClick={onNew}- title="New relationship"- aria-label="New relationship"- className="inline-flex h-9 w-9 items-center justify-center rounded border border-port-border text-gray-300 hover:text-white hover:bg-port-border/40"- >- <Plus size={16} aria-hidden="true" />- </button>+ {isExisting && (+ <button+ type="button"+ onClick={onNew}+ title="New relationship"+ aria-label="New relationship"+ className="inline-flex h-9 w-9 items-center justify-center rounded border border-port-border text-gray-300 hover:text-white hover:bg-port-border/40"+ >+ <Plus size={16} aria-hidden="true" />+ </button>+ )}</div><div className="mt-4 grid gap-3 sm:grid-cols-2">@@ -660,7 +662,7 @@ function BeeperIdentitiesPanel({ personId }) {);}-function EmptyState({ onNew }) {+function EmptyState() {return (<div className="flex min-h-[280px] flex-col items-center justify-center rounded border border-dashed border-port-border bg-port-card/60 p-8 text-center"><Users size={42} className="text-gray-600" aria-hidden="true" />@@ -668,14 +670,6 @@ function EmptyState({ onNew }) {<p className="mt-2 max-w-md text-sm text-gray-500">Add the first person in your circle, then PortOS can keep cadence, ring size, and care queue visible.</p>- <button- type="button"- onClick={onNew}- className="mt-5 inline-flex items-center gap-2 rounded bg-port-accent px-3 py-2 text-sm font-medium text-black hover:bg-port-accent/90"- >- <Plus size={15} aria-hidden="true" />- Add Relationship- </button></div>);}@@ -847,7 +841,7 @@ function OutreachQueue() {);}-function CareQueue({ contacts, statusFilter, onStatusFilterChange, onSelect, onLogTouch, onNew }) {+function CareQueue({ contacts, statusFilter, onStatusFilterChange, onSelect, onLogTouch }) {// External people are outside the tribe — no care cadence is owed, so they// never appear in the queue (otherwise their null daysRemaining would sort// them to the top alongside genuinely-overdue contacts). Memoized + status@@ -864,7 +858,7 @@ function CareQueue({ contacts, statusFilter, onStatusFilterChange, onSelect, onL// A filtered-to-empty queue is a success state ("nobody is overdue"), not the// "no relationships yet" onboarding empty — only show the latter when the whole// roster is empty.- if (!queue.length && statusFilter === DEFAULT_STATUS) return <EmptyState onNew={onNew} />;+ if (!queue.length && statusFilter === DEFAULT_STATUS) return <EmptyState />;return (<div className="grid gap-3">@@ -1428,7 +1422,7 @@ export default function Tribe() {</div>{contacts.length === 0 ? (- <EmptyState onNew={startNewRelationship} />+ <EmptyState />) : (<div className="grid gap-3 md:grid-cols-2">{filteredContacts.map((contact) => (@@ -1471,7 +1465,7 @@ export default function Tribe() {{activeTab === 'map' && (contacts.length === 0 ? (- <EmptyState onNew={startNewRelationship} />+ <EmptyState />) : (<TribeCircleMapcontacts={contacts}@@ -1492,7 +1486,6 @@ export default function Tribe() {onStatusFilterChange={setStatusFilter}onSelect={(contact) => { selectContact(contact); setActiveTab('circle'); }}onLogTouch={logTouch}- onNew={startNewRelationship}/></div><ContactFormdiff --git a/client/src/pages/Tribe.test.jsx b/client/src/pages/Tribe.test.jsxindex 59ab6ebcd2..d4178e393e 100644--- a/client/src/pages/Tribe.test.jsx+++ b/client/src/pages/Tribe.test.jsx@@ -116,6 +116,32 @@ describe('Tribe deep-linkable tabs', () => {});});+describe('Tribe create actions', () => {+ beforeEach(() => {+ api.getTribePeople.mockClear();+ window.localStorage.clear();+ });++ it('starts a new relationship from the header Add only while the roster is empty', async () => {+ api.getTribePeople.mockResolvedValue({ people: [] });+ renderAt('/tribe?tab=circle');+ expect(await screen.findByText('No relationships yet')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'Add' })).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'Add Relationship' })).toBeNull();+ expect(screen.getByRole('heading', { name: 'New Relationship' })).toBeInTheDocument();+ expect(screen.queryByRole('button', { name: 'New relationship' })).toBeNull();+ });++ it('offers the form plus action when editing an existing relationship', async () => {+ api.getTribePeople.mockResolvedValue({ people: PEOPLE });+ renderAt('/tribe?person=p2');+ await waitFor(() => expect(screen.getByTestId('location').textContent).toContain('tab=circle'));+ expect(screen.getByRole('heading', { name: 'Relationship' })).toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'New relationship' })).toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'Add' })).toBeInTheDocument();+ });+});+describe('Tribe care filter', () => {beforeEach(() => {api.getTribePeople.mockClear();diff --git a/client/src/pages/X.jsx b/client/src/pages/X.jsxindex 9cf383d26d..940b90b915 100644--- a/client/src/pages/X.jsx+++ b/client/src/pages/X.jsx@@ -45,6 +45,7 @@ export default function XPage() {const [drafts, setDrafts] = useState([]);const [resourcesAccountId, setResourcesAccountId] = useState(null);const [loading, setLoading] = useState(true);+ const [accountsReadFailed, setAccountsReadFailed] = useState(false);const [busy, setBusy] = useState('');const [error, setError] = useState('');const [notice, setNotice] = useState('');@@ -95,6 +96,7 @@ export default function XPage() {const loadAccounts = useCallback(async () => {const result = await api.getXAccounts({ silent: true }).catch((err) => ({ error: err.message, accounts: [] }));if (result.error) setError(result.error);+ setAccountsReadFailed(Boolean(result.error));setAccounts(result.accounts || []);setLoading(false);}, []);@@ -266,5 +268,5 @@ export default function XPage() {const notFound = Boolean(accountId && !selected);if (loading) return <PageSkeleton header="bar" label="Loading X" tabs={TABS.length} cards={3} />;- return <div className="flex h-full min-h-0 flex-col"><PageHeader icon={AtSign} title="X" subtitle="Account health, reach diagnostics, and review-gated drafts" actions={accountSwitcher} /><TabPills tabs={TABS} activeTab={activeTab} onChange={(nextTab) => selected ? navigate(accountPath(selected.id, nextTab)) : navigate('/x')} ariaLabel="X sections" /><section className="flex-1 overflow-auto p-4">{error && <div role="status" className="mb-3 rounded border border-port-error p-3 text-sm text-port-error">{error}</div>}{notice && <div className="mb-3 rounded border border-port-border p-3 text-sm text-gray-200">{notice}</div>}{notFound && <div className="mb-3 rounded border border-port-error p-4 text-sm text-port-error">This X account was not found. <button type="button" className="underline" onClick={() => navigate('/x')}>Return to accounts.</button></div>}{activeTab === 'health' && selected && renderHealth()}{activeTab === 'posts' && selected && renderPosts()}{activeTab === 'drafts' && selected && renderDrafts()}{activeTab === 'accounts' && renderAccounts()}{accountDrawer}</section></div>;+ return <div className="flex h-full min-h-0 flex-col"><PageHeader icon={AtSign} title="X" subtitle="Account health, reach diagnostics, and review-gated drafts" actions={accounts.length === 0 && !accountsReadFailed ? null : accountSwitcher} /><TabPills tabs={TABS} activeTab={activeTab} onChange={(nextTab) => selected ? navigate(accountPath(selected.id, nextTab)) : navigate('/x')} ariaLabel="X sections" /><section className="flex-1 overflow-auto p-4">{error && <div role="status" className="mb-3 rounded border border-port-error p-3 text-sm text-port-error">{error}</div>}{notice && <div className="mb-3 rounded border border-port-border p-3 text-sm text-gray-200">{notice}</div>}{notFound && <div className="mb-3 rounded border border-port-error p-4 text-sm text-port-error">This X account was not found. <button type="button" className="underline" onClick={() => navigate('/x')}>Return to accounts.</button></div>}{activeTab === 'health' && selected && renderHealth()}{activeTab === 'posts' && selected && renderPosts()}{activeTab === 'drafts' && selected && renderDrafts()}{activeTab === 'accounts' && renderAccounts()}{accountDrawer}</section></div>;}diff --git a/client/src/pages/X.test.jsx b/client/src/pages/X.test.jsxindex dcb14a2c47..b27cef9b3c 100644--- a/client/src/pages/X.test.jsx+++ b/client/src/pages/X.test.jsx@@ -130,6 +130,20 @@ describe('X page', () => {expect(screen.getByTestId('location')).toHaveTextContent(`/x/${account.id}/accounts?xAccount=edit`);});+ it('offers one Add account control when no accounts exist and the header switcher once they do', async () => {+ api.getXAccounts.mockResolvedValueOnce({ accounts: [] });+ const first = renderPage('/x');+ await screen.findByRole('heading', { name: 'X accounts' });+ expect(screen.getAllByRole('button', { name: 'Add account' })).toHaveLength(1);+ expect(screen.queryByLabelText('X account in scope')).not.toBeInTheDocument();+ first.unmount();++ renderPage('/x');+ await screen.findByRole('heading', { name: 'X accounts' });+ expect(screen.getAllByRole('button', { name: 'Add account' })).toHaveLength(2);+ expect(screen.getByLabelText('X account in scope')).toBeInTheDocument();+ });+it('renders a not-found fallback for stale account URLs', async () => {renderPage('/x/00000000-0000-4000-8000-000000000099/health');expect(await screen.findByText(/This X account was not found/)).toBeInTheDocument();