Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: name the nested cause when a restore's media index rebuild cannot reach Postgres (#12628)

[._.]/ Adam Eivy3af3448f7067
diff --git a/server/services/backup.js b/server/services/backup.js
index 744e5d2c26..950ecfa237 100644
--- a/server/services/backup.js
+++ b/server/services/backup.js
@@ -1384,6 +1384,17 @@ export async function openSnapshotStream(destPath, snapshotId, { source } = {})
return archive;
}
+// pg rejects an unreachable database with an AggregateError whose own message
+// is empty; the useful text (e.g. ECONNREFUSED) lives on the nested errors.
+function describeReconcileFailure(reason) {
+ if (reason?.message) return reason.message;
+ if (Array.isArray(reason?.errors)) {
+ const parts = [...new Set(reason.errors.map(err => err?.code || err?.message).filter(Boolean))];
+ if (parts.length > 0) return parts.join(', ');
+ }
+ return reason?.code || String(reason);
+}
+
async function reconcileLiveFileRestore(subdirFilter) {
const refreshes = [
...(!subdirFilter || subdirFilter === 'brain' || subdirFilter.startsWith('brain/')
@@ -1411,7 +1422,7 @@ async function reconcileLiveFileRestore(subdirFilter) {
refreshes.map(({ run }) => Promise.resolve().then(run)),
);
const failures = results.flatMap((result, index) => result.status === 'rejected'
- ? [`${refreshes[index].label}: ${result.reason?.message ?? String(result.reason)}`]
+ ? [`${refreshes[index].label}: ${describeReconcileFailure(result.reason)}`]
: []);
if (failures.length > 0) {
diff --git a/server/services/backup.test.js b/server/services/backup.test.js
index 2aa8cf8310..1c7d5ea49b 100644
--- a/server/services/backup.test.js
+++ b/server/services/backup.test.js
@@ -4027,6 +4027,19 @@ describe('restoreSnapshot snapshotId, filter flags, and settings re-sync', () =>
expect(reloadSettings).toHaveBeenCalledTimes(1);
expect(invalidateBrainCaches).toHaveBeenCalledTimes(1);
});
+
+ it('names the nested cause when the media index rebuild cannot reach Postgres', async () => {
+ reconcileMediaAssets.mockRejectedValueOnce(
+ new AggregateError([Object.assign(new Error(''), { code: 'ECONNREFUSED' })], ''),
+ );
+ const proc = fakeProc();
+ spawn.mockReturnValue(proc);
+ const pending = restoreSnapshot('/dest', 'snap-1', { dryRun: false });
+ await vi.waitFor(() => expect(spawn).toHaveBeenCalled());
+ proc.emit('close', 0);
+
+ await expect(pending).rejects.toThrow(/media index rebuild: ECONNREFUSED\)/);
+ });
});
});