Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: require operator authority for the remaining Pipeline agent-backed generation routes (#10907)

Adam Eivy3b26108d7963
diff --git a/server/lib/hostControlRoutes.js b/server/lib/hostControlRoutes.js
index 275b830514..3c7bb70e98 100644
--- a/server/lib/hostControlRoutes.js
+++ b/server/lib/hostControlRoutes.js
@@ -44,11 +44,15 @@
* - pipeline and FableLoom: autopilot start is gated — with gap filing or
* self-improvement on it queues CoS agents — and so are the Pipeline
* text/visual generation operations listed under "Pipeline authoring"
- * below (#10068) and FableLoom authoring/production (#10668): callers
- * choose the provider, and the staged runner can
- * fall back to a CLI/TUI one, so they can launch a tool-capable agent
- * against stored creative text. Ordinary record CRUD, reads and
- * cancellation stay open.
+ * and "Pipeline authoring, remainder" below (#10068, #10907) and
+ * FableLoom authoring/production (#10668): callers choose the provider,
+ * and the staged runner can fall back to a CLI/TUI one, so they can
+ * launch a tool-capable agent against stored creative text. Ordinary
+ * record CRUD, reads, cancellation and SSE progress stay open, as do the
+ * deterministic Pipeline routes (series merge preview/apply, arc
+ * derive-from-manuscript/commit, manuscript cuts preview/apply, comic
+ * extract-pages, audio extract-lines, scene video, TTS and music
+ * rendering): none reaches the staged runner.
* - Creative Director and Creative Commissions (#10867): project create/edit
* choose agent instructions and provider pins; start/resume/directive/
* replan/plan-step/auto-cast/smoke-test/review enqueue or re-arm writable
@@ -558,6 +562,51 @@ export const HOST_CONTROL_ROUTES = Object.freeze([
'POST /api/pipeline/issues/:id/stages/comicPages/pages/:pageIndex/refine-render',
'POST /api/pipeline/issues/:id/stages/storyboards/scenes/:sceneIndex/shots/:shotIndex/render',
+ // Pipeline authoring, remainder (#10907): series/arc planning, analysis,
+ // manuscript, editorial and cover generation. Every entry below reaches
+ // `runStagedLLM` (or the cover render queue) with a caller-chosen
+ // providerId/model and no tool-free restriction, so a CLI/TUI provider or
+ // runtime fallback runs as an approval-bypass agent over stored prose. Gate
+ // the whole operation, including API-first requests, before any run, store
+ // write, checkpoint, SSE attach or queue effect. Autopilot, resume and retry
+ // reach the same services directly (not over HTTP) and are unaffected.
+ 'POST /api/pipeline/series/generate-concept',
+ 'POST /api/pipeline/series/merge/ai-resolve',
+ 'POST /api/pipeline/series/:id/discover-voice',
+ 'POST /api/pipeline/series/:id/arc/generate',
+ 'POST /api/pipeline/series/:id/arc/verify',
+ 'POST /api/pipeline/series/:id/arc/resolve-issues',
+ 'POST /api/pipeline/series/:id/arc/derive-from-manuscript',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/episodes/generate',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/verify',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/generate-beats',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/cover-concepts/generate',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/cover/render',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/back-cover/render',
+ 'POST /api/pipeline/series/:id/reverse-outline/generate',
+ 'POST /api/pipeline/series/:id/continuity-bible/generate',
+ 'POST /api/pipeline/issues/:id/pov-rewrites',
+ 'POST /api/pipeline/series/:id/manuscript/completeness',
+ 'POST /api/pipeline/series/:id/manuscript/completeness/stream',
+ 'POST /api/pipeline/series/:id/manuscript/review/comments/:commentId/fix',
+ 'POST /api/pipeline/series/:id/manuscript/reformat',
+ 'POST /api/pipeline/issues/:id/editorial/analyze',
+ 'POST /api/pipeline/series/:id/editorial/analyze',
+ 'POST /api/pipeline/issues/:id/judge',
+ 'POST /api/pipeline/series/:id/editorial/panel/run',
+ 'POST /api/pipeline/series/:id/editorial/rank',
+ 'POST /api/pipeline/series/:id/review',
+ 'POST /api/pipeline/series/:id/review/fix',
+ 'POST /api/pipeline/series/:id/editorial/checks/run',
+ 'POST /api/pipeline/series/:id/editorial/custom-checks/preview',
+ 'POST /api/pipeline/issues/:id/cover-concepts/generate',
+ 'POST /api/pipeline/issues/:id/stages/comicPages/cover/render',
+ 'POST /api/pipeline/issues/:id/stages/comicPages/back-cover/render',
+ 'POST /api/pipeline/issues/:id/stages/storyboards/extract-scenes',
+ 'POST /api/pipeline/issues/:id/stages/:stageId/extract-canon',
+ 'POST /api/pipeline/issues/:id/stages/:stageId/describe-canon',
+ 'POST /api/pipeline/issues/:id/stages/audio/cues/generate',
+
// Writers Room authoring reaches the staged runner, including CLI/TUI
// fallback. Stored prose and live cursor text are caller-controlled; a
// configured provider or live-mode budget does not grant host authority.
diff --git a/server/lib/hostControlRoutes.test.js b/server/lib/hostControlRoutes.test.js
index 266772acb3..90c57d9819 100644
--- a/server/lib/hostControlRoutes.test.js
+++ b/server/lib/hostControlRoutes.test.js
@@ -340,6 +340,126 @@ describe('Pipeline authoring policy (#10068)', () => {
});
});
+describe('Pipeline authoring remainder policy (#10907)', () => {
+ // Operations that reach runStagedLLM (or the cover render queue) with a
+ // caller-chosen provider; the whole operation needs operator authority.
+ const protectedRoutes = [
+ 'POST /api/pipeline/series/generate-concept',
+ 'POST /api/pipeline/series/merge/ai-resolve',
+ 'POST /api/pipeline/series/:id/discover-voice',
+ 'POST /api/pipeline/series/:id/arc/generate',
+ 'POST /api/pipeline/series/:id/arc/verify',
+ 'POST /api/pipeline/series/:id/arc/resolve-issues',
+ 'POST /api/pipeline/series/:id/arc/derive-from-manuscript',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/episodes/generate',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/verify',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/generate-beats',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/cover-concepts/generate',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/cover/render',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/back-cover/render',
+ 'POST /api/pipeline/series/:id/reverse-outline/generate',
+ 'POST /api/pipeline/series/:id/continuity-bible/generate',
+ 'POST /api/pipeline/issues/:id/pov-rewrites',
+ 'POST /api/pipeline/series/:id/manuscript/completeness',
+ 'POST /api/pipeline/series/:id/manuscript/completeness/stream',
+ 'POST /api/pipeline/series/:id/manuscript/review/comments/:commentId/fix',
+ 'POST /api/pipeline/series/:id/manuscript/reformat',
+ 'POST /api/pipeline/issues/:id/editorial/analyze',
+ 'POST /api/pipeline/series/:id/editorial/analyze',
+ 'POST /api/pipeline/issues/:id/judge',
+ 'POST /api/pipeline/series/:id/editorial/panel/run',
+ 'POST /api/pipeline/series/:id/editorial/rank',
+ 'POST /api/pipeline/series/:id/review',
+ 'POST /api/pipeline/series/:id/review/fix',
+ 'POST /api/pipeline/series/:id/editorial/checks/run',
+ 'POST /api/pipeline/series/:id/editorial/custom-checks/preview',
+ 'POST /api/pipeline/issues/:id/cover-concepts/generate',
+ 'POST /api/pipeline/issues/:id/stages/comicPages/cover/render',
+ 'POST /api/pipeline/issues/:id/stages/comicPages/back-cover/render',
+ 'POST /api/pipeline/issues/:id/stages/storyboards/extract-scenes',
+ 'POST /api/pipeline/issues/:id/stages/:stageId/extract-canon',
+ 'POST /api/pipeline/issues/:id/stages/:stageId/describe-canon',
+ 'POST /api/pipeline/issues/:id/stages/audio/cues/generate',
+ ];
+ // Reviewed Pipeline mutations that never reach the staged runner: record
+ // CRUD, cancellation, deterministic transforms and local-sidecar media.
+ const recordOrContained = [
+ 'DELETE /api/pipeline/audio/music-library/:filename',
+ 'DELETE /api/pipeline/issues/:id',
+ 'DELETE /api/pipeline/issues/:id/pov-rewrites/:rewriteId',
+ 'DELETE /api/pipeline/issues/:id/stages/audio/music',
+ 'DELETE /api/pipeline/series/:id',
+ 'DELETE /api/pipeline/series/:id/seasons/:seasonId',
+ 'DELETE /api/pipeline/editorial/custom-checks/:id',
+ 'PATCH /api/pipeline/editorial/checks/:id',
+ 'PATCH /api/pipeline/editorial/custom-checks/:id',
+ 'PATCH /api/pipeline/editorial/readiness-gate',
+ 'PATCH /api/pipeline/issues/:id',
+ 'PATCH /api/pipeline/issues/:id/stages/audio/lines/:lineIdx',
+ 'PATCH /api/pipeline/issues/:id/stages/comicPages/pages/:pageIndex',
+ 'PATCH /api/pipeline/series/:id',
+ 'PATCH /api/pipeline/series/:id/arc-fields/:field/lock',
+ 'PATCH /api/pipeline/series/:id/manuscript/review/comments/:commentId',
+ 'PATCH /api/pipeline/series/:id/seasons/:seasonId',
+ 'PATCH /api/pipeline/tts/narrate/segment',
+ 'POST /api/pipeline/editorial/custom-checks',
+ 'POST /api/pipeline/issues/:id/auto-run-text/cancel',
+ 'POST /api/pipeline/issues/:id/stages/:stageId/restore',
+ 'POST /api/pipeline/issues/:id/stages/audio/cues/:cueIdx/render',
+ 'POST /api/pipeline/issues/:id/stages/audio/extract-lines',
+ 'POST /api/pipeline/issues/:id/stages/audio/lines/:lineIdx/render',
+ 'POST /api/pipeline/issues/:id/stages/audio/music/attach',
+ 'POST /api/pipeline/issues/:id/stages/audio/music/generate',
+ 'POST /api/pipeline/issues/:id/stages/audio/music/upload',
+ 'POST /api/pipeline/issues/:id/stages/comicPages/extract-pages',
+ 'POST /api/pipeline/issues/:id/stages/storyboards/scenes/:index/video',
+ 'POST /api/pipeline/series',
+ 'POST /api/pipeline/series/:id/arc/derive-from-manuscript/commit',
+ 'POST /api/pipeline/series/:id/autopilot/cancel',
+ 'POST /api/pipeline/series/:id/autopilot/model-outcomes',
+ 'POST /api/pipeline/series/:id/autopilot/pause',
+ 'POST /api/pipeline/series/:id/continuity-bible/generate/cancel',
+ 'POST /api/pipeline/series/:id/editorial/analyze/cancel',
+ 'POST /api/pipeline/series/:id/editorial/checks/run/cancel',
+ 'POST /api/pipeline/series/:id/editorial/panel/run/cancel',
+ 'POST /api/pipeline/series/:id/issues',
+ 'POST /api/pipeline/series/:id/manuscript/completeness/cancel',
+ 'POST /api/pipeline/series/:id/manuscript/cuts/apply',
+ 'POST /api/pipeline/series/:id/manuscript/cuts/preview',
+ 'POST /api/pipeline/series/:id/manuscript/review/comments/:commentId/accept',
+ 'POST /api/pipeline/series/:id/manuscript/review/comments/:commentId/undo',
+ 'POST /api/pipeline/series/:id/reverse-outline/generate/cancel',
+ 'POST /api/pipeline/series/:id/review/cancel',
+ 'POST /api/pipeline/series/:id/review/fix/cancel',
+ 'POST /api/pipeline/series/:id/seasons',
+ 'POST /api/pipeline/series/:id/seasons/:seasonId/generate-beats/cancel',
+ 'POST /api/pipeline/series/merge',
+ 'POST /api/pipeline/series/merge/preview',
+ 'POST /api/pipeline/tts/narrate',
+ 'POST /api/pipeline/tts/narrate/segment',
+ 'POST /api/pipeline/tts/preview',
+ 'POST /api/pipeline/tts/synthesize',
+ 'PUT /api/pipeline/series/:id/manuscript/sections/:issueId',
+ ];
+
+ it('gates each audited operation and maps every entry to a mounted route', () => {
+ const mounted = new Set(getApiRouteCatalog().routes.map(({ method, path }) => method + ' ' + path));
+ for (const route of protectedRoutes) {
+ const [method, path] = route.split(' ');
+ expect(mounted.has(route), route).toBe(true);
+ expect(hostControlRouteFor(method, path), route).toBe(route);
+ }
+ });
+
+ it('classifies every mounted Pipeline mutation: gated, or reviewed as non-agent', () => {
+ const open = getApiRouteCatalog().routes
+ .filter(({ method, path }) => /^(POST|PUT|PATCH|DELETE)$/.test(method) && /^\/api\/pipeline(\/|$)/.test(path))
+ .filter(({ method, path }) => !isHostControlRoute(method, path))
+ .map(({ method, path }) => `${method} ${path}`);
+ expect([...new Set(open)].sort()).toEqual([...recordOrContained].sort());
+ });
+});
+
describe('Music Video agent workflow policy (#9869)', () => {
it('gates mounted agent workflows and keeps record, cancellation and contained rendering contracts', () => {
const protectedRoutes = [
diff --git a/server/routes/hostControlPipelineAuthoring.test.js b/server/routes/hostControlPipelineAuthoring.test.js
index d6c29b2663..c3aecbf2fb 100644
--- a/server/routes/hostControlPipelineAuthoring.test.js
+++ b/server/routes/hostControlPipelineAuthoring.test.js
@@ -37,6 +37,32 @@ const effects = vi.hoisted(() => ({
updateIssue: vi.fn(async (id, patch) => ({ id, ...patch })),
cancelAutoRun: vi.fn(() => true),
}));
+// Remainder (#10907): one double per newly gated operation plus the store writes
+// an authorized handler performs afterwards. Distinct fns, so a call count of 6
+// (one per authorized caller) is attributable to exactly one route.
+const remainder = vi.hoisted(() => {
+ const returns = {
+ pov: { status: 'ok' },
+ completeness: { issues: [], runId: 'example-run' },
+ comicCover: { stage: { cover: {} } },
+ comicBackCover: { stage: { backCover: {} } },
+ extractScenes: { extracted: { scenes: [] }, runId: 'example-run' },
+ extractCanon: { universe: {}, results: [], failures: [] },
+ describeCanon: { universe: {}, report: {} },
+ audioCues: { cues: [], runId: 'example-run' },
+ seedReview: { comments: [] },
+ updateStage: { issue: {}, stage: { cues: [] } },
+ };
+ const names = [
+ 'concepts', 'mergeAi', 'voice', 'arcOverview', 'arcVerify', 'arcResolve', 'arcDerive', 'episodes',
+ 'volumeVerify', 'volumeBeats', 'volumeCoverConcepts', 'volumeCover', 'volumeBackCover', 'reverseOutline',
+ 'continuity', 'pov', 'completeness', 'completenessStream', 'manuscriptFix', 'reformat', 'issueAnalyze',
+ 'seriesAnalyze', 'judge', 'panel', 'rank', 'seriesReview', 'seriesFix', 'checksRun', 'checkPreview',
+ 'comicCoverConcepts', 'comicCover', 'comicBackCover', 'extractScenes', 'extractCanon', 'describeCanon',
+ 'audioCues', 'seedReview', 'trendSnapshot', 'updateStage',
+ ];
+ return Object.fromEntries(names.map((name) => [name, vi.fn(async () => returns[name] ?? {})]));
+});
vi.mock('../services/auth.js', async (importOriginal) => ({
...await importOriginal(),
isAuthEnabled: vi.fn(async () => auth.enabled),
@@ -59,6 +85,10 @@ vi.mock('../services/pipeline/visualStages.js', () => ({
refineComicPageRender: effects.refineRender,
enqueueStoryboardShotStartFrame: effects.shotFrame,
enqueueStoryboardSceneVideo: vi.fn(),
+ renderComicCover: remainder.comicCover,
+ renderComicBackCover: remainder.comicBackCover,
+ renderVolumeCover: remainder.volumeCover,
+ renderVolumeBackCover: remainder.volumeBackCover,
refineComicPanelPrompt: effects.refinePanel,
generateComicPanelImagePrompts: effects.panelCandidates,
refineStoryboardScenePrompt: effects.refineScene,
@@ -67,27 +97,127 @@ vi.mock('../services/pipeline/visualStages.js', () => ({
vi.mock('../services/pipeline/series.js', async (importOriginal) => ({
...await importOriginal(),
updateSeries: effects.updateSeries,
+ getSeries: vi.fn(async (id) => ({ id, name: 'Example Series', universeId: 'example-universe' })),
}));
vi.mock('../services/pipeline/issues.js', async (importOriginal) => ({
...await importOriginal(),
updateIssue: effects.updateIssue,
+ updateStage: remainder.updateStage,
+ updateStageWithLatest: remainder.updateStage,
getIssue: vi.fn(async (id) => ({
id,
- stages: { comicPages: { pages: [{ panels: [{}] }] }, storyboards: { scenes: [{ shots: [{}] }] } },
+ seriesId: 'example-series',
+ stages: {
+ comicPages: { pages: [{ panels: [{}] }] },
+ storyboards: { scenes: [{ shots: [{}] }] },
+ prose: { output: 'Example prose' },
+ teleplay: { output: 'Example teleplay' },
+ },
})),
}));
+vi.mock('../services/pipeline/seriesCanon.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ getSeriesCanon: vi.fn(async () => ({ characters: [], places: [], objects: [] })),
+}));
+vi.mock('../services/pipeline/seriesGenerate.js', async (importOriginal) => ({
+ ...await importOriginal(), generateSeriesConcepts: remainder.concepts,
+}));
+vi.mock('../services/recordMergeAI.js', async (importOriginal) => ({
+ ...await importOriginal(), mergeFieldsWithAI: remainder.mergeAi,
+}));
+vi.mock('../services/pipeline/seriesVoiceDiscover.js', async (importOriginal) => ({
+ ...await importOriginal(), discoverSeriesVoice: remainder.voice,
+}));
+vi.mock('../services/pipeline/arcPlanner.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ generateArcOverview: remainder.arcOverview,
+ verifyArc: remainder.arcVerify,
+ resolveVerifyIssues: remainder.arcResolve,
+ deriveFromManuscript: remainder.arcDerive,
+ generateSeasonEpisodes: remainder.episodes,
+ verifyVolume: remainder.volumeVerify,
+ generateVolumeCoverConcepts: remainder.volumeCoverConcepts,
+ generateComicCoverConcepts: remainder.comicCoverConcepts,
+ analyzeManuscriptCompleteness: remainder.completeness,
+}));
+vi.mock('../services/pipeline/volumeBeatsRunner.js', async (importOriginal) => ({
+ ...await importOriginal(), startVolumeBeatsRun: remainder.volumeBeats,
+}));
+vi.mock('../services/pipeline/reverseOutline.js', async (importOriginal) => ({
+ ...await importOriginal(), startReverseOutlineRun: remainder.reverseOutline,
+}));
+vi.mock('../services/pipeline/continuityBible.js', async (importOriginal) => ({
+ ...await importOriginal(), startContinuityBibleRun: remainder.continuity,
+}));
+vi.mock('../services/pipeline/perspectiveRewrite.js', async (importOriginal) => ({
+ ...await importOriginal(), generatePerspectiveRewrite: remainder.pov,
+}));
+vi.mock('../services/pipeline/manuscriptReview.js', async (importOriginal) => ({
+ ...await importOriginal(), seedReviewFromFindings: remainder.seedReview,
+}));
+vi.mock('../services/pipeline/manuscriptFix.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ generateManuscriptFix: remainder.manuscriptFix,
+ reformatManuscriptStageText: remainder.reformat,
+}));
+vi.mock('../services/pipeline/manuscriptCompletenessRunner.js', async (importOriginal) => ({
+ ...await importOriginal(), startCompletenessReview: remainder.completenessStream,
+}));
+vi.mock('../services/pipeline/editorialScore.js', async (importOriginal) => ({
+ ...await importOriginal(), recordTrendSnapshot: remainder.trendSnapshot,
+}));
+vi.mock('../services/pipeline/editorialAnalysis.js', async (importOriginal) => ({
+ ...await importOriginal(), analyzeIssue: remainder.issueAnalyze,
+}));
+vi.mock('../services/pipeline/editorialAnalysisRunner.js', async (importOriginal) => ({
+ ...await importOriginal(), startSeriesAnalysis: remainder.seriesAnalyze,
+}));
+vi.mock('../services/pipeline/pipelineJudge.js', async (importOriginal) => ({
+ ...await importOriginal(), judgeIssue: remainder.judge,
+}));
+vi.mock('../services/pipeline/readerPanelRunner.js', async (importOriginal) => ({
+ ...await importOriginal(), startReaderPanel: remainder.panel,
+}));
+vi.mock('../services/pipeline/editorial/comparativeRank.js', async (importOriginal) => ({
+ ...await importOriginal(), runComparativeRank: remainder.rank,
+}));
+vi.mock('../services/pipeline/seriesReview.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ startSeriesReviewRun: remainder.seriesReview,
+ startSeriesFixRun: remainder.seriesFix,
+}));
+vi.mock('../services/pipeline/editorial/checkRunner.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ startEditorialChecksRun: remainder.checksRun,
+ previewCustomCheck: remainder.checkPreview,
+}));
+vi.mock('../services/sceneExtractor.js', async (importOriginal) => ({
+ ...await importOriginal(), extractScenes: remainder.extractScenes,
+}));
+vi.mock('../services/universeCanon.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ extractCanonFromProse: remainder.extractCanon,
+ describeCanonFromProse: remainder.describeCanon,
+}));
+vi.mock('../services/pipeline/audioCues.js', async (importOriginal) => ({
+ ...await importOriginal(), deriveAudioCues: remainder.audioCues,
+}));
import { authGate, hostControlRouteGate } from '../services/authGate.js';
import { createSession, revokeSessionById } from '../services/auth.js';
-import seriesRoutes from './pipeline/series.js';
-import issueRoutes from './pipeline/issues.js';
+import pipelineRoutes from './pipeline/index.js';
let ownerSession;
const id = '00000000-0000-4000-8000-000000000001';
const picker = { providerId: 'example-cli', model: 'example-model' };
const issue = `/api/pipeline/issues/${id}`;
const imageBody = { description: 'Example scene', width: 512, height: 512 };
-// [path, body, effect observed on success]
+const series = `/api/pipeline/series/${id}`;
+const season = `${series}/seasons/example-season`;
+const pickOverride = { providerOverride: 'example-cli', modelOverride: 'example-model' };
+const squarePx = { width: 512, height: 512 };
+const customCheck = { label: 'Example check', prompt: 'Flag example problems' };
+// [path, body, effect observed on success, picker key the effect receives (default: derived from the body)]
const operations = [
[`/api/pipeline/series/${id}/generate-title-logo`, picker, effects.titleLogo],
[`${issue}/stages/prose/generate`, { seedInput: 'Example seed', ...picker }, effects.generateStage],
@@ -101,6 +231,48 @@ const operations = [
[`${issue}/stages/comicPages/pages/0/refine-render`,
{ instruction: 'Example correction', width: 512, height: 512, ...picker }, effects.refineRender],
[`${issue}/stages/storyboards/scenes/0/shots/0/render`, { width: 512, height: 512 }, effects.shotFrame],
+ // Remainder (#10907)
+ ['/api/pipeline/series/generate-concept', { universeId: 'example-universe', ...picker }, remainder.concepts],
+ ['/api/pipeline/series/merge/ai-resolve', {
+ survivorId: 'ser-00000000-0000-4000-8000-000000000002', loserId: 'ser-00000000-0000-4000-8000-000000000003',
+ fields: ['name'], ...picker,
+ }, remainder.mergeAi],
+ [`${series}/discover-voice`, picker, remainder.voice],
+ [`${series}/arc/generate`, pickOverride, remainder.arcOverview],
+ [`${series}/arc/verify`, pickOverride, remainder.arcVerify],
+ [`${series}/arc/resolve-issues`, pickOverride, remainder.arcResolve],
+ [`${series}/arc/derive-from-manuscript`, pickOverride, remainder.arcDerive],
+ [`${season}/episodes/generate`, pickOverride, remainder.episodes],
+ [`${season}/verify`, pickOverride, remainder.volumeVerify],
+ [`${season}/generate-beats`, pickOverride, remainder.volumeBeats, 'providerId'],
+ [`${season}/cover-concepts/generate`, pickOverride, remainder.volumeCoverConcepts],
+ [`${season}/cover/render`, squarePx, remainder.volumeCover, null],
+ [`${season}/back-cover/render`, squarePx, remainder.volumeBackCover, null],
+ [`${series}/reverse-outline/generate`, picker, remainder.reverseOutline],
+ [`${series}/continuity-bible/generate`, picker, remainder.continuity],
+ [`${issue}/pov-rewrites`, { povCharacterId: 'example-character', ...picker }, remainder.pov],
+ [`${series}/manuscript/completeness`, pickOverride, remainder.completeness],
+ [`${series}/manuscript/completeness/stream`, pickOverride, remainder.completenessStream],
+ [`${series}/manuscript/review/comments/example-comment/fix`, pickOverride, remainder.manuscriptFix],
+ [`${series}/manuscript/reformat`, { stageId: 'prose', content: 'Example text', ...pickOverride }, remainder.reformat],
+ [`${issue}/editorial/analyze`, picker, remainder.issueAnalyze],
+ [`${series}/editorial/analyze`, picker, remainder.seriesAnalyze],
+ [`${issue}/judge`, picker, remainder.judge],
+ [`${series}/editorial/panel/run`, picker, remainder.panel],
+ [`${series}/editorial/rank`, picker, remainder.rank],
+ [`${series}/review`, picker, remainder.seriesReview, 'providerOverride'],
+ [`${series}/review/fix`, picker, remainder.seriesFix, 'providerOverride'],
+ [`${series}/editorial/checks/run`, picker, remainder.checksRun, 'providerOverride'],
+ [`${series}/editorial/custom-checks/preview`, { ...customCheck, ...picker }, remainder.checkPreview, 'providerOverride'],
+ [`${issue}/cover-concepts/generate`, pickOverride, remainder.comicCoverConcepts],
+ [`${issue}/stages/comicPages/cover/render`, squarePx, remainder.comicCover, null],
+ [`${issue}/stages/comicPages/back-cover/render`, squarePx, remainder.comicBackCover, null],
+ [`${issue}/stages/storyboards/extract-scenes`, { force: true, ...pickOverride }, remainder.extractScenes],
+ [`${issue}/stages/prose/extract-canon`, { providerOverride: 'example-cli', model: 'example-model' }, remainder.extractCanon],
+ [`${issue}/stages/prose/describe-canon`, {
+ providerOverride: 'example-cli', model: 'example-model', targets: [{ id: 'example-noun', kind: 'character' }],
+ }, remainder.describeCanon],
+ [`${issue}/stages/audio/cues/generate`, pickOverride, remainder.audioCues],
];
const appFor = (address = '192.0.2.10') => {
const app = express();
@@ -109,8 +281,7 @@ const appFor = (address = '192.0.2.10') => {
next();
});
app.use(authGate, hostControlRouteGate, express.json());
- app.use('/api/pipeline', seriesRoutes);
- app.use('/api/pipeline', issueRoutes);
+ app.use('/api/pipeline', pipelineRoutes);
app.use(errorMiddleware);
return app;
};
@@ -120,7 +291,7 @@ const call = (app, [path, body], headers = {}, method = 'post') => {
return pending.send(body);
};
const expectNoEffects = () => {
- for (const effect of Object.values(effects)) expect(effect).not.toHaveBeenCalled();
+ for (const effect of [...Object.values(effects), ...Object.values(remainder)]) expect(effect).not.toHaveBeenCalled();
};
beforeEach(async () => {
@@ -129,7 +300,7 @@ beforeEach(async () => {
ownerSession = await createSession();
});
-describe('Pipeline agent-backed generation authority (#10068)', () => {
+describe('Pipeline agent-backed generation authority (#10068, #10907)', () => {
it('refuses remote and proxy-marked password-free callers before any effect', async () => {
for (const operation of operations) {
for (const [address, headers] of [
@@ -207,11 +378,11 @@ describe('Pipeline agent-backed generation authority (#10068)', () => {
expect(response.status, `${operation[0]}: ${JSON.stringify(response.body)}`).toBe(200);
}
}
- for (const [path, body, effect] of operations) {
+ for (const [path, body, effect, key = ['providerId', 'providerOverride'].find((name) => body[name])] of operations) {
expect(effect, path).toHaveBeenCalledTimes(6);
- if (body.providerId) {
- const options = effect.mock.lastCall.find((value) => value && typeof value === 'object' && value.providerId);
- expect(options, path).toEqual(expect.objectContaining(picker));
+ if (key) {
+ const options = effect.mock.lastCall.find((value) => value && typeof value === 'object' && value[key]);
+ expect(options?.[key], path).toBe('example-cli');
}
}
});
diff --git a/server/routes/hostControlPipelineProviderDispatch.test.js b/server/routes/hostControlPipelineProviderDispatch.test.js
new file mode 100644
index 0000000000..6de9a1a514
--- /dev/null
+++ b/server/routes/hostControlPipelineProviderDispatch.test.js
@@ -0,0 +1,139 @@
+import { afterAll, afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import express from 'express';
+import { request } from '../lib/testHelper.js';
+import { errorMiddleware } from '../lib/errorHandler.js';
+import { cleanupTempDataRoots, lazyTempDataRoot, makePathsProxy } from '../lib/mockPathsDataRoot.js';
+
+vi.mock('../lib/fileUtils.js', async (importOriginal) =>
+ makePathsProxy(await importOriginal(), { dataRoot: () => lazyTempDataRoot('portos-pipeline-dispatch-') }));
+afterAll(cleanupTempDataRoots);
+afterEach(() => vi.restoreAllMocks());
+
+// Real Pipeline routes, real stage runner, real auth gates (#10907). Only the
+// edges are doubled: the provider registry (one synthetic CLI provider), the
+// prompt renderer, run-record creation, the series record, and the provider
+// execution itself. `runPromptThroughProvider` is the sink the audit named, so
+// a refused request must leave it untouched and an authorized one must reach it
+// with the CLI provider the caller picked.
+const auth = vi.hoisted(() => ({ enabled: false }));
+const cliProvider = vi.hoisted(() => ({
+ id: 'example-cli', name: 'Example CLI', type: 'cli', enabled: true, command: 'example-agent', args: [], defaultModel: 'example-model',
+}));
+const sink = vi.hoisted(() => ({
+ runPromptThroughProvider: vi.fn(async () => ({ text: '{"logline":"Example","scenes":[],"plotlines":[]}' })),
+}));
+const SERIES_ID = 'ser-00000000-0000-4000-8000-000000000001';
+
+vi.mock('../services/auth.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ isAuthEnabled: vi.fn(async () => auth.enabled),
+ verifyPassword: vi.fn(async () => true),
+}));
+vi.mock('../services/settings.js', () => ({
+ settingsEvents: { on: vi.fn(), off: vi.fn(), emit: vi.fn() },
+ getSettings: vi.fn(async () => ({})),
+}));
+vi.mock('../services/providers.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ getProviderById: vi.fn(async (providerId) => (providerId === cliProvider.id ? cliProvider : null)),
+ getActiveProvider: vi.fn(async () => cliProvider),
+}));
+vi.mock('../services/promptService.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ buildPrompt: vi.fn(async () => 'Example rendered prompt'),
+ getStage: vi.fn(() => ({})),
+}));
+vi.mock('../services/runner.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ createRun: vi.fn(async () => ({ runId: 'example-run-0001' })),
+ patchRunMetadata: vi.fn(async () => undefined),
+}));
+vi.mock('../services/promptRunner.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ runPromptThroughProvider: sink.runPromptThroughProvider,
+}));
+vi.mock('../services/pipeline/series.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ getSeries: vi.fn(async (id) => ({ id, name: 'Example Series', locked: {} })),
+}));
+vi.mock('../services/pipeline/arcPlanner/context.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ buildArcOverviewContext: vi.fn(async () => ({})),
+}));
+vi.mock('../services/pipeline/arcPlanner.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ collectManuscriptSections: vi.fn(async () => [
+ { issueId: 'example-issue', number: 1, title: 'One', stageId: 'prose', content: 'Example prose.' },
+ ]),
+}));
+vi.mock('../services/pipeline/seriesCanon.js', async (importOriginal) => ({
+ ...await importOriginal(),
+ getSeriesCanon: vi.fn(async () => ({ characters: [] })),
+}));
+
+import { authGate, hostControlRouteGate } from '../services/authGate.js';
+import { createSession } from '../services/auth.js';
+import pipelineRoutes from './pipeline/index.js';
+
+const operations = [
+ [`/api/pipeline/series/${SERIES_ID}/reverse-outline/generate`, { providerId: cliProvider.id, force: true }],
+ [`/api/pipeline/series/${SERIES_ID}/arc/generate`, { providerOverride: cliProvider.id }],
+];
+const appFor = (address) => {
+ const app = express();
+ app.use((req, _res, next) => {
+ Object.defineProperty(req.socket, 'remoteAddress', { value: address });
+ next();
+ });
+ app.use(authGate, hostControlRouteGate, express.json());
+ app.use('/api/pipeline', pipelineRoutes);
+ app.use(errorMiddleware);
+ return app;
+};
+const post = (app, [path, body], headers = {}) => {
+ const pending = request(app).post(path);
+ for (const [name, value] of Object.entries(headers)) pending.set(name, value);
+ return pending.send(body);
+};
+
+beforeEach(() => {
+ vi.clearAllMocks();
+ auth.enabled = false;
+});
+
+describe('Pipeline generation never reaches a CLI provider for unauthorized callers (#10907)', () => {
+ it('refuses a remote password-free caller and a legacy Basic holder before the provider sink', async () => {
+ for (const operation of operations) {
+ const remote = await post(appFor('192.0.2.10'), operation);
+ expect([remote.status, remote.body.code], operation[0]).toEqual([403, 'HOST_CONTROL_FORBIDDEN']);
+ }
+ auth.enabled = true;
+ for (const operation of operations) {
+ const basic = await post(appFor('192.0.2.10'), operation, {
+ Authorization: 'Basic ' + Buffer.from(':example-password').toString('base64'),
+ });
+ expect([basic.status, basic.body.code], operation[0]).toEqual([403, 'HOST_CONTROL_FORBIDDEN']);
+ }
+ // An in-flight reverse-outline run starts asynchronously; give it a turn to
+ // reach the sink if the gate had let it through.
+ await new Promise((resolve) => setImmediate(resolve));
+ expect(sink.runPromptThroughProvider).not.toHaveBeenCalled();
+ });
+
+ it('lets a local caller and an operator session run the same operations on the chosen CLI provider', async () => {
+ const operator = await createSession();
+ for (const [enabled, address, headers] of [
+ [false, '127.0.0.1', {}],
+ [true, '192.0.2.10', { Authorization: `Bearer ${operator.token}` }],
+ ]) {
+ auth.enabled = enabled;
+ for (const operation of operations) {
+ sink.runPromptThroughProvider.mockClear();
+ const response = await post(appFor(address), operation, headers);
+ expect(response.status, `${operation[0]}: ${JSON.stringify(response.body)}`).toBe(200);
+ await vi.waitFor(() => expect(sink.runPromptThroughProvider, operation[0]).toHaveBeenCalledTimes(1));
+ expect(sink.runPromptThroughProvider.mock.calls[0][0].provider).toEqual(cliProvider);
+ }
+ }
+ });
+});