Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: log failed task-block and claim-release writes on spawn failure (#12982) (#13026)

[._.]/3dff1fe51ee7
diff --git a/server/services/agentSpawnPreparation.js b/server/services/agentSpawnPreparation.js
index 6e7bb2676c..0f1d900337 100644
--- a/server/services/agentSpawnPreparation.js
+++ b/server/services/agentSpawnPreparation.js
@@ -38,7 +38,9 @@ export function createAgentSpawnContext(task) {
completeExecution(context.toolExecution.id, { success: false });
}
if (context.claimAcquired) {
- await updateTask(context.task.id, { metadata: buildRelease() }, context.task.taskType || 'user').catch(() => {});
+ await updateTask(context.task.id, { metadata: buildRelease() }, context.task.taskType || 'user').catch((err) => {
+ emitLog('warn', `Failed to release claim for task ${context.task.id}: ${err.message}`, { taskId: context.task.id });
+ });
}
await releaseAppReviewMarker(context.task.metadata?.app).catch(err => {
emitLog('warn', `Failed to release app review marker for ${context.task.metadata?.app}: ${err.message}`, { taskId: context.task.id });
@@ -64,7 +66,9 @@ export function createAgentSpawnContext(task) {
blockedCategory: category,
blockedAt: new Date().toISOString(),
},
- }, context.task.taskType || 'user').catch(() => {});
+ }, context.task.taskType || 'user').catch((err) => {
+ emitLog('warn', `Failed to persist blocked state for task ${context.task.id}: ${err.message}`, { taskId: context.task.id });
+ });
}
await context.cleanupOnError(reason);
if (emit === 'agent:error'
diff --git a/server/services/agentSpawnPreparation.test.js b/server/services/agentSpawnPreparation.test.js
index 66bb0b9745..6f616ef2c5 100644
--- a/server/services/agentSpawnPreparation.test.js
+++ b/server/services/agentSpawnPreparation.test.js
@@ -15,7 +15,11 @@ vi.mock('./agentPromptBuilder.js', () => ({ getAppWorkspace: vi.fn() }));
vi.mock('./instanceIdentity.js', () => ({ ensureInstanceId: vi.fn() }));
vi.mock('./appActivity.js', () => ({ releaseAppReviewMarker: vi.fn() }));
-import { prepareAgentSpawn } from './agentSpawnPreparation.js';
+import { prepareAgentSpawn, createAgentSpawnContext } from './agentSpawnPreparation.js';
+import { cosEvents, emitLog } from './cosEvents.js';
+import { updateTask } from './cos.js';
+import { release } from './executionLanes.js';
+import { releaseAppReviewMarker } from './appActivity.js';
describe('prepareAgentSpawn — duplicate dispatch', () => {
it('skips a task another run already owns and reports the skip on stdout, not stderr', async () => {
@@ -30,3 +34,19 @@ describe('prepareAgentSpawn — duplicate dispatch', () => {
expect(warn).not.toHaveBeenCalled();
});
});
+
+describe('createAgentSpawnContext — failed bookkeeping writes', () => {
+ it('logs a rejected block write and still cleans up and emits agent:error', async () => {
+ updateTask.mockReset().mockRejectedValue(new Error('store down'));
+ releaseAppReviewMarker.mockResolvedValue(); emitLog.mockClear(); release.mockClear(); cosEvents.emit.mockClear();
+ const context = createAgentSpawnContext({ id: 'task-9', taskType: 'user', metadata: {} });
+ Object.assign(context, { laneAcquired: true, agentId: 'agent-9', claimAcquired: true });
+
+ expect(await context.blockAndBail({ reason: 'no provider', category: 'config' })).toBeNull();
+
+ expect(emitLog).toHaveBeenCalledWith('warn', expect.stringContaining('Failed to persist blocked state for task task-9: store down'), { taskId: 'task-9' });
+ expect(emitLog).toHaveBeenCalledWith('warn', expect.stringContaining('Failed to release claim for task task-9: store down'), { taskId: 'task-9' });
+ expect(release).toHaveBeenCalledWith('agent-9');
+ expect(cosEvents.emit).toHaveBeenCalledWith('agent:error', expect.objectContaining({ taskId: 'task-9' }));
+ });
+});