Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: re-check an interrupted snapshot under its lease before marking it failed (#12618)
[._.]/ Adam Eivy3e5485fd5b7c
diff --git a/server/services/backup.js b/server/services/backup.jsindex 691415e846..bfb9b29108 100644--- a/server/services/backup.js+++ b/server/services/backup.js@@ -1159,19 +1159,27 @@ async function markInterruptedSnapshotsFailed(snapshotsRoot) {if (!entry.isDirectory() || entry.name.startsWith('.') || !SNAPSHOT_ID_PATTERN.test(entry.name)) continue;const id = entry.name;const snapshotDir = join(snapshotsRoot, id);- const { interrupted, failed } = await snapshotState(snapshotDir, id, true);- if (!interrupted || failed) continue;+ const isCandidate = ({ interrupted, failed }) => interrupted && !failed;+ // Lease only candidates, so a download starting now is not refused+ // SNAPSHOT_DELETING by a healthy snapshot's sweep.+ if (!isCandidate(await snapshotState(snapshotDir, id, true))) continue;+ // Own the snapshot before the final state check, as deleteSnapshot does.const { release, refusal } = await claimSnapshotLease(snapshotDir, 'delete');if (refusal) continue;- const removeIfPresent = (path) => unlink(path).catch(err => { if (err.code !== 'ENOENT') throw err; });- await writeFile(failedMarkerPath(snapshotDir), INTERRUPTED_FAILURE_REASON)- .then(() => removeIfPresent(markerPath(snapshotDir)))- .then(() => removeIfPresent(parentMarkerPath(snapshotDir, id)))- .then(- () => { marked += 1; },- err => console.error(`❌ Backup: failed to mark interrupted snapshot ${id} failed: code=${err?.code ?? 'UNKNOWN'}`),- );- release();+ try {+ const exists = await stat(snapshotDir).then(info => info.isDirectory(), () => false);+ if (!exists || !isCandidate(await snapshotState(snapshotDir, id, true))) continue;+ const removeIfPresent = (path) => unlink(path).catch(err => { if (err.code !== 'ENOENT') throw err; });+ await writeFile(failedMarkerPath(snapshotDir), INTERRUPTED_FAILURE_REASON)+ .then(() => removeIfPresent(markerPath(snapshotDir)))+ .then(() => removeIfPresent(parentMarkerPath(snapshotDir, id)))+ .then(+ () => { marked += 1; },+ err => console.error(`❌ Backup: failed to mark interrupted snapshot ${id} failed: code=${err?.code ?? 'UNKNOWN'}`),+ );+ } finally {+ release();+ }}if (marked) console.log(`💾 Backup: marked ${marked} interrupted snapshot(s) failed`);}