Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Music video: Plan step's art direction row opens the Look step (#11410)

[._.]/3efd720b98bd
diff --git a/client/src/lib/musicVideoStages.js b/client/src/lib/musicVideoStages.js
index dc159df14a..e7f0aa6329 100644
--- a/client/src/lib/musicVideoStages.js
+++ b/client/src/lib/musicVideoStages.js
@@ -762,7 +762,8 @@ function feedbackItem(project, stage, readiness, { optional = false } = {}) {
// Storyboard readiness problems, grouped by what the user has to go fix. The
// server returns plain sentences; the first matching rule picks the group.
const STORYBOARD_PROBLEM_GROUPS = [
- { id: 'art', label: 'Art direction', test: /art direction|art feedback/i, action: { label: 'Review art direction', anchor: APPROVAL_ANCHORS.art } },
+ // The art approval lives on the Look step, so the button goes there.
+ { id: 'art', label: 'Art direction', test: /art direction|art feedback/i, action: { label: 'Review art direction', stage: APPROVAL_STAGES.art, anchor: APPROVAL_ANCHORS.art } },
// A document storyboard needs a manifest from its current build; its message mentions timing, so it is matched first.
{ id: 'manifest', label: 'Document shot manifest', test: /shot manifest/i, action: { label: 'Import the shot manifest', anchor: 'mv-review-planning' } },
{ id: 'lyrics', label: 'Lyrics', test: /lyrics|instrumental/i, action: { label: 'Import lyrics', stage: 'setup', anchor: 'mv-lyrics-import' } },
@@ -782,11 +783,16 @@ function storyboardProblemItems(readiness, scenes = []) {
return [...STORYBOARD_PROBLEM_GROUPS.flatMap((group, index) => {
const earlier = STORYBOARD_PROBLEM_GROUPS.slice(0, index);
const mine = problems.filter((text) => group.test.test(text) && !earlier.some((g) => g.test.test(text)));
- return mine.length ? [{ id: `board-${group.id}`, label: group.label, done: false, details: mine, action: group.action }] : [];
+ if (!mine.length) return [];
+ // An art approval that went stale says what changed, so the row is not a bare "approve first".
+ const stale = group.id === 'art' && staleApprovalText(readiness?.art?.stale);
+ const details = stale ? mine.map((text) => (ART_APPROVAL_PROBLEM.test(text) ? `${stale} Approve it again on the Look step.` : text)) : mine;
+ return [{ id: `board-${group.id}`, label: group.label, done: false, details, action: group.action }];
}), ...(anchors ? [anchors] : [])];
}
const ANCHOR_PROBLEM = /^Review lyric anchors for /;
+const ART_APPROVAL_PROBLEM = /^Review and approve the current art direction/;
const quoted = (lines) => (lines.length ? lines.map((line) => `“${line}”`).join(' / ') : 'nothing');
/**
diff --git a/client/src/lib/musicVideoStages.test.js b/client/src/lib/musicVideoStages.test.js
index c331e4f92d..28d2ea9c9a 100644
--- a/client/src/lib/musicVideoStages.test.js
+++ b/client/src/lib/musicVideoStages.test.js
@@ -474,6 +474,12 @@ describe('stageChecklist', () => {
expect(stageChecklist('setup', { id: 'p', autonomousRun: { status: 'awaiting-approval' } })[0].detail).toBe('The autonomous run is waiting for your approval.');
expect(stageChecklist('board', castProject({ scenes: [scene()] }), NOT_APPROVED).map((i) => [i.id, i.done]))
.toEqual([['shots', true], ['board-art', false]]);
+ // The Plan step's art row goes to the Look step, where the art approval is, and says what changed.
+ const artRow = (readiness) => stageChecklist('board', castProject({ scenes: [scene()] }), readiness).find((i) => i.id === 'board-art');
+ expect(artRow(NOT_APPROVED)).toMatchObject({ details: ['Review and approve the current art direction first.'],
+ action: { label: 'Review art direction', stage: 'cast-sets', anchor: 'mv-review-art' } });
+ expect(artRow({ ...NOT_APPROVED, art: { approved: false, problems: [], stale: { changedFields: ['visual spec'] } } }).details)
+ .toEqual(['Approved earlier — changed since: visual spec. Approve it again on the Look step.']);
expect(stageChecklist('produce', castProject({ scenes: [scene()] }), NOT_APPROVED).find((i) => i.id === 'approve-storyboard'))
.toMatchObject({ done: false, detail: 'Finish the plan first.', action: { stage: 'board' } });
expect(stageChecklist('produce', castProject({ scenes: [scene(), scene({ sceneId: 's2', videoHistoryId: null })] }), APPROVED)[0])