Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: serialize agent activity writes per agent and day so concurrent logs are not lost (#12964)

[._.]/ Adam Eivy419fd929cd1a
diff --git a/server/services/agentActivity.js b/server/services/agentActivity.js
index 64ffa05047..586a8728bb 100644
--- a/server/services/agentActivity.js
+++ b/server/services/agentActivity.js
@@ -10,6 +10,7 @@ import { existsSync } from 'fs';
import { join } from 'path';
import EventEmitter from 'events';
import { ensureDir, getDateString, atomicWrite, PATHS } from '../lib/fileUtils.js';
+import { createKeyedFileWriteQueue } from '../lib/fileWriteQueue.js';
const AGENTS_DIR = PATHS.agentPersonalities;
const ACTIVITY_DIR = join(AGENTS_DIR, 'activity');
@@ -18,6 +19,11 @@ const ACTIVITY_DIR = join(AGENTS_DIR, 'activity');
// activity and is never read as a day nor unlinked as an expired one.
const DAY_FILE_RE = /^\d{4}-\d{2}-\d{2}\.json$/;
+// Each day file is a whole-file JSON read-modify-write. Keyed per agent/day so
+// concurrent logActivity calls for one file serialize (no lost entries) while
+// different agents or days still write in parallel.
+const queueActivityWrite = createKeyedFileWriteQueue();
+
// Event emitter for activity events
export const activityEvents = new EventEmitter();
@@ -80,8 +86,6 @@ export async function logActivity(activity) {
const date = new Date(timestamp || Date.now());
const dateStr = getDateString(date);
- const data = await loadActivity(agentId, date);
-
const entry = {
id: `${Date.now()}-${Math.random().toString(36).substr(2, 9)}`,
accountId,
@@ -95,8 +99,11 @@ export async function logActivity(activity) {
timestamp: timestamp || date.toISOString()
};
- data.activities.push(entry);
- await saveActivity(agentId, dateStr, data);
+ await queueActivityWrite(`${agentId}/${dateStr}`, async () => {
+ const data = await loadActivity(agentId, date);
+ data.activities.push(entry);
+ await saveActivity(agentId, dateStr, data);
+ });
// Invalidate cache for this account
todayCache.delete(`${accountId}-${action}`);
diff --git a/server/services/agentActivity.test.js b/server/services/agentActivity.test.js
index f410176b46..77b7cd99b7 100644
--- a/server/services/agentActivity.test.js
+++ b/server/services/agentActivity.test.js
@@ -1,5 +1,5 @@
import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest';
-import { mkdir, readdir, rm, writeFile } from 'fs/promises';
+import { mkdir, readdir, readFile, rm, writeFile } from 'fs/promises';
import { join } from 'path';
import { mockPathsDataRoot } from '../lib/mockPathsDataRoot.js';
@@ -10,7 +10,7 @@ vi.mock('../lib/fileUtils.js', async () => {
return makeProxy(actual);
});
-const { cleanupOldActivity, getActivityTimeline } = await import('./agentActivity.js');
+const { cleanupOldActivity, getActivityTimeline, getTodayActionCount, logActivity } = await import('./agentActivity.js');
const activityRoot = join(tempRoot, 'agents', 'activity');
@@ -140,3 +140,31 @@ describe('cleanupOldActivity', () => {
await expect(dayFiles()).resolves.toEqual([`${old}.json`, `${today}.json`].sort());
});
});
+
+describe('logActivity concurrency', () => {
+ beforeEach(async () => {
+ await rm(activityRoot, { recursive: true, force: true });
+ });
+
+ // Fire-and-forget bursts (WebSocket frames) must not lose entries to a
+ // load → push → save race on the same agent/day file.
+ it('persists every entry from an unawaited burst for one agent and day', async () => {
+ const accountId = 'burst-account';
+ const timestamp = new Date().toISOString();
+ const writes = Array.from({ length: 20 }, (_, index) => logActivity({
+ agentId: 'agent-burst',
+ accountId,
+ action: 'burst-action',
+ status: 'completed',
+ params: { index },
+ timestamp,
+ }));
+ await Promise.all(writes);
+
+ const dayFile = (await readdir(join(activityRoot, 'agent-burst')))[0];
+ const { activities } = JSON.parse(await readFile(join(activityRoot, 'agent-burst', dayFile), 'utf-8'));
+ expect(activities).toHaveLength(20);
+ expect(new Set(activities.map(a => a.params.index)).size).toBe(20);
+ await expect(getTodayActionCount(accountId, 'burst-action')).resolves.toBe(20);
+ });
+});