Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: route native recycle changes through Windows CI (#13251)

[._.]/ Adam Eivy441694daf7c5
diff --git a/scripts/ci-test-plan.js b/scripts/ci-test-plan.js
index da1e4d35dc..b192392954 100644
--- a/scripts/ci-test-plan.js
+++ b/scripts/ci-test-plan.js
@@ -284,6 +284,8 @@ export const WINDOWS_RISK_RULES = [
/\.(?:ps1|cmd|bat)$/i,
/^scripts\/fix-windows-console(?:\.test)?\.js$/,
/^scripts\/ps1-bom\.test\.js$/,
+ // Shell32 recycling and its opt-in real-bin smoke require an actual Windows runner.
+ /^server\/lib\/nativeTrash(?:\.(?:smoke\.)?test)?\.js$/,
/^server\/lib\/(?:bufferedSpawn|detachedSpawn|childProcess|bashResolver|processEnv|platform|spawnCwd|cliProviderRun|grok)\b/,
// The cmd.exe wrap and npm-shim bypass every Windows CLI launch goes through.
/^server\/lib\/aiToolkit\/internal\/windowsSafeSpawn\.js$/,
diff --git a/scripts/ci-test-plan.test.js b/scripts/ci-test-plan.test.js
index 8e45c0caa5..9d7cd70c2f 100644
--- a/scripts/ci-test-plan.test.js
+++ b/scripts/ci-test-plan.test.js
@@ -1673,6 +1673,9 @@ describe('Windows escalation on a full plan (#7440)', () => {
'scripts/launch.cmd',
'scripts/fix-windows-console.js',
'scripts/ps1-bom.test.js',
+ 'server/lib/nativeTrash.js',
+ 'server/lib/nativeTrash.test.js',
+ 'server/lib/nativeTrash.smoke.test.js',
'server/lib/bufferedSpawn.js',
'server/lib/aiToolkit/internal/windowsSafeSpawn.js',
'server/lib/pathSafety.js',
@@ -1722,6 +1725,26 @@ describe('Windows escalation on a full plan (#7440)', () => {
expect(plan(['server/lib/bufferedSpawn.js']).windows).toBe(true);
});
+ it('routes native recycling source and both tests to real Windows coverage (#13251)', () => {
+ const source = 'server/lib/nativeTrash.js';
+ const tests = ['server/lib/nativeTrash.test.js', 'server/lib/nativeTrash.smoke.test.js'];
+ const unrelated = 'server/lib/nativeTrashXdg.test.js';
+ const trackedFiles = [...TRACKED, ...WINDOWS_CONTRACT_TESTS, source, ...tests, unrelated];
+ for (const changedFiles of [[source], ...tests.map(path => [path]), [source, ...tests]]) {
+ const selected = buildCiTestPlan(changedFiles, { trackedFiles, clientDependencies: [] });
+ expect(selected.full).toBe(false);
+ expect(selected.windows).toBe(true);
+ expect(selected.windowsMode).toBe(changedFiles.includes(source) ? 'related' : 'files');
+ expect(selected.windowsSources).toEqual(changedFiles.includes(source) ? [source] : []);
+ expect(selected.windowsFiles).toEqual([...new Set([
+ ...WINDOWS_CONTRACT_TESTS, ...changedFiles.filter(path => tests.includes(path)),
+ ])].sort());
+ expect(selected.windowsFiles).not.toContain(unrelated);
+ }
+ // The Linux XDG implementation does not broaden this Windows-only rule.
+ expect(buildCiTestPlan([unrelated], { trackedFiles }).windows).toBe(false);
+ });
+
it('selects the changed cancellation fixtures explicitly on Windows without widening unrelated tests (#11641)', () => {
const fixtures = ['server/lib/mockPathsDataRoot.test.js', 'server/services/cosAgentIndex.completionOrder.test.js'];
const unrelated = 'server/services/exampleUnrelated.test.js';