Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix([issue-12656]): record when the load wait began and cover the page-side script

[._.]/ Adam Eivy455a934ee786
diff --git a/server/services/htmlComposition/browser.js b/server/services/htmlComposition/browser.js
index 3623a499ab..a79dd63d7f 100644
--- a/server/services/htmlComposition/browser.js
+++ b/server/services/htmlComposition/browser.js
@@ -443,12 +443,13 @@ async function connectComposition(assets, {
// failures separate (#12656): a command timeout means the renderer stopped
// answering (host starvation or a hung target); this stall means the page
// answered but its load event never came, which is a lifecycle fault.
+ const loadWaitMs = sinceStart();
const loaded = await evaluate(`new Promise(resolve => {
if (document.readyState === 'complete') return resolve('loaded');
addEventListener('load', () => resolve('loaded'), { once: true });
setTimeout(() => resolve('stalled:' + document.readyState), ${DOCUMENT_LOAD_DEADLINE_MS});
})`, 'document load');
- if (loaded !== 'loaded') throw new Error(`Composition document load stalled: ${loaded.slice('stalled:'.length)} after ${DOCUMENT_LOAD_DEADLINE_MS}ms while the page stayed responsive (${commandFacts(sinceStart())})`);
+ if (typeof loaded === 'string' && loaded.startsWith('stalled:')) throw new Error(`Composition document load stalled: ${loaded.slice('stalled:'.length)} after ${DOCUMENT_LOAD_DEADLINE_MS}ms while the page stayed responsive (${commandFacts(loadWaitMs)})`);
phase = 'font-readiness';
await evaluate('document.fonts.ready.then(() => true)', 'font readiness');
phase = 'ready';
diff --git a/server/services/htmlComposition/browser.setupDiagnostics.test.js b/server/services/htmlComposition/browser.setupDiagnostics.test.js
index 2563400c69..6f9dc78021 100644
--- a/server/services/htmlComposition/browser.setupDiagnostics.test.js
+++ b/server/services/htmlComposition/browser.setupDiagnostics.test.js
@@ -6,13 +6,14 @@ import { afterAll, afterEach, describe, expect, it, vi } from 'vitest';
import { EventEmitter } from 'node:events';
import { mkdir, writeFile } from 'node:fs/promises';
import { join } from 'node:path';
+import vm from 'node:vm';
import { cleanupTempDataRoots, lazyTempDataRoot, makePathsProxy } from '../../lib/mockPathsDataRoot.js';
vi.mock('../../lib/fileUtils.js', async importOriginal => makePathsProxy(await importOriginal(), {
dataRoot: () => lazyTempDataRoot('portos-composition-setup-diagnostics-'),
}));
-const owner = vi.hoisted(() => ({ order: [], transport: null, sent: null }));
+const owner = vi.hoisted(() => ({ order: [], transport: null, sent: null, expressions: [] }));
vi.mock('./ownedBrowser.js', () => ({
launchCompositionBrowser: async () => ({
transport: owner.transport,
@@ -39,7 +40,8 @@ function scriptedTransport(stallOn, replies = {}) {
readyState: 1,
send(text, callback) {
callback?.();
- const { id, method } = JSON.parse(text);
+ const { id, method, params } = JSON.parse(text);
+ if (method === 'Runtime.evaluate') owner.expressions.push(params.expression);
if (method === stallOn) return stalled();
setImmediate(() => emitter.emit('message', Buffer.from(JSON.stringify({ id, result: replies[method] ?? REPLIES[method] ?? {} }))));
},
@@ -52,7 +54,7 @@ function scriptedTransport(stallOn, replies = {}) {
const { PATHS } = await import('../../lib/fileUtils.js');
const { openComposition } = await import('./browser.js');
-afterEach(() => { vi.useRealTimers(); owner.order = []; });
+afterEach(() => { vi.useRealTimers(); owner.order = []; owner.expressions = []; });
afterAll(() => cleanupTempDataRoots());
describe('composition CDP setup timeout evidence', () => {
@@ -108,5 +110,30 @@ describe('composition CDP setup timeout evidence', () => {
expect(error.message).toMatch(/^Composition document load stalled: loading after \d+ms while the page stayed responsive \(phase=document-load,/);
expect(error.message).not.toContain('Browser command timed out');
+ // sentMs is when the wait began, not the moment of failure.
+ expect(error.message).toMatch(/sentMs=\d+, timeoutMs=\d+/);
+ });
+
+ it('sends a load wait that resolves on a complete document or the load event and gives up with the readyState at the deadline', async () => {
+ const { directory } = await openStagedComposition('load-script', scriptedTransport(null, { 'Runtime.evaluate': { result: { value: 'loaded' } } }));
+ const page = await openComposition(directory, { ownedBrowser: true });
+ await page.close();
+ const expression = owner.expressions[0];
+ expect(expression).toContain('27000');
+
+ const run = (readyState) => {
+ const timers = [];
+ const listeners = [];
+ const sandbox = { document: { readyState }, addEventListener: (_name, listener) => listeners.push(listener), setTimeout: (callback, ms) => timers.push({ callback, ms }) };
+ return { result: vm.runInNewContext(expression, sandbox), timers, listeners };
+ };
+ await expect(run('complete').result).resolves.toBe('loaded');
+ const loading = run('loading');
+ loading.listeners[0]();
+ await expect(loading.result).resolves.toBe('loaded');
+ const stuck = run('interactive');
+ expect(stuck.timers.map(timer => timer.ms)).toEqual([27000]);
+ stuck.timers[0].callback();
+ await expect(stuck.result).resolves.toBe('stalled:interactive');
});
});