Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
Give test-owned CDP browsers a fixture-owned artifacts root (#11584)
[._.]/ Adam Eivy46eeaa588805
diff --git a/server/routes/musicVideoProductionReview.browser.test.js b/server/routes/musicVideoProductionReview.browser.test.jsindex 234cf37f7b..c8a288320e 100644--- a/server/routes/musicVideoProductionReview.browser.test.js+++ b/server/routes/musicVideoProductionReview.browser.test.js@@ -18,7 +18,7 @@ vi.mock('../services/auth.js', () => ({ isAuthEnabled: async () => true, verifyPlet endpoint;vi.mock('../services/browserService.js', () => ({ loadConfig: async () => ({ chromePath: chrome }), cdpRequest: path => fetch(`${endpoint}${path}`) }));const { findFfmpeg } = await import('../lib/ffmpeg.js');-const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser } = await import('../services/htmlComposition/testBrowserCleanup.js');+const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser, _createTestArtifactsRoot } = await import('../services/htmlComposition/testBrowserCleanup.js');const chrome = [process.env.CHROME_PATH, chromium.executablePath(), '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', '/usr/bin/google-chrome'].find(p => p && existsSync(p));const ffmpeg = await findFfmpeg();// Server-only CI intentionally does not install the client workspace. This@@ -36,9 +36,9 @@ try {// Vitest does not run afterAll when the whole suite is skipped.const canRun = browserSuiteCanRun('musicVideo browser suite', { Chrome: chrome, ffmpeg, 'client workspace dependencies': clientBundler }, { onUnavailable: cleanupTempDataRoots });-let browser, proc, server;+let browser, artifacts, proc, server;afterAll(async () => {- await _cleanupTestBrowser({ browser, proc, cleanup: () => {} });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: () => {} });if (server) await new Promise(resolve => server.close(resolve));cleanupTempDataRoots();// A just-killed Chrome helper can recreate the data root after removal; CI's Linux run left one (#10312).@@ -95,7 +95,8 @@ describe.skipIf(!canRun)('production review in a real browser (Chrome, ffmpeg anserver = await new Promise(resolve => { const listener = app.listen(0, '127.0.0.1', () => resolve(listener)); });proc = spawn(chrome, _testChromeCaptureArgs(join(PATHS.data, 'test-chrome')), { stdio: ['ignore', 'ignore', 'pipe'] });endpoint = new URL(await _waitForTestChrome(proc)).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });const page = await browser.newPage({ viewport: { width: 1280, height: 1000 } });const errors = []; page.on('pageerror', e => errors.push(e.message));await page.goto(`http://127.0.0.1:${server.address().port}`);diff --git a/server/routes/musicVideoRichAuthoring.browser.test.js b/server/routes/musicVideoRichAuthoring.browser.test.jsindex 906340f625..5eedf1fc22 100644--- a/server/routes/musicVideoRichAuthoring.browser.test.js+++ b/server/routes/musicVideoRichAuthoring.browser.test.js@@ -28,7 +28,7 @@ vi.mock('../services/auth.js', () => ({ isAuthEnabled: async () => true, verifyRlet endpoint;vi.mock('../services/browserService.js', () => ({ loadConfig: async () => ({ chromePath: chrome }), cdpRequest: path => fetch(`${endpoint}${path}`) }));const { findFfmpeg } = await import('../lib/ffmpeg.js');-const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser } = await import('../services/htmlComposition/testBrowserCleanup.js');+const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser, _createTestArtifactsRoot } = await import('../services/htmlComposition/testBrowserCleanup.js');const chrome = [process.env.CHROME_PATH, chromium.executablePath(), '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', '/usr/bin/google-chrome'].find(p => p && existsSync(p));const ffmpeg = await findFfmpeg();// Server-only CI intentionally does not install the client workspace. This@@ -46,9 +46,9 @@ try {// Vitest skips cleanup hooks when no browser test can run.const canRun = browserSuiteCanRun('musicVideo browser suite', { Chrome: chrome, ffmpeg, 'client workspace dependencies': clientBundler }, { onUnavailable: cleanupTempDataRoots });-let browser, proc, server;+let browser, artifacts, proc, server;afterAll(async () => {- await _cleanupTestBrowser({ browser, proc, cleanup: () => {} });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: () => {} });if (server) await new Promise(resolve => server.close(resolve));cleanupTempDataRoots();});@@ -89,7 +89,8 @@ describe.skipIf(!canRun)('rich document authoring in a real browser (Chrome, ffmserver = await new Promise(resolve => { const listener = app.listen(0, '127.0.0.1', () => resolve(listener)); });proc = spawn(chrome, _testChromeCaptureArgs(join(PATHS.data, 'test-chrome')), { stdio: ['ignore', 'ignore', 'pipe'] });endpoint = new URL(await _waitForTestChrome(proc)).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });const page = await browser.newPage({ viewport: { width: 1280, height: 1000 } });const errors = []; page.on('pageerror', e => errors.push(e.message));// The harness mounts no Toaster, so a failed UI request is otherwise invisible: record everydiff --git a/server/routes/musicVideoSongRevision.browser.test.js b/server/routes/musicVideoSongRevision.browser.test.jsindex 31bf91a3c0..e6cb7dbf01 100644--- a/server/routes/musicVideoSongRevision.browser.test.js+++ b/server/routes/musicVideoSongRevision.browser.test.js@@ -14,7 +14,7 @@ import { errorMiddleware } from '../lib/errorHandler.js';import { browserSuiteCanRun } from '../lib/browserSuiteGate.js';vi.mock('../lib/paths.js', async original => makePathsProxy(await original(), { dataRoot: () => lazyTempDataRoot('mv-song-browser-') }));vi.mock('../services/settings.js', () => ({ getSettings: async () => ({}) }));-const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser } = await import('../services/htmlComposition/testBrowserCleanup.js');+const { _testChromeCaptureArgs, _waitForTestChrome, _cleanupTestBrowser, _createTestArtifactsRoot } = await import('../services/htmlComposition/testBrowserCleanup.js');const chrome = [process.env.CHROME_PATH, chromium.executablePath(), '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome', '/usr/bin/google-chrome'].find(p => p && existsSync(p));const client = resolve(import.meta.dirname, '../../client');const requireClient = createRequire(join(client, 'package.json'));@@ -23,7 +23,7 @@ try { bundler = ['vite', '@vitejs/plugin-react', '@tailwindcss/postcss'].map(namcatch (err) { if (err.code !== 'MODULE_NOT_FOUND') throw err; }const canRun = browserSuiteCanRun('song revision browser suite', { Chrome: chrome, 'client workspace dependencies': bundler }, { onUnavailable: cleanupTempDataRoots });// Prerequisite discovery may initialize mocked paths; skipped suites have no cleanup hooks.-let browser, proc, server, io, songs, musicVideoEvents;+let browser, artifacts, proc, server, io, songs, musicVideoEvents;const fixtureCleanup = new AbortController();const broadcast = event => io.emit('music-video:song-revision', event);afterAll(async () => {@@ -31,7 +31,7 @@ afterAll(async () => {fixtureCleanup.abort();await songs?.__testing.settle(); songs?.__setSongRevisionDepsForTests();try {- await _cleanupTestBrowser({ browser, proc, cleanup: async () => {+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: async () => {try {if (io) await new Promise(resolve => io.close(resolve));else if (server) await new Promise(resolve => server.close(resolve));@@ -93,7 +93,8 @@ describe.skipIf(!canRun)('song revision in Chrome (client dependencies required)server = await new Promise(resolve => { const listener = app.listen(0, '127.0.0.1', () => resolve(listener)); });io = new Server(server); musicVideoEvents.on('song-revision', broadcast);proc = spawn(chrome, _testChromeCaptureArgs(join(PATHS.data, 'chrome')), { stdio: ['ignore', 'ignore', 'pipe'] });- browser = await chromium.connectOverCDP(await _waitForTestChrome(proc));+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(await _waitForTestChrome(proc), { artifactsDir: artifacts.path });const page = await browser.newPage({ viewport: { width: 1000, height: 900 } });const errors = []; page.on('pageerror', e => errors.push(e.message));await page.goto(`http://127.0.0.1:${server.address().port}`);diff --git a/server/services/codeAnimation/export.realBrowser.test.js b/server/services/codeAnimation/export.realBrowser.test.jsindex 833a1389b4..5a21670921 100644--- a/server/services/codeAnimation/export.realBrowser.test.js+++ b/server/services/codeAnimation/export.realBrowser.test.js@@ -9,7 +9,7 @@ import { join } from 'node:path';import { chromium } from 'playwright-core';import { cleanupTempDataRoots, lazyTempDataRoot, makePathsProxy } from '../../lib/mockPathsDataRoot.js';import { findFfmpeg, findFfprobe } from '../../lib/ffmpeg.js';-import { _cleanupTestBrowser, _waitForTestChrome } from '../htmlComposition/testBrowserCleanup.js';+import { _cleanupTestBrowser, _createTestArtifactsRoot, _waitForTestChrome } from '../htmlComposition/testBrowserCleanup.js';const state = vi.hoisted(() => ({ html: '' }));let endpoint;@@ -104,6 +104,7 @@ window.renderFrame = (t) => {let proc;let browser;+let artifacts;const decodeRaw = (input, extra = []) => execFileSync(ffmpeg, ['-v', 'error', '-i', input, ...extra, '-f', 'rawvideo', '-pix_fmt', 'rgb24', '-'], { maxBuffer: 80 * 1024 * 1024 });const meanAbsDiff = (a, b) => {let sum = 0;@@ -118,16 +119,17 @@ describe.skipIf(!chrome || !ffmpeg || !ffprobe)('Code Animation frame-exact expotry {const ws = await _waitForTestChrome(proc);endpoint = new URL(ws).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });} catch (error) {// Retain the owned handle for afterAll if termination itself fails.- await _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots, startupError: error });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots, startupError: error });}// Enclose the existing startup (20s), disconnect (5s) and owned-child// termination (10s) budgets without cutting off evidence.}, 40000);- afterAll(() => _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots }), 20000);+ afterAll(() => _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots }), 20000);it('exports duration × fps unique frames from a slow renderFrame, matching direct screenshots, as BT.709 H.264 with the controls hidden', async () => {state.html = FIXTURE;diff --git a/server/services/codeAnimation/stages.realBrowser.db.test.js b/server/services/codeAnimation/stages.realBrowser.db.test.jsindex f63fec8108..832858082b 100644--- a/server/services/codeAnimation/stages.realBrowser.db.test.js+++ b/server/services/codeAnimation/stages.realBrowser.db.test.js@@ -10,7 +10,7 @@ import { join } from 'node:path';import { chromium } from 'playwright-core';import { cleanupTempDataRoots, lazyTempDataRoot, makePathsProxy } from '../../lib/mockPathsDataRoot.js';import { findFfmpeg, findFfprobe } from '../../lib/ffmpeg.js';-import { _cleanupTestBrowser, _selectTestChrome, _waitForTestChrome, _testChromeCaptureArgs } from '../htmlComposition/testBrowserCleanup.js';+import { _cleanupTestBrowser, _createTestArtifactsRoot, _selectTestChrome, _waitForTestChrome, _testChromeCaptureArgs } from '../htmlComposition/testBrowserCleanup.js';let endpoint;vi.mock('../browserService.js', () => ({ cdpRequest: path => fetch(`${endpoint}${path}`) }));@@ -69,6 +69,7 @@ const manifest = {let proc;let browser;+let artifacts;let projectId;describe.skipIf(!dbReady || !chrome || !ffmpeg || !ffprobe)('Production stages with real Chrome and ffmpeg', () => {@@ -78,10 +79,11 @@ describe.skipIf(!dbReady || !chrome || !ffmpeg || !ffprobe)('Production stages wtry {const ws = await _waitForTestChrome(proc, 20000, { source: selected.source, executable: chrome, profile });endpoint = new URL(ws).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });} catch (error) {// Retain the owned handle for afterAll if termination itself fails.- await _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots, startupError: error });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots, startupError: error });}// Enclose the existing startup (20s), version probe (up to 3s), disconnect// (5s) and owned-child termination (10s) budgets without cutting off evidence.@@ -89,7 +91,7 @@ describe.skipIf(!dbReady || !chrome || !ffmpeg || !ffprobe)('Production stages wafterAll(async () => {if (projectId) await query('DELETE FROM code_animation_projects WHERE id = $1', [projectId]);- await _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots });await close();}, 20000);diff --git a/server/services/htmlComposition/index.test.js b/server/services/htmlComposition/index.test.jsindex 6bdc4ff899..f6d6d62694 100644--- a/server/services/htmlComposition/index.test.js+++ b/server/services/htmlComposition/index.test.js@@ -12,7 +12,7 @@ import { loadHistory } from '../videoGen/history.js';import { videoGenEvents } from '../videoGen/events.js';import { renderComposition, cancel } from './index.js';import { installMotionKit } from './motionKit.js';-import { _cleanupTestBrowser, _waitForTestChrome, _testChromeCaptureArgs } from './testBrowserCleanup.js';+import { _cleanupTestBrowser, _createTestArtifactsRoot, _waitForTestChrome, _testChromeCaptureArgs } from './testBrowserCleanup.js';vi.mock('./encode.js', async importOriginal => {const actual = await importOriginal();@@ -36,6 +36,7 @@ const chrome = [process.env.CHROME_PATH, chromium.executablePath(),const ffmpeg = await findFfmpeg();let proc;let browser;+let artifacts;let browserSession;// The delayed paint is intentional test input: a screenshot before the seek@@ -60,7 +61,8 @@ describe.skipIf(!chrome || !ffmpeg)('HTML composition with real Chrome and ffmpeproc = spawn(chrome, _testChromeCaptureArgs(profile), { stdio: ['ignore', 'ignore', 'pipe'] });const ws = await _waitForTestChrome(proc);endpoint = new URL(ws).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });browserSession = await browser.newBrowserCDPSession();}, 30000);@@ -80,7 +82,7 @@ describe.skipIf(!chrome || !ffmpeg)('HTML composition with real Chrome and ffmpe}});- afterAll(() => _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots }));+ afterAll(() => _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots }));it('awaits every seek, encodes exactly 12 frames, disposes its private target and registers a thumbnail', async () => {const input = await composition();diff --git a/server/services/htmlComposition/testBrowserCleanup.js b/server/services/htmlComposition/testBrowserCleanup.jsindex f8033928ff..5bdf00ca11 100644--- a/server/services/htmlComposition/testBrowserCleanup.js+++ b/server/services/htmlComposition/testBrowserCleanup.js@@ -1,8 +1,9 @@import { spawn } from '../../lib/childProcess.js';-import { closeSync, existsSync, openSync, opendirSync, readSync, statfsSync } from 'node:fs';+import { closeSync, existsSync, lstatSync, mkdtempSync, openSync, opendirSync, readSync, rmSync, statfsSync } from 'node:fs';import { availableParallelism, tmpdir } from 'node:os';import { basename, join } from 'node:path';import { killWithEscalation } from '../../lib/killWithEscalation.js';+import { recordTempRootOwner } from '../../lib/mockPathsDataRoot.js';// These owned browsers render on explicit seek(t), not wall/display time.// Chromium's display scheduler must not pace a song-length offline capture.@@ -388,21 +389,54 @@ async function terminateOwnedChrome(proc, observeProcess) {}}+// Playwright's CDP adapter otherwise mints its own `playwright-artifacts-*`+// root and removes it from a Disconnected listener nobody awaits (#11584).+// Pass `artifactsDir: path` to connectOverCDP and the handle to+// _cleanupTestBrowser. The owner row names this test file if the root leaks.+export function _createTestArtifactsRoot({ parent = tmpdir() } = {}) {+ const path = mkdtempSync(join(parent, 'portos-cdp-artifacts-'));+ const { dev, ino } = lstatSync(path);+ recordTempRootOwner(path);+ return Object.freeze({ path, dev, ino });+}++// The owned Chrome may still write downloads into the root until it exits.+// Remove only the directory created above, and keep it as evidence when exit+// is unconfirmed or the path no longer names that directory. No path in text.+function removeTestArtifactsRoot({ path, dev, ino }, childSettled) {+ if (!childSettled) return 'skipped; owned child exit unconfirmed, root preserved';+ const current = lstatSync(path, { throwIfNoEntry: false });+ if (current) {+ if (!current.isDirectory() || current.isSymbolicLink() || current.dev !== dev || current.ino !== ino) {+ return 'refused; root identity changed';+ }+ rmSync(path, { recursive: true, force: true });+ }+ return lstatSync(path, { throwIfNoEntry: false }) ? 'incomplete; root still exists' : null;+}+// Test-only lifecycle boundary. Disconnect failure must not strand the owned// child, and neither failure may prevent removal of temporary test data.// A startup failure remains primary even if teardown also fails.-export async function _cleanupTestBrowser({ browser, proc, cleanup, startupError, observeProcess = _testChromeProcessFacts }) {+export async function _cleanupTestBrowser({ browser, proc, artifacts, cleanup, startupError, observeProcess = _testChromeProcessFacts }) {const errors = startupError ? [startupError] : [];const cleanupFailure = (stage, error) => {const code = /^[A-Z0-9_]{1,32}$/.test(error?.code) ? error.code : 'unknown';errors.push(new Error(`Test Chrome ${stage} cleanup failed (${code})`));};+ let childSettled = false;try {await withinDeadline(() => browser?.close(), 5000, 'browser disconnect',() => `; process: ${describeProcess(proc, observeProcess)}`).catch(error => errors.push(error));- await terminateOwnedChrome(proc, observeProcess).catch(error => errors.push(error));+ await terminateOwnedChrome(proc, observeProcess).then(() => { childSettled = true; }, error => errors.push(error));} finally {try { proc?.stderr?.destroy(); } catch (error) { cleanupFailure('stderr', error); }+ if (artifacts) {+ try {+ const failure = removeTestArtifactsRoot(artifacts, childSettled);+ if (failure) errors.push(new Error(`Test Chrome artifacts cleanup ${failure}`));+ } catch (error) { cleanupFailure('artifacts', error); }+ }try { await cleanup(); } catch (error) { cleanupFailure('temporary data', error); }}if (startupError && errors.length === 1) throw startupError;diff --git a/server/services/htmlComposition/testBrowserCleanup.test.js b/server/services/htmlComposition/testBrowserCleanup.test.jsindex 21e23647eb..739d70e370 100644--- a/server/services/htmlComposition/testBrowserCleanup.test.js+++ b/server/services/htmlComposition/testBrowserCleanup.test.js@@ -1,9 +1,11 @@-import { mkdtempSync, rmSync } from 'node:fs';+import { existsSync, mkdirSync, mkdtempSync, readFileSync, renameSync, rmSync, writeFileSync } from 'node:fs';+import { spawnSync } from 'node:child_process';+import { fileURLToPath } from 'node:url';import { tmpdir } from 'node:os';import { join } from 'node:path';import { EventEmitter } from 'node:events';import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';-import { _cleanupTestBrowser, _describeTestChromeStartup, _testChromeProcessFacts, _waitForTestChrome, _withTestCaptureDiagnostics } from './testBrowserCleanup.js';+import { _cleanupTestBrowser, _createTestArtifactsRoot, _describeTestChromeStartup, _testChromeProcessFacts, _waitForTestChrome, _withTestCaptureDiagnostics } from './testBrowserCleanup.js';function child() {const proc = new EventEmitter();@@ -633,3 +635,120 @@ describe('owned test Chrome cleanup', () => {expect(vi.getTimerCount()).toBe(0);});});++// Playwright's CDP adapter mints `playwright-artifacts-*` itself unless told+// otherwise, and removes it from a Disconnected listener nobody awaits (#11584).+describe('fixture-owned CDP artifacts root', () => {+ const originalRoot = process.env.PORTOS_TEST_TEMP_ROOT;+ let runRoot;+ beforeEach(() => {+ runRoot = mkdtempSync(join(tmpdir(), 'cdp-artifacts-run-'));+ process.env.PORTOS_TEST_TEMP_ROOT = runRoot;+ vi.spyOn(console, 'log').mockImplementation(() => {});+ vi.spyOn(console, 'error').mockImplementation(() => {});+ });+ afterEach(() => {+ vi.useRealTimers();+ vi.restoreAllMocks();+ if (originalRoot === undefined) delete process.env.PORTOS_TEST_TEMP_ROOT;+ else process.env.PORTOS_TEST_TEMP_ROOT = originalRoot;+ rmSync(runRoot, { recursive: true, force: true });+ });+ const exited = () => {+ const proc = child();+ proc.signalCode = 'SIGKILL';+ return proc;+ };++ it('keeps the root through deferred browser writes after disconnect and removes it once the child exits', async () => {+ vi.useFakeTimers();+ const artifacts = _createTestArtifactsRoot({ parent: runRoot });+ const proc = child();+ let landed = false;+ proc.kill.mockImplementation(signal => {+ // Disconnect already resolved; Chrome may still land a download here.+ // Writing into a directory removed too early throws out of this timer.+ setTimeout(() => {+ writeFileSync(join(artifacts.path, 'download.bin'), 'x');+ landed = true;+ proc.signalCode = signal;+ proc.emit('exit', null, signal);+ }, 100);+ return true;+ });+ const result = _cleanupTestBrowser({ browser: { close: async () => {} }, proc, artifacts, cleanup: vi.fn() });+ await vi.advanceTimersByTimeAsync(99);+ expect(existsSync(artifacts.path)).toBe(true);+ await vi.advanceTimersByTimeAsync(1);+ await result;+ expect(landed).toBe(true);+ expect(existsSync(artifacts.path)).toBe(false);+ expect(vi.getTimerCount()).toBe(0);+ });++ it('preserves the root as evidence when owned exit is unconfirmed', async () => {+ vi.useFakeTimers();+ const artifacts = _createTestArtifactsRoot({ parent: runRoot });+ const proc = child();+ proc.kill.mockImplementation(() => true);+ const cleanup = vi.fn();+ const result = _cleanupTestBrowser({ proc, artifacts, cleanup }).catch(error => error);+ await vi.advanceTimersByTimeAsync(10000);+ const error = await result;+ expect(error.message).toContain('child termination exceeded 10000ms deadline');+ expect(error.message).toContain('Test Chrome artifacts cleanup skipped; owned child exit unconfirmed, root preserved');+ expect(error.message).not.toContain(runRoot);+ expect(existsSync(artifacts.path)).toBe(true);+ expect(cleanup).toHaveBeenCalledOnce();+ });++ it('refuses to remove a directory that replaced the created root', async () => {+ const artifacts = _createTestArtifactsRoot({ parent: runRoot });+ renameSync(artifacts.path, `${artifacts.path}-moved`);+ mkdirSync(artifacts.path);+ const error = await _cleanupTestBrowser({ proc: exited(), artifacts, cleanup: () => {} }).catch(caught => caught);+ expect(error.message).toBe('Test Chrome artifacts cleanup refused; root identity changed');+ expect(existsSync(artifacts.path)).toBe(true);+ expect(existsSync(`${artifacts.path}-moved`)).toBe(true);+ });++ // The negative control restores the ownership gap: a root nobody removes.+ it.each([+ ['removes the owned root', true, [], undefined],+ ['reports an unremoved root with its creating test (negative control)', false,+ ['⚠️ test temp leak: portos-cdp-artifacts- ×1 (created by testBrowserCleanup.test.js)'], 1],+ ])('global teardown %s', async (_name, passHandle, warnings, exitCode) => {+ const artifacts = _createTestArtifactsRoot({ parent: runRoot });+ writeFileSync(join(artifacts.path, 'trace.json'), '{}');+ await _cleanupTestBrowser({ proc: exited(), artifacts: passHandle ? artifacts : undefined, cleanup: () => {} });+ const { teardown } = await import('../../../scripts/vitestTempRootSetup.js');+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});+ const originalExit = process.exitCode;+ let observed;+ try {+ process.exitCode = undefined;+ teardown();+ observed = process.exitCode;+ } finally { process.exitCode = originalExit; }+ expect(warn.mock.calls.map(([line]) => line)).toEqual(warnings);+ expect(observed).toBe(exitCode);+ });++ it('every server CDP fixture passes a fixture-owned artifacts root', () => {+ const unowned = source => [...source.matchAll(/chromium\.connectOverCDP\(/g)].filter(match => {+ let depth = 1;+ let end = match.index + match[0].length;+ for (; end < source.length && depth; end++) depth += source[end] === '(' ? 1 : source[end] === ')' ? -1 : 0;+ return !source.slice(match.index, end).includes('artifactsDir');+ }).length;+ expect(unowned('browser = await chromium.connectOverCDP(endpoint);')).toBe(1);+ expect(unowned('chromium.connectOverCDP(await wait(proc), { artifactsDir: artifacts.path })')).toBe(0);+ const server = fileURLToPath(new URL('../../', import.meta.url));+ const listed = spawnSync('git', ['grep', '-l', '-F', 'chromium.connectOverCDP(', '--', '*.test.js'], { cwd: server, encoding: 'utf8' });+ expect(listed.status).toBe(0);+ // This file's probe strings above are not fixtures.+ const files = listed.stdout.split('\n').filter(file => file && file !== 'services/htmlComposition/testBrowserCleanup.test.js');+ expect(files.length).toBeGreaterThan(0);+ expect(files.filter(file => unowned(readFileSync(join(server, file), 'utf8')))).toEqual([]);+ });+});diff --git a/server/services/musicVideo/compositionRender.test.js b/server/services/musicVideo/compositionRender.test.jsindex 18cbbbf288..3674999981 100644--- a/server/services/musicVideo/compositionRender.test.js+++ b/server/services/musicVideo/compositionRender.test.js@@ -7,7 +7,7 @@ import { chromium } from 'playwright-core';import { cleanupTempDataRoots, lazyTempDataRoot, makePathsProxy, sweepStrayTempRoots } from '../../lib/mockPathsDataRoot.js';import { findFfmpeg, probeVideoDuration } from '../../lib/ffmpeg.js';import { PATHS } from '../../lib/fileUtils.js';-import { _cleanupTestBrowser } from '../htmlComposition/testBrowserCleanup.js';+import { _cleanupTestBrowser, _createTestArtifactsRoot } from '../htmlComposition/testBrowserCleanup.js';import { beatSnapClips, buildMusicVideoFfmpegArgs, resolveSceneClips } from './render.js';import { composedLyricWindows, projectTypographyPlan, renderableCues, sectionCardCues } from './composition.js';import { COMPOSITION_SCRATCH_DIR, removeCompositionScratch, renderTypographyOverlays } from './compositionRender.js';@@ -29,6 +29,7 @@ const ffmpeg = await findFfmpeg();if (!chrome || !ffmpeg) cleanupTempDataRoots();let proc;let browser;+let artifacts;const FPS = 24;const run = (args) => execFileSync(ffmpeg, ['-v', 'error', ...args], { maxBuffer: 256 * 1024 * 1024 });@@ -66,11 +67,12 @@ describe.skipIf(!chrome || !ffmpeg)('music-video typography overlay with real Ch});});endpoint = new URL(ws).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });}, 30000);afterAll(async () => {- await _cleanupTestBrowser({ browser, proc, cleanup: cleanupTempDataRoots });+ await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: cleanupTempDataRoots });// Real ffprobe/ffmpeg subprocess work (#9032) — see sweepStrayTempRoots's doc.await sweepStrayTempRoots('portos-mv-composition-');});diff --git a/server/services/musicVideo/documentRender.browser.test.js b/server/services/musicVideo/documentRender.browser.test.jsindex 21e56d991e..08849e44a6 100644--- a/server/services/musicVideo/documentRender.browser.test.js+++ b/server/services/musicVideo/documentRender.browser.test.js@@ -68,7 +68,7 @@ vi.mock('../../lib/paths.js', async (importOriginal) => makePathsProxy(await imp}));const { findFfmpeg } = await import('../../lib/ffmpeg.js');-const { _cleanupTestBrowser, _waitForTestChrome, _testChromeCaptureArgs } = await import('../htmlComposition/testBrowserCleanup.js');+const { _cleanupTestBrowser, _createTestArtifactsRoot, _waitForTestChrome, _testChromeCaptureArgs } = await import('../htmlComposition/testBrowserCleanup.js');afterAll(() => { lifecycle.diagnostics.dispose(); cleanupTempDataRoots(); });@@ -83,6 +83,7 @@ const canRun = browserSuiteCanRun('documentRender browser suite', { Chrome: chrodescribe.skipIf(!canRun)('layered template with real Chrome and ffmpeg', () => {let proc;let browser;+ let artifacts;let PATHS, encodeDocumentComposition, prepareDocumentRender, documentRenderClock, importDocumentTemplate;let generateMixedMediaDocument, regenerateMixedMediaSection, acceptMixedMediaDocument, buildDocumentPreview, PREVIEW_MEDIA_BUDGET_BYTES, projects;beforeAll(async () => {@@ -103,7 +104,8 @@ describe.skipIf(!canRun)('layered template with real Chrome and ffmpeg', () => {proc = spawn(chrome, _testChromeCaptureArgs(profile), { stdio: ['ignore', 'ignore', 'pipe'] });const ws = await _waitForTestChrome(proc);endpoint = new URL(ws).origin.replace('ws:', 'http:');- browser = await chromium.connectOverCDP(endpoint);+ artifacts = _createTestArtifactsRoot();+ browser = await chromium.connectOverCDP(endpoint, { artifactsDir: artifacts.path });}, 30000);afterAll(async () => {try {@@ -112,7 +114,7 @@ describe.skipIf(!canRun)('layered template with real Chrome and ffmpeg', () => {expect(owned.closed, `owned capture child closed before fixture teardown; ${lifecycle.diagnostics.describe(owned)}`).toBe(true);expect(existsSync(owned.profile), `owned capture profile removed before fixture teardown; ${lifecycle.diagnostics.describe(owned)}`).toBe(false);}- } finally { await _cleanupTestBrowser({ browser, proc, cleanup: () => {} }); }+ } finally { await _cleanupTestBrowser({ browser, proc, artifacts, cleanup: () => {} }); }});// Uniquely catches dropped effect data, missing staged modules and preview/export curve drift.