Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: report where an API code reviewer stalled (connect vs body) on timeout (#13133)
Adam Eivy4765d4aeafb6
diff --git a/server/services/aiProvider.js b/server/services/aiProvider.jsindex 8fb6105548..fdcc110cca 100644--- a/server/services/aiProvider.js+++ b/server/services/aiProvider.js@@ -213,7 +213,11 @@ async function postChatCompletion(provider, model, prompt, { temperature, max_to}const controller = new AbortController();- const timer = setTimeout(() => controller.abort(), timeout);+ // Distinguishes the deadline from a caller cancel, and records how far the+ // exchange got, so a stalled provider reports WHERE it stalled (#13133).+ let timedOut = false;+ let stallPhase = 'no-response';+ const timer = setTimeout(() => { timedOut = true; controller.abort(); }, timeout);// The caller's cancellation, folded into the same controller as the deadline.// Without it, pressing Stop leaves the request running to its full timeout —// most visible on the subscription's fallback leg, which is exactly where a@@ -230,6 +234,7 @@ async function postChatCompletion(provider, model, prompt, { temperature, max_tosignal: controller.signal,body: JSON.stringify({ model, messages: [{ role: 'user', content: prompt }], temperature, max_tokens })});+ stallPhase = 'response-body';if (!response.ok) {const errorText = await response.text().catch(() => 'Unknown error');@@ -273,7 +278,12 @@ async function postChatCompletion(provider, model, prompt, { temperature, max_to// `err.cause` and is otherwise silently discarded (#7669).const cause = err.cause;const causeDetail = cause ? ` (cause: ${[cause.code, cause.message].filter(Boolean).join(' ')})` : '';- return { error: `Provider request failed: ${err.message}${causeDetail}` };+ const stalled = timedOut+ ? ` — timed out after ${timeout}ms ${stallPhase === 'no-response'+ ? 'before the provider sent response headers (connect or first byte)'+ : 'after response headers while the body was still streaming'}`+ : '';+ return { error: `Provider request failed: ${err.message}${causeDetail}${stalled}`, ...(timedOut ? { stallPhase } : {}) };} finally {clearTimeout(timer);signal?.removeEventListener('abort', onAbort);@@ -553,7 +563,7 @@ export async function callProviderAISimple(provider, model, prompt, options = {}return { text: retry.text, finishReason: retry.finishReason, ...(retry.usage ? { usage: retry.usage } : {}) };}statusOp.error(retry.error, { model: retryModel });- return { error: retry.error, ...(Number.isInteger(retry.status) ? { status: retry.status } : {}) };+ return { error: retry.error, ...(Number.isInteger(retry.status) ? { status: retry.status } : {}), ...(retry.stallPhase ? { stallPhase: retry.stallPhase } : {}) };};if (options.allowModelRecovery !== false && first.status === 400 && LM_STUDIO_NO_MODEL_RE.test(first.body || '')) {@@ -579,7 +589,7 @@ export async function callProviderAISimple(provider, model, prompt, options = {}}statusOp.error(first.error);- return { error: first.error, ...(Number.isInteger(first.status) ? { status: first.status } : {}) };+ return { error: first.error, ...(Number.isInteger(first.status) ? { status: first.status } : {}), ...(first.stallPhase ? { stallPhase: first.stallPhase } : {}) };}// Extracted to lib/llmText.js in #4901 — unfencing a string needs no provider,diff --git a/server/services/aiProvider.test.js b/server/services/aiProvider.test.jsindex 5d6d4d6d96..6d8435b586 100644--- a/server/services/aiProvider.test.js+++ b/server/services/aiProvider.test.js@@ -524,6 +524,40 @@ describe('HTTP provider body cancellation', () => {expect(vi.getTimerCount()).toBe(0);});+ it('reports a deadline hit before response headers as a connect/first-byte stall', async () => {+ vi.useFakeTimers();+ vi.stubGlobal('fetch', vi.fn((_url, { signal }) => new Promise((_, reject) => {+ signal.addEventListener('abort', () => reject(new Error('This operation was aborted')), { once: true });+ })));+ const pending = callProviderAISimple(provider, 'model', 'prompt', { allowModelRecovery: false });+ await vi.advanceTimersByTimeAsync(1000);+ expect(await pending).toMatchObject({ stallPhase: 'no-response', error: expect.stringMatching(/timed out after 1000ms before the provider sent response headers/) });+ });++ it('reports a deadline hit after response headers as a body stall', async () => {+ vi.useFakeTimers();+ vi.stubGlobal('fetch', vi.fn(async (_url, { signal }) => ({ ok: true, text: () => new Promise((_, reject) => {+ signal.addEventListener('abort', () => reject(new Error('body aborted')), { once: true });+ }) })));+ const pending = callProviderAISimple(provider, 'model', 'prompt', { allowModelRecovery: false });+ await vi.advanceTimersByTimeAsync(1000);+ expect(await pending).toMatchObject({ stallPhase: 'response-body', error: expect.stringMatching(/timed out after 1000ms after response headers/) });+ });++ it('does not label a caller cancel as a stall', async () => {+ vi.useFakeTimers();+ const caller = new AbortController();+ vi.stubGlobal('fetch', vi.fn((_url, { signal }) => new Promise((_, reject) => {+ if (signal.aborted) reject(new Error('This operation was aborted'));+ else signal.addEventListener('abort', () => reject(new Error('This operation was aborted')), { once: true });+ })));+ const pending = callProviderAISimple(provider, 'model', 'prompt', { signal: caller.signal, allowModelRecovery: false });+ caller.abort();+ const result = await pending;+ expect(result.stallPhase).toBeUndefined();+ expect(result.error).not.toContain('timed out');+ });+it.each(['list', 'load-error'])('bounds the LM Studio %s body after headers', async (stage) => {vi.useFakeTimers();let started;diff --git a/server/services/codeReview.js b/server/services/codeReview.jsindex cada1d837a..0ccd4b7ddb 100644--- a/server/services/codeReview.js+++ b/server/services/codeReview.js@@ -1061,6 +1061,7 @@ async function runConfiguredProviderCompletion({ backend, model: pinnedModel, me...(result.text ? { text: result.text } : {}),...(result.status ? { status: result.status } : {}),...(result.statusCode ? { statusCode: result.statusCode } : {}),+ ...(result.stallPhase ? { stallPhase: result.stallPhase } : {}),...(result.name ? { name: result.name } : {}),...(result.code ? { code: result.code } : {}),}@@ -1074,7 +1075,7 @@ async function runReviewerCompletion({ backend, model: pinnedModel, messages, usif (result.ok || !Number.isFinite(diffSizeBytes) || !isTimeoutFailure(result.error)) return resultreturn {...result,- error: localCodeReviewTimeoutError({ backend, timeoutMs: result.timeoutMs ?? timeoutMs, diffSizeBytes, phase: 'reviewer-process' }),+ error: localCodeReviewTimeoutError({ backend, timeoutMs: result.timeoutMs ?? timeoutMs, diffSizeBytes, phase: result.stallPhase || 'reviewer-process' }),}}if (!isLocalLlmReviewer(backend)) {diff --git a/server/services/codeReview.providers.test.js b/server/services/codeReview.providers.test.jsindex 45411af0cd..091b59c9d2 100644--- a/server/services/codeReview.providers.test.js+++ b/server/services/codeReview.providers.test.js@@ -373,6 +373,16 @@ describe('configured provider reviewers', () => {expect(result.error).toContain('42 KiB');});+ it.each([+ ['no-response', 'backend never answered'],+ ['response-body', 'backend was reachable but did not finish'],+ ])('reports the %s stall point of a timed-out API reviewer', async (stallPhase, description) => {+ callProviderAISimple.mockResolvedValue({ error: 'Provider request failed: This operation was aborted', stallPhase });+ const result = await runLocalCodeReview({ backend, diff: 'x'.repeat(42 * 1024) });+ expect(result.error).toContain(description);+ expect(result.error).toContain('timed out after');+ });+describe('getProviderReviewUnsupported', () => {// Any CLI with a command can review code (confined when it has no enforced// mode), so only a missing command is reported.