Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: disable scene board Move earlier/later on document-mode compositions (#10785)

[._.]/ Adam Eivy5895bce18236
diff --git a/client/src/components/musicVideo/SceneCard.jsx b/client/src/components/musicVideo/SceneCard.jsx
index d7cbedf81f..976871b046 100644
--- a/client/src/components/musicVideo/SceneCard.jsx
+++ b/client/src/components/musicVideo/SceneCard.jsx
@@ -70,6 +70,8 @@ const SCENE_TIME_FIELDS = [['Start', 'startSec'], ['End', 'endSec']];
* Opening or closing it also calls `onSeek(scene)`, so the docked preview
* jumps to the scene's start.
*/
+const MOVE_DOCUMENT_TITLE = "This video's shot order comes from its composition document";
+
export default function SceneCard({
scene, index, isLast, generatingFrame, generatingVideo, frameProgress = null, videoProgress = null,
settingsSaving, videoBlockedReason, canContinueShot,
@@ -208,11 +210,14 @@ export default function SceneCard({
<div className="space-y-2 p-3 pt-0">
{/* A move swaps this shot with its neighbor; the song timing and lyric stay with the slot. */}
<div className="flex items-center justify-end gap-2">
- <button type="button" onClick={() => onMove(index, -1)} disabled={index === 0} title="Swap with the previous shot; the song timing stays put"
+ {documentComposition && (
+ <span className="mr-auto text-[11px] text-gray-400">Shot order comes from the composition document, so it can't be reordered here.</span>
+ )}
+ <button type="button" onClick={() => onMove(index, -1)} disabled={index === 0 || documentComposition} title={documentComposition ? MOVE_DOCUMENT_TITLE : "Swap with the previous shot; the song timing stays put"}
className="min-h-[44px] inline-flex items-center justify-center gap-1 rounded border border-port-border px-2 text-xs disabled:opacity-30 sm:min-h-0 sm:py-1">
<ArrowUp size={14} aria-hidden="true" /> Move earlier
</button>
- <button type="button" onClick={() => onMove(index, 1)} disabled={isLast} title="Swap with the next shot; the song timing stays put"
+ <button type="button" onClick={() => onMove(index, 1)} disabled={isLast || documentComposition} title={documentComposition ? MOVE_DOCUMENT_TITLE : "Swap with the next shot; the song timing stays put"}
className="min-h-[44px] inline-flex items-center justify-center gap-1 rounded border border-port-border px-2 text-xs disabled:opacity-30 sm:min-h-0 sm:py-1">
<ArrowDown size={14} aria-hidden="true" /> Move later
</button>
diff --git a/client/src/components/musicVideo/SceneCard.test.jsx b/client/src/components/musicVideo/SceneCard.test.jsx
index 7be9054382..34f93f6cd3 100644
--- a/client/src/components/musicVideo/SceneCard.test.jsx
+++ b/client/src/components/musicVideo/SceneCard.test.jsx
@@ -128,3 +128,18 @@ describe('lyric type per shot (#10583)', () => {
expect(onSave.mock.calls).toEqual([['s1', { textZone: 'upper' }], ['s1', { textZone: 'lower' }], ['s1', { textZone: 'none' }], ['s1', { lyricRole: 'stamp' }], ['s1', { textZone: null }]]);
});
});
+
+describe('move buttons (#10785)', () => {
+ const scene = { sceneId: 's1', startSec: 0, endSec: 5, takes: [] };
+ it('disables Move earlier/later on a document composition and explains why', () => {
+ const onMove = vi.fn();
+ const props = { scene, index: 1, isLast: false, onMove, onEditLocal: () => {}, onSave: () => {} };
+ const { rerender } = render(<SceneCard {...props} />);
+ expect(screen.getByRole('button', { name: /Move earlier/ }).disabled).toBe(false);
+ expect(screen.getByRole('button', { name: /Move later/ }).disabled).toBe(false);
+ rerender(<SceneCard {...props} documentComposition />);
+ expect(screen.getByRole('button', { name: /Move earlier/ }).disabled).toBe(true);
+ expect(screen.getByRole('button', { name: /Move later/ }).disabled).toBe(true);
+ expect(screen.getByText(/comes from the composition document/)).toBeTruthy();
+ });
+});