Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: show an error with Retry when a Digital Twin list read fails (#12783)
Adam Eivy60c15cb452d2
diff --git a/client/src/components/digital-twin/ListEnrichment.jsx b/client/src/components/digital-twin/ListEnrichment.jsxindex 4aa34cbb69..b69c9574aa 100644--- a/client/src/components/digital-twin/ListEnrichment.jsx+++ b/client/src/components/digital-twin/ListEnrichment.jsx@@ -27,6 +27,8 @@ export default function ListEnrichment({onBack,onRefresh,providers,+ providersError = null,+ onRetryProviders,selectedProvider,setSelectedProvider}) {@@ -266,13 +268,17 @@ export default function ListEnrichment({{/* Provider Selection & Analyze Button */}<div className="bg-port-card rounded-lg border border-port-border p-4 sm:p-6 mb-6"><div className="flex flex-col sm:flex-row items-stretch sm:items-center gap-4">- <TwinProviderPicker- className="flex-1"- label="Analyze with"- providers={providers}- selected={selectedProvider}- onChange={setSelectedProvider}- />+ {providersError ? (+ <ListLoadError className="flex-1" what="AI providers" error={providersError} onRetry={onRetryProviders} />+ ) : (+ <TwinProviderPicker+ className="flex-1"+ label="Analyze with"+ providers={providers}+ selected={selectedProvider}+ onChange={setSelectedProvider}+ />+ )}<buttononClick={analyzeList}diff --git a/client/src/components/digital-twin/ListEnrichment.test.jsx b/client/src/components/digital-twin/ListEnrichment.test.jsxindex 83901d5680..8951dc67e5 100644--- a/client/src/components/digital-twin/ListEnrichment.test.jsx+++ b/client/src/components/digital-twin/ListEnrichment.test.jsx@@ -96,3 +96,63 @@ describe('ListEnrichment analysis disclosures', () => {expect(document.getElementById('item-analysis-panel')).toBeNull();});});++describe('ListEnrichment stored-list load', () => {+ beforeEach(() => vi.clearAllMocks());++ const renderEditor = () => render(+ <ListEnrichment+ categoryId="favorite_books"+ onBack={() => {}}+ onRefresh={() => {}}+ providers={[{ id: 'example', name: 'Example', models: ['example-model'] }]}+ selectedProvider={{ providerId: 'example', model: 'example-model' }}+ setSelectedProvider={() => {}}+ />+ );++ // Saving replaces the stored list, so an editor seeded from a failed read+ // would let the next save overwrite real data with a blank list.+ it('shows an error with Retry instead of a blank editor when the stored list fails to load', async () => {+ api.getEnrichmentListItems+ .mockRejectedValueOnce(new Error('offline'))+ .mockResolvedValueOnce([{ title: 'Example Book', note: '' }]);+ renderEditor();++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load .*offline/i);+ expect(screen.queryByRole('button', { name: /Analyze & Generate/i })).toBeNull();+ expect(screen.queryByRole('textbox')).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ await waitFor(() => expect(screen.getByDisplayValue('Example Book')).toBeInTheDocument());+ expect(screen.queryByRole('alert')).toBeNull();+ expect(api.saveEnrichmentList).not.toHaveBeenCalled();+ });++ it('opens a blank editor only when the stored list is genuinely empty', async () => {+ api.getEnrichmentListItems.mockResolvedValue([]);+ renderEditor();+ expect(await screen.findByRole('button', { name: /Analyze & Generate/i })).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ expect(screen.getAllByRole('textbox').length).toBeGreaterThan(0);+ });++ it('surfaces a failed provider list beside the picker instead of an empty picker', async () => {+ api.getEnrichmentListItems.mockResolvedValue([]);+ const onRetryProviders = vi.fn();+ render(+ <ListEnrichment+ categoryId="favorite_books"+ onBack={() => {}}+ providers={[]}+ providersError={new Error('providers down')}+ onRetryProviders={onRetryProviders}+ selectedProvider={null}+ setSelectedProvider={() => {}}+ />+ );+ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load AI providers/i);+ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ expect(onRetryProviders).toHaveBeenCalledTimes(1);+ });+});diff --git a/client/src/components/digital-twin/ObservedTasteEvidence.jsx b/client/src/components/digital-twin/ObservedTasteEvidence.jsxindex da99b38e00..bfc4a16076 100644--- a/client/src/components/digital-twin/ObservedTasteEvidence.jsx+++ b/client/src/components/digital-twin/ObservedTasteEvidence.jsx@@ -1,7 +1,9 @@-import { useState, useEffect, useCallback } from 'react';+import { useState, useEffect, useCallback, useMemo } from 'react';import { Telescope, RefreshCw, Sparkles, Music, Tv, Clock, AlertTriangle, CheckCircle } from 'lucide-react';import * as api from '../../services/api';import toast from '../ui/Toast';+import ListLoadError from '../ui/ListLoadError';+import useProviderList from '../../hooks/useProviderList';import BrailleSpinner from '../BrailleSpinner';import TwinProviderPicker from './TwinProviderPicker.jsx';import MarkdownOutput from '../cos/MarkdownOutput';@@ -80,18 +82,19 @@ export default function ObservedTasteEvidence() {const [loading, setLoading] = useState(true);const [recomputing, setRecomputing] = useState(false);const [interpreting, setInterpreting] = useState(false);- const [providers, setProviders] = useState([]);- const [selected, setSelected] = useState(null);+ const [loadError, setLoadError] = useState(null);+ const providerList = useProviderList();+ const providers = useMemo(() => providerList.items.filter((p) => p.enabled), [providerList.items]);+ // Until the user picks one, default to the first enabled provider.+ const [picked, setSelected] = useState(null);+ const selected = picked+ ?? (providers[0] ? { providerId: providers[0].id, model: providers[0].defaultModel || '' } : null);const load = useCallback(async () => {- const [ev, provData] = await Promise.all([- api.getTwinEvidence({ silent: true }).catch(() => null),- api.getProviders().catch(() => ({ providers: [] })),- ]);+ setLoading(true);+ setLoadError(null);+ const ev = await api.getTwinEvidence({ silent: true }).catch((err) => { setLoadError(err); return null; });if (ev) setEvidence(ev);- const enabled = (provData.providers || []).filter((p) => p.enabled);- setProviders(enabled);- if (enabled.length > 0) setSelected({ providerId: enabled[0].id, model: enabled[0].defaultModel || '' });setLoading(false);}, []);@@ -104,6 +107,7 @@ export default function ObservedTasteEvidence() {setRecomputing(false);if (!res) { toast('Recompute failed', { icon: '⚠️' }); return; }setEvidence(res.evidence);+ setLoadError(null);toast('Observed evidence recomputed', { icon: '🧭' });};@@ -161,7 +165,11 @@ export default function ObservedTasteEvidence() {</button></div>- {!hasEvidence && (+ {loadError && (+ <ListLoadError what="observed evidence" error={loadError} onRetry={load} />+ )}++ {!hasEvidence && !loadError && (<div className="text-sm text-gray-400 bg-port-bg border border-port-border rounded-lg p-4">No observed evidence yet. Once you've synced Spotify / YouTube history (or logged activity), hit{' '}<span className="text-gray-300">Recompute</span> to build your evidence profile.@@ -230,7 +238,11 @@ export default function ObservedTasteEvidence() {<div className="border-t border-port-border pt-4 space-y-3"><div className="flex flex-col sm:flex-row sm:items-end gap-3"><div className="flex-1">- {providers.length === 0 ? (+ {providerList.state === 'error' ? (+ <ListLoadError what="AI providers" error={providerList.error} onRetry={providerList.retry} />+ ) : providerList.state === 'loading' ? (+ <BrailleSpinner text="Loading providers" />+ ) : providers.length === 0 ? (<><p className="block text-xs text-gray-500 mb-1">Interpret with AI provider</p><p className="text-xs text-gray-500">No AI provider configured — add one in AI Providers.</p>diff --git a/client/src/components/digital-twin/ObservedTasteEvidence.test.jsx b/client/src/components/digital-twin/ObservedTasteEvidence.test.jsxnew file mode 100644index 0000000000..2dd838d740--- /dev/null+++ b/client/src/components/digital-twin/ObservedTasteEvidence.test.jsx@@ -0,0 +1,56 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen, fireEvent, waitFor } from '@testing-library/react';++vi.mock('../../services/api', () => ({+ getTwinEvidence: vi.fn(),+ getProviders: vi.fn(),+ recomputeTwinEvidence: vi.fn(),+ interpretTwinConsumption: vi.fn(),+}));+vi.mock('../ui/Toast', () => ({ default: Object.assign(vi.fn(), { success: vi.fn(), error: vi.fn() }) }));+vi.mock('./TwinProviderPicker.jsx', () => ({+ default: ({ providers }) => <div data-testid="picker">{providers.map((p) => p.id).join(',')}</div>,+}));++import * as api from '../../services/api';+import ObservedTasteEvidence from './ObservedTasteEvidence';++const EVIDENCE = { taste: { windows: { month: {}, week: {} } } };+const PROVIDERS = { providers: [{ id: 'example', name: 'Example', enabled: true, defaultModel: 'm' }] };++describe('ObservedTasteEvidence failed reads', () => {+ beforeEach(() => vi.clearAllMocks());++ it('shows an error with Retry, not "No observed evidence yet", when the evidence read fails', async () => {+ api.getTwinEvidence.mockRejectedValueOnce(new Error('offline')).mockResolvedValueOnce(EVIDENCE);+ api.getProviders.mockResolvedValue(PROVIDERS);+ render(<ObservedTasteEvidence />);++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load observed evidence.*offline/i);+ expect(screen.queryByText(/No observed evidence yet/i)).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ await waitFor(() => expect(screen.queryByRole('alert')).toBeNull());+ expect(await screen.findByRole('button', { name: /What does this say about me/i })).toBeInTheDocument();+ });++ it('shows an error with Retry, not "No AI provider configured", when the provider list fails', async () => {+ api.getTwinEvidence.mockResolvedValue(EVIDENCE);+ api.getProviders.mockRejectedValueOnce(new Error('providers down')).mockResolvedValueOnce(PROVIDERS);+ render(<ObservedTasteEvidence />);++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load AI providers/i);+ expect(screen.queryByText(/No AI provider configured/i)).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByTestId('picker')).toHaveTextContent('example');+ });++ it('keeps the empty copy for a genuinely empty evidence profile and provider list', async () => {+ api.getTwinEvidence.mockResolvedValue({});+ api.getProviders.mockResolvedValue({ providers: [] });+ render(<ObservedTasteEvidence />);+ expect(await screen.findByText(/No observed evidence yet/i)).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });+});diff --git a/client/src/components/digital-twin/tabs/AccountsTab.jsx b/client/src/components/digital-twin/tabs/AccountsTab.jsxindex 4d7b544d9f..d1a3e88bca 100644--- a/client/src/components/digital-twin/tabs/AccountsTab.jsx+++ b/client/src/components/digital-twin/tabs/AccountsTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect } from 'react';+import { useCallback, useEffect, useMemo, useState } from 'react';import {GitBranch,Camera,@@ -28,7 +28,9 @@ import InlineConfirmRow from '../../ui/InlineConfirmRow';import { FormField } from '../../ui/FormField';import * as api from '../../../services/api';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';import { useConfirmDelete } from '../../../hooks/useConfirmDelete';+import useListResource from '../../../hooks/useListResource';// Platform icon mappingconst PLATFORM_ICONS = {@@ -97,38 +99,44 @@ const EMPTY_FORM = {notes: ''};+const fetchAccounts = () => api.getSocialAccounts({}, { silent: true }).then((data) => data?.accounts ?? []);+const fetchPlatforms = () => api.getSocialAccountPlatforms({ silent: true }).then((data) => data?.platforms ?? []);+const fetchOrgLinks = () => api.getSocialAccountOrgLinks({ silent: true });+export default function AccountsTab() {- const [accounts, setAccounts] = useState([]);- const [platforms, setPlatforms] = useState([]);+ const accountsResource = useListResource(fetchAccounts);+ const platformsResource = useListResource(fetchPlatforms);+ const orgLinksResource = useListResource(fetchOrgLinks);+ const { items: accounts, setItems: setAccounts, retry: retryAccounts } = accountsResource;+ const { items: platforms, retry: retryPlatforms } = platformsResource;+ const { items: orgLinkRows, setItems: setOrgLinkRows, retry: retryOrgLinks } = orgLinksResource;const [stats, setStats] = useState(null);- const [loading, setLoading] = useState(true);const [showForm, setShowForm] = useState(false);const [editingId, setEditingId] = useState(null);const [form, setForm] = useState(EMPTY_FORM);const [saving, setSaving] = useState(false);const [deleting, setDeleting] = useState(null);// Map socialAccountId → { orgId, orgName } for the "in org registry" badge (#2147).- const [orgLinks, setOrgLinks] = useState({});+ const orgLinks = useMemo(() => Object.fromEntries(orgLinkRows.map(l => [l.socialAccountId, l])), [orgLinkRows]);+ // Without the link list an account that IS in the registry would offer "Add to+ // org registry" and create a duplicate org, so the action waits for a good read.+ const orgLinksReady = orgLinksResource.state === 'ready';const [linkingId, setLinkingId] = useState(null);const { isConfirming, requestDelete, cancelDelete, confirmDelete } = useConfirmDelete();- useEffect(() => {- loadData();+ const loadStats = useCallback(async () => {+ setStats(await api.getSocialAccountStats().catch(() => null));}, []);- const loadData = async () => {- const [accountsData, platformsData, statsData, linksData] = await Promise.all([- api.getSocialAccounts().catch(() => ({ accounts: [] })),- api.getSocialAccountPlatforms().catch(() => ({ platforms: [] })),- api.getSocialAccountStats().catch(() => null),- // Degrades to no badges if Privacy Center isn't provisioned yet.- api.getSocialAccountOrgLinks({ silent: true }).catch(() => [])- ]);- setAccounts(accountsData.accounts || []);- setPlatforms(platformsData.platforms || []);- setStats(statsData);- setOrgLinks(Object.fromEntries((linksData || []).map(l => [l.socialAccountId, l])));- setLoading(false);+ useEffect(() => {+ loadStats();+ }, [loadStats]);++ const reloadAll = () => {+ retryAccounts();+ retryPlatforms();+ retryOrgLinks();+ loadStats();};// "Add to org registry": create a platform-category org linked to this account.@@ -143,7 +151,7 @@ export default function AccountsTab() {}).catch(() => null);if (created) {// Reactive update — no full refetch.- setOrgLinks(prev => ({ ...prev, [account.id]: { socialAccountId: account.id, orgId: created.id, orgName: created.name } }));+ setOrgLinkRows(prev => [...prev, { socialAccountId: account.id, orgId: created.id, orgName: created.name }]);toast.success(`Added ${created.name} to org registry`);}setLinkingId(null);@@ -162,18 +170,20 @@ export default function AccountsTab() {if (updated) {toast.success(`Updated ${form.platform} account`);setEditingId(null);+ setAccounts(prev => prev.map(a => (a.id === updated.id ? updated : a)));}} else {const created = await api.createSocialAccount(form).catch(() => null);if (created) {toast.success(`Added ${form.platform} account`);+ setAccounts(prev => [...prev, created]);}}setSaving(false);setShowForm(false);setForm(EMPTY_FORM);- loadData();+ loadStats();};const handleEdit = (account) => {@@ -194,7 +204,8 @@ export default function AccountsTab() {const success = await api.deleteSocialAccount(id).catch(() => false);if (success !== false) {toast.success('Account removed');- loadData();+ setAccounts(prev => prev.filter(a => a.id !== id));+ loadStats();}setDeleting(null);};@@ -216,7 +227,16 @@ export default function AccountsTab() {groupedAccounts[category].push(account);}- if (loading) {+ const loadError = [accountsResource, platformsResource].find((resource) => resource.state === 'error');+ if (loadError) {+ return (+ <div className="p-4">+ <ListLoadError what={loadError === accountsResource ? 'social accounts' : 'social platforms'} error={loadError.error} onRetry={reloadAll} />+ </div>+ );+ }++ if (accountsResource.state === 'loading' || platformsResource.state === 'loading') {return (<div className="flex items-center justify-center py-12"><BrailleSpinner text="Loading" />@@ -236,7 +256,7 @@ export default function AccountsTab() {</div><div className="flex items-center gap-2"><button- onClick={loadData}+ onClick={reloadAll}className="p-2 text-gray-400 hover:text-white border border-port-border rounded-lg hover:bg-port-card transition-colors min-h-[40px] min-w-[40px] flex items-center justify-center"title="Refresh" aria-label="Refresh">@@ -252,6 +272,10 @@ export default function AccountsTab() {</div></div>+ {orgLinksResource.state === 'error' && (+ <ListLoadError what="org registry links" error={orgLinksResource.error} onRetry={retryOrgLinks} />+ )}+{/* Stats Summary */}{stats && stats.total > 0 && (<div className="grid grid-cols-1 sm:grid-cols-3 gap-3">@@ -479,7 +503,7 @@ export default function AccountsTab() {<Building2 className="w-3 h-3" />In org registry</span>- ) : (+ ) : orgLinksReady && (<buttononClick={() => handleAddToOrgRegistry(account)}disabled={linkingId === account.id}diff --git a/client/src/components/digital-twin/tabs/AccountsTab.test.jsx b/client/src/components/digital-twin/tabs/AccountsTab.test.jsxindex c8799feb5f..64f435deeb 100644--- a/client/src/components/digital-twin/tabs/AccountsTab.test.jsx+++ b/client/src/components/digital-twin/tabs/AccountsTab.test.jsx@@ -168,4 +168,38 @@ describe('AccountsTab', () => {expect(screen.getByText(/Add your social media accounts to build your digital identity profile and reference your profiles across platforms\./i)).toBeInTheDocument();expect(screen.queryByText(/content learning/i)).not.toBeInTheDocument();});++ it('fails into a retry instead of "No social accounts yet" when the account read fails', async () => {+ api.getSocialAccounts.mockRejectedValueOnce(new Error('boom'));+ const user = userEvent.setup();+ render(<AccountsTab />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load social accounts');+ expect(screen.queryByText('No social accounts yet')).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('@octocat')).toBeInTheDocument();+ });++ it('fails into a retry when the platform list read fails', async () => {+ api.getSocialAccountPlatforms.mockRejectedValueOnce(new Error('boom'));+ render(<AccountsTab />);+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load social platforms');+ });++ it('withholds "Add to org registry" while the link read is failed, so an already-linked account is not duplicated', async () => {+ api.getSocialAccountOrgLinks.mockRejectedValueOnce(new Error('privacy down'));+ const user = userEvent.setup();+ render(<AccountsTab />);++ expect(await screen.findByText('@octocat')).toBeInTheDocument();+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load org registry links');+ expect(screen.queryByRole('button', { name: /Add to org registry/ })).not.toBeInTheDocument();++ api.getSocialAccountOrgLinks.mockResolvedValueOnce([{ socialAccountId: 'acc-1', orgId: 'org-1', orgName: 'Example Org' }]);+ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('In org registry')).toBeInTheDocument();+ expect(screen.getAllByRole('button', { name: /Add to org registry/ })).toHaveLength(1);+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });});diff --git a/client/src/components/digital-twin/tabs/AutobiographyTab.jsx b/client/src/components/digital-twin/tabs/AutobiographyTab.jsxindex 009cd686e8..8fac66a8f2 100644--- a/client/src/components/digital-twin/tabs/AutobiographyTab.jsx+++ b/client/src/components/digital-twin/tabs/AutobiographyTab.jsx@@ -25,6 +25,8 @@ import * as api from '../../../services/api';import { copyToClipboard } from '../../../lib/clipboard';import { countWords } from '../../../lib/textUtils';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import { useConfirmDelete } from '../../../hooks/useConfirmDelete';import { formatCount, formatDateTime, formatDateNumeric } from '../../../utils/formatters';import { isValidTimeString } from '../../../utils/timeWindow';@@ -37,13 +39,19 @@ const DEFAULT_REMINDER_TIME = '09:00';// story written against the user's own question is saved under.const CUSTOM_PROMPT_ID = 'custom';+const fetchThemes = () => api.getAutobiographyThemes({ silent: true });+// Suggestions come from the prompt bank and what's already been written —+// never from the theme filter.+const fetchSuggestions = () => api.getAutobiographySuggestions({ silent: true });+export default function AutobiographyTab({ onRefresh }) {const [searchParams, setSearchParams] = useSearchParams();const [stats, setStats] = useState(null);- const [stories, setStories] = useState([]);- const [themes, setThemes] = useState([]);const [loading, setLoading] = useState(true);const [filterTheme, setFilterTheme] = useState(null);+ const fetchStories = useCallback(() => api.getAutobiographyStories(filterTheme, { silent: true }), [filterTheme]);+ const { items: stories, setItems: setStories, state: storiesState, error: storiesError, retry: retryStories } = useListResource(fetchStories);+ const { items: themes, state: themesState, error: themesError, retry: retryThemes } = useListResource(fetchThemes);// Writing stateconst [currentPrompt, setCurrentPrompt] = useState(null);@@ -52,7 +60,7 @@ export default function AutobiographyTab({ onRefresh }) {const [saving, setSaving] = useState(false);// Story ideas — the same menu the daily prompt notification offers- const [suggestions, setSuggestions] = useState([]);+ const { items: suggestions, state: suggestionsState, error: suggestionsError, retry: refreshSuggestions } = useListResource(fetchSuggestions);const [ownQuestion, setOwnQuestion] = useState('');// Storytelling-craft evaluation, keyed by story id while it runs@@ -81,36 +89,26 @@ export default function AutobiographyTab({ onRefresh }) {const { isConfirming, requestDelete, cancelDelete, confirmDelete } = useConfirmDelete();- const loadData = useCallback(async () => {- const [statsData, storiesData, themesData, configData] = await Promise.all([+ // Stats and config are single objects, not lists: a failed read stays `null`+ // (absent), which hides their panels rather than rendering a wrong value.+ const refreshStats = useCallback(async () => {+ setStats(await api.getAutobiographyStats().catch(() => null));+ }, []);++ const loadMeta = useCallback(async () => {+ const [statsData, configData] = await Promise.all([api.getAutobiographyStats().catch(() => null),- api.getAutobiographyStories(filterTheme).catch(() => []),- api.getAutobiographyThemes().catch(() => []),api.getAutobiographyConfig().catch(() => null)]);setStats(statsData);- setStories(storiesData);- setThemes(themesData);setConfig(configData);setReminderTimeDraft(configData?.reminder?.time || DEFAULT_REMINDER_TIME);setLoading(false);- }, [filterTheme]);-- // Suggestions come from the prompt bank and what's already been written —- // never from the theme filter, so this stays out of `loadData` and its- // filterTheme dependency. It refreshes on mount and after a save, which is- // exactly when the set can actually change.- const refreshSuggestions = useCallback(async () => {- setSuggestions(await api.getAutobiographySuggestions({ silent: true }).catch(() => []));}, []);useEffect(() => {- loadData();- }, [loadData]);-- useEffect(() => {- refreshSuggestions();- }, [refreshSuggestions]);+ loadMeta();+ }, [loadMeta]);// Auto-load prompt from URL param (when arriving from notification)useEffect(() => {@@ -196,7 +194,9 @@ export default function AutobiographyTab({ onRefresh }) {// Show follow-ups from the saved story if it already has them, otherwise offer to generatesetFollowUps({ storyId: result.id, prompts: result.followUpPrompts || null });setExpandedStory(result.id);- loadData();+ // Newest first, and only when the story belongs under the active theme filter.+ if (!filterTheme || result.themeId === filterTheme) setStories(prev => [result, ...prev]);+ refreshStats();// The prompt just used drops out of the bank, so the menu changes here.refreshSuggestions();onRefresh?.();@@ -264,7 +264,8 @@ export default function AutobiographyTab({ onRefresh }) {toast.success('Story updated');setEditingStory(null);setEditContent('');- loadData();+ setStories(prev => prev.map(s => (s.id === storyId ? { ...s, ...result } : s)));+ refreshStats();}};@@ -273,7 +274,8 @@ export default function AutobiographyTab({ onRefresh }) {.catch((err) => { toast.error(err.message); return null; });if (result) {toast.success('Story deleted');- loadData();+ setStories(prev => prev.filter(s => s.id !== storyId));+ refreshStats();}};@@ -425,6 +427,9 @@ export default function AutobiographyTab({ onRefresh }) {<span className="text-sm font-medium text-white">Story ideas</span><span className="text-xs text-gray-500">Every story answers a question</span></div>+ {suggestionsState === 'error' && (+ <ListLoadError what="story ideas" error={suggestionsError} onRetry={refreshSuggestions} />+ )}{suggestions.length > 0 && (<div className="space-y-2">{suggestions.map((prompt) => (@@ -596,7 +601,10 @@ export default function AutobiographyTab({ onRefresh }) {)}{/* Theme Filter */}- {stories.length > 0 && (+ {themesState === 'error' && (+ <ListLoadError what="story themes" error={themesError} onRetry={retryThemes} />+ )}+ {(stories.length > 0 || filterTheme) && (<div className="flex flex-wrap gap-2"><buttononClick={() => setFilterTheme(null)}@@ -626,7 +634,15 @@ export default function AutobiographyTab({ onRefresh }) {)}{/* Stories List */}- {stories.length === 0 && !writing && (+ {storiesState === 'loading' && (+ <div className="flex items-center justify-center py-8">+ <BrailleSpinner text="Loading stories" />+ </div>+ )}+ {storiesState === 'error' && (+ <ListLoadError what="stories" error={storiesError} onRetry={retryStories} />+ )}+ {storiesState === 'ready' && stories.length === 0 && !writing && (<div className="text-center py-12 text-gray-500"><BookOpen className="w-12 h-12 mx-auto mb-3 opacity-50" /><p className="text-lg">No stories yet</p>diff --git a/client/src/components/digital-twin/tabs/AutobiographyTab.test.jsx b/client/src/components/digital-twin/tabs/AutobiographyTab.test.jsxnew file mode 100644index 0000000000..c8e0c55764--- /dev/null+++ b/client/src/components/digital-twin/tabs/AutobiographyTab.test.jsx@@ -0,0 +1,73 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { MemoryRouter } from 'react-router';++vi.mock('../../../services/api', () => ({+ getAutobiographyStats: vi.fn(),+ getAutobiographyStories: vi.fn(),+ getAutobiographyThemes: vi.fn(),+ getAutobiographyConfig: vi.fn(),+ getAutobiographySuggestions: vi.fn(),+ getAutobiographyPromptById: vi.fn(),+ getAutobiographyPrompt: vi.fn(),+ saveAutobiographyStory: vi.fn(),+ deleteAutobiographyStory: vi.fn(),+}));+vi.mock('../../ui/Toast', () => ({ default: Object.assign(vi.fn(), { success: vi.fn(), error: vi.fn() }) }));+vi.mock('../StoryCraftPanel', () => ({ default: () => null }));++import AutobiographyTab from './AutobiographyTab';+import * as api from '../../../services/api';++const STORY = {+ id: 'story-1', themeId: 'childhood', themeLabel: 'Childhood', promptText: 'A question?',+ content: 'Once upon a time', wordCount: 4, createdAt: '2026-01-01T00:00:00.000Z',+};+const THEME = { id: 'childhood', label: 'Childhood' };++const renderTab = () => render(<MemoryRouter><AutobiographyTab onRefresh={vi.fn()} /></MemoryRouter>);++describe('AutobiographyTab failed loads', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ api.getAutobiographyStats.mockResolvedValue({ totalStories: 1, totalWords: 4, byTheme: {} });+ api.getAutobiographyConfig.mockResolvedValue(null);+ api.getAutobiographyStories.mockResolvedValue([STORY]);+ api.getAutobiographyThemes.mockResolvedValue([THEME]);+ api.getAutobiographySuggestions.mockResolvedValue([]);+ });++ it('shows a retryable error instead of "No stories yet" when the story read fails', async () => {+ api.getAutobiographyStories.mockRejectedValueOnce(new Error('boom'));+ const user = userEvent.setup();+ renderTab();++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load stories');+ expect(screen.queryByText('No stories yet')).toBeNull();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText("A question?")).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('keeps "No stories yet" for a genuinely empty journal', async () => {+ api.getAutobiographyStories.mockResolvedValue([]);+ renderTab();+ expect(await screen.findByText('No stories yet')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('shows a retryable error row when the themes read fails', async () => {+ api.getAutobiographyThemes.mockRejectedValueOnce(new Error('boom'));+ renderTab();+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load story themes');+ expect(await screen.findByText("A question?")).toBeInTheDocument();+ });++ it('shows a retryable error row when the story ideas read fails', async () => {+ api.getAutobiographySuggestions.mockRejectedValueOnce(new Error('boom'));+ renderTab();+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load story ideas');+ });+});diff --git a/client/src/components/digital-twin/tabs/DocumentsTab.jsx b/client/src/components/digital-twin/tabs/DocumentsTab.jsxindex c9efb1bfb3..787bdfafbe 100644--- a/client/src/components/digital-twin/tabs/DocumentsTab.jsx+++ b/client/src/components/digital-twin/tabs/DocumentsTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect } from 'react';+import { useState } from 'react';import {FileText,Plus,@@ -15,32 +15,24 @@ import * as api from '../../../services/api';import toast from '../../ui/Toast';import Modal from '../../ui/Modal';import { FormField } from '../../ui/FormField';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import { DOCUMENT_CATEGORIES } from '../constants';import { timeAgo } from '../../../utils/formatters';+const fetchDocuments = () => api.getDigitalTwinDocuments({ silent: true });+export default function DocumentsTab({ onRefresh }) {- const [documents, setDocuments] = useState([]);+ const { items: documents, state: documentsState, error: documentsError, retry: loadDocuments } = useListResource(fetchDocuments);const [selectedDoc, setSelectedDoc] = useState(null);const [editMode, setEditMode] = useState(false);const [editContent, setEditContent] = useState('');- const [loading, setLoading] = useState(true);const [saving, setSaving] = useState(false);const [showCreate, setShowCreate] = useState(false);const [newDoc, setNewDoc] = useState({ filename: '', title: '', category: 'core', content: '' });const [deleteConfirm, setDeleteConfirm] = useState(null);- useEffect(() => {- loadDocuments();- }, []);-- const loadDocuments = async () => {- setLoading(true);- const docs = await api.getDigitalTwinDocuments().catch(() => []);- setDocuments(docs);- setLoading(false);- };-const loadDocument = async (id) => {const doc = await api.getDigitalTwinDocument(id);setSelectedDoc(doc);@@ -57,7 +49,7 @@ export default function DocumentsTab({ onRefresh }) {setSaving(false);if (!saved) return;toast.success('Document saved');- await loadDocuments();+ loadDocuments();await loadDocument(selectedDoc.id);setEditMode(false);onRefresh();@@ -66,7 +58,7 @@ export default function DocumentsTab({ onRefresh }) {const handleToggleEnabled = async (doc, enabled) => {await api.updateSoulDocument(doc.id, { enabled });toast.success(enabled ? 'Document enabled' : 'Document disabled');- await loadDocuments();+ loadDocuments();if (selectedDoc?.id === doc.id) {await loadDocument(doc.id);}@@ -76,7 +68,7 @@ export default function DocumentsTab({ onRefresh }) {const handleWeightChange = async (doc, weight) => {await api.updateSoulDocument(doc.id, { weight });toast.success(`Weight set to ${weight}`);- await loadDocuments();+ loadDocuments();if (selectedDoc?.id === doc.id) {setSelectedDoc({ ...selectedDoc, weight });}@@ -99,7 +91,7 @@ export default function DocumentsTab({ onRefresh }) {setSaving(false);if (!created) return;toast.success('Document created');- await loadDocuments();+ loadDocuments();setShowCreate(false);setNewDoc({ filename: '', title: '', category: 'core', content: '' });onRefresh();@@ -112,11 +104,11 @@ export default function DocumentsTab({ onRefresh }) {setSelectedDoc(null);}setDeleteConfirm(null);- await loadDocuments();+ loadDocuments();onRefresh();};- if (loading) {+ if (documentsState === 'loading') {return (<div className="flex items-center justify-center h-64"><div className="text-gray-500">Loading documents...</div>@@ -140,7 +132,11 @@ export default function DocumentsTab({ onRefresh }) {</div><div className="flex-1 overflow-y-auto max-h-[50vh] lg:max-h-none">- {documents.length === 0 ? (+ {documentsState === 'error' ? (+ <div className="p-3">+ <ListLoadError what="documents" error={documentsError} onRetry={loadDocuments} />+ </div>+ ) : documents.length === 0 ? (<div className="p-4 text-center text-gray-500">No documents yet</div>diff --git a/client/src/components/digital-twin/tabs/DocumentsTab.test.jsx b/client/src/components/digital-twin/tabs/DocumentsTab.test.jsxindex 46d4191945..641500ab76 100644--- a/client/src/components/digital-twin/tabs/DocumentsTab.test.jsx+++ b/client/src/components/digital-twin/tabs/DocumentsTab.test.jsx@@ -46,3 +46,27 @@ describe('DocumentsTab failed save', () => {await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Document saved'));});});++describe('DocumentsTab failed load', () => {+ beforeEach(() => vi.clearAllMocks());++ it('shows a retryable load error instead of "No documents yet", then the list once Retry succeeds', async () => {+ api.getDigitalTwinDocuments.mockRejectedValueOnce(new Error('boom')).mockResolvedValueOnce([DOC]);+ const user = userEvent.setup();+ render(<DocumentsTab onRefresh={vi.fn()} />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load documents');+ expect(screen.queryByText('No documents yet')).toBeNull();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByRole('button', { name: /Core Values/ })).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('keeps "No documents yet" for a genuinely empty library', async () => {+ api.getDigitalTwinDocuments.mockResolvedValue([]);+ render(<DocumentsTab onRefresh={vi.fn()} />);+ expect(await screen.findByText('No documents yet')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });+});diff --git a/client/src/components/digital-twin/tabs/EnrichTab.jsx b/client/src/components/digital-twin/tabs/EnrichTab.jsxindex b21c4973ab..15afa42cef 100644--- a/client/src/components/digital-twin/tabs/EnrichTab.jsx+++ b/client/src/components/digital-twin/tabs/EnrichTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect, useCallback, useRef } from 'react';+import { useState, useEffect, useCallback, useMemo, useRef } from 'react';import { useSearchParams } from 'react-router';import {Sparkles,ChevronRight,@@ -13,6 +13,8 @@ import {Sparkles,import BrailleSpinner from '../../BrailleSpinner';import * as api from '../../../services/api';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';+import useProviderList from '../../../hooks/useProviderList';import TwinProviderPicker from '../TwinProviderPicker.jsx';import { ENRICHMENT_CATEGORIES } from '../constants';@@ -44,8 +46,12 @@ export default function EnrichTab({ onRefresh }) {const [writingSamples, setWritingSamples] = useState(() => [mkSample()]);const [analyzingWriting, setAnalyzingWriting] = useState(false);const [writingAnalysis, setWritingAnalysis] = useState(null);- const [providers, setProviders] = useState([]);- const [selectedProvider, setSelectedProvider] = useState(null);+ const providerList = useProviderList();+ const providers = useMemo(() => providerList.items.filter(p => p.enabled), [providerList.items]);+ // Until the user picks one, default to the first enabled provider.+ const [pickedProvider, setSelectedProvider] = useState(null);+ const selectedProvider = pickedProvider+ ?? (providers[0] ? { providerId: providers[0].id, model: providers[0].defaultModel } : null);const [savingWritingStyle, setSavingWritingStyle] = useState(false);const loadData = useCallback(async () => {@@ -55,19 +61,9 @@ export default function EnrichTab({ onRefresh }) {setLoading(false);}, []);- const loadProviders = useCallback(async () => {- const data = await api.getProviders().catch(() => ({ providers: [] }));- const enabled = (data.providers || []).filter(p => p.enabled);- setProviders(enabled);- if (enabled.length > 0) {- setSelectedProvider({ providerId: enabled[0].id, model: enabled[0].defaultModel });- }- }, []);-useEffect(() => {loadData();- loadProviders();- }, [loadData, loadProviders]);+ }, [loadData]);const addWritingSample = () => {setWritingSamples([...writingSamples, mkSample()]);@@ -263,6 +259,8 @@ export default function EnrichTab({ onRefresh }) {onRefresh?.();}}providers={providers}+ providersError={providerList.state === 'error' ? providerList.error : null}+ onRetryProviders={providerList.retry}selectedProvider={selectedProvider}setSelectedProvider={setSelectedProvider}/>@@ -547,12 +545,16 @@ export default function EnrichTab({ onRefresh }) {</p>{/* Provider Selection */}- <TwinProviderPicker- label="Analyze with"- providers={providers}- selected={selectedProvider}- onChange={setSelectedProvider}- />+ {providerList.state === 'error' ? (+ <ListLoadError what="AI providers" error={providerList.error} onRetry={providerList.retry} />+ ) : (+ <TwinProviderPicker+ label="Analyze with"+ providers={providers}+ selected={selectedProvider}+ onChange={setSelectedProvider}+ />+ )}{/* Writing Samples */}<div className="space-y-3">diff --git a/client/src/components/digital-twin/tabs/EnrichTab.test.jsx b/client/src/components/digital-twin/tabs/EnrichTab.test.jsxnew file mode 100644index 0000000000..14cf13b59c--- /dev/null+++ b/client/src/components/digital-twin/tabs/EnrichTab.test.jsx@@ -0,0 +1,39 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen, fireEvent, waitFor } from '@testing-library/react';+import { MemoryRouter } from 'react-router';++vi.mock('../../../services/api', () => ({+ getDigitalTwinEnrichProgress: vi.fn(),+ getProviders: vi.fn(),+ analyzeWritingSamples: vi.fn(),+}));+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn() } }));+vi.mock('../TwinProviderPicker.jsx', () => ({+ default: ({ providers }) => <div data-testid="picker">{providers.map((p) => p.id).join(',')}</div>,+}));+vi.mock('../ListEnrichment', () => ({ default: () => null }));++import * as api from '../../../services/api';+import EnrichTab from './EnrichTab';++describe('EnrichTab provider list', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ api.getDigitalTwinEnrichProgress.mockResolvedValue({ categories: {} });+ });++ it('shows an error with Retry instead of an empty picker when the provider list fails', async () => {+ api.getProviders+ .mockRejectedValueOnce(new Error('providers down'))+ .mockResolvedValueOnce({ providers: [{ id: 'example', enabled: true, defaultModel: 'm' }] });+ render(<MemoryRouter><EnrichTab /></MemoryRouter>);++ fireEvent.click(await screen.findByRole('button', { name: /Analyze Your Writing/i }));+ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load AI providers/i);+ expect(screen.queryByTestId('picker')).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ await waitFor(() => expect(screen.getByTestId('picker')).toHaveTextContent('example'));+ expect(screen.queryByRole('alert')).toBeNull();+ });+});diff --git a/client/src/components/digital-twin/tabs/ExportTab.jsx b/client/src/components/digital-twin/tabs/ExportTab.jsxindex c6936c0562..f9156a1acd 100644--- a/client/src/components/digital-twin/tabs/ExportTab.jsx+++ b/client/src/components/digital-twin/tabs/ExportTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect } from 'react';+import { useCallback, useState, useEffect } from 'react';import {Download,Copy,Check,@@ -14,13 +14,22 @@ import toast from '../../ui/Toast';import { copyToClipboard } from '../../../lib/clipboard';import { downloadBlob } from '../../../lib/downloadBlob';import { formatCount } from '../../../utils/formatters';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import { DOCUMENT_CATEGORIES } from '../constants';+const fetchDocuments = () => api.getDigitalTwinDocuments({ silent: true });+const fetchFormats = () => api.getDigitalTwinExportFormats({ silent: true });+export default function ExportTab({ onRefresh: _onRefresh }) {- const [documents, setDocuments] = useState([]);- const [formats, setFormats] = useState([]);- const [loading, setLoading] = useState(true);+ const documentsResource = useListResource(fetchDocuments);+ const formatsResource = useListResource(fetchFormats);+ const { items: documents, retry: retryDocuments } = documentsResource;+ const { items: formats, retry: retryFormats } = formatsResource;+ const loadError = [documentsResource, formatsResource].find((resource) => resource.state === 'error') || null;+ const loading = !loadError && (documentsResource.state === 'loading' || formatsResource.state === 'loading');+ const retryLoad = useCallback(() => { retryDocuments(); retryFormats(); }, [retryDocuments, retryFormats]);const [exporting, setExporting] = useState(false);// Export configuration@@ -32,24 +41,13 @@ export default function ExportTab({ onRefresh: _onRefresh }) {const [exportResult, setExportResult] = useState(null);const [copied, setCopied] = useState(false);+ // Default: select all enabled documents once the library has loaded. An empty+ // selection exports EVERYTHING (see handleExport), so it must never be seeded+ // from a failed read — the whole tab fails into a retry instead.useEffect(() => {- loadData();- }, []);-- const loadData = async () => {- setLoading(true);- const [docsData, formatsData] = await Promise.all([- api.getDigitalTwinDocuments().catch(() => []),- api.getDigitalTwinExportFormats().catch(() => [])- ]);- setDocuments(docsData);- setFormats(formatsData);-- // Default: select all enabled documents- setSelectedDocs(docsData.filter(d => d.enabled).map(d => d.id));-- setLoading(false);- };+ if (documentsResource.state !== 'ready') return;+ setSelectedDocs(documents.filter(d => d.enabled).map(d => d.id));+ }, [documentsResource.state, documents]);const toggleDocument = (docId) => {setSelectedDocs(prev =>@@ -131,6 +129,10 @@ export default function ExportTab({ onRefresh: _onRefresh }) {);}+ if (loadError) {+ return <ListLoadError what="export options" error={loadError.error} onRetry={retryLoad} />;+ }+return (<div className="grid grid-cols-1 lg:grid-cols-2 gap-4 sm:gap-6">{/* Configuration */}diff --git a/client/src/components/digital-twin/tabs/ExportTab.test.jsx b/client/src/components/digital-twin/tabs/ExportTab.test.jsxindex a071bfc752..7ba212e3ac 100644--- a/client/src/components/digital-twin/tabs/ExportTab.test.jsx+++ b/client/src/components/digital-twin/tabs/ExportTab.test.jsx@@ -1,4 +1,4 @@-import { act, fireEvent, render, screen } from '@testing-library/react';+import { act, fireEvent, render, screen, waitFor } from '@testing-library/react';import { beforeEach, describe, expect, it, vi } from 'vitest';vi.mock('../../../services/api', () => ({@@ -28,4 +28,26 @@ describe('ExportTab', () => {expect(exportButton).toBeEnabled();expect(exportButton).toHaveTextContent('Generate Export');});++ it('fails the whole tab into a retry when the document read fails, and never exports an unseeded selection', async () => {+ api.getDigitalTwinDocuments.mockRejectedValueOnce(new Error('boom'));++ render(<ExportTab />);+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load export options');+ // Without the documents the selection would be empty, which exports EVERY document.+ expect(screen.queryByRole('button', { name: 'Generate Export' })).toBeNull();++ await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Retry' })); });+ expect(await screen.findByRole('button', { name: 'Generate Export' })).toBeEnabled();+ api.exportSoul.mockResolvedValueOnce({ content: 'x' });+ await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Generate Export' })); });+ await waitFor(() => expect(api.exportSoul).toHaveBeenCalledWith('system_prompt', ['doc-1'], false));+ });++ it('fails into a retry when only the formats read fails', async () => {+ api.getDigitalTwinExportFormats.mockRejectedValueOnce(new Error('boom'));++ render(<ExportTab />);+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load export options');+ });});diff --git a/client/src/components/digital-twin/tabs/ImportTab.jsx b/client/src/components/digital-twin/tabs/ImportTab.jsxindex e83078a57e..0314819a6c 100644--- a/client/src/components/digital-twin/tabs/ImportTab.jsx+++ b/client/src/components/digital-twin/tabs/ImportTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect } from 'react';+import { useEffect, useMemo, useState } from 'react';import {Upload,BookOpen,@@ -20,6 +20,9 @@ import TwinProviderPicker from '../TwinProviderPicker.jsx';import { formatBytes } from '../../../utils/formatters';import FilePickerButton from '../../ui/FilePickerButton';import { pluralize } from '../../../lib/textUtils';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';+import useProviderList from '../../../hooks/useProviderList';const SOURCE_ICONS = {goodreads: BookOpen,@@ -35,9 +38,12 @@ const SOURCE_COLORS = {ical: 'text-blue-400 bg-blue-500/20'};+const fetchSources = () => api.getDigitalTwinImportSources({ silent: true }).then((data) => data?.sources ?? []);+export default function ImportTab() {- const [sources, setSources] = useState([]);- const [providers, setProviders] = useState([]);+ const { items: sources, state: sourcesState, error: sourcesError, retry: retrySources } = useListResource(fetchSources);+ const { items: allProviders, state: providersState, error: providersError, retry: retryProviders } = useProviderList();+ const providers = useMemo(() => allProviders.filter(p => p.enabled), [allProviders]);const [selectedSource, setSelectedSource] = useState(null);const [selectedProvider, setSelectedProvider] = useState(null);const [fileContent, setFileContent] = useState('');@@ -49,23 +55,9 @@ export default function ImportTab() {const [importingSpotifyBrowser, setImportingSpotifyBrowser] = useState(false);useEffect(() => {- loadSources();- loadProviders();- }, []);-- const loadSources = async () => {- const data = await api.getDigitalTwinImportSources().catch(() => ({ sources: [] }));- setSources(data.sources || []);- };-- const loadProviders = async () => {- const data = await api.getProviders().catch(() => ({ providers: [] }));- const enabled = (data.providers || []).filter(p => p.enabled);- setProviders(enabled);- if (enabled.length > 0) {- setSelectedProvider({ providerId: enabled[0].id, model: enabled[0].defaultModel });- }- };+ if (providersState !== 'ready' || providers.length === 0) return;+ setSelectedProvider((prev) => prev ?? { providerId: providers[0].id, model: providers[0].defaultModel });+ }, [providersState, providers]);const handleFileUpload = (e) => {const file = e.target.files?.[0];@@ -192,7 +184,10 @@ export default function ImportTab() {</div>{/* Source Selection */}- {!selectedSource && (+ {!selectedSource && sourcesState === 'error' && (+ <ListLoadError what="import sources" error={sourcesError} onRetry={retrySources} />+ )}+ {!selectedSource && sourcesState !== 'error' && (<div className="grid grid-cols-1 sm:grid-cols-2 gap-4">{sources.map(source => {const Icon = SOURCE_ICONS[source.id] || FileText;@@ -336,13 +331,17 @@ export default function ImportTab() {</div>{/* Provider Selection */}- <TwinProviderPicker- className="mb-6"- label="Analysis Provider"- providers={providers}- selected={selectedProvider}- onChange={setSelectedProvider}- />+ {providersState === 'error' ? (+ <ListLoadError className="mb-6" what="AI providers" error={providersError} onRetry={retryProviders} />+ ) : (+ <TwinProviderPicker+ className="mb-6"+ label="Analysis Provider"+ providers={providers}+ selected={selectedProvider}+ onChange={setSelectedProvider}+ />+ )}{/* Analyze Button */}<buttondiff --git a/client/src/components/digital-twin/tabs/ImportTab.test.jsx b/client/src/components/digital-twin/tabs/ImportTab.test.jsxnew file mode 100644index 0000000000..7d2530ff3e--- /dev/null+++ b/client/src/components/digital-twin/tabs/ImportTab.test.jsx@@ -0,0 +1,60 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';++vi.mock('../../../services/api', () => ({+ getDigitalTwinImportSources: vi.fn(),+ getProviders: vi.fn(),+ analyzeDigitalTwinImport: vi.fn(),+ openDigitalTwinSpotifyBrowser: vi.fn(),+ importDigitalTwinSpotifyBrowser: vi.fn(),+}));+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn(), warning: vi.fn() } }));+vi.mock('../TwinProviderPicker.jsx', () => ({+ default: ({ providers, selected }) => (+ <div data-testid="provider-picker">{providers.map((p) => p.id).join(',')}|{selected?.providerId ?? 'none'}</div>+ ),+}));++import ImportTab from './ImportTab';+import * as api from '../../../services/api';++const SOURCE = { id: 'spotify', name: 'Spotify', format: 'zip', description: 'Listening history' };+const PROVIDER = { id: 'example-provider', enabled: true, defaultModel: 'example-model' };++describe('ImportTab failed loads', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ api.getDigitalTwinImportSources.mockResolvedValue({ sources: [SOURCE] });+ api.getProviders.mockResolvedValue({ providers: [PROVIDER, { id: 'off', enabled: false }] });+ });++ it('shows a retryable error instead of an empty source grid, then the sources after Retry', async () => {+ api.getDigitalTwinImportSources.mockRejectedValueOnce(new Error('boom'));+ const user = userEvent.setup();+ render(<ImportTab />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load import sources');+ expect(screen.queryByText('Spotify')).toBeNull();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('Spotify')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('shows a provider load error with Retry, keeps Spotify import blocked, and seeds the first enabled provider on retry', async () => {+ api.getProviders.mockRejectedValueOnce(new Error('providers down'));+ const user = userEvent.setup();+ render(<ImportTab />);++ await user.click(await screen.findByText('Spotify'));+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load AI providers');+ expect(screen.queryByTestId('provider-picker')).toBeNull();+ expect(screen.getByRole('button', { name: /Request and import history/ })).toBeDisabled();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByTestId('provider-picker')).toHaveTextContent('example-provider|example-provider');+ expect(screen.queryByRole('alert')).toBeNull();+ expect(screen.getByRole('button', { name: /Request and import history/ })).toBeEnabled();+ });+});diff --git a/client/src/components/digital-twin/tabs/InterviewTab.jsx b/client/src/components/digital-twin/tabs/InterviewTab.jsxindex 7389b66cc5..60cf3c3a7e 100644--- a/client/src/components/digital-twin/tabs/InterviewTab.jsx+++ b/client/src/components/digital-twin/tabs/InterviewTab.jsx@@ -11,12 +11,17 @@ import {} from 'lucide-react';import * as api from '../../../services/api';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import useProviderModels from '../../../hooks/useProviderModels';import ProviderModelSelector from '../../ProviderModelSelector';import InterviewAnalysisCard from '../InterviewAnalysisCard';import { ENRICHMENT_CATEGORIES } from '../constants';import { formatCount } from '../../../utils/formatters';+// Module-level so the identity is stable for useListResource.+const fetchGaps = () => api.getDigitalTwinGaps({ silent: true }).then((data) => data?.gaps ?? []);+export default function InterviewTab({ onRefresh }) {const navigate = useNavigate();const {@@ -27,21 +32,18 @@ export default function InterviewTab({ onRefresh }) {const [content, setContent] = useState('');const [analyzing, setAnalyzing] = useState(false);const [analysisResult, setAnalysisResult] = useState(null);- const [gaps, setGaps] = useState([]);+ const {+ items: gaps, state: gapsState, error: gapsError, retry: retryGaps, setItems: setGaps+ } = useListResource(fetchGaps);const [enrichProgress, setEnrichProgress] = useState(null);- const loadEnrichmentData = useCallback(async () => {- const [gapsData, progressData] = await Promise.all([- api.getDigitalTwinGaps().catch(() => ({ gaps: [] })),- api.getDigitalTwinEnrichProgress().catch(() => null)- ]);- setGaps(gapsData.gaps || []);- setEnrichProgress(progressData);+ const loadProgress = useCallback(async () => {+ setEnrichProgress(await api.getDigitalTwinEnrichProgress().catch(() => null));}, []);useEffect(() => {- loadEnrichmentData();- }, [loadEnrichmentData]);+ loadProgress();+ }, [loadProgress]);const handleAnalyze = async () => {if (!content.trim() || content.trim().length < 50) {@@ -64,9 +66,10 @@ export default function InterviewTab({ onRefresh }) {} else {setAnalysisResult(result.analysisResult);if (result.gaps) setGaps(result.gaps);+ else retryGaps();toast.success('Assessment analyzed successfully');onRefresh?.();- loadEnrichmentData();+ loadProgress();}setAnalyzing(false);};@@ -210,7 +213,11 @@ export default function InterviewTab({ onRefresh }) {</div>)}- {sortedGaps.length === 0 && (+ {gapsState === 'error' && (+ <ListLoadError what="enrichment gaps" error={gapsError} onRetry={retryGaps} />+ )}++ {gapsState === 'ready' && sortedGaps.length === 0 && (<div className="bg-port-card rounded-lg border border-port-border p-4 flex items-center gap-3"><AlertCircle size={18} className="text-gray-500" /><span className="text-sm text-gray-400">diff --git a/client/src/components/digital-twin/tabs/InterviewTab.test.jsx b/client/src/components/digital-twin/tabs/InterviewTab.test.jsxnew file mode 100644index 0000000000..a7dadc10cd--- /dev/null+++ b/client/src/components/digital-twin/tabs/InterviewTab.test.jsx@@ -0,0 +1,49 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen, fireEvent, waitFor } from '@testing-library/react';+import { MemoryRouter } from 'react-router';++vi.mock('../../../services/api', () => ({+ getDigitalTwinGaps: vi.fn(),+ getDigitalTwinEnrichProgress: vi.fn(),+ analyzeAssessment: vi.fn(),+}));+vi.mock('../../../hooks/useProviderModels', () => ({+ default: () => ({+ providers: [], selectedProviderId: '', selectedModel: '', availableModels: [],+ setSelectedProviderId: vi.fn(), setSelectedModel: vi.fn(), loading: false,+ }),+}));+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn() } }));++import * as api from '../../../services/api';+import InterviewTab from './InterviewTab';++const renderTab = () => render(<MemoryRouter><InterviewTab /></MemoryRouter>);++describe('InterviewTab gaps load', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ api.getDigitalTwinEnrichProgress.mockResolvedValue({ categories: {} });+ });++ it('shows an error with Retry, not "No gap data available", when the gaps read fails', async () => {+ api.getDigitalTwinGaps+ .mockRejectedValueOnce(new Error('offline'))+ .mockResolvedValueOnce({ gaps: [{ dimension: 'openness', confidence: 0.2, suggestedCategory: null }] });+ renderTab();++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load enrichment gaps.*offline/i);+ expect(screen.queryByText(/No gap data available/i)).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('openness')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('keeps the empty copy for a genuinely empty gap list', async () => {+ api.getDigitalTwinGaps.mockResolvedValue({ gaps: [] });+ renderTab();+ expect(await screen.findByText(/No gap data available/i)).toBeInTheDocument();+ await waitFor(() => expect(screen.queryByRole('alert')).toBeNull());+ });+});diff --git a/client/src/components/digital-twin/tabs/OverviewTab.jsx b/client/src/components/digital-twin/tabs/OverviewTab.jsxindex 03333e9183..6efa31fc09 100644--- a/client/src/components/digital-twin/tabs/OverviewTab.jsx+++ b/client/src/components/digital-twin/tabs/OverviewTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect } from 'react';+import { useState, useEffect, useMemo } from 'react';import { useNavigate } from 'react-router';import {Heart,@@ -16,6 +16,8 @@ import {} from 'lucide-react';import * as api from '../../../services/api';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';+import useProviderList from '../../../hooks/useProviderList';import { FormField } from '../../ui/FormField';import TwinProviderPicker from '../TwinProviderPicker.jsx';@@ -42,12 +44,19 @@ export default function OverviewTab({ status, settings, onRefresh, onSettingsChaconst [showValidation, setShowValidation] = useState(false);const [contradictions, setContradictions] = useState(null);const [checkingContradictions, setCheckingContradictions] = useState(false);- const [providers, setProviders] = useState([]);- const [selectedProvider, setSelectedProvider] = useState(null);+ const providerList = useProviderList();+ const providers = useMemo(() => providerList.items.filter(p => p.enabled), [providerList.items]);+ // Until the user picks one, default to the first enabled provider.+ const [pickedProvider, setSelectedProvider] = useState(null);+ const selectedProvider = pickedProvider+ ?? (providers[0] ? { providerId: providers[0].id, model: providers[0].defaultModel } : null);const [showWizard, setShowWizard] = useState(false);const [traits, setTraits] = useState(null);const [confidence, setConfidence] = useState(null);const [gaps, setGaps] = useState([]);+ // A failed insights read keeps whatever loaded before and surfaces a Retry+ // instead of rendering as an empty personality map / no gaps.+ const [insightsError, setInsightsError] = useState(null);useEffect(() => {if (!showSettings) setSettingsForm(settings || {});@@ -55,19 +64,21 @@ export default function OverviewTab({ status, settings, onRefresh, onSettingsChauseEffect(() => {loadCompleteness();- loadProviders();loadTraitsAndConfidence();}, []);const loadTraitsAndConfidence = async () => {- const [traitsData, confidenceData, gapsData] = await Promise.all([- api.getDigitalTwinTraits().catch(() => ({ traits: null })),- api.getDigitalTwinConfidence().catch(() => ({ confidence: null })),- api.getDigitalTwinGaps().catch(() => ({ gaps: [] }))+ setInsightsError(null);+ const [traitsRes, confidenceRes, gapsRes] = await Promise.allSettled([+ api.getDigitalTwinTraits({ silent: true }),+ api.getDigitalTwinConfidence({ silent: true }),+ api.getDigitalTwinGaps({ silent: true })]);- setTraits(traitsData.traits);- setConfidence(confidenceData.confidence);- setGaps(gapsData.gaps || []);+ if (traitsRes.status === 'fulfilled') setTraits(traitsRes.value.traits);+ if (confidenceRes.status === 'fulfilled') setConfidence(confidenceRes.value.confidence);+ if (gapsRes.status === 'fulfilled') setGaps(gapsRes.value.gaps || []);+ const failed = [traitsRes, confidenceRes, gapsRes].find(r => r.status === 'rejected');+ if (failed) setInsightsError(failed.reason instanceof Error ? failed.reason : new Error('Request failed'));};const loadCompleteness = async () => {@@ -77,15 +88,6 @@ export default function OverviewTab({ status, settings, onRefresh, onSettingsChasetLoadingCompleteness(false);};- const loadProviders = async () => {- const data = await api.getProviders().catch(() => ({ providers: [] }));- const enabled = (data.providers || []).filter(p => p.enabled);- setProviders(enabled);- if (enabled.length > 0) {- setSelectedProvider({ providerId: enabled[0].id, model: enabled[0].defaultModel });- }- };-const checkContradictions = async () => {if (!selectedProvider) {toast.error('Select a provider first');@@ -321,6 +323,10 @@ export default function OverviewTab({ status, settings, onRefresh, onSettingsCha)}</div>+ {insightsError && (+ <ListLoadError what="personality traits, confidence and gaps" error={insightsError} onRetry={loadTraitsAndConfidence} />+ )}+{/* Personality Traits & Confidence - New Phase 1 & 2 Components */}<div className="grid grid-cols-1 lg:grid-cols-2 gap-6"><PersonalityMap@@ -435,13 +441,17 @@ export default function OverviewTab({ status, settings, onRefresh, onSettingsCha</p><div className="flex flex-col sm:flex-row items-stretch sm:items-center gap-3 sm:gap-4 mb-4">- <TwinProviderPicker- compact- className="flex-1 min-w-0"- providers={providers}- selected={selectedProvider}- onChange={setSelectedProvider}- />+ {providerList.state === 'error' ? (+ <ListLoadError className="flex-1 min-w-0" what="AI providers" error={providerList.error} onRetry={providerList.retry} />+ ) : (+ <TwinProviderPicker+ compact+ className="flex-1 min-w-0"+ providers={providers}+ selected={selectedProvider}+ onChange={setSelectedProvider}+ />+ )}<buttononClick={checkContradictions}diff --git a/client/src/components/digital-twin/tabs/OverviewTab.test.jsx b/client/src/components/digital-twin/tabs/OverviewTab.test.jsxnew file mode 100644index 0000000000..1326da8018--- /dev/null+++ b/client/src/components/digital-twin/tabs/OverviewTab.test.jsx@@ -0,0 +1,64 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen, fireEvent, waitFor } from '@testing-library/react';+import { MemoryRouter } from 'react-router';++vi.mock('../../../services/api', () => ({+ getDigitalTwinTraits: vi.fn(),+ getDigitalTwinConfidence: vi.fn(),+ getDigitalTwinGaps: vi.fn(),+ getDigitalTwinCompleteness: vi.fn(),+ getProviders: vi.fn(),+ detectSoulContradictions: vi.fn(),+ updateSoulSettings: vi.fn(),+}));+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn() } }));+vi.mock('../SoulWizard', () => ({ default: () => null }));+vi.mock('../PersonalityMap', () => ({ default: ({ traits }) => <div data-testid="map">{traits ? 'traits' : 'no-traits'}</div> }));+vi.mock('../ConfidenceGauge', () => ({ default: () => null }));+vi.mock('../GapRecommendations', () => ({ default: ({ gaps }) => <div data-testid="gaps">{gaps.length}</div> }));+vi.mock('../NextActionBanner', () => ({ default: () => null }));+vi.mock('../TwinProviderPicker.jsx', () => ({+ default: ({ providers }) => <div data-testid="picker">{providers.map((p) => p.id).join(',')}</div>,+}));++import * as api from '../../../services/api';+import OverviewTab from './OverviewTab';++const STATUS = { documentCount: 2, healthScore: 50, enabledDocuments: 2, documentsByCategory: {} };+const renderTab = () => render(+ <MemoryRouter><OverviewTab status={STATUS} settings={{}} onRefresh={() => {}} onSettingsChange={() => {}} /></MemoryRouter>+);++describe('OverviewTab failed reads', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ api.getDigitalTwinTraits.mockResolvedValue({ traits: { openness: 0.5 } });+ api.getDigitalTwinConfidence.mockResolvedValue({ confidence: { overall: 0.5 } });+ api.getDigitalTwinGaps.mockResolvedValue({ gaps: [{ dimension: 'x' }] });+ api.getDigitalTwinCompleteness.mockResolvedValue(null);+ api.getProviders.mockResolvedValue({ providers: [{ id: 'example', enabled: true }] });+ });++ it('shows an error with Retry when traits/confidence/gaps fail instead of an empty personality map', async () => {+ api.getDigitalTwinGaps.mockRejectedValueOnce(new Error('gaps offline'));+ renderTab();++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load personality traits, confidence and gaps.*gaps offline/i);+ expect(screen.queryByTestId('gaps')).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByTestId('gaps')).toHaveTextContent('1');+ expect(screen.queryByRole('alert')).toBeNull();+ });++ it('shows an error with Retry for a failed provider list instead of an empty picker', async () => {+ api.getProviders.mockRejectedValueOnce(new Error('providers down')).mockResolvedValueOnce({ providers: [{ id: 'example', enabled: true }] });+ renderTab();++ expect(await screen.findByRole('alert')).toHaveTextContent(/Could not load AI providers/i);+ expect(screen.queryByTestId('picker')).toBeNull();++ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ await waitFor(() => expect(screen.getByTestId('picker')).toHaveTextContent('example'));+ });+});diff --git a/client/src/components/digital-twin/tabs/PersonalityTab.jsx b/client/src/components/digital-twin/tabs/PersonalityTab.jsxindex 8a2947af0c..c3ab0054fb 100644--- a/client/src/components/digital-twin/tabs/PersonalityTab.jsx+++ b/client/src/components/digital-twin/tabs/PersonalityTab.jsx@@ -22,6 +22,8 @@ import { timeAgo, formatDateShort } from '../../../utils/formatters';import { filterGenerationModels } from '../../../utils/providers.js';import ProviderModelSelector from '../../ProviderModelSelector';import SettingsLoadError from '../../ui/SettingsLoadError';+import ListLoadError from '../../ui/ListLoadError';+import useProviderList from '../../../hooks/useProviderList';// Pure helpers are exported for unit tests (PersonalityTab.test.jsx).@@ -178,9 +180,11 @@ function RunDetail({ run }) {}export default function PersonalityTab() {- const [providers, setProviders] = useState([]);+ const providersResource = useProviderList();+ const providers = useMemo(() => providersResource.items.filter((p) => p.enabled), [providersResource.items]);const [history, setHistory] = useState([]);- const [loading, setLoading] = useState(true);+ const [historyLoading, setHistoryLoading] = useState(true);+ const loading = historyLoading || providersResource.state === 'loading';// Run configurationconst [selectedProviders, setSelectedProviders] = useState([]);@@ -222,15 +226,13 @@ export default function PersonalityTab() {}, []);const loadData = async () => {- setLoading(true);- const [providersData, historyData, settingsData] = await Promise.all([- api.getProviders({ silent: true }).catch(() => ({ providers: [] })),+ setHistoryLoading(true);+ const [historyData, settingsData] = await Promise.all([// No limit — fetch the full retained history (server-capped) so every// kept record is reachable for compare/delete.api.getModelPersonalityHistory(undefined, { silent: true }).catch(() => null),api.getModelPersonalitySettings({ silent: true }).catch(() => null)]);- setProviders((providersData.providers || []).filter((p) => p.enabled));setHistoryError(!Array.isArray(historyData));setSettingsError(!settingsData);if (Array.isArray(historyData)) setHistory(historyData);@@ -241,7 +243,7 @@ export default function PersonalityTab() {setScorerModel(settingsData.scorerModel || '');setHistoryCap(settingsData.historyCap ?? 200);}- setLoading(false);+ setHistoryLoading(false);};const toggleProvider = (providerId, model) => {@@ -354,7 +356,10 @@ export default function PersonalityTab() {<div className="bg-port-card rounded-lg border border-port-border p-4"><h3 className="font-semibold text-white mb-4">Select Providers & Models</h3><div className="space-y-3 max-h-64 overflow-y-auto">- {providers.length === 0 && (+ {providersResource.state === 'error' && (+ <ListLoadError what="AI providers" error={providersResource.error} onRetry={providersResource.retry} />+ )}+ {providersResource.state === 'ready' && providers.length === 0 && (<p className="text-sm text-gray-500">No enabled AI providers. Configure one in Settings → AI Providers.</p>)}{providers.map((provider) => (@@ -429,6 +434,9 @@ export default function PersonalityTab() {<div className="bg-port-card rounded-lg border border-port-border p-4 space-y-4"><h3 className="font-semibold text-white">Options</h3>{settingsError && <SettingsLoadError onRetry={loadData} />}+ {providersResource.state === 'error' && (+ <ListLoadError what="AI providers" error={providersResource.error} onRetry={providersResource.retry} />+ )}<div className="grid grid-cols-1 sm:grid-cols-2 lg:grid-cols-3 gap-4"><ProviderModelSelectorlabel="Alignment scorer provider"diff --git a/client/src/components/digital-twin/tabs/PersonalityTab.providers.test.jsx b/client/src/components/digital-twin/tabs/PersonalityTab.providers.test.jsxnew file mode 100644index 0000000000..6e9783db3c--- /dev/null+++ b/client/src/components/digital-twin/tabs/PersonalityTab.providers.test.jsx@@ -0,0 +1,46 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { MemoryRouter } from 'react-router';++const api = vi.hoisted(() => ({+ getProviders: vi.fn(),+ getModelPersonalityHistory: vi.fn(),+ getModelPersonalitySettings: vi.fn(),+}));+vi.mock('../../../services/api', () => api);+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn() } }));+vi.mock('../../../hooks/useChartColors.js', () => ({ default: () => ({}) }));++import PersonalityTab from './PersonalityTab.jsx';++beforeEach(() => {+ vi.clearAllMocks();+ api.getModelPersonalityHistory.mockResolvedValue([]);+ api.getModelPersonalitySettings.mockResolvedValue({ historyCap: 200, defaultIncludeAlignment: true });+});++describe('PersonalityTab provider list (#12783)', () => {+ it('shows a retryable error, not "No enabled AI providers", when the provider read fails', async () => {+ const user = userEvent.setup();+ api.getProviders+ .mockRejectedValueOnce(new Error('providers offline'))+ .mockResolvedValueOnce({ providers: [{ id: 'p1', name: 'Example Provider', enabled: true, models: ['alpha'], defaultModel: 'alpha' }] });+ render(<MemoryRouter><PersonalityTab /></MemoryRouter>);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load AI providers — providers offline');+ expect(screen.queryByText(/No enabled AI providers/)).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByRole('button', { name: 'alpha' })).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });++ it('keeps the "No enabled AI providers" copy for a genuinely empty list', async () => {+ api.getProviders.mockResolvedValue({ providers: [] });+ render(<MemoryRouter><PersonalityTab /></MemoryRouter>);++ expect(await screen.findByText(/No enabled AI providers/)).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });+});diff --git a/client/src/components/digital-twin/tabs/PersonasTab.jsx b/client/src/components/digital-twin/tabs/PersonasTab.jsxindex 314cc89abf..456f856f13 100644--- a/client/src/components/digital-twin/tabs/PersonasTab.jsx+++ b/client/src/components/digital-twin/tabs/PersonasTab.jsx@@ -1,8 +1,10 @@-import { useState, useEffect } from 'react';+import { useState } from 'react';import { Drama, Plus, Pencil, Trash2, Check, X, CheckCircle2, SlidersHorizontal } from 'lucide-react';import BrailleSpinner from '../../BrailleSpinner';import * as api from '../../../services/api';import toast from '../../ui/Toast';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import {describeTraitAdjustments,BIG_FIVE_LEAN,@@ -51,15 +53,26 @@ function buildAdjustmentsPayload(adj) {return Object.keys(out).length > 0 ? out : null;}+// Silent: a failed read renders <ListLoadError>, so a toast would double up.+const fetchPersonas = () => api.getDigitalTwinPersonas({ silent: true });+// The active pointer is one record or none; wrapped as a list so a failed read+// stays distinct from "no persona is active" (toggling reads this to decide+// between activating and deactivating).+const fetchActivePersona = () => api.getActiveDigitalTwinPersona({ silent: true }).then(active => (active?.id ? [active] : []));+/*** Twin Personas (M34 P7). Named context variants whose instructions are* prepended to the embodied-twin context. The active persona flavors the* context that CoS agents see; identity-building flows stay persona-free.*/export default function PersonasTab({ onRefresh }) {- const [personas, setPersonas] = useState([]);- const [activeId, setActiveId] = useState(null);- const [loading, setLoading] = useState(true);+ const personasResource = useListResource(fetchPersonas);+ const activeResource = useListResource(fetchActivePersona);+ const { items: personas, setItems: setPersonas } = personasResource;+ // `undefined` = follow the server's pointer; a local activate/deactivate/delete overrides it.+ const [activeOverride, setActiveId] = useState(undefined);+ const activeId = activeOverride !== undefined ? activeOverride : (activeResource.items[0]?.id ?? null);+ const loading = personasResource.state === 'loading' || activeResource.state === 'loading';const [busy, setBusy] = useState(false);const [showCreate, setShowCreate] = useState(false);@@ -70,21 +83,6 @@ export default function PersonasTab({ onRefresh }) {const [confirmDeleteId, setConfirmDeleteId] = useState(null);- useEffect(() => {- loadData();- }, []);-- const loadData = async () => {- setLoading(true);- const [personaData, active] = await Promise.all([- api.getDigitalTwinPersonas({ silent: true }).catch(() => []),- api.getActiveDigitalTwinPersona({ silent: true }).catch(() => null)- ]);- setPersonas(personaData);- setActiveId(active?.id ?? null);- setLoading(false);- };-const createPersona = async () => {if (!createForm.name.trim() || !createForm.instructions.trim()) {toast.error('Name and instructions are required');@@ -162,6 +160,22 @@ export default function PersonasTab({ onRefresh }) {onRefresh?.();};+ // Both reads gate the tab: an empty default for either would show "No personas+ // yet" for a failed list, or let a toggle activate an already-active persona.+ const failed = [+ { what: 'personas', resource: personasResource },+ { what: 'the active persona', resource: activeResource },+ ].filter(({ resource }) => resource.state === 'error');+ if (failed.length > 0) {+ return (+ <div className="space-y-3">+ {failed.map(({ what, resource }) => (+ <ListLoadError key={what} what={what} error={resource.error} onRetry={resource.retry} />+ ))}+ </div>+ );+ }+if (loading) {return (<div className="flex items-center justify-center h-64">diff --git a/client/src/components/digital-twin/tabs/PersonasTab.test.jsx b/client/src/components/digital-twin/tabs/PersonasTab.test.jsxnew file mode 100644index 0000000000..7fca33bffe--- /dev/null+++ b/client/src/components/digital-twin/tabs/PersonasTab.test.jsx@@ -0,0 +1,60 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';++vi.mock('../../../services/api', () => ({+ getDigitalTwinPersonas: vi.fn(),+ getActiveDigitalTwinPersona: vi.fn(),+ setActiveDigitalTwinPersona: vi.fn(),+}));+vi.mock('../../ui/Toast', () => ({ default: { success: vi.fn(), error: vi.fn() } }));++import PersonasTab from './PersonasTab';+import * as api from '../../../services/api';++const PERSONA = { id: 'persona-1', name: 'Example Persona', instructions: 'Be brief.' };++beforeEach(() => {+ vi.clearAllMocks();+ api.getDigitalTwinPersonas.mockResolvedValue([PERSONA]);+ api.getActiveDigitalTwinPersona.mockResolvedValue({ id: PERSONA.id });+ api.setActiveDigitalTwinPersona.mockResolvedValue({});+});++describe('PersonasTab failed reads stay distinct from empty ones (#12783)', () => {+ it('shows a retryable error, not "No personas yet", when the persona list fails', async () => {+ const user = userEvent.setup();+ api.getDigitalTwinPersonas.mockRejectedValueOnce(new Error('personas offline'));+ render(<PersonasTab />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load personas — personas offline');+ expect(screen.queryByText(/No personas yet/)).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /New Persona/ })).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('Example Persona')).toBeInTheDocument();+ });++ it('does not treat a failed active-pointer read as "nothing is active"', async () => {+ const user = userEvent.setup();+ api.getActiveDigitalTwinPersona.mockRejectedValueOnce(new Error('pointer offline'));+ render(<PersonasTab />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load the active persona');+ // The toggle would otherwise read activeId=null and "activate" the already-active persona.+ expect(screen.queryByText('Example Persona')).not.toBeInTheDocument();+ expect(api.setActiveDigitalTwinPersona).not.toHaveBeenCalled();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('Example Persona')).toBeInTheDocument();+ });++ it('keeps the empty copy for a genuinely empty list', async () => {+ api.getDigitalTwinPersonas.mockResolvedValue([]);+ api.getActiveDigitalTwinPersona.mockResolvedValue(null);+ render(<PersonasTab />);++ expect(await screen.findByText(/No personas yet/)).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });+});diff --git a/client/src/components/digital-twin/tabs/TasteTab.jsx b/client/src/components/digital-twin/tabs/TasteTab.jsxindex 52d360b46e..6be7367ec7 100644--- a/client/src/components/digital-twin/tabs/TasteTab.jsx+++ b/client/src/components/digital-twin/tabs/TasteTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect, useCallback } from 'react';+import { useState, useEffect, useCallback, useMemo, useRef } from 'react';import {Palette,Film,Music,@@ -25,6 +25,8 @@ import * as api from '../../../services/api';import socket from '../../../services/socket';import toast from '../../ui/Toast';import Banner from '../../ui/Banner';+import ListLoadError from '../../ui/ListLoadError';+import useProviderList from '../../../hooks/useProviderList';import MarkdownOutput from '../../cos/MarkdownOutput';import { isApiProvider } from '../../../utils/providers';import TwinProviderPicker from '../TwinProviderPicker.jsx';@@ -97,13 +99,23 @@ export default function TasteTab({ onRefresh }) {// Summary generationconst [generatingSummary, setGeneratingSummary] = useState(false);- const [providers, setProviders] = useState([]);+ const providersResource = useProviderList();+ // Taste summaries / personalized questions need a chat-completions endpoint —+ // CLI providers (Claude Code, Codex, Antigravity CLI) can't run them. Filter the+ // picker so the user can't accidentally select an incompatible default.+ const providers = useMemo(+ () => providersResource.items.filter(p => p.enabled && isApiProvider(p)),+ [providersResource.items]+ );const [selectedProvider, setSelectedProvider] = useState(null);// Review modeconst [reviewSection, setReviewSection] = useState(null);const [reviewResponses, setReviewResponses] = useState([]);const [loadingReview, setLoadingReview] = useState(false);+ const [reviewError, setReviewError] = useState(null);+ // Newest review request wins: a late answer for a section the user already left is dropped.+ const reviewRequestRef = useRef(0);// Personalized question stateconst [_personalizedQuestion, setPersonalizedQuestion] = useState(null);@@ -121,22 +133,17 @@ export default function TasteTab({ onRefresh }) {setLoading(false);}, []);- const loadProviders = useCallback(async () => {- const data = await api.getProviders().catch(() => ({ providers: [] }));- // Taste summaries / personalized questions need a chat-completions endpoint —- // CLI providers (Claude Code, Codex, Antigravity CLI) can't run them. Filter the- // picker so the user can't accidentally select an incompatible default.- const apiProviders = (data.providers || []).filter(p => p.enabled && isApiProvider(p));- setProviders(apiProviders);- if (apiProviders.length > 0) {- setSelectedProvider({ providerId: apiProviders[0].id, model: apiProviders[0].defaultModel });+ // Seed the default model once the provider list is read; a later re-read never+ // overrides a choice the user already made.+ useEffect(() => {+ if (providers.length > 0) {+ setSelectedProvider(prev => prev || { providerId: providers[0].id, model: providers[0].defaultModel });}- }, []);+ }, [providers]);useEffect(() => {loadProfile();- loadProviders();- }, [loadProfile, loadProviders]);+ }, [loadProfile]);const startSection = async (sectionId) => {setActiveSection(sectionId);@@ -240,10 +247,18 @@ export default function TasteTab({ onRefresh }) {};const handleReviewSection = async (sectionId) => {+ reviewRequestRef.current += 1;+ const request = reviewRequestRef.current;setReviewSection(sectionId);setLoadingReview(true);- const responses = await api.getTasteSectionResponses(sectionId).catch(() => []);- setReviewResponses(responses);+ setReviewError(null);+ setReviewResponses([]);+ const outcome = await api.getTasteSectionResponses(sectionId, { silent: true })+ .then(data => ({ responses: Array.isArray(data) ? data : [], error: null }))+ .catch(err => ({ responses: [], error: err instanceof Error ? err : new Error('Request failed') }));+ if (reviewRequestRef.current !== request) return;+ setReviewResponses(outcome.responses);+ setReviewError(outcome.error);setLoadingReview(false);};@@ -344,7 +359,9 @@ export default function TasteTab({ onRefresh }) {</div><div><h2 className="text-xl font-semibold text-white">{section?.label} — Responses</h2>- <p className="text-sm text-gray-400">{reviewResponses.length} responses recorded</p>+ {!loadingReview && !reviewError && (+ <p className="text-sm text-gray-400">{reviewResponses.length} responses recorded</p>+ )}</div></div></div>@@ -353,6 +370,10 @@ export default function TasteTab({ onRefresh }) {<div className="flex items-center justify-center h-48"><BrailleSpinner text="Loading" /></div>+ ) : reviewError ? (+ // A failed read must not look like "0 responses recorded", and the+ // summary / reset actions below act on responses the user never saw.+ <ListLoadError what="your responses" error={reviewError} onRetry={() => handleReviewSection(reviewSection)} />) : (<div className="space-y-4">{reviewResponses.map((r, i) => (@@ -466,7 +487,10 @@ export default function TasteTab({ onRefresh }) {<div className="text-sm"><MarkdownOutput content={section.summary} /></div></div>)}- {!selectedProvider && (+ {providersResource.state === 'error' && (+ <ListLoadError className="mb-4" what="AI providers" error={providersResource.error} onRetry={providersResource.retry} />+ )}+ {!selectedProvider && providersResource.state === 'ready' && (<Banner tone="warning" size="lg" className="mb-4">No API-based provider configured — Go Deeper and Generate Summary need one.{' '}<a href="/ai" className="underline hover:text-yellow-300">@@ -784,6 +808,9 @@ export default function TasteTab({ onRefresh }) {</p></div><div className="flex flex-col sm:flex-row items-stretch sm:items-center gap-2 w-full sm:w-auto">+ {providersResource.state === 'error' && (+ <ListLoadError what="AI providers" error={providersResource.error} onRetry={providersResource.retry} />+ )}<TwinProviderPickercompactclassName="flex-1 min-w-0"diff --git a/client/src/components/digital-twin/tabs/TasteTab.loadFailure.test.jsx b/client/src/components/digital-twin/tabs/TasteTab.loadFailure.test.jsxnew file mode 100644index 0000000000..5af2bd2d27--- /dev/null+++ b/client/src/components/digital-twin/tabs/TasteTab.loadFailure.test.jsx@@ -0,0 +1,80 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen, within } from '@testing-library/react';+import userEvent from '@testing-library/user-event';++vi.mock('../../../services/api', () => ({+ getTasteProfile: vi.fn(),+ getTasteNextQuestion: vi.fn(),+ getTasteSectionResponses: vi.fn(),+ getProviders: vi.fn(),+}));+vi.mock('../../../services/socket', () => ({ default: { connected: false, on: vi.fn(), off: vi.fn() } }));+vi.mock('../../ui/Toast', () => ({ default: Object.assign(vi.fn(), { success: vi.fn(), error: vi.fn() }) }));+vi.mock('../ObservedTasteEvidence', () => ({ default: () => null }));+vi.mock('../../cos/MarkdownOutput', () => ({ default: ({ content }) => <div>{content}</div> }));+vi.mock('../TwinProviderPicker.jsx', () => ({+ default: ({ providers }) => <div data-testid="provider-picker">{providers.map(p => p.name).join(',')}</div>,+}));++import TasteTab from './TasteTab';+import * as api from '../../../services/api';++const PROFILE = {+ completedCount: 0,+ totalSections: 1,+ sections: [{ id: 'movies', label: 'Movies', description: 'Films', status: 'in_progress', progress: { coreAnswered: 1, coreTotal: 3, percentage: 33 } }],+};+const API_PROVIDER = { id: 'p1', name: 'Example API', enabled: true, type: 'api', defaultModel: 'm1', models: ['m1'] };++beforeEach(() => {+ vi.clearAllMocks();+ api.getTasteProfile.mockResolvedValue(PROFILE);+ api.getTasteNextQuestion.mockResolvedValue(null);+ api.getProviders.mockResolvedValue({ providers: [API_PROVIDER] });+ api.getTasteSectionResponses.mockResolvedValue([{ questionText: 'Favorite film?', answer: 'Example Film' }]);+});++describe('TasteTab failed reads stay distinct from empty ones (#12783)', () => {+ it('shows a retryable error, not "0 responses", when the review read fails, and hides the actions that act on it', async () => {+ const user = userEvent.setup();+ api.getTasteSectionResponses.mockRejectedValueOnce(new Error('responses offline'));+ render(<TasteTab />);++ await user.click(await screen.findByRole('button', { name: /Review/ }));+ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load your responses — responses offline');+ expect(screen.queryByText(/responses recorded/)).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /Reset Section/ })).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /Generate Summary/ })).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('Example Film')).toBeInTheDocument();+ expect(screen.getByText('1 responses recorded')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });++ it('shows a retryable error instead of the "no API provider" banner when providers fail to load', async () => {+ const user = userEvent.setup();+ api.getProviders.mockRejectedValueOnce(new Error('providers offline'));+ render(<TasteTab />);++ await user.click(await screen.findByRole('button', { name: /Movies/ }));+ const alert = await screen.findByRole('alert');+ expect(alert).toHaveTextContent('Could not load AI providers');+ expect(screen.queryByText(/No API-based provider configured/)).not.toBeInTheDocument();++ await user.click(within(alert).getByRole('button', { name: 'Retry' }));+ await screen.findByRole('button', { name: /Go Deeper/ });+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ expect(screen.queryByText(/No API-based provider configured/)).not.toBeInTheDocument();+ });++ it('still explains a genuinely empty provider list with the banner', async () => {+ const user = userEvent.setup();+ api.getProviders.mockResolvedValue({ providers: [] });+ render(<TasteTab />);++ await user.click(await screen.findByRole('button', { name: /Movies/ }));+ expect(await screen.findByText(/No API-based provider configured/)).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });+});diff --git a/client/src/components/digital-twin/tabs/TestTab.jsx b/client/src/components/digital-twin/tabs/TestTab.jsxindex 2d04b2de79..f85033a689 100644--- a/client/src/components/digital-twin/tabs/TestTab.jsx+++ b/client/src/components/digital-twin/tabs/TestTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect, useRef } from 'react';+import { useState, useEffect, useMemo, useRef } from 'react';import {Play,CheckCircle,XCircle,@@ -22,16 +22,32 @@ import ValuesAlignmentPanel from './ValuesAlignmentPanel';import AdversarialBoundaryPanel from './AdversarialBoundaryPanel';import MultiTurnPanel from './MultiTurnPanel';import PersonaBadge from '../PersonaBadge';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';+import useProviderList from '../../../hooks/useProviderList';import { TEST_STATUS } from '../constants';import { timeAgo } from '../../../utils/formatters';const pairKey = (providerId, model) => `${providerId}:${model}`;+// Silent: each read below renders its own <ListLoadError>, so a toast would double up.+const fetchTests = () => api.getDigitalTwinTests({ silent: true });+const fetchHistory = () => api.getDigitalTwinTestHistory(5, { silent: true });+const fetchPersonas = () => api.getDigitalTwinPersonas({ silent: true });+export default function TestTab({ onRefresh }) {- const [tests, setTests] = useState([]);- const [providers, setProviders] = useState([]);- const [history, setHistory] = useState([]);- const [loading, setLoading] = useState(true);+ // Tests and providers gate the whole tab (nothing can run without them), so+ // a failed read of either is a tab-level error; history and personas are+ // optional sections with their own inline error row.+ const testsResource = useListResource(fetchTests);+ const providersResource = useProviderList();+ const historyResource = useListResource(fetchHistory);+ const personasResource = useListResource(fetchPersonas);+ const { items: tests } = testsResource;+ const { items: history } = historyResource;+ const { items: personas } = personasResource;+ const providers = useMemo(() => providersResource.items.filter(p => p.enabled), [providersResource.items]);+ const loading = testsResource.state === 'loading' || providersResource.state === 'loading';const [running, setRunning] = useState(false);// The in-flight multi-model batch: { id, order: [pairKey…], received: Map<pairKey, entry> }.// null when nothing is running, so a late/duplicate/foreign frame is dropped.@@ -41,7 +57,6 @@ export default function TestTab({ onRefresh }) {// Test configurationconst [selectedProviders, setSelectedProviders] = useState([]);const [selectedTests, setSelectedTests] = useState([]);- const [personas, setPersonas] = useState([]);const [selectedPersonaId, setSelectedPersonaId] = useState(''); // '' = base twin (no persona)// Results@@ -57,8 +72,26 @@ export default function TestTab({ onRefresh }) {const [feedbackGiven, setFeedbackGiven] = useState({}); // key: `${providerId}:${model}:${testId}` → validationconst [feedbackStats, setFeedbackStats] = useState(null);+ // Default: select all tests once the suite is read.+ useEffect(() => {+ if (testsResource.state === 'ready') setSelectedTests(testsResource.items.map(t => t.testId));+ }, [testsResource.state, testsResource.items]);++ // Drop the persona selection if it no longer exists (e.g. deleted elsewhere).+ // A falsy prev ('' = base twin) fails the .some() check and falls back to '',+ // so no extra guard is needed. Only judged against a successful read: a+ // failed or in-flight list must not clear the user's choice.+ useEffect(() => {+ if (personasResource.state !== 'ready') return;+ setSelectedPersonaId(prev => (personasResource.items.some(p => p.id === prev) ? prev : ''));+ }, [personasResource.state, personasResource.items]);+useEffect(() => {- loadData();+ let active = true;+ api.getBehavioralFeedbackStats().catch(() => null).then(fbStats => {+ if (active && fbStats) setFeedbackStats(fbStats);+ });+ return () => { active = false; };}, []);// Merge each provider/model result into the visible set as the server reports@@ -82,33 +115,6 @@ export default function TestTab({ onRefresh }) {};}, []);- const loadData = async () => {- setLoading(true);- const [testsData, providersData, historyData, fbStats, personaData] = await Promise.all([- api.getDigitalTwinTests().catch(() => []),- api.getProviders().catch(() => ({ providers: [] })),- api.getDigitalTwinTestHistory(5).catch(() => []),- api.getBehavioralFeedbackStats().catch(() => null),- api.getDigitalTwinPersonas({ silent: true }).catch(() => [])- ]);-- setTests(testsData);- const providersList = providersData.providers || [];- setProviders(providersList.filter(p => p.enabled));- setHistory(historyData);- if (fbStats) setFeedbackStats(fbStats);- setPersonas(Array.isArray(personaData) ? personaData : []);- // Drop the persona selection if it no longer exists (e.g. deleted elsewhere).- // A falsy prev ('' = base twin) fails the .some() check and falls back to '',- // so no extra guard is needed.- setSelectedPersonaId(prev => ((personaData || []).some(p => p.id === prev) ? prev : ''));-- // Default: select all tests- setSelectedTests(testsData.map(t => t.testId));-- setLoading(false);- };-const submitFeedback = async (providerId, model, testId, testName, response, validation) => {const key = `${providerId}:${model}:${testId}`;setFeedbackGiven(prev => ({ ...prev, [key]: validation }));@@ -146,7 +152,7 @@ export default function TestTab({ onRefresh }) {// catch and the values-alignment panel via the onPersonaNotFound callback.const handlePersonaNotFound = () => {setSelectedPersonaId('');- loadData();+ personasResource.retry();};const toggleTest = (testId) => {@@ -192,7 +198,7 @@ export default function TestTab({ onRefresh }) {setResults(multiResults);}- await loadData();+ historyResource.retry();toast.success('Tests completed');onRefresh();} catch (err) {@@ -254,6 +260,20 @@ export default function TestTab({ onRefresh }) {);}+ const requiredFailures = [+ { what: 'the behavioral test suite', resource: testsResource },+ { what: 'AI providers', resource: providersResource },+ ].filter(({ resource }) => resource.state === 'error');+ if (requiredFailures.length > 0) {+ return (+ <div className="space-y-3">+ {requiredFailures.map(({ what, resource }) => (+ <ListLoadError key={what} what={what} error={resource.error} onRetry={resource.retry} />+ ))}+ </div>+ );+ }+if (tests.length === 0) {return (<div className="flex flex-col items-center justify-center h-64 text-center">@@ -343,6 +363,9 @@ export default function TestTab({ onRefresh }) {</div>{/* Persona selector — run the suite as a named persona (P7) or the base twin */}+ {personasResource.state === 'error' && (+ <ListLoadError what="personas" error={personasResource.error} onRetry={personasResource.retry} />+ )}{personas.length > 0 && (<div className="bg-port-card rounded-lg border border-port-border p-4 flex flex-col sm:flex-row sm:items-center gap-2 sm:gap-3"><label htmlFor="test-persona" className="text-sm font-medium text-gray-400">@@ -653,6 +676,9 @@ export default function TestTab({ onRefresh }) {)}{/* History */}+ {historyResource.state === 'error' && (+ <ListLoadError what="recent test runs" error={historyResource.error} onRetry={historyResource.retry} />+ )}{history.length > 0 && (<div className="bg-port-card rounded-lg border border-port-border p-4"><h3 className="font-semibold text-white mb-4 flex items-center gap-2">diff --git a/client/src/components/digital-twin/tabs/TestTab.test.jsx b/client/src/components/digital-twin/tabs/TestTab.test.jsxindex dcb81c23c3..34703ee10c 100644--- a/client/src/components/digital-twin/tabs/TestTab.test.jsx+++ b/client/src/components/digital-twin/tabs/TestTab.test.jsx@@ -134,3 +134,56 @@ describe('TestTab multi-model progress (#10063)', () => {expect(api.runSoulMultiTests).not.toHaveBeenCalled();});});++describe('TestTab failed reads stay distinct from empty lists (#12783)', () => {+ it('shows a retryable error, not "No Test Suite Found", when the suite read fails', async () => {+ const user = userEvent.setup();+ api.getDigitalTwinTests.mockRejectedValueOnce(new Error('suite offline'));+ render(<TestTab onRefresh={vi.fn()} />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load the behavioral test suite — suite offline');+ expect(screen.queryByText('No Test Suite Found')).not.toBeInTheDocument();+ expect(screen.queryByRole('button', { name: /Run Selected Tests/ })).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByRole('button', { name: 'alpha' })).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });++ it('shows a retryable error instead of an empty provider picker when providers fail to load', async () => {+ const user = userEvent.setup();+ api.getProviders.mockRejectedValueOnce(new Error('providers offline'));+ render(<TestTab onRefresh={vi.fn()} />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load AI providers');+ expect(screen.queryByRole('button', { name: /Run Selected Tests/ })).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByRole('button', { name: 'alpha' })).toBeInTheDocument();+ });++ it('flags failed history and persona reads inline while the rest of the tab stays usable', async () => {+ const user = userEvent.setup();+ api.getDigitalTwinTestHistory+ .mockRejectedValueOnce(new Error('history offline'))+ .mockResolvedValueOnce([{ runId: 'r1', score: 1, passed: 1, total: 1, model: 'alpha', timestamp: new Date().toISOString() }]);+ api.getDigitalTwinPersonas+ .mockRejectedValueOnce(new Error('personas offline'))+ .mockResolvedValueOnce([{ id: 'persona-1', name: 'Alice Example' }]);+ render(<TestTab onRefresh={vi.fn()} />);++ await screen.findByRole('button', { name: 'alpha' });+ const alerts = await screen.findAllByRole('alert');+ expect(alerts.map(a => a.textContent)).toEqual([+ expect.stringContaining('Could not load personas — personas offline'),+ expect.stringContaining('Could not load recent test runs — history offline'),+ ]);+ expect(screen.queryByText('Recent Test Runs')).not.toBeInTheDocument();+ expect(screen.getByRole('button', { name: /Run Selected Tests/ })).toBeInTheDocument();++ await user.click(within(alerts[1]).getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('Recent Test Runs')).toBeInTheDocument();+ await user.click(within(alerts[0]).getByRole('button', { name: 'Retry' }));+ expect(await screen.findByRole('option', { name: 'Alice Example' })).toBeInTheDocument();+ });+});diff --git a/client/src/components/digital-twin/tabs/TimeCapsuleTab.jsx b/client/src/components/digital-twin/tabs/TimeCapsuleTab.jsxindex 7664480f4b..feb012dab0 100644--- a/client/src/components/digital-twin/tabs/TimeCapsuleTab.jsx+++ b/client/src/components/digital-twin/tabs/TimeCapsuleTab.jsx@@ -1,4 +1,4 @@-import { useState, useEffect, useCallback } from 'react';+import { useState } from 'react';import {Archive,Plus,Trash2,@@ -17,11 +17,16 @@ import * as api from '../../../services/api';import toast from '../../ui/Toast';import ConfirmButtonPair from '../../ui/ConfirmButtonPair';import FormField from '../../ui/FormField';+import ListLoadError from '../../ui/ListLoadError';+import useListResource from '../../../hooks/useListResource';import { formatBytes, formatDateTime, timeAgo } from '../../../utils/formatters';+// Silent: a failed read renders <ListLoadError>, so a toast would double up.+const fetchSnapshots = () => api.listTimeCapsuleSnapshots({ silent: true });+export default function TimeCapsuleTab({ onRefresh: _onRefresh }) {- const [snapshots, setSnapshots] = useState([]);- const [loading, setLoading] = useState(true);+ const { items: snapshots, state, error, retry, setItems: setSnapshots } = useListResource(fetchSnapshots);+ const loading = state === 'loading';const [creating, setCreating] = useState(false);// Create form@@ -42,15 +47,6 @@ export default function TimeCapsuleTab({ onRefresh: _onRefresh }) {// Delete confirmationconst [confirmDelete, setConfirmDelete] = useState(null);- const loadSnapshots = useCallback(async () => {- setLoading(true);- const data = await api.listTimeCapsuleSnapshots().catch(() => []);- setSnapshots(data);- setLoading(false);- }, []);-- useEffect(() => { loadSnapshots(); }, [loadSnapshots]);-const handleCreate = async () => {if (!label.trim()) return;setCreating(true);@@ -110,6 +106,12 @@ export default function TimeCapsuleTab({ onRefresh: _onRefresh }) {);}+ // A failed read must not read as "0 snapshots archived", and creating or+ // comparing against a list that never loaded would show a partial archive.+ if (state === 'error') {+ return <ListLoadError what="time capsule snapshots" error={error} onRetry={retry} />;+ }+return (<div className="space-y-4">{/* Header */}diff --git a/client/src/components/digital-twin/tabs/TimeCapsuleTab.test.jsx b/client/src/components/digital-twin/tabs/TimeCapsuleTab.test.jsxnew file mode 100644index 0000000000..800d0cbeb3--- /dev/null+++ b/client/src/components/digital-twin/tabs/TimeCapsuleTab.test.jsx@@ -0,0 +1,38 @@+import { describe, it, expect, vi, beforeEach } from 'vitest';+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';++vi.mock('../../../services/api', () => ({+ listTimeCapsuleSnapshots: vi.fn(),+}));++import TimeCapsuleTab from './TimeCapsuleTab';+import * as api from '../../../services/api';++beforeEach(() => vi.clearAllMocks());++describe('TimeCapsuleTab failed reads stay distinct from an empty archive (#12783)', () => {+ it('shows a retryable error, not "No snapshots yet", when the list read fails', async () => {+ const user = userEvent.setup();+ api.listTimeCapsuleSnapshots+ .mockRejectedValueOnce(new Error('archive offline'))+ .mockResolvedValueOnce([{ id: 's1', label: 'Example Snapshot', createdAt: '2026-01-01T00:00:00.000Z', sizeBytes: 10, counts: {} }]);+ render(<TimeCapsuleTab />);++ expect(await screen.findByRole('alert')).toHaveTextContent('Could not load time capsule snapshots — archive offline');+ expect(screen.queryByText('No snapshots yet')).not.toBeInTheDocument();+ expect(screen.queryByText(/snapshots? archived/)).not.toBeInTheDocument();++ await user.click(screen.getByRole('button', { name: 'Retry' }));+ expect(await screen.findByText('1 snapshot archived')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });++ it('keeps the empty copy for a genuinely empty archive', async () => {+ api.listTimeCapsuleSnapshots.mockResolvedValue([]);+ render(<TimeCapsuleTab />);++ expect(await screen.findByText('No snapshots yet')).toBeInTheDocument();+ expect(screen.queryByRole('alert')).not.toBeInTheDocument();+ });+});diff --git a/client/src/hooks/README.md b/client/src/hooks/README.mdindex 03bcac8d21..cd9b0618cc 100644--- a/client/src/hooks/README.md+++ b/client/src/hooks/README.md@@ -299,6 +299,7 @@ grep -i "what you want to do" client/src/hooks/README.md| `useImageVariants` | Fetches the original-vs-cleaned variant set for the one open image (`GET /api/image-gen/:filename/variants`), normalized; reuses the held group across toggle clicks and aborts a superseded lookup. `null` while unfetched or failed, `[]` when the image is not indexed. | `MediaPreview` calls it for every image preview; neither a page-owned ref list nor a 60-row gallery window is a complete source of variant lineage. || `useGalleryPage` | Bounded image or mixed-media browsing with debounced server search, scopes, totals, stale-response cancellation and retryable next pages. `preserveLoadedOnRefresh` reloads the retained window in compact pages while keeping existing cards mounted. | Gallery grids and pickers; `getGalleryImages` hydrates known references separately. || `useListResource` | `useListResource(fetcher, { enabled })` → `{ items, state: 'loading'\|'ready'\|'error', error, retry, setItems }` — one list read whose failure stays distinct from an empty result; a superseded response is dropped. `fetcher` must be referentially stable. | Any picker or list section fed by one list fetch (LoRA library, track library, model catalog) — render `<ListLoadError onRetry={retry}>` on `'error'` and the empty copy only on `'ready'`, never `.catch(() => [])`. |+| `useProviderList` | `useProviderList({ enabled })` → the `useListResource` shape (`{ items, state, error, retry, setItems }`) over `GET /providers`, silent so the caller owns the error UI. | Any picker or tab that needs the provider list — render `<ListLoadError what="AI providers" onRetry={retry}>` on `error`, and gate "no providers" copy on `state === 'ready'`. || `usePagedCollection` | `usePagedCollection(fetchPage, { enabled })` — bounded cursor pages, deduplication by id, single-flight loading, abort/stale-query protection, retry, reset, and local mutation via setItems; an optional `meta` returned by `fetchPage` is exposed as the latest page's response-level data. | Growing cursor-based collections; pair with `InfiniteScrollFooter`. || `useGoalOrganize` / `useGoalCreate` | Shared goal suggestion preview, explicit apply, and guarded create flows for both Goals views. | Goals List and Tree views. |diff --git a/client/src/hooks/index.js b/client/src/hooks/index.jsindex ed906e6aed..eca4e9a339 100644--- a/client/src/hooks/index.js+++ b/client/src/hooks/index.js@@ -214,6 +214,7 @@ export * from './useCooldownTick.js';export { default as useDrawerTab } from './useDrawerTab.js';export { default as useSettingsForm } from './useSettingsForm.js';export { default as useListResource } from './useListResource.js';+export { default as useProviderList } from './useProviderList.js';export { default as useDownloadPreflightConfirm } from './useDownloadPreflightConfirm.js';export { default as useChordPlayer } from './useChordPlayer.js';export { default as useDrumPlayer } from './useDrumPlayer.js';diff --git a/client/src/hooks/useProviderList.js b/client/src/hooks/useProviderList.jsnew file mode 100644index 0000000000..482c25bbf1--- /dev/null+++ b/client/src/hooks/useProviderList.js@@ -0,0 +1,15 @@+import * as api from '../services/api';+import useListResource from './useListResource.js';++// Module-level so the identity is stable for useListResource. `silent` because+// every consumer renders its own <ListLoadError> instead of the global toast.+const fetchProviders = () => api.getProviders({ silent: true }).then((data) => data?.providers ?? []);++/**+ * The AI provider list as a `useListResource` read: a failed `GET /providers`+ * is `state: 'error'` (render `<ListLoadError onRetry={retry}>`), never an+ * empty picker that looks like "no providers configured".+ */+export default function useProviderList({ enabled = true } = {}) {+ return useListResource(fetchProviders, { enabled });+}diff --git a/client/src/listFetchConventions.test.js b/client/src/listFetchConventions.test.jsindex 29d541f55f..92991825cc 100644--- a/client/src/listFetchConventions.test.js+++ b/client/src/listFetchConventions.test.js@@ -62,20 +62,6 @@ const KNOWN = Object.freeze({'src/components/brain/tabs/DailyLogTab.jsx': 1,'src/components/brain/tabs/FeedsTab.jsx': 1,'src/components/brain/tabs/TrustTab.jsx': 1,- 'src/components/digital-twin/ObservedTasteEvidence.jsx': 1,- 'src/components/digital-twin/tabs/AccountsTab.jsx': 3,- 'src/components/digital-twin/tabs/AutobiographyTab.jsx': 3,- 'src/components/digital-twin/tabs/DocumentsTab.jsx': 1,- 'src/components/digital-twin/tabs/EnrichTab.jsx': 1,- 'src/components/digital-twin/tabs/ExportTab.jsx': 2,- 'src/components/digital-twin/tabs/ImportTab.jsx': 2,- 'src/components/digital-twin/tabs/InterviewTab.jsx': 1,- 'src/components/digital-twin/tabs/OverviewTab.jsx': 2,- 'src/components/digital-twin/tabs/PersonalityTab.jsx': 1,- 'src/components/digital-twin/tabs/PersonasTab.jsx': 1,- 'src/components/digital-twin/tabs/TasteTab.jsx': 2,- 'src/components/digital-twin/tabs/TestTab.jsx': 4,- 'src/components/digital-twin/tabs/TimeCapsuleTab.jsx': 1,'src/components/meatspace/EpigeneticTracker.jsx': 1,'src/components/meatspace/HealthCategorySection.jsx': 1,'src/components/meatspace/post/PostSessionLauncher.jsx': 2,diff --git a/client/src/services/apiDigitalTwin.js b/client/src/services/apiDigitalTwin.jsindex 07b110dbe4..12b8413cca 100644--- a/client/src/services/apiDigitalTwin.js+++ b/client/src/services/apiDigitalTwin.js@@ -19,7 +19,7 @@ export const updateDigitalTwinDocument = (id, data, options = {}) => request(`/dconst deleteDigitalTwinDocument = (id) => request(`/digital-twin/documents/${id}`, { method: 'DELETE' });// Digital Twin - Testing-export const getDigitalTwinTests = () => request('/digital-twin/tests');+export const getDigitalTwinTests = (options) => request('/digital-twin/tests', options);const runDigitalTwinTests = (providerId, model, testIds = null, personaId = null) => request('/digital-twin/tests/run', {method: 'POST',body: JSON.stringify({ providerId, model, testIds, personaId })@@ -28,7 +28,7 @@ const runDigitalTwinMultiTests = (providers, testIds = null, personaId = null, rmethod: 'POST',body: JSON.stringify({ providers, testIds, personaId, requestId })});-export const getDigitalTwinTestHistory = (limit = 10) => request(`/digital-twin/tests/history?limit=${limit}`);+export const getDigitalTwinTestHistory = (limit = 10, options) => request(`/digital-twin/tests/history?limit=${limit}`, options);// Digital Twin - Values-Alignment Testing (M34 P6)export const getValuesAlignmentTests = (options = {}) => request('/digital-twin/values-tests', options);@@ -68,7 +68,7 @@ const submitDigitalTwinEnrichAnswer = (data, options = {}) => request('/digital-});// Digital Twin - Export-export const getDigitalTwinExportFormats = () => request('/digital-twin/export/formats');+export const getDigitalTwinExportFormats = (options = {}) => request('/digital-twin/export/formats', options);const exportDigitalTwin = (format, documentIds = null, includeDisabled = false) => request('/digital-twin/export', {method: 'POST',body: JSON.stringify({ format, documentIds, includeDisabled })@@ -173,7 +173,7 @@ export const saveEnrichmentList = (category, content, items, options = {}) => reexport const getEnrichmentListItems = (category, options) => request(`/digital-twin/enrich/list-items/${category}`, options);// Digital Twin Traits & Confidence-export const getDigitalTwinTraits = () => request('/digital-twin/traits');+export const getDigitalTwinTraits = (options) => request('/digital-twin/traits', options);export const analyzeDigitalTwinTraits = (providerId, model, forceReanalyze = false, options = {}) => request('/digital-twin/traits/analyze', {method: 'POST',body: JSON.stringify({ providerId, model, forceReanalyze }),@@ -184,16 +184,16 @@ export const updateDigitalTwinTraits = (updates, options = {}) => request('/digibody: JSON.stringify(updates),...options});-export const getDigitalTwinConfidence = () => request('/digital-twin/confidence');+export const getDigitalTwinConfidence = (options) => request('/digital-twin/confidence', options);export const calculateDigitalTwinConfidence = (providerId, model, options = {}) => request('/digital-twin/confidence/calculate', {method: 'POST',body: JSON.stringify({ providerId, model }),...options});-export const getDigitalTwinGaps = () => request('/digital-twin/gaps');+export const getDigitalTwinGaps = (options) => request('/digital-twin/gaps', options);// Digital Twin External Import-export const getDigitalTwinImportSources = () => request('/digital-twin/import/sources');+export const getDigitalTwinImportSources = (options = {}) => request('/digital-twin/import/sources', options);export const openDigitalTwinSpotifyBrowser = (options = {}) => request('/digital-twin/import/spotify/browser/open', {method: 'POST',...options@@ -230,7 +230,7 @@ export const submitTasteAnswer = (section, questionId, answer, meta = {}, optionbody: JSON.stringify({ section, questionId, answer, ...meta }),...options});-export const getTasteSectionResponses = (section) => request(`/digital-twin/taste/${section}/responses`);+export const getTasteSectionResponses = (section, options) => request(`/digital-twin/taste/${section}/responses`, options);export const generateTasteSummary = (providerId, model, section) => request('/digital-twin/taste/summary', {method: 'POST',body: JSON.stringify({ providerId, model, ...(section ? { section } : {}) })@@ -253,14 +253,14 @@ export const updateAutobiographyConfig = (config, options = {}) => request('/digbody: JSON.stringify(config),...options});-export const getAutobiographyThemes = () => request('/digital-twin/autobiography/themes');+export const getAutobiographyThemes = (options = {}) => request('/digital-twin/autobiography/themes', options);export const getAutobiographyPrompt = (exclude, options = {}) =>request(`/digital-twin/autobiography/prompt${exclude ? `?exclude=${exclude}` : ''}`, options);export const getAutobiographyPromptById = (id) => request(`/digital-twin/autobiography/prompt/${id}`);export const getAutobiographySuggestions = (options = {}) =>request('/digital-twin/autobiography/suggestions', options);-export const getAutobiographyStories = (theme = null) =>- request(`/digital-twin/autobiography/stories${theme ? `?theme=${theme}` : ''}`);+export const getAutobiographyStories = (theme = null, options = {}) =>+ request(`/digital-twin/autobiography/stories${theme ? `?theme=${theme}` : ''}`, options);export const saveAutobiographyStory = (promptId, content, { parentStoryId, customPromptText } = {}, options = {}) =>request('/digital-twin/autobiography/stories', {method: 'POST',@@ -303,11 +303,11 @@ export const analyzeAssessment = (content, providerId, model, options = {}) =>});// Digital Twin - Social Accounts-export const getSocialAccounts = (params = {}) => {+export const getSocialAccounts = (params = {}, options = {}) => {const qs = new URLSearchParams(params).toString();- return request(`/digital-twin/social-accounts${qs ? `?${qs}` : ''}`);+ return request(`/digital-twin/social-accounts${qs ? `?${qs}` : ''}`, options);};-export const getSocialAccountPlatforms = () => request('/digital-twin/social-accounts/platforms');+export const getSocialAccountPlatforms = (options = {}) => request('/digital-twin/social-accounts/platforms', options);export const getSocialAccountStats = () => request('/digital-twin/social-accounts/stats');export const createSocialAccount = (data) => request('/digital-twin/social-accounts', {method: 'POST',@@ -322,7 +322,7 @@ export const deleteSocialAccount = (id) => request(`/digital-twin/social-account});// Digital Twin - Time Capsule Snapshots-export const listTimeCapsuleSnapshots = () => request('/digital-twin/snapshots');+export const listTimeCapsuleSnapshots = (options) => request('/digital-twin/snapshots', options);export const createTimeCapsuleSnapshot = (label, description = '') => request('/digital-twin/snapshots', {method: 'POST',body: JSON.stringify({ label, description })