Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
ci: skip every test job for quality-snapshot-only pull requests
Claude611975dfdf34
diff --git a/docs/GITHUB_ACTIONS.md b/docs/GITHUB_ACTIONS.mdindex d0e60ea31c..4575d24f23 100644--- a/docs/GITHUB_ACTIONS.md+++ b/docs/GITHUB_ACTIONS.md@@ -126,7 +126,10 @@ grant one.An always-run list (`ALWAYS_RUN_TESTS` in the planner) is added to every plan,so no impact scope can drop it. A documentation-only PR therefore still runs the-server job with those files selected. Two kinds of test qualify:+server job with those files selected. The one exception is a PR that changes+only generated data no code or test reads (`GENERATED_DATA_RULES`: the repo-root+`.quality.json` that `npm run quality:snapshot` publishes): it skips every job,+and `CI Gate` passes once the impact job's diff scan does. Two kinds of test qualify:- **Cross-install contract snapshots** — `server/services/taskPromptDefaults.test.js`pins the prompt-upgrade contract, and nothing else in the suite notices whendiff --git a/scripts/ci-test-plan.js b/scripts/ci-test-plan.jsindex a59a270b8a..cecf01a93f 100644--- a/scripts/ci-test-plan.js+++ b/scripts/ci-test-plan.js@@ -537,6 +537,15 @@ const DOCUMENTATION_RULES = [/\.(?:md|mdx|png|jpe?g|gif|webp|svg|ico)$/i,];+// Generated data no code or test reads from this checkout: the repo-root+// `.quality.json` is the numeric snapshot `appQualitySnapshotFile.js` lands+// through its own immediately-merged PR. A PR touching only these skips every+// runner, the always-run guards included — there is nothing for them to check.+// The hidden-content diff scan in the impact job still reads it.+const GENERATED_DATA_RULES = [+ /^\.quality\.json$/,+];+// Text snapshots are executable test inputs, but their extension is deliberately// outside EXECUTABLE_RE. Keep this mapping explicit rather than treating every// `.txt` file as a test fixture: an unmapped text artifact must still widen CI.@@ -766,6 +775,7 @@ const isPythonScript = (path) => PYTHON_SCRIPT_RE.test(path);const isExecutable = (path) => EXECUTABLE_RE.test(path) || isPythonScript(path);// A documentation directory can also contain runnable contracts and helpers.const isDocumentationOnly = (path) => !isExecutable(path) && DOCUMENTATION_RULES.some((rule) => rule.test(path));+const isGeneratedData = (path) => GENERATED_DATA_RULES.some((rule) => rule.test(path));const isServerRunnerFile = (path) => RUNNER_ROOTS.server.some((root) => path.startsWith(root));const isClientRunnerFile = (path) => RUNNER_ROOTS.client.some((root) => path.startsWith(root));@@ -1125,14 +1135,17 @@ function buildSuitePlan(changedFiles, {});}- const alwaysRun = alwaysRunTests(trackedSet);+ const dataOnly = changed.length > 0 && changed.every(isGeneratedData);+ const alwaysRun = dataOnly ? [] : alwaysRunTests(trackedSet);- const relevant = changed.filter((path) => !isDocumentationOnly(path));+ const relevant = changed.filter((path) => !isDocumentationOnly(path) && !isGeneratedData(path));if (relevant.length === 0) {const { server: alwaysRunServer, client: alwaysRunClient } = splitByRunner(alwaysRun);+ const reason = dataOnly ? 'generated data-only change'+ : changed.length ? 'documentation-only change' : 'no changed files';const plan = {full: false,- reason: changed.length ? 'documentation-only change' : 'no changed files',+ reason,changedFiles: changed,server: alwaysRunServer.length > 0 ? { mode: 'files', files: alwaysRunServer, sources: [] } : skippedRunner(),client: alwaysRunClient.length > 0 ? { mode: 'files', files: alwaysRunClient, sources: [] } : skippedRunner(),diff --git a/scripts/ci-test-plan.test.js b/scripts/ci-test-plan.test.jsindex 4b8b600852..6670a7135e 100644--- a/scripts/ci-test-plan.test.js+++ b/scripts/ci-test-plan.test.js@@ -523,6 +523,35 @@ describe('CI test impact planner', () => {});});+ // Quality snapshot PRs land through the publisher's immediate merge; their+ // diff is one numeric data file nothing reads from the checkout.+ it('skips every job, always-run guards included, for a quality-snapshot-only change', () => {+ const plan = buildCiTestPlan(['.quality.json'], { trackedFiles: [...TRACKED, '.quality.json'] });++ expect(plan).toMatchObject({+ full: false,+ reason: 'generated data-only change',+ server: { mode: 'skip' },+ client: { mode: 'skip' },+ browserFiles: [],+ db: false,+ lint: { mode: 'skip' },+ build: false,+ smoke: false,+ windows: false,+ });+ });++ it('keeps the always-run guards when the quality snapshot rides with other changes', () => {+ const docs = buildCiTestPlan(['.quality.json', 'docs/GITHUB_ACTIONS.md'], { trackedFiles: [...TRACKED, '.quality.json'] });+ expect(docs).toMatchObject({ reason: 'documentation-only change', server: { mode: 'files' } });+ expect(docs.server.files).toContain('server/services/taskPromptDefaults.test.js');++ const code = buildCiTestPlan(['.quality.json', 'server/services/auth.js'], { trackedFiles: [...TRACKED, '.quality.json'] });+ expect(code.reason).not.toMatch(/unmapped executable surface/);+ expect(code.server.mode).not.toBe('skip');+ });+// The prompt-integrity snapshot guards a cross-install upgrade contract that// no other test covers, so no impact scope may drop it — including the scopes// that otherwise skip the server runner entirely.