Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: bound model cleanup messages to observed residency (#10729)
Adam Eivy63f06392c594
diff --git a/client/src/components/settings/MemoryManagement.jsx b/client/src/components/settings/MemoryManagement.jsxindex 5dab2f65d4..5557b28cea 100644--- a/client/src/components/settings/MemoryManagement.jsx+++ b/client/src/components/settings/MemoryManagement.jsx@@ -78,7 +78,7 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {const [lastFetched, setLastFetched] = useState(0);const [unavailableSources, setUnavailableSources] = useState([]);// Backends the user marked intentionally disabled stay in unavailableSources- // (so "Free everything" still skips their unknown residency) but are excluded+ // (so "Unload listed resources" still skips their unknown residency) but are excluded// from the "Status unavailable" banner — the nag the user opted out of.const [disabledSources, setDisabledSources] = useState([]);// Guards asynchronous setState calls — a late /voice/status response that@@ -97,7 +97,7 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {// the prior snapshot.const refresh = useCallback(async (options = {}) => {const priority = options?.priority === true;- // "Free everything" needs one authoritative pre-action snapshot. Do not+ // "Unload listed resources" needs one authoritative pre-action snapshot. Do not// let a socket event start a newer read while that priority refresh is in// flight, or the caller would have to act on an older last-known snapshot.if (!priority && priorityRefreshRef.current) return snapshotRef.current;@@ -217,9 +217,9 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {const failed = results.filter((r) => r.status === 'rejected').length;if (fresh.unavailableSources.length > 0) {const labels = fresh.unavailableSources.map((source) => SOURCE_LABELS[source] || source).join(', ');- toast.error(`Freed verified resources only — could not verify ${labels}`);- } else if (failed) toast.error(`Freed most resources — ${failed} action(s) failed`);- else toast.success('Freed all memory-resident models');+ toast.error(`Could not check ${labels}. Cleanup skipped those sources; check the refreshed residency list.`);+ } else if (failed) toast.error(`${failed} cleanup ${failed === 1 ? 'action' : 'actions'} failed. Check the refreshed residency list before starting a large render.`);+ else toast.success('Cleanup requests completed for the listed models and voice services.');await refresh();});@@ -251,6 +251,9 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {<div className="text-xs text-gray-500">Free unified memory before running large diffusion / video models</div>+ <div className="text-xs text-gray-500">+ This panel checks Ollama, LM Studio, Whisper and Kokoro only. Other runtimes and system memory are not measured.+ </div></div><div className="flex items-center gap-2"><button@@ -270,7 +273,7 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {className={`${btnClass} text-port-warning border border-port-warning/50 hover:bg-port-warning/10`}><Trash2 className="w-3 h-3" />- Free everything+ Unload listed resources</button></div></div>@@ -280,7 +283,7 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {<AlertTriangle className="mt-0.5 h-3 w-3 shrink-0" /><span>Status unavailable for {bannerSources.map((source) => SOURCE_LABELS[source] || source).join(', ')}.- Last known values remain visible; unknown resources are excluded from Free everything.+ Last known values remain visible; unknown resources are excluded from Unload listed resources.</span></div>)}@@ -288,7 +291,7 @@ export default function MemoryManagement({ onLoadedModelsChange } = {}) {{loadedOllama.length === 0 && loadedLmStudio.length === 0&& !whisperRunning && ttsState.state === 'lazy' && unavailableSources.length === 0 ? (<div className="px-3 py-3 text-xs text-gray-500 italic">- Nothing memory-resident — full unified memory is available for diffusion.+ No models or voice services monitored by this panel are reported as loaded. This does not measure free system memory.</div>) : (<div>diff --git a/client/src/components/settings/MemoryManagement.test.jsx b/client/src/components/settings/MemoryManagement.test.jsxindex c570e88afd..baaea0b728 100644--- a/client/src/components/settings/MemoryManagement.test.jsx+++ b/client/src/components/settings/MemoryManagement.test.jsx@@ -58,14 +58,36 @@ describe('MemoryManagement', () => {getLoadedLlmModels.mockRejectedValueOnce(new Error('LLM status failed'));getTtsStatus.mockRejectedValueOnce(new Error('TTS status failed'));getVoiceStatus.mockRejectedValueOnce(new Error('voice status failed'));- fireEvent.click(screen.getByRole('button', { name: 'Free everything' }));+ fireEvent.click(screen.getByRole('button', { name: 'Unload listed resources' }));- await waitFor(() => expect(toast.error).toHaveBeenCalledWith(expect.stringContaining('could not verify')));+ await waitFor(() => expect(toast.error).toHaveBeenCalledWith(expect.stringContaining('Cleanup skipped those sources')));expect(unloadLmStudioModel).not.toHaveBeenCalled();- expect(toast.success).not.toHaveBeenCalledWith('Freed all memory-resident models');+ expect(toast.success).not.toHaveBeenCalled();expect(screen.queryByText(/full unified memory is available/i)).not.toBeInTheDocument();});+ it('does not claim free system memory for a successful empty observation', async () => {+ getLoadedLlmModels.mockResolvedValue({ ollama: [], lmstudio: [] });+ render(<MemoryManagement />);++ expect(await screen.findByText(/does not measure free system memory/i)).toBeInTheDocument();+ expect(screen.getByText(/Ollama, LM Studio, Whisper and Kokoro only/)).toBeInTheDocument();+ expect(screen.queryByText(/full unified memory/i)).not.toBeInTheDocument();+ });++ it('reports failure, not partial success, when the only real unload fails', async () => {+ unloadLmStudioModel.mockRejectedValue(new Error('unload failed'));+ render(<MemoryManagement />);+ expect(await screen.findByText('example/lmstudio-model')).toBeInTheDocument();+ fireEvent.click(screen.getByRole('button', { name: 'Unload listed resources' }));++ await waitFor(() => expect(toast.error).toHaveBeenCalledWith(+ '1 cleanup action failed. Check the refreshed residency list before starting a large render.',+ ));+ expect(toast.error).not.toHaveBeenCalledWith(expect.stringContaining('most resources'));+ expect(toast.success).not.toHaveBeenCalled();+ });+it('ignores an older refresh that resolves after a newer snapshot', async () => {render(<MemoryManagement />);expect(await screen.findByText('example/lmstudio-model')).toBeInTheDocument();@@ -117,7 +139,7 @@ describe('MemoryManagement', () => {// Wait for the first refresh to clear the loading state so the poll result// is the thing under test, not the pre-poll empty render.- expect(await screen.findByRole('button', { name: 'Free everything' })).toBeInTheDocument();+ expect(await screen.findByRole('button', { name: 'Unload listed resources' })).toBeInTheDocument();// The banned nag is suppressed for the disabled backend, even though its// residency is unknown.expect(screen.queryByText(/Status unavailable for LM Studio/i)).not.toBeInTheDocument();@@ -174,7 +196,7 @@ describe('MemoryManagement', () => {render(<MemoryManagement />);// First (good) poll: lmstudio is known-disabled, so the banner is silent even// though its residency error would otherwise show.- expect(await screen.findByRole('button', { name: 'Free everything' })).toBeInTheDocument();+ expect(await screen.findByRole('button', { name: 'Unload listed resources' })).toBeInTheDocument();expect(screen.queryByText(/Status unavailable for/i)).not.toBeInTheDocument();// A later FAILED poll re-adds both backends to unavailableSources, but the// still-known-disabled lmstudio must stay excluded from the banner (ollama,@@ -182,6 +204,6 @@ describe('MemoryManagement', () => {fireEvent.click(screen.getByRole('button', { name: 'Refresh' }));await waitFor(() => expect(getLoadedLlmModels).toHaveBeenCalledTimes(2));expect(screen.getByText(/Status unavailable for Ollama/i)).toBeInTheDocument();- expect(screen.queryByText(/LM Studio/i)).not.toBeInTheDocument();+ expect(screen.queryByText(/Status unavailable for LM Studio/i)).not.toBeInTheDocument();});});