Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: Writers Room names a missing or failed work instead of 'No work selected' (#13003)
[._.]/ Adam Eivy6b6d5cde36fb
diff --git a/client/src/pages/WritersRoom.jsx b/client/src/pages/WritersRoom.jsxindex 8ab1f362c1..8c67f22986 100644--- a/client/src/pages/WritersRoom.jsx+++ b/client/src/pages/WritersRoom.jsx@@ -17,6 +17,7 @@ import { usePagedCollection } from '../hooks/usePagedCollection';import useListResource from '../hooks/useListResource';import useMounted from '../hooks/useMounted';import ListLoadError from '../components/ui/ListLoadError';+import LoadFailedState from '../components/ui/LoadFailedState';const LIBRARY_COLLAPSED_KEY = 'wr.libraryCollapsed';@@ -33,6 +34,8 @@ export default function WritersRoom() {const [activeWork, setActiveWork] = useState(null);const [creatingWork, setCreatingWork] = useState(null);const [loadingWork, setLoadingWork] = useState(false);+ const [workError, setWorkError] = useState(null);+ const [retryNonce, setRetryNonce] = useState(0);const [showExercise, setShowExercise] = useState(false);const [editorDirty, setEditorDirty] = useState(false);const [draftMutation, setDraftMutation] = useState(null);@@ -78,18 +81,19 @@ export default function WritersRoom() {// Load the active work when the URL changesuseEffect(() => {+ setWorkError(null);if (!workId) {setActiveWork(null);return;}let cancelled = false;setLoadingWork(true);- getWritersRoomWork(workId)+ getWritersRoomWork(workId, { silent: true }).then((work) => { if (!cancelled) setActiveWork(work); })- .catch(() => { if (!cancelled) setActiveWork(null); })+ .catch((err) => { if (!cancelled) { setActiveWork(null); setWorkError(err); } }).finally(() => { if (!cancelled) setLoadingWork(false); });return () => { cancelled = true; };- }, [workId]);+ }, [workId, retryNonce]);const selectWork = (id) => {if (!id) {@@ -238,7 +242,26 @@ export default function WritersRoom() {<section aria-label="Work editor" className="min-h-0 flex flex-col flex-1">{loadingWork && <div className="p-6 text-sm text-gray-500">Loading work…</div>}- {!loadingWork && !activeWork && (+ {!loadingWork && !activeWork && workError && (+ <div className="flex-1 flex items-center justify-center p-8">+ {workError.status === 404 || workError.status === 400 ? (+ <EmptyState+ icon={NotebookPen}+ title="This work no longer exists"+ message="The link may be stale or the work was deleted."+ actionLabel="Back to library"+ onAction={() => selectWork(null)}+ />+ ) : (+ <LoadFailedState+ title="Couldn't open this work"+ hint={workError.message}+ onRetry={() => setRetryNonce((n) => n + 1)}+ />+ )}+ </div>+ )}+ {!loadingWork && !activeWork && !workError && !workId && (<div className="flex-1 flex items-center justify-center p-8"><EmptyStateicon={NotebookPen}diff --git a/client/src/pages/WritersRoom.test.jsx b/client/src/pages/WritersRoom.test.jsxindex 74140bd3f6..f7e4b0468a 100644--- a/client/src/pages/WritersRoom.test.jsx+++ b/client/src/pages/WritersRoom.test.jsx@@ -11,7 +11,7 @@ vi.mock('../services/apiWritersRoom', async (importOriginal) => ({}));import WritersRoom from './WritersRoom';-import { listWritersRoomFolders, listWritersRoomWorks } from '../services/apiWritersRoom';+import { listWritersRoomFolders, listWritersRoomWorks, getWritersRoomWork } from '../services/apiWritersRoom';describe('WritersRoom empty state', () => {it('shows a retriable error when the folder list fails to load', async () => {@@ -70,3 +70,34 @@ it('loads 50 works, appends on demand, and restarts an expired snapshot', asyncexpect(screen.queryByText('First work')).toBeNull();expect(listWritersRoomWorks).toHaveBeenLastCalledWith({ limit: 50, cursor: null }, expect.anything());});++describe('WritersRoom open work failures', () => {+ const renderAt = (path) => render(+ <MemoryRouter initialEntries={[path]}>+ <Routes>+ <Route path="/writers-room" element={<WritersRoom />} />+ <Route path="/writers-room/works/:workId" element={<WritersRoom />} />+ </Routes>+ </MemoryRouter>,+ );++ it('shows a not-found panel for a missing work and returns to the library', async () => {+ getWritersRoomWork.mockRejectedValueOnce(Object.assign(new Error('Invalid work id'), { status: 400 }));+ renderAt('/writers-room/works/gone');+ expect(await screen.findByText('This work no longer exists')).toBeInTheDocument();+ expect(screen.queryByText('No work selected')).toBeNull();+ fireEvent.click(screen.getByRole('button', { name: 'Back to library' }));+ expect(await screen.findByText('No work selected')).toBeInTheDocument();+ });++ it('offers Retry after a failed read and opens the work once it recovers', async () => {+ getWritersRoomWork+ .mockRejectedValueOnce(Object.assign(new Error('offline'), { status: 503 }))+ .mockResolvedValueOnce({ id: 'w1', title: 'Recovered', drafts: [], activeDraftVersionId: null });+ renderAt('/writers-room/works/w1');+ expect(await screen.findByText("Couldn't open this work")).toBeInTheDocument();+ fireEvent.click(screen.getByRole('button', { name: 'Retry' }));+ await waitFor(() => expect(screen.queryByText("Couldn't open this work")).toBeNull());+ expect(getWritersRoomWork).toHaveBeenCalledTimes(2);+ });+});diff --git a/client/src/services/apiWritersRoom.js b/client/src/services/apiWritersRoom.jsindex 341cb128b5..47f82efc8c 100644--- a/client/src/services/apiWritersRoom.js+++ b/client/src/services/apiWritersRoom.js@@ -25,7 +25,7 @@ export const createWritersRoomWork = (data, options = {}) => request('/writers-rbody: JSON.stringify(data),...options,});-export const getWritersRoomWork = (id) => request(`/writers-room/works/${enc(id)}`);+export const getWritersRoomWork = (id, options = {}) => request(`/writers-room/works/${enc(id)}`, options);export const updateWritersRoomWork = (id, patch, options = {}) => request(`/writers-room/works/${enc(id)}`, {method: 'PATCH',body: JSON.stringify(patch),