Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: let test workers close before checking for leaked processes (#12143)

Adam Eivy6bd01e4dd8cf
diff --git a/scripts/lib/vitestStaleRunRoots.js b/scripts/lib/vitestStaleRunRoots.js
index d6ab780a4f..8153a31f05 100644
--- a/scripts/lib/vitestStaleRunRoots.js
+++ b/scripts/lib/vitestStaleRunRoots.js
@@ -102,6 +102,21 @@ function rootIsOrphaned(root, probe, now) {
} catch (error) { return error.code === 'ENOENT'; }
}
+// Only fixed categories leave the private process snapshot; never argv or env.
+function processKind({ args = [] }) {
+ const executable = basename(args[0] ?? '').toLowerCase();
+ if (executable === 'esbuild') return 'esbuild';
+ if (/^(node|nodejs)(\.exe)?$/.test(executable)) {
+ if (args.some(arg => /[/\\]tinypool[/\\]/.test(arg))) return 'tinypool';
+ if (args.some(arg => /[/\\]vitest[/\\]/.test(arg))) return 'vitest';
+ return 'node';
+ }
+ if (/^(chrome|chromium|google chrome|google chrome helper)(\.exe)?$/.test(executable)) return 'browser';
+ if (/^(sh|bash|zsh)$/.test(executable)) return 'shell';
+ if (/^python[0-9.]*$/.test(executable)) return 'python';
+ return 'other';
+}
+
function ownedSnapshot(parent, prefix, read) {
const records = read();
if (!Array.isArray(records)) return null;
@@ -110,7 +125,7 @@ function ownedSnapshot(parent, prefix, read) {
const owned = records.flatMap(record => {
if (!Number.isSafeInteger(record.pid) || record.pid <= 1 || typeof record.start !== 'string' || !record.start) return [];
const root = testProcessRoot(record, parent, prefix);
- return root && !ancestors.has(record.pid) ? [{ pid: record.pid, start: record.start, root }] : [];
+ return root && !ancestors.has(record.pid) ? [{ pid: record.pid, start: record.start, root, kind: processKind(record), parent: ancestors.has(record.ppid) ? 'runner' : 'descendant' }] : [];
});
return { ancestors, owned };
}
@@ -135,7 +150,7 @@ export function terminatePid(record, { valid, kill = (pid, signal) => process.ki
/** Only individually proven processes are signalled; an unowned group member is never collateral cleanup. */
export function killTestProcessesUnder(root, { read = readTestProcesses, probe = isOwnerAlive,
- kill = (pid, signal) => process.kill(pid, signal) } = {}) {
+ kill = (pid, signal) => process.kill(pid, signal), onKilled = () => {} } = {}) {
let rootExists = true;
try { if (!lstatSync(root).isDirectory()) return 0; } catch (error) {
if (error.code !== 'ENOENT') return 0;
@@ -156,7 +171,8 @@ export function killTestProcessesUnder(root, { read = readTestProcesses, probe =
let killed = 0;
for (const record of snapshot.owned) {
if (record.root !== root || !stillOwned(record, snapshot, parent, prefix, read)) continue;
- try { kill(record.pid, 'SIGKILL'); killed++; } catch { /* already gone */ }
+ try { kill(record.pid, 'SIGKILL'); killed++; } catch { continue; /* already gone */ }
+ onKilled({ kind: record.kind, parent: record.parent });
}
return killed;
}
diff --git a/scripts/testOwnedProcessRecovery.test.js b/scripts/testOwnedProcessRecovery.test.js
index 9a0a6bf2b9..6feffa64e6 100644
--- a/scripts/testOwnedProcessRecovery.test.js
+++ b/scripts/testOwnedProcessRecovery.test.js
@@ -66,6 +66,28 @@ describe('test process ownership boundaries', () => {
expect(testProcessRoot({ args: ['chrome', `--user-data-dir=${root}/profile`] }, parent, 'pvt-')).toBe(root);
});
+ it('reports only fixed process categories for successfully stopped owned children', () => {
+ const host = mkdtempSync(join(tmpdir(), 'recovery-diagnostics-'));
+ const root = join(host, 'pvt-owned');
+ mkdirSync(root);
+ writeFileSync(join(root, '.owner.pid'), '999999 0\n');
+ const ancestors = [{ pid: process.pid, ppid: process.ppid }, { pid: process.ppid, ppid: 1 }];
+ const child = { pid: 900001, ppid: process.pid, start: 'original',
+ args: ['/example/node', '/example/vitest/dist/workers/forks.js', '--secret=fixture-secret'],
+ env: { NODE_ENV: 'test', PORTOS_TEST_TEMP_ROOT: root } };
+ const onKilled = vi.fn();
+ const kill = vi.fn();
+ try {
+ expect(killTestProcessesUnder(root, { read: () => [...ancestors, child], probe: () => false, kill, onKilled })).toBe(1);
+ expect(kill).toHaveBeenCalledExactlyOnceWith(child.pid, 'SIGKILL');
+ expect(onKilled).toHaveBeenCalledExactlyOnceWith({ kind: 'vitest', parent: 'runner' });
+ kill.mockImplementation(() => { throw Error('already gone'); });
+ onKilled.mockClear();
+ expect(killTestProcessesUnder(root, { read: () => [...ancestors, child], probe: () => false, kill, onKilled })).toBe(0);
+ expect(onKilled).not.toHaveBeenCalled();
+ } finally { rmSync(host, { recursive: true, force: true }); }
+ });
+
it('refuses reused identities, caller ancestors and ownership changes before delayed escalation', () => {
vi.useFakeTimers();
const host = mkdtempSync(join(tmpdir(), 'recovery-race-'));
diff --git a/scripts/vitestTempRootSetup.js b/scripts/vitestTempRootSetup.js
index 0e3649d448..bf137fd4c7 100644
--- a/scripts/vitestTempRootSetup.js
+++ b/scripts/vitestTempRootSetup.js
@@ -8,7 +8,12 @@ import { join } from 'node:path';
import { describeOwnedBrowserObservation, describeStageFixtureRoot, readOwnedBrowserObservations } from '../server/test/ownedBrowserDiagnostics.js';
import { OWNER_FILE, killTestProcessesUnder } from './lib/vitestStaleRunRoots.js';
-export function setup() {}
+export function setup({ vitest }) {
+ const root = process.env.PORTOS_TEST_TEMP_ROOT;
+ // Vitest runs global teardown before closing its worker pool. Its close hook
+ // runs after pool.close(), so live runner workers are not mistaken for leaks.
+ vitest.onClose(() => cleanupRunTempRoot(root));
+}
// Vitest's nanoid transform scratch still exists when global teardown runs.
// Exclude it only inside our owned root; never sweep arbitrary host directories.
@@ -67,12 +72,18 @@ export function isEffectivelyEmpty(path) {
return children.every((child) => isEffectivelyEmpty(join(path, child)));
}
-export function teardown() {
- const root = process.env.PORTOS_TEST_TEMP_ROOT;
+export function cleanupRunTempRoot(root = process.env.PORTOS_TEST_TEMP_ROOT) {
if (!root) return;
// A process a suite failed to tear down would outlive the run (#10840).
- const processes = process.platform === 'win32' ? 0 : killTestProcessesUnder(root);
+ const kinds = new Map();
+ const processes = process.platform === 'win32' ? 0 : killTestProcessesUnder(root, {
+ onKilled: ({ kind, parent }) => {
+ const key = `kind=${kind} parent=${parent}`;
+ kinds.set(key, (kinds.get(key) ?? 0) + 1);
+ },
+ });
if (processes) console.warn(`⚠️ test process leak: stopped ${processes} process${processes === 1 ? '' : 'es'} still running under the run temp root`);
+ for (const [kind, count] of kinds) console.warn(`⚠️ stopped owned test processes: ${kind} count=${count}`);
let entries;
try {
entries = readdirSync(root);
diff --git a/scripts/vitestTempRootSetup.test.js b/scripts/vitestTempRootSetup.test.js
index 8d94749e08..2c48692973 100644
--- a/scripts/vitestTempRootSetup.test.js
+++ b/scripts/vitestTempRootSetup.test.js
@@ -8,7 +8,7 @@ import { cleanupTempDataRoots, lazyTempDataRoot } from '../server/lib/mockPathsD
import { describeStageFixtureRoot, observeOwnedBrowsers, readOwnedBrowserObservations } from '../server/test/ownedBrowserDiagnostics.js';
import { join } from 'node:path';
import { afterEach, describe, expect, it, vi } from 'vitest';
-import { teardown } from './vitestTempRootSetup.js';
+import { cleanupRunTempRoot, setup } from './vitestTempRootSetup.js';
vi.mock('node:fs', async importOriginal => {
const actual = await importOriginal();
@@ -31,12 +31,26 @@ describe('vitestTempRootSetup teardown', () => {
populate(root);
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
process.exitCode = undefined;
- teardown();
+ cleanupRunTempRoot();
const result = { warnings: warn.mock.calls.map((c) => c[0]), exitCode: process.exitCode, removed: !existsSync(root) };
rmSync(root, { recursive: true, force: true });
return result;
}
+ it('defers root cleanup until Vitest closes its pool and retains the setup root', () => {
+ const root = mkdtempSync(join(tmpdir(), 'pvt-close-test-'));
+ const onClose = vi.fn();
+ try {
+ process.env.PORTOS_TEST_TEMP_ROOT = root;
+ expect(setup({ vitest: { onClose } })).toBeUndefined();
+ expect(existsSync(root)).toBe(true);
+ expect(onClose).toHaveBeenCalledTimes(1);
+ process.env.PORTOS_TEST_TEMP_ROOT = originalRoot;
+ onClose.mock.calls[0][0]();
+ expect(existsSync(root)).toBe(false);
+ } finally { rmSync(root, { recursive: true, force: true }); }
+ });
+
it('ignores browser-owned Chrome scratch directories but still fails on a leaked fixture beside them', () => {
const browserOnly = runTeardown((root) => {
for (const name of ['com.google.Chrome.aB3dE9', '.com.google.Chrome.xY7zQ2', '.org.chromium.Chromium.k9L2mN', 'com.google.Chrome.chrome_chrome_Unpacker_BeginUnzipping.AbC123', 'com.google.Chrome.chrome_chrome_url_fetcher_.AbC123']) {
@@ -307,7 +321,7 @@ describe('vitestTempRootSetup teardown', () => {
symlinkSync(outside, join(root, 'outside-link'), directoryLink);
symlinkSync(join(sandbox, 'missing'), join(root, 'dangling-link'), directoryLink);
const result = spawnSync(process.execPath, ['--input-type=module', '-e',
- `import { teardown } from ${JSON.stringify(new URL('./vitestTempRootSetup.js', import.meta.url).href)}; teardown();`], {
+ `import { cleanupRunTempRoot } from ${JSON.stringify(new URL('./vitestTempRootSetup.js', import.meta.url).href)}; cleanupRunTempRoot();`], {
env: { ...process.env, PORTOS_TEST_TEMP_ROOT: root },
encoding: 'utf8', timeout: 5000,
});