Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: drop superseded filter/range/vault responses in history, charts, feeds, trust, savings, wiki and published views (#12951)

[._.]/ Adam Eivy6fb00ab9741a
diff --git a/client/src/components/agents/tabs/PublishedTab.jsx b/client/src/components/agents/tabs/PublishedTab.jsx
index dd0ac81432..bfedd3ce04 100644
--- a/client/src/components/agents/tabs/PublishedTab.jsx
+++ b/client/src/components/agents/tabs/PublishedTab.jsx
@@ -4,6 +4,7 @@ import BrailleSpinner from '../../BrailleSpinner';
import LoadFailedState from '../../ui/LoadFailedState';
import { FormField } from '../../ui/FormField';
import { timeAgo, formatDateTime } from '../../../utils/formatters';
+import useLatestRequest from '../../../hooks/useLatestRequest.js';
export default function PublishedTab({ agentId }) {
const [accounts, setAccounts] = useState([]);
@@ -13,6 +14,7 @@ export default function PublishedTab({ agentId }) {
const [publishedError, setPublishedError] = useState(false);
const [publishedDays, setPublishedDays] = useState(7);
const [loading, setLoading] = useState(true);
+ const beginPublishedLoad = useLatestRequest();
const fetchAccounts = useCallback(async () => {
const data = await api.getPlatformAccounts(agentId);
@@ -30,21 +32,24 @@ export default function PublishedTab({ agentId }) {
}, [fetchAccounts]);
const loadPublished = useCallback(async () => {
+ const isCurrent = beginPublishedLoad();
if (!agentId || !selectedAccountId) {
setPublished({ posts: [], comments: [] });
+ setPublishedLoading(false);
return;
}
setPublishedLoading(true);
setPublishedError(false);
try {
const data = await api.getAgentPublished({ agentId, accountId: selectedAccountId, days: publishedDays }, { silent: true });
+ if (!isCurrent()) return;
setPublished(data);
} catch {
+ if (!isCurrent()) return;
setPublishedError(true);
- } finally {
- setPublishedLoading(false);
}
- }, [agentId, selectedAccountId, publishedDays]);
+ setPublishedLoading(false);
+ }, [agentId, selectedAccountId, publishedDays, beginPublishedLoad]);
useEffect(() => {
loadPublished();
diff --git a/client/src/components/brain/tabs/FeedsTab.jsx b/client/src/components/brain/tabs/FeedsTab.jsx
index 04f5400e4f..7e6cc9f12a 100644
--- a/client/src/components/brain/tabs/FeedsTab.jsx
+++ b/client/src/components/brain/tabs/FeedsTab.jsx
@@ -15,6 +15,7 @@ import { timeAgo } from '../../../utils/formatters';
import { normalizeUrl } from '../../../utils/urlNormalize';
import LoadFailedState from '../../ui/LoadFailedState';
import ListLoadError from '../../ui/ListLoadError';
+import useLatestRequest from '../../../hooks/useLatestRequest.js';
export default function FeedsTab({ onRefresh }) {
const [inputUrl, setInputUrl] = useState('');
@@ -29,6 +30,7 @@ export default function FeedsTab({ onRefresh }) {
const [unreadOnly, setUnreadOnly] = useState(false);
const [confirmingDeleteId, setConfirmingDeleteId] = useState(null);
const inputRef = useRef(null);
+ const beginItemsLoad = useLatestRequest();
const fetchFeeds = useCallback(async () => {
try {
@@ -43,14 +45,17 @@ export default function FeedsTab({ onRefresh }) {
}, []);
const fetchItems = useCallback(async () => {
+ const isCurrent = beginItemsLoad();
try {
const data = await api.getFeedItems({ feedId: selectedFeedId, unreadOnly });
+ if (!isCurrent()) return;
setItems(data || []);
setItemsError(null);
} catch (error) {
+ if (!isCurrent()) return;
setItemsError(error instanceof Error ? error : new Error('Request failed'));
}
- }, [selectedFeedId, unreadOnly]);
+ }, [selectedFeedId, unreadOnly, beginItemsLoad]);
useEffect(() => {
Promise.all([fetchFeeds(), fetchItems()]).then(() => setLoading(false));
diff --git a/client/src/components/brain/tabs/TrustTab.jsx b/client/src/components/brain/tabs/TrustTab.jsx
index fbb3b454d0..fb10d66119 100644
--- a/client/src/components/brain/tabs/TrustTab.jsx
+++ b/client/src/components/brain/tabs/TrustTab.jsx
@@ -1,4 +1,5 @@
-import { useState, useEffect, useCallback } from 'react';
+import { useState, useEffect, useCallback, useRef } from 'react';
+import useLatestRequest from '../../../hooks/useLatestRequest.js';
import * as api from '../../../services/api';
import {
RefreshCw,
@@ -30,8 +31,12 @@ export default function TrustTab({ onRefresh }) {
const [expandedId, setExpandedId] = useState(null);
const [editingSettings, setEditingSettings] = useState(false);
const [settingsForm, setSettingsForm] = useState({});
+ const beginLoad = useLatestRequest();
+ // Seed the edit form once; an inbox-filter reload must not discard in-progress edits.
+ const formSeededRef = useRef(false);
const fetchData = useCallback(async () => {
+ const isCurrent = beginLoad();
const asError = (error) => (error instanceof Error ? error : new Error('Request failed'));
// The rows own their error UI (silent), and a failure is carried as a
// value so it never reads as an empty log or as default settings.
@@ -41,6 +46,7 @@ export default function TrustTab({ onRefresh }) {
api.getBrainSettings({ silent: true })
.then((data) => ({ data }), (error) => ({ error: asError(error) })),
]);
+ if (!isCurrent()) return;
setInboxError(inboxResult.error || null);
if (inboxResult.data) {
@@ -50,10 +56,13 @@ export default function TrustTab({ onRefresh }) {
setSettingsError(settingsResult.error || null);
if (settingsResult.data) {
setSettings(settingsResult.data);
- setSettingsForm(settingsResult.data);
+ if (!formSeededRef.current) {
+ formSeededRef.current = true;
+ setSettingsForm(settingsResult.data);
+ }
}
setLoading(false);
- }, [statusFilter]);
+ }, [statusFilter, beginLoad]);
useEffect(() => {
fetchData();
diff --git a/client/src/components/brain/tabs/TrustTab.test.jsx b/client/src/components/brain/tabs/TrustTab.test.jsx
index 8be89478f8..c2efac6a8d 100644
--- a/client/src/components/brain/tabs/TrustTab.test.jsx
+++ b/client/src/components/brain/tabs/TrustTab.test.jsx
@@ -98,3 +98,17 @@ describe('TrustTab failed reads', () => {
expect(screen.getByText('No entries found.')).toBeInTheDocument();
});
});
+
+describe('TrustTab filter reloads (#12951)', () => {
+ it('keeps an in-progress settings edit when only the status filter changes', async () => {
+ await renderTab();
+ fireEvent.click(screen.getByRole('button', { name: 'Edit' }));
+ const input = screen.getByLabelText('Confidence Threshold');
+ fireEvent.change(input, { target: { value: '0.9' } });
+
+ fireEvent.change(screen.getByLabelText('Filter by status'), { target: { value: 'filed' } });
+ await act(async () => {});
+
+ expect(screen.getByLabelText('Confidence Threshold')).toHaveValue(0.9);
+ });
+});
diff --git a/client/src/components/meatspace/AlcoholChart.jsx b/client/src/components/meatspace/AlcoholChart.jsx
index 8e601af426..a5c6cabd4a 100644
--- a/client/src/components/meatspace/AlcoholChart.jsx
+++ b/client/src/components/meatspace/AlcoholChart.jsx
@@ -6,6 +6,7 @@ import * as api from '../../services/api';
import BrailleSpinner from '../BrailleSpinner';
import LoadFailureNotice from './LoadFailureNotice';
import useChartColors from '../../hooks/useChartColors.js';
+import useLatestRequest from '../../hooks/useLatestRequest.js';
import { formatMonthDay, localDateKey } from '../../utils/formatters';
const VIEWS = [
@@ -23,10 +24,12 @@ export default function AlcoholChart({ sex = 'male', onRefreshKey, onViewChange
const [view, setView] = useState('30d');
const [unit, setUnit] = useState('grams'); // 'grams' or 'drinks'
const chartColors = useChartColors();
+ const beginLoad = useLatestRequest();
const dailyMax = sex === 'female' ? 1 : 2;
const fetchData = useCallback(async () => {
+ const isCurrent = beginLoad();
const days = VIEWS.find(v => v.id === view)?.days || 30;
const from = new Date();
from.setDate(from.getDate() - days);
@@ -34,6 +37,7 @@ export default function AlcoholChart({ sex = 'male', onRefreshKey, onViewChange
const toStr = localDateKey();
const entries = await api.getDailyAlcohol(fromStr, toStr, { silent: true }).catch(() => null);
+ if (!isCurrent()) return;
setFailed(entries === null);
if (entries === null) {
// Do not zero-fill: a failed load must not read as a month of abstinence.
@@ -65,7 +69,7 @@ export default function AlcoholChart({ sex = 'male', onRefreshKey, onViewChange
setData(chartData);
setLoading(false);
- }, [view]);
+ }, [view, beginLoad]);
useEffect(() => {
fetchData();
diff --git a/client/src/components/meatspace/AlcoholChart.test.jsx b/client/src/components/meatspace/AlcoholChart.test.jsx
index a1768eeb73..3302f4ecb5 100644
--- a/client/src/components/meatspace/AlcoholChart.test.jsx
+++ b/client/src/components/meatspace/AlcoholChart.test.jsx
@@ -8,7 +8,7 @@ vi.mock('recharts', () => {
const Pass = ({ children }) => <div>{children}</div>;
return {
ResponsiveContainer: ({ children }) => <div data-testid="chart">{children}</div>,
- BarChart: Pass, Bar: () => null, XAxis: () => null, YAxis: () => null,
+ BarChart: ({ data }) => <div data-testid="bars" data-n={data.length} />, Bar: () => null, XAxis: () => null, YAxis: () => null,
CartesianGrid: () => null, Tooltip: () => null, ReferenceLine: () => null
};
});
@@ -36,3 +36,19 @@ describe('AlcoholChart load failure vs empty', () => {
expect(screen.queryByText(/Could not load daily alcohol/)).not.toBeInTheDocument();
});
});
+
+describe('AlcoholChart superseded loads (#12951)', () => {
+ it('draws the selected range when an earlier range resolves last', async () => {
+ let resolveMonth;
+ api.getDailyAlcohol.mockImplementationOnce(() => new Promise((resolve) => { resolveMonth = resolve; }));
+ api.getDailyAlcohol.mockResolvedValueOnce([]);
+ render(<AlcoholChart />);
+ fireEvent.click(screen.getByRole('button', { name: '7 Days' }));
+ const bars = await screen.findByTestId('bars');
+ expect(bars).toHaveAttribute('data-n', '8');
+
+ resolveMonth([]);
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(screen.getByTestId('bars')).toHaveAttribute('data-n', '8');
+ });
+});
diff --git a/client/src/components/meatspace/NicotineChart.jsx b/client/src/components/meatspace/NicotineChart.jsx
index 6c2c5f8546..a4249a091a 100644
--- a/client/src/components/meatspace/NicotineChart.jsx
+++ b/client/src/components/meatspace/NicotineChart.jsx
@@ -6,6 +6,7 @@ import * as api from '../../services/api';
import BrailleSpinner from '../BrailleSpinner';
import LoadFailureNotice from './LoadFailureNotice';
import useChartColors from '../../hooks/useChartColors.js';
+import useLatestRequest from '../../hooks/useLatestRequest.js';
import { formatMonthDay, localDateKey } from '../../utils/formatters';
const VIEWS = [
@@ -29,12 +30,14 @@ const CustomTooltip = ({ active, payload, label }) => {
export default function NicotineChart({ onRefreshKey, onViewChange }) {
const chartColors = useChartColors();
+ const beginLoad = useLatestRequest();
const [data, setData] = useState([]);
const [failed, setFailed] = useState(false);
const [loading, setLoading] = useState(true);
const [view, setView] = useState('30d');
const fetchData = useCallback(async () => {
+ const isCurrent = beginLoad();
const days = VIEWS.find(v => v.id === view)?.days || 30;
const from = new Date();
from.setDate(from.getDate() - days);
@@ -42,6 +45,7 @@ export default function NicotineChart({ onRefreshKey, onViewChange }) {
const toStr = localDateKey();
const entries = await api.getDailyNicotine(fromStr, toStr, { silent: true }).catch(() => null);
+ if (!isCurrent()) return;
setFailed(entries === null);
if (entries === null) {
// Do not zero-fill: a failed load must not read as zero consumption.
@@ -71,7 +75,7 @@ export default function NicotineChart({ onRefreshKey, onViewChange }) {
setData(chartData);
setLoading(false);
- }, [view]);
+ }, [view, beginLoad]);
useEffect(() => {
fetchData();
diff --git a/client/src/components/models/SubscriptionsTab.jsx b/client/src/components/models/SubscriptionsTab.jsx
index 38721f279e..4b6c5c699e 100644
--- a/client/src/components/models/SubscriptionsTab.jsx
+++ b/client/src/components/models/SubscriptionsTab.jsx
@@ -14,6 +14,7 @@ import {
rowCells,
} from '../usage/SubscriptionSavingsCard';
import { useQuotaUpdates } from '../../hooks/useQuotaUpdates';
+import useLatestRequest from '../../hooks/useLatestRequest.js';
import useUrlParams from '../../hooks/useUrlParams';
import { USAGE_PERIOD_OPTIONS, resolveUsagePeriod, DEFAULT_USAGE_PERIOD } from '../../lib/usagePeriods';
@@ -194,6 +195,7 @@ export default function SubscriptionsTab() {
const [quotas, setQuotas] = useState(null);
const [drafts, setDrafts] = useState({});
const [busyFamily, setBusyFamily] = useState(null);
+ const beginSavingsLoad = useLatestRequest();
const loadPlans = useCallback(async () => {
const data = await api.getSubscriptions({ silent: true }).catch(() => null);
@@ -201,9 +203,11 @@ export default function SubscriptionsTab() {
}, []);
const loadSavings = useCallback(async () => {
+ const isCurrent = beginSavingsLoad();
const data = await api.getUsage({ period }).catch(() => null);
+ if (!isCurrent()) return;
setSavings(data?.subscriptionSavings ?? null);
- }, [period]);
+ }, [period, beginSavingsLoad]);
const loadQuotas = useCallback(async (refresh = false) => {
const data = await api.getProviderUsage({ refresh }).catch(() => null);
diff --git a/client/src/components/wiki/tabs/GraphTab.jsx b/client/src/components/wiki/tabs/GraphTab.jsx
index 5e6d019be2..057ed8ea18 100644
--- a/client/src/components/wiki/tabs/GraphTab.jsx
+++ b/client/src/components/wiki/tabs/GraphTab.jsx
@@ -5,6 +5,7 @@ import { RefreshCw, Network, ZoomIn, ZoomOut } from 'lucide-react';
import { WIKI_CATEGORIES } from '../constants.jsx';
import BrailleSpinner from '../../BrailleSpinner';
import OfflineNotesNotice from '../../OfflineNotesNotice.jsx';
+import useLatestRequest from '../../../hooks/useLatestRequest.js';
export default function GraphTab({ vaultId }) {
const navigate = useNavigate();
@@ -18,16 +19,19 @@ export default function GraphTab({ vaultId }) {
const [hoveredNode, setHoveredNode] = useState(null);
const nodesRef = useRef([]);
const connectionCountsRef = useRef(new Map());
+ const beginLoad = useLatestRequest();
const loadGraph = useCallback(async () => {
+ const isCurrent = beginLoad();
setLoading(true);
const data = await api.getNotesVaultGraph(vaultId).catch(() => null);
+ if (!isCurrent()) return;
if (data && !data.error) {
setGraphData(data);
layoutNodes(data);
}
setLoading(false);
- }, [vaultId]);
+ }, [vaultId, beginLoad]);
useEffect(() => {
loadGraph();
diff --git a/client/src/components/wiki/tabs/SearchTab.jsx b/client/src/components/wiki/tabs/SearchTab.jsx
index e87d2fa4ee..7a16d6820c 100644
--- a/client/src/components/wiki/tabs/SearchTab.jsx
+++ b/client/src/components/wiki/tabs/SearchTab.jsx
@@ -3,6 +3,7 @@ import { useNavigate, useSearchParams } from 'react-router';
import * as api from '../../../services/api';
import { Search, FileText, X, RefreshCw, Tag } from 'lucide-react';
import OfflineNotesNotice from '../../OfflineNotesNotice.jsx';
+import useLatestRequest from '../../../hooks/useLatestRequest.js';
export default function SearchTab({ vaultId }) {
const navigate = useNavigate();
@@ -11,14 +12,17 @@ export default function SearchTab({ vaultId }) {
const [results, setResults] = useState(null);
const [searching, setSearching] = useState(false);
const inputRef = useRef(null);
+ const beginSearch = useLatestRequest();
const handleSearch = useCallback(async () => {
if (!query.trim() || !vaultId) return;
+ const isCurrent = beginSearch();
setSearching(true);
const data = await api.searchNotes(vaultId, query.trim(), 50).catch(() => null);
+ if (!isCurrent()) return;
setSearching(false);
if (data) setResults(data);
- }, [query, vaultId]);
+ }, [query, vaultId, beginSearch]);
const openNote = (notePath) => {
const next = new URLSearchParams(searchParams);
diff --git a/client/src/components/wiki/tabs/SearchTab.test.jsx b/client/src/components/wiki/tabs/SearchTab.test.jsx
new file mode 100644
index 0000000000..9cc53e3e20
--- /dev/null
+++ b/client/src/components/wiki/tabs/SearchTab.test.jsx
@@ -0,0 +1,30 @@
+import { render, screen, fireEvent, act } from '@testing-library/react';
+import { MemoryRouter } from 'react-router';
+import { describe, it, expect, vi } from 'vitest';
+import SearchTab from './SearchTab';
+import * as api from '../../../services/api';
+
+vi.mock('../../../services/api');
+
+const renderTab = (vaultId) => (
+ <MemoryRouter><SearchTab vaultId={vaultId} /></MemoryRouter>
+);
+
+describe('SearchTab superseded searches (#12951)', () => {
+ it('drops a slower earlier-vault response that resolves after the current search', async () => {
+ let resolveOld;
+ api.searchNotes.mockImplementationOnce(() => new Promise((resolve) => { resolveOld = resolve; }));
+ api.searchNotes.mockResolvedValueOnce({ results: [], total: 0 });
+ const { rerender } = render(renderTab('v1'));
+ const box = screen.getByLabelText('Search wiki pages and raw sources');
+ fireEvent.change(box, { target: { value: 'alpha' } });
+ fireEvent.keyDown(box, { key: 'Enter' });
+
+ rerender(renderTab('v2'));
+ fireEvent.keyDown(box, { key: 'Enter' });
+ await act(async () => {});
+
+ await act(async () => { resolveOld({ results: [{ path: 'old/stale.md', name: 'Stale Result', snippet: 'x' }], total: 1 }); });
+ expect(screen.queryByText('Stale Result')).not.toBeInTheDocument();
+ });
+});
diff --git a/client/src/pages/HistoryPage.jsx b/client/src/pages/HistoryPage.jsx
index ba736580e5..93b167c54c 100644
--- a/client/src/pages/HistoryPage.jsx
+++ b/client/src/pages/HistoryPage.jsx
@@ -7,6 +7,7 @@ import LoadFailedState from '../components/ui/LoadFailedState';
import Banner from '../components/ui/Banner';
import ListLoadError from '../components/ui/ListLoadError';
import useListResource from '../hooks/useListResource.js';
+import useLatestRequest from '../hooks/useLatestRequest.js';
import { clickableProps, onActivateKeyDown } from '../lib/a11yKeyboard.js';
export function HistoryPage() {
@@ -17,6 +18,7 @@ export function HistoryPage() {
const [filter, setFilter] = useState({ action: '', success: '' });
const [confirmingClear, setConfirmingClear] = useState(false);
const [expandedId, setExpandedId] = useState(null);
+ const beginLoad = useLatestRequest();
const fetchActions = useCallback(async () => {
const list = await api.getHistoryActions({ silent: true });
@@ -26,6 +28,7 @@ export function HistoryPage() {
const { items: actions, state: actionsState, error: actionsError, retry: retryActions } = actionsResource;
const loadData = useCallback(async () => {
+ const isCurrent = beginLoad();
setLoading(true);
const [historyData, statsData] = await Promise.all([
api.getHistory({
@@ -35,11 +38,12 @@ export function HistoryPage() {
}).catch(() => null),
api.getHistoryStats().catch(() => null),
]);
+ if (!isCurrent()) return;
setHistoryFailed(historyData === null);
if (historyData) setHistory(historyData.entries || []);
setStats(statsData);
setLoading(false);
- }, [filter]);
+ }, [filter, beginLoad]);
useEffect(() => {
loadData();
diff --git a/client/src/pages/Wiki.jsx b/client/src/pages/Wiki.jsx
index 29b1842071..635f15d513 100644
--- a/client/src/pages/Wiki.jsx
+++ b/client/src/pages/Wiki.jsx
@@ -189,9 +189,9 @@ export default function Wiki() {
case 'browse':
return <WikiBrowseTab key={selectedVaultId} vaultId={selectedVaultId} notes={wikiNotes} rawNotes={rawNotes} allNotes={notes} onRefresh={handleRefresh} />;
case 'search':
- return <WikiSearchTab vaultId={selectedVaultId} onRefresh={handleRefresh} />;
+ return <WikiSearchTab key={selectedVaultId} vaultId={selectedVaultId} onRefresh={handleRefresh} />;
case 'graph':
- return <WikiGraphTab vaultId={selectedVaultId} />;
+ return <WikiGraphTab key={selectedVaultId} vaultId={selectedVaultId} />;
case 'log':
return <WikiLogTab vaultId={selectedVaultId} allNotes={notes} />;
default: