Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: exclude unnumbered tooling from data migrations
[._.]/ Adam Eivy7112f5af4cb6
diff --git a/scripts/run-migrations.js b/scripts/run-migrations.jsindex b5cbe9d868..fdbf956121 100644--- a/scripts/run-migrations.js+++ b/scripts/run-migrations.js@@ -129,17 +129,16 @@ async function acquireMigrationLock(lockDir, { waitMs = LOCK_WAIT_MS, pollMs = L}/**- * Scan for migration files (*.js, sorted by filename). Co-located vitest+ * Scan for numbered migration files (NNN-name.js, sorted by filename). Co-located vitest* files (*.test.js) are excluded — they don't export `up()` and would* throw the runner if imported as migrations. The vitest config picks* them up via its own scripts test glob in server/vitest.config.js.- * `_`-prefixed files (e.g. `_lib.js`, `_testHelpers.js`) are shared- * helpers consumed by migration files and their tests — they're never- * migrations themselves.+ * Unnumbered modules include shared helpers and executable tooling; importing+ * them here can run unrelated checks or exit the process before migrations finish.*/async function scanMigrationFiles(migrationsDir) {return (await readdir(migrationsDir))- .filter(f => f.endsWith('.js') && !f.endsWith('.test.js') && !f.startsWith('_'))+ .filter(f => /^\d+-.*\.js$/.test(f) && !f.endsWith('.test.js')).sort();}diff --git a/scripts/run-migrations.test.js b/scripts/run-migrations.test.jsindex 8283d200e3..89bd327d16 100644--- a/scripts/run-migrations.test.js+++ b/scripts/run-migrations.test.js@@ -172,19 +172,27 @@ export default {expect(JSON.parse(readFileSync(appliedFile, 'utf-8'))).toEqual(['002-purge.js', '001-fixture.js']);});- it('skips `_`-prefixed shared-helper files (never imports them as migrations)', async () => {- // _lib.js / _testHelpers.js are imported by migration files + tests but- // they don't export `up()` — if the runner tried to load them it would- // throw "does not export an up() function".- writeFileSync(join(migrationsDir, '_lib.js'), `-export const md5 = (s) => s;-// no default export, no up() — would throw if the runner picked this up.-`);+ it('runs numbered migrations without importing helper, CLI or test modules', async () => {+ for (const file of ['_lib.js', 'shippedPromptHistory.js', 'check-shipped-prompt-history.js', '001-fixture.test.js']) {+ writeFileSync(join(migrationsDir, file), 'throw new Error("Non-migration module was imported");');+ }const ran = await runMigrations({ rootDir, migrationsDir });expect(ran).toBe(1); // only 001-fixture.js ranexpect(JSON.parse(readFileSync(appliedFile, 'utf-8'))).toEqual(['001-fixture.js']);+ expect(existsSync(join(dataDir, 'fixture-marker.txt'))).toBe(true);+ await expect(listPendingMigrations({ rootDir, migrationsDir })).resolves.toEqual([]);+ });++ it('still rejects numbered modules without up() and leaves them pending', async () => {+ writeFileSync(join(migrationsDir, '002-invalid.js'), 'export const notAMigration = true;');++ await expect(runMigrations({ rootDir, migrationsDir }))+ .rejects.toThrow('Migration "002-invalid.js" does not export an up() function');++ expect(JSON.parse(readFileSync(appliedFile, 'utf-8'))).toEqual(['001-fixture.js']);+ await expect(listPendingMigrations({ rootDir, migrationsDir })).resolves.toEqual(['002-invalid.js']);});});@@ -583,9 +591,10 @@ describe('listPendingMigrations', () => {expect(pending).toEqual([]);});- it('excludes *.test.js and `_`-prefixed helper files', async () => {- writeFileSync(join(migrationsDir, '001-a.test.js'), '// test');- writeFileSync(join(migrationsDir, '_lib.js'), 'export const x = 1;');+ it('excludes tests and unnumbered helper or CLI modules', async () => {+ for (const file of ['001-a.test.js', '_lib.js', 'shippedPromptHistory.js', 'check-shipped-prompt-history.js']) {+ writeFileSync(join(migrationsDir, file), 'throw new Error("Pending discovery must not import modules");');+ }const pending = await listPendingMigrations({ rootDir, migrationsDir });expect(pending).toEqual(['001-a.js', '002-b.js', '003-c.js']);});