Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: find the actual Outlook scroll container and expose selector failures (#11021)

Adam Eivy7279e0d3c5e9
diff --git a/server/services/messagePlaywrightSync.js b/server/services/messagePlaywrightSync.js
index ade3060288..4035448605 100644
--- a/server/services/messagePlaywrightSync.js
+++ b/server/services/messagePlaywrightSync.js
@@ -37,16 +37,14 @@ function outlookRowContext(selector, requireScroll = true) {
}
if (!requireScroll || initialRows.length === 0) return { rows };
- const first = initialRows[0];
- const list = first.closest('[role="listbox"], [role="list"]');
- let scrollContainer = first.closest('[role="region"]') || list?.parentElement;
- // Custom layouts may have an ordinary overflow container instead of ARIA roles.
- if (!scrollContainer) {
- for (let parent = first.parentElement; parent; parent = parent.parentElement) {
- if (parent.scrollHeight > parent.clientHeight && /auto|scroll/.test(getComputedStyle(parent).overflowY)) {
- scrollContainer = parent;
- break;
- }
+ // ARIA regions can wrap a separate scrolling element. Walk from the rows
+ // outward instead of assuming the region or list parent can actually scroll.
+ let scrollContainer;
+ for (let parent = initialRows[0].parentElement; parent; parent = parent.parentElement) {
+ if (/auto|scroll|overlay|hidden/.test(getComputedStyle(parent).overflowY)
+ || (parent === document.scrollingElement && parent.scrollHeight > parent.clientHeight)) {
+ scrollContainer = parent;
+ break;
}
}
if (!scrollContainer || typeof scrollContainer.scrollBy !== 'function'
diff --git a/server/services/messagePlaywrightSync.test.js b/server/services/messagePlaywrightSync.test.js
index e7dd272afe..a2d0472007 100644
--- a/server/services/messagePlaywrightSync.test.js
+++ b/server/services/messagePlaywrightSync.test.js
@@ -150,10 +150,13 @@ describe('Outlook configured row extraction', () => {
scrollBy: vi.fn(() => { paint = Math.min(paint + 1, paints.length - 1); }),
scrollTo: vi.fn(() => { paint = 0; })
};
+ const staticRegion = { contains: () => true, scrollBy() {}, scrollTo() {} };
+ if (container === 'nested') scroll.parentElement = staticRegion;
const list = { parentElement: scroll };
const rows = paints.map(records => records.map(data => ({
- ...attr({ 'data-itemid': data.providerRowId }), parentElement: container === 'overflow' ? scroll : null,
- closest: sel => container === 'region' && sel === '[role="region"]' ? scroll
+ ...attr({ 'data-itemid': data.providerRowId }), parentElement: container === 'none' ? null : container === 'list' ? list : scroll,
+ closest: sel => container === 'nested' && sel === '[role="region"]' ? staticRegion
+ : container === 'region' && sel === '[role="region"]' ? scroll
: container === 'list' && sel.includes('[role="listbox"]') ? list : null,
scrollIntoView() {},
click() { clicked.push(data.providerRowId); opened = true; },
@@ -181,7 +184,7 @@ describe('Outlook configured row extraction', () => {
};
evaluateOnPage.mockImplementation((_page, script) => vm.runInNewContext(script, {
document, location: { href: 'https://example.com/mail/' },
- getComputedStyle: () => ({ overflowY: 'auto' }), setTimeout: callback => callback()
+ getComputedStyle: el => ({ overflowY: el === scroll ? 'auto' : 'visible' }), setTimeout: callback => callback()
}));
return { clicked, scroll };
}
@@ -210,7 +213,7 @@ describe('Outlook configured row extraction', () => {
expect(clicked).toEqual(['first', 'second', 'second']);
});
- it.each(['region', 'list', 'overflow'])('retains bounded full/unread virtualized scrolling with a %s container', async container => {
+ it.each(['region', 'list', 'overflow', 'nested'])('retains bounded full/unread virtualized scrolling with a %s container', async container => {
for (const selector of [defaultSelector, customSelector]) {
tryReadFile.mockResolvedValue(selector === defaultSelector ? '{}' : JSON.stringify({ outlook: { messageRow: selector } }));
for (const mode of ['unread', 'full']) {
diff --git a/server/services/messageSync.js b/server/services/messageSync.js
index e80fbbb9a1..10cd22fb7a 100644
--- a/server/services/messageSync.js
+++ b/server/services/messageSync.js
@@ -215,6 +215,7 @@ export async function syncAccount(accountId, io, options = {}) {
// Support structured result { messages, status } or plain array
const newMessages = Array.isArray(providerResult) ? providerResult : providerResult?.messages ?? [];
const providerStatus = Array.isArray(providerResult) ? 'success' : providerResult?.status ?? 'success';
+ const providerReason = typeof providerResult?.error === 'string' ? { reason: providerResult.error } : {};
// Sent mail (Gmail reply-detection ingest, #2796) is activity-only: recorded to
// the timeline but never added to the inbox cache/eval/trim. Kept separate here.
const sentMessages = Array.isArray(providerResult) ? [] : (providerResult?.sentMessages ?? []);
@@ -357,13 +358,13 @@ export async function syncAccount(accountId, io, options = {}) {
console.error(`🤝 Sent-ingest watermark failed for account ${accountId}: ${messageLogError(err)}`));
}
- io?.emit('messages:sync:completed', { accountId, newMessages: uniqueNew.length, pruned, status: providerStatus });
+ io?.emit('messages:sync:completed', { accountId, newMessages: uniqueNew.length, pruned, status: providerStatus, ...providerReason });
if (providerStatus === 'success') {
io?.emit('messages:changed', {});
}
console.log(`📧 Sync complete for account ${account.id}: ${uniqueNew.length} new, ${pruned} pruned, status=${providerStatus}`);
- return { newMessages: uniqueNew.length, pruned, total: cache.messages.length, status: providerStatus };
+ return { newMessages: uniqueNew.length, pruned, total: cache.messages.length, status: providerStatus, ...providerReason };
};
// Serialize the load→mutate→save region against `refreshMessage` /
diff --git a/server/services/messageSync.test.js b/server/services/messageSync.test.js
index 2e3647a02b..84eb59920d 100644
--- a/server/services/messageSync.test.js
+++ b/server/services/messageSync.test.js
@@ -520,6 +520,20 @@ describe('syncAccount', () => {
expect(result.newMessages).toBe(0);
});
+ it('retains actionable browser selector failures in the HTTP result and socket completion', async () => {
+ getAccount.mockResolvedValue({ id: VALID_UUID, name: 'Outlook', type: 'outlook', enabled: true });
+ readFile.mockResolvedValue(JSON.stringify({ messages: [{ id: 'existing', externalId: 'existing-row' }] }));
+ const reason = 'Invalid Outlook messageRow selector. Edit it in Messages > Sync and test again.';
+ syncPlaywright.mockResolvedValue({ messages: [], status: 'extraction-failed', error: reason });
+ updateSyncStatus.mockResolvedValue();
+
+ expect(await syncAccount(VALID_UUID, mockIo, { mode: 'full' })).toMatchObject({
+ status: 'extraction-failed', reason, total: 1, pruned: 0
+ });
+ expect(mockIo.emit).toHaveBeenCalledWith('messages:sync:completed', expect.objectContaining({ status: 'extraction-failed', reason }));
+ expect(mockIo.emit).not.toHaveBeenCalledWith('messages:changed', {});
+ });
+
it('selects the supported full mode for a Teams sync that omits the mode', async () => {
getAccount.mockResolvedValue({ id: VALID_UUID, name: 'Teams', type: 'teams', enabled: true });
readFile.mockResolvedValue(JSON.stringify({ syncCursor: null, messages: [] }));