Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: stop recovered completion after rejected runtime hold writes (#13484)

Adam Eivy755bc8dc7e46
diff --git a/server/services/agentFinalization.js b/server/services/agentFinalization.js
index 90be315c83..8c84dba2b9 100644
--- a/server/services/agentFinalization.js
+++ b/server/services/agentFinalization.js
@@ -1305,7 +1305,7 @@ export async function retireDeadAgent({ agent, task, success, exitCode, duration
? await resolveDeliveryRecoveryUpdate(task, recoveryOutcome, agent.id) : null;
if (recoveryUpdate) {
const update = await updateTask(task.id, recoveryUpdate, task.taskType || 'user', ...runtimeRecoveryFence(task, recoveryUpdate));
- if (update?.error) throw new Error(`Could not persist recovered task outcome: ${update.error}`);
+ if (update?.error || update?.statusChanged) throw new Error(`Could not persist recovered task outcome: ${update.error || 'task ownership changed'}`);
}
await completeAgent(agent.id, {
success: effectiveSuccess,
diff --git a/server/services/agentFinalization.outputHooks.test.js b/server/services/agentFinalization.outputHooks.test.js
index d221408b70..949b794544 100644
--- a/server/services/agentFinalization.outputHooks.test.js
+++ b/server/services/agentFinalization.outputHooks.test.js
@@ -512,6 +512,19 @@ describe('recovery output-hook dispatch (#3182)', () => {
} finally { forge.mockRestore(); gitRead.mockRestore(); }
});
+ it('stops recovered runtime finalization when its conditional prerequisite write loses ownership', async () => {
+ isProgrammaticIoTaskType.mockReturnValue(false);
+ persistedAgent.taskId = TASK.id;
+ persistedAgent.metadata.taskOutcome = { status: 'blocked', reason: 'The running fix remains unverified.',
+ recovery: { mode: 'runtime', prUrl: 'https://github.com/example/PortOS/pull/123', requiredCommit: 'a'.repeat(40) } };
+ persistedAgent.metadata.taskOutcomeSource = 'terminal-result';
+ updateTask.mockResolvedValueOnce({ statusChanged: true });
+ await expect(retireDeadAgent({ agent: persistedAgent, task: { id: TASK.id, status: 'in_progress', metadata: {} },
+ success: true, exitCode: 0 })).rejects.toThrow('task ownership changed');
+ expect(completeAgent).not.toHaveBeenCalled();
+ expect(addTask).not.toHaveBeenCalled();
+ });
+
it.each(['worktree', 'pinned-claim'])('hands %s cleanup-only work to completion recovery without another agent or success claim', async mode => {
const taskOutcome = { status: 'incomplete', reason: 'Verified delivery; owner still holds checkout.', recovery: { mode: 'cleanup' } };
isProgrammaticIoTaskType.mockReturnValue(false);