Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: keep newest snapshot on same-millisecond ties (#12067)
[._.]/ Adam Eivy78238f9a8b07
diff --git a/server/services/musicVideo/productionReview.js b/server/services/musicVideo/productionReview.jsindex 623eb94f65..4272f2eaf2 100644--- a/server/services/musicVideo/productionReview.js+++ b/server/services/musicVideo/productionReview.js@@ -959,7 +959,8 @@ const MAX_RECENT_REVISIONS = 5;*/function pruneReviewedRevisions(snapshots, feedback) {const keep = new Set((feedback || []).filter(f => !f.resolvedAt).map(f => f.basis));- Object.entries(snapshots).sort(([, a], [, b]) => String(b.capturedAt).localeCompare(String(a.capturedAt)))+ // Reversed first so a same-millisecond tie keeps the later-inserted (newer) snapshot.+ Object.entries(snapshots).reverse().sort(([, a], [, b]) => String(b.capturedAt).localeCompare(String(a.capturedAt))).slice(0, MAX_RECENT_REVISIONS).forEach(([key]) => keep.add(key));return Object.fromEntries(Object.entries(snapshots).filter(([key]) => keep.has(key)));}diff --git a/server/services/musicVideo/productionReview.retention.test.js b/server/services/musicVideo/productionReview.retention.test.jsindex ba65a7d2db..8f6b0870a1 100644--- a/server/services/musicVideo/productionReview.retention.test.js+++ b/server/services/musicVideo/productionReview.retention.test.js@@ -1,4 +1,4 @@-import { describe, it, expect } from 'vitest';+import { describe, it, expect, vi } from 'vitest';import { approveProductionStage, productionReadiness, productionAlignmentBasis, recordProductionFeedback } from './productionReview.js';function artProject(visualLanguage) {@@ -17,6 +17,17 @@ const revise = (previous, n) => ({ ...artProject(`Grain ${n}`), productionReviewconst approve = (p) => approveProductionStage(p, { stage: 'art', basis: productionReadiness(p).basis.art });describe('production review record growth', () => {+ it('keeps the newest snapshots when captures share one timestamp', () => {+ vi.useFakeTimers();+ vi.setSystemTime(new Date('2026-01-01T00:00:00Z'));+ try {+ let project = artProject('Grain 0');+ for (let n = 0; n < 8; n++) project = approve(revise(project, n));+ const { basis } = productionReadiness(project);+ expect(Object.keys(project.productionReview.reviewedRevisions)).toContain(basis.art);+ } finally { vi.useRealTimers(); }+ });+it('bounds approval history and revision snapshots across many approvals', () => {let project = artProject('Grain 0');for (let n = 0; n < 60; n++) project = approve(revise(project, n));