Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: run the scheduled Brain digest and weekly review tool-free (#13089)
Adam Eivy78f690307a04
diff --git a/server/services/brain.js b/server/services/brain.jsindex cce6764ee7..7ec6e7dc7e 100644--- a/server/services/brain.js+++ b/server/services/brain.js@@ -16,6 +16,8 @@ import { buildPrompt } from './promptService.js';import { validate } from '../lib/validation.js';import { extractJson } from '../lib/jsonExtract.js';import { runPromptThroughProvider } from './promptRunner.js';+import { isToolFreeOneShotProvider } from '../lib/providerVendors.js';+import { ServerError } from '../lib/errorHandler.js';import { getDomainAutonomyMode } from './cosState.js';import { getDomainBudgetStatus, recordDomainUsage } from './domainUsage.js';import { deleteMemoryAssets } from './chatgptImport.js';@@ -35,6 +37,8 @@ import {extractedMemorySchema} from '../lib/brainValidation.js';+export const TOOL_FREE_REQUIRED = 'TOOL_FREE_REQUIRED';+// Extracted field validators by destinationconst EXTRACTED_VALIDATORS = {people: extractedPeopleSchema,@@ -45,9 +49,12 @@ const EXTRACTED_VALIDATORS = {};/**- * Call AI provider with a prompt+ * Call AI provider with a prompt.+ * `toolFree` is for prompts that embed stored Brain records (writable by any+ * caller on a password-free install): the run is pinned to a provider that can+ * disable its host tools, with no fallback to one that cannot.*/-async function callAI(promptStageName, variables, providerOverride, modelOverride) {+async function callAI(promptStageName, variables, providerOverride, modelOverride, { toolFree = false } = {}) {const provider = providerOverride? await getProviderById(providerOverride): await getActiveProvider();@@ -56,6 +63,13 @@ async function callAI(promptStageName, variables, providerOverride, modelOverridthrow new Error('No AI provider available');}+ if (toolFree && !isToolFreeOneShotProvider(provider)) {+ throw new ServerError(+ `Brain provider '${provider.id}' cannot run without tools, so it cannot process stored Brain records unattended. Choose an API provider or a tool-free CLI (claude, grok, pi).`,+ { status: 400, code: TOOL_FREE_REQUIRED }+ );+ }+const prompt = await buildPrompt(promptStageName, variables);let model = modelOverride || provider.defaultModel;@@ -78,6 +92,8 @@ async function callAI(promptStageName, variables, providerOverride, modelOverridconst { text, model: effectiveModel } = await runPromptThroughProvider({provider: providerForCall, prompt, source: `brain-${promptStageName}`, model,+ // Pin the admitted provider so runtime fallback cannot switch to one with tools.+ ...(toolFree && { toolFree: true, allowFallback: false }),});return { content: text, model: effectiveModel || model, providerId: provider.id, prompt };}@@ -627,7 +643,8 @@ export async function runDailyDigest(providerOverride, modelOverride) {now: new Date().toISOString()},providerOverride || meta.defaultProvider,- modelOverride || meta.defaultModel+ modelOverride || meta.defaultModel,+ { toolFree: true });const parsed = parseJsonResponse(aiResult.content, digestOutputSchema, aiResult.prompt);@@ -689,7 +706,8 @@ export async function runWeeklyReview(providerOverride, modelOverride) {now: new Date().toISOString()},providerOverride || meta.defaultProvider,- modelOverride || meta.defaultModel+ modelOverride || meta.defaultModel,+ { toolFree: true });const parsed = parseJsonResponse(aiResult.content, reviewOutputSchema, aiResult.prompt);diff --git a/server/services/brain.test.js b/server/services/brain.test.jsindex ca02458895..f6acf7f167 100644--- a/server/services/brain.test.js+++ b/server/services/brain.test.js@@ -1467,6 +1467,37 @@ describe('brain service', () => {]);});+ it('runs tool-free with no fallback so stored records cannot steer a tool-capable agent', async () => {+ storage.getProjects.mockResolvedValue([{ id: 'p1', name: 'Proj', status: 'active' }]);+ storage.getAdminItems.mockResolvedValue([]);+ storage.getPeople.mockResolvedValue([]);+ storage.getInboxLog.mockResolvedValue([]);+ storage.createDigest.mockImplementation(async (data) => ({ id: 'd1', ...data }));+ getProviderById.mockResolvedValue({ id: 'lmstudio', enabled: true, type: 'api', endpoint: 'http://localhost:1234/v1', defaultModel: 'test' });+ runPromptThroughProvider.mockResolvedValue({+ text: JSON.stringify({ digestText: 'd', topActions: ['a'], stuckThing: 's', smallWin: 'w' }),+ runId: 'r', model: 'test'+ });++ await runDailyDigest('lmstudio');++ expect(runPromptThroughProvider).toHaveBeenCalledWith(expect.objectContaining({ toolFree: true, allowFallback: false }));+ });++ it.each([+ ['digest', () => runDailyDigest('codex-tui')],+ ['review', () => runWeeklyReview('codex-tui')]+ ])('refuses a provider without a tool-disable switch for the %s and starts no run', async (_name, run) => {+ storage.getProjects.mockResolvedValue([{ id: 'p1', name: 'Proj', status: 'active' }]);+ storage.getAdminItems.mockResolvedValue([]);+ storage.getPeople.mockResolvedValue([]);+ storage.getInboxLog.mockResolvedValue([{ id: 'i1', capturedAt: new Date().toISOString() }]);+ getProviderById.mockResolvedValue({ id: 'codex-tui', enabled: true, type: 'cli', command: 'unknown-agent', args: [], defaultModel: 'm' });++ await expect(run()).rejects.toMatchObject({ code: 'TOOL_FREE_REQUIRED', message: expect.stringContaining("'codex-tui'") });+ expect(runPromptThroughProvider).not.toHaveBeenCalled();+ });+it('does not clone the provider when headlessArgs is empty/absent', async () => {storage.getProjects.mockResolvedValue([{ id: 'p1', name: 'Proj', status: 'active' }]);storage.getAdminItems.mockResolvedValue([]);diff --git a/server/services/brainScheduler.js b/server/services/brainScheduler.jsindex b956e3456e..891b71912a 100644--- a/server/services/brainScheduler.js+++ b/server/services/brainScheduler.js@@ -9,7 +9,7 @@*/import * as storage from './brainStorage.js';-import { runDailyDigest, runWeeklyReview } from './brain.js';+import { runDailyDigest, runWeeklyReview, TOOL_FREE_REQUIRED } from './brain.js';let schedulerInterval = null;let lastCheckTime = null;@@ -123,6 +123,14 @@ function isWeeklyReviewMissed(settings, now) {/*** Run the scheduler check*/+// A provider that cannot run tool-free is a deliberate policy refusal (the user+// must pick another provider), not a defect, so it stays off stderr.+function logRunFailure(err, label, isCatchUp) {+ const refused = err.code === TOOL_FREE_REQUIRED;+ const log = refused ? console.log : console.error;+ log(`🧠 Scheduler: ${refused ? '🚫 ' : ''}${label} ${refused ? 'skipped' : 'failed'}: ${err.message}${isCatchUp ? ' (retry in 30min)' : ''}`);+}+async function checkSchedule() {const now = new Date();const settings = await storage.loadMeta();@@ -144,7 +152,7 @@ async function checkSchedule() {runDailyDigest().catch(err => {lastDailyFailure = new Date();- console.error(`🧠 Scheduler: ${isCatchUp ? 'Catch-up d' : 'D'}aily digest failed: ${err.message}${isCatchUp ? ' (retry in 30min)' : ''}`);+ logRunFailure(err, `${isCatchUp ? 'Catch-up d' : 'D'}aily digest`, isCatchUp);}).finally(() => { dailyRunning = false; });}@@ -158,7 +166,7 @@ async function checkSchedule() {runWeeklyReview().catch(err => {lastWeeklyFailure = new Date();- console.error(`🧠 Scheduler: ${isCatchUp ? 'Catch-up w' : 'W'}eekly review failed: ${err.message}${isCatchUp ? ' (retry in 30min)' : ''}`);+ logRunFailure(err, `${isCatchUp ? 'Catch-up w' : 'W'}eekly review`, isCatchUp);}).finally(() => { weeklyRunning = false; });}diff --git a/server/services/brainScheduler.test.js b/server/services/brainScheduler.test.jsindex 113e47e0f9..c0122e3d9c 100644--- a/server/services/brainScheduler.test.js+++ b/server/services/brainScheduler.test.js@@ -4,7 +4,7 @@ const loadMeta = vi.hoisted(() => vi.fn());const runDailyDigest = vi.hoisted(() => vi.fn());const runWeeklyReview = vi.hoisted(() => vi.fn());vi.mock('./brainStorage.js', () => ({ loadMeta }));-vi.mock('./brain.js', () => ({ runDailyDigest, runWeeklyReview }));+vi.mock('./brain.js', () => ({ runDailyDigest, runWeeklyReview, TOOL_FREE_REQUIRED: 'TOOL_FREE_REQUIRED' }));const flush = () => vi.advanceTimersByTimeAsync(0);@@ -50,4 +50,17 @@ describe('brainScheduler opt-in', () => {expect(runDailyDigest).toHaveBeenCalledTimes(1);expect(runWeeklyReview).toHaveBeenCalledTimes(1);});++ it('skips a run refused for a tool-capable provider without crashing or logging an error', async () => {+ loadMeta.mockResolvedValue(meta({ scheduledReviewsEnabled: true }));+ const refusal = Object.assign(new Error("Brain provider 'x' cannot run without tools"), { code: 'TOOL_FREE_REQUIRED' });+ runDailyDigest.mockRejectedValue(refusal);+ runWeeklyReview.mockRejectedValue(refusal);+ startBrainScheduler();+ await flush();+ expect(runDailyDigest).toHaveBeenCalledTimes(1);+ expect(runWeeklyReview).toHaveBeenCalledTimes(1);+ expect(console.error).not.toHaveBeenCalled();+ expect(console.log).toHaveBeenCalledWith(expect.stringContaining('skipped'));+ });});