Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: preserve silent audio in FableLoom web exports (#13108)

Adam Eivy7ae1c48fd3d9
diff --git a/server/services/fableLoom/exportMedia.js b/server/services/fableLoom/exportMedia.js
index a0c25c09b2..9bbd5d632b 100644
--- a/server/services/fableLoom/exportMedia.js
+++ b/server/services/fableLoom/exportMedia.js
@@ -94,8 +94,8 @@ const loudness = profile => `loudnorm=I=${profile.integratedLufs}:TP=${profile.t
async function audioFilter(bin, inputArgs, profile, signal) {
const stderr = await encode(bin, ['-v', 'info', ...inputArgs, '-vn', '-af', `${loudness(profile)}:print_format=json`, '-f', 'null', '-'], signal, true);
const measurement = JSON.parse(stderr.slice(stderr.lastIndexOf('{'), stderr.lastIndexOf('}') + 1));
- // Silence has no finite integrated loudness; preserve silence through the same filter.
- if (!Number.isFinite(Number(measurement.input_i))) return loudness(profile);
+ // Applying loudnorm to digital silence can emit non-finite samples into AAC.
+ if (measurement.input_i === '-inf' && measurement.input_tp === '-inf') return null;
const values = ['input_i', 'input_tp', 'input_lra', 'input_thresh', 'target_offset'].map(k => Number(measurement[k]));
if (!values.every(Number.isFinite)) throw refusal('EXPORT_MEDIA_INVALID', 'Audio loudness could not be measured.');
return `${loudness(profile)}:measured_I=${values[0]}:measured_TP=${values[1]}:measured_LRA=${values[2]}:measured_thresh=${values[3]}:offset=${values[4]}:linear=true`;
diff --git a/server/services/fableLoom/exports.test.js b/server/services/fableLoom/exports.test.js
index 1ef31e00a3..16a4ec47b2 100644
--- a/server/services/fableLoom/exports.test.js
+++ b/server/services/fableLoom/exports.test.js
@@ -250,7 +250,16 @@ describe('portable FableLoom export boundary', () => {
});
videoIt('preserves silent soundtracks and clips without audio in web profiles', async () => {
- const silent = await archive(await begin({ episodeIds: ['episode-one'], mediaProfile: 'web-720p' }));
+ const outcomes = [];
+ const realRun = ffmpeg.runFfmpegProcess;
+ vi.spyOn(ffmpeg, 'runFfmpegProcess').mockImplementation(async options => {
+ const result = await realRun(options);
+ outcomes.push({ ok: result.ok, reason: result.reason });
+ return result;
+ });
+ const silentId = await begin({ episodeIds: ['episode-one'], mediaProfile: 'web-720p' });
+ expect((await terminal(silentId)).status, JSON.stringify(outcomes)).toBe('completed');
+ const silent = await archive(silentId);
const silentAssets = JSON.parse(silent.files.get('manifest.json')).loom.episodes[0].nodes[0].playbackAssets;
const output = join(PATHS.videos, 'without-audio.mp4');
expect(await runFfmpegProcess({ bin, timeoutMs: 10_000, args: ['-nostdin', '-y', '-v', 'error',