Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: await MIDI backup admission workflow completion in tests
[._.]/ Adam Eivy7b048c396b0b
diff --git a/server/services/audioMidiTranscription.backupAdmission.test.js b/server/services/audioMidiTranscription.backupAdmission.test.jsindex 5bdbe38356..2fa164802b 100644--- a/server/services/audioMidiTranscription.backupAdmission.test.js+++ b/server/services/audioMidiTranscription.backupAdmission.test.js@@ -9,6 +9,7 @@ import { existsSync } from 'node:fs';import { mkdtemp, readdir, rm, writeFile } from 'node:fs/promises';import { tmpdir } from 'node:os';import { join } from 'node:path';+import { EventEmitter } from 'node:events';vi.mock('../lib/databaseMaintenanceJournal.js', () => ({ assertDatabaseAdmission: () => {} }));vi.mock('../lib/pythonSetup.js', async (importOriginal) => ({@@ -16,6 +17,10 @@ vi.mock('../lib/pythonSetup.js', async (importOriginal) => ({isMuscriptorRuntimeReady: vi.fn(async () => true),resolveMuscriptorPython: vi.fn(() => 'python3'),}));+vi.mock('../lib/fileUtils.js', async importOriginal => {+ const actual = await importOriginal();+ return { ...actual, importFileToDir: vi.fn(actual.importFileToDir) };+});vi.mock('./hfToken.js', () => ({ hfChildEnv: vi.fn(async () => ({})) }));vi.mock('../lib/sidecarProcess.js', () => ({runSidecarProcess: vi.fn(async ({ args }) => {@@ -25,13 +30,33 @@ vi.mock('../lib/sidecarProcess.js', () => ({parseSidecarResult: vi.fn(() => ({ notes: 1 })),}));-const { startMidiTranscription } = await import('./audioMidiTranscription.js');+const { startMidiTranscription, attachMidiTranscriptionSseClient, getActiveMidiTranscriptionJobId } = await import('./audioMidiTranscription.js');+const { importFileToDir } = await import('../lib/fileUtils.js');const { acquireBackupSnapshotCut } = await import('../lib/backupSnapshotBoundary.js');const dirs = [];afterAll(() => Promise.all(dirs.map(dir => rm(dir, { recursive: true, force: true }))));-const settleSeveral = () => new Promise(resolve => setTimeout(resolve, 100));+// Observe the public producer/completion frames rather than assuming host I/O+// has finished within a 100ms sleep or vi.waitFor's default one-second budget.+function observeJob(jobId) {+ const importing = Promise.withResolvers();+ const done = Promise.withResolvers();+ const req = new EventEmitter();+ const res = {+ req, writeHead() {}, end() {},+ write(message) {+ const frame = JSON.parse(message.slice('data: '.length));+ if (frame.stage === 'importing') importing.resolve(frame);+ if (['complete', 'error', 'canceled'].includes(frame.type)) {+ importing.resolve(frame); // an early failure must fail the assertion, not strand it+ done.resolve(frame);+ }+ },+ };+ expect(attachMidiTranscriptionSseClient(jobId, res)).toBe(true);+ return { importing: importing.promise, done: done.promise, close: () => req.emit('close') };+}async function scratch() {const dir = await mkdtemp(join(tmpdir(), 'portos-midi-admission-'));@@ -47,16 +72,24 @@ describe('MIDI transcription backup admission', () => {const { audioPath, destDir } = await scratch();const onComplete = vi.fn(async () => ({}));const release = await acquireBackupSnapshotCut();+ const ownerKey = 'midi-admission-copy';+ let job;try {- await startMidiTranscription({ audioPath, destDir, onComplete });- await settleSeveral();+ const { jobId } = await startMidiTranscription({ audioPath, destDir, onComplete, ownerKey });+ job = observeJob(jobId);+ await expect(job.importing).resolves.toMatchObject({ type: 'progress', stage: 'importing' });+ expect(importFileToDir).not.toHaveBeenCalled();expect(onComplete).not.toHaveBeenCalled();expect(existsSync(destDir) ? await readdir(destDir) : []).toEqual([]);release();- await vi.waitFor(() => expect(onComplete).toHaveBeenCalledOnce());+ await expect(job.done).resolves.toMatchObject({ type: 'complete' });+ expect(onComplete).toHaveBeenCalledOnce();+ expect(getActiveMidiTranscriptionJobId(ownerKey)).toBeNull();expect(await readdir(destDir)).toHaveLength(1);} finally {release();+ await job?.done;+ job?.close();}});@@ -66,25 +99,31 @@ describe('MIDI transcription backup admission', () => {const entered = new Promise(resolve => { enteredRow = resolve; });let finishRow;const rowDone = new Promise(resolve => { finishRow = resolve; });- await startMidiTranscription({- audioPath,+ const ownerKey = 'midi-admission-discard';+ const { jobId } = await startMidiTranscription({+ ownerKey, audioPath,destDir,onComplete: async () => { enteredRow(); await rowDone; return { discarded: true, reason: 'audio source changed' }; },});+ const job = observeJob(jobId);await entered;let cutReady = false;const cut = acquireBackupSnapshotCut().then(release => { cutReady = true; return release; });try {- await settleSeveral();+ await Promise.resolve();expect(cutReady, 'cut acquired while the .mid row was still committing').toBe(false);finishRow();const release = await cut;// The declined file was unlinked inside the lease, so the cut sees neither it nor a row.expect(await readdir(destDir)).toEqual([]);release();+ await expect(job.done).resolves.toMatchObject({ type: 'complete', discarded: true });+ expect(getActiveMidiTranscriptionJobId(ownerKey)).toBeNull();} finally {finishRow();(await cut)();+ await job.done;+ job.close();}});});