Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
feat([issue-12590]): collapse app Issues tab run settings into a summary row
[._.]/ Adam Eivy7b957789f0fc
diff --git a/client/src/components/apps/tabs/IssuesTab.jsx b/client/src/components/apps/tabs/IssuesTab.jsxindex bb565ec4c8..713300a25a 100644--- a/client/src/components/apps/tabs/IssuesTab.jsx+++ b/client/src/components/apps/tabs/IssuesTab.jsx@@ -308,6 +308,11 @@ export default function IssuesTab({ appId, appName }) {&& Array.isArray(reviewOverrides.reviewers)&& !reviewOverrides.reviewers.some(reviewer => reviewer !== 'copilot');const [showReviewOverride, setShowReviewOverride] = useState(false);+ const [showSettings, setShowSettings] = useState(false);+ const runSettingsId = useId();+ // An invalid or active review override must never hide behind the collapsed summary.+ const settingsForcedOpen = invalidReviewOverride || Object.keys(reviewOverrides).length > 0;+ const settingsOpen = showSettings || settingsForcedOpen;useEffect(() => {setReviewOverrides({});setShowReviewOverride(false);@@ -541,6 +546,25 @@ export default function IssuesTab({ appId, appName }) {// authenticated user got told to authenticate.const unavailable = data?.transient === true;+ const reviewerCsv = !claimReviewers || prCompletion !== 'review-then-merge' || invalidReviewOverride ? null+ : Object.keys(reviewOverrides).length+ ? [+ ...(reviewOverrides.reviewers ?? claimReviewers.reviewers),+ ...(reviewOverrides.usernames ?? claimReviewers.usernames ?? []).map(username => `@${username}`),+ ].join(', ')+ : claimReviewers.csv;+ const pickedProvider = picker.providers?.find(p => p.id === picker.selectedProviderId);+ const runSettingsSummary = [+ `Run with: ${[+ pickedProvider?.name || picker.selectedProviderId || 'Auto (default)',+ picker.selectedModel || 'default model',+ picker.effort || 'default effort',+ ].join(' · ')}`,+ `After PR: ${prCompletionOption(prCompletion)?.label ?? prCompletion}`,+ reviewerCsv ? `Reviewers: ${reviewerCsv}` : null,+ overrideContext.trim() ? 'extra context set' : null,+ ].filter(Boolean).join(' · ');+return (<div className="space-y-4"><div className="flex flex-wrap items-center gap-3">@@ -603,6 +627,19 @@ export default function IssuesTab({ appId, appName }) {</button></div>+ {error && (+ <Banner tone="error" size="md" icon={AlertTriangle}>+ Couldn't load issues — {error}+ </Banner>+ )}++ {!error && unavailable && (+ <Banner tone="warning" size="md" icon={AlertTriangle}>+ {data.headline || `Couldn't reach ${forgeLabel}`} ({data.reason})+ {data.remedy ? ` — ${data.remedy}.` : ''}+ </Banner>+ )}+{data?.forge === 'github' && (<div className="flex flex-wrap items-center gap-3 text-xs"><button@@ -659,118 +696,124 @@ export default function IssuesTab({ appId, appName }) {</div>)}- <div className="space-y-3 px-3 py-2 bg-port-card border border-port-border rounded-lg">- <div className="flex flex-col sm:flex-row sm:items-center gap-2">- <span className="flex items-center gap-1.5 text-xs text-gray-500 uppercase tracking-wide shrink-0">- <Bot size={14} /> Run with- </span>- <div className="flex-1">- <ProviderModelSelector- {...picker.selectorProps}- compact- />- </div>- </div>- <div className="flex flex-col sm:flex-row sm:items-center gap-2">- <label htmlFor={prCompletionId} className="flex items-center gap-1.5 text-xs text-gray-500 uppercase tracking-wide shrink-0">- <GitPullRequest size={14} /> After opening PR- </label>- <div className="flex-1 flex flex-wrap items-center gap-2">- <select- id={prCompletionId}- aria-label="After opening PR"- value={prCompletion}- onChange={e => { setPrCompletion(e.target.value); setPrCompletionTouched(true); }}- className="px-2.5 py-1.5 bg-port-bg border border-port-border rounded-lg text-xs text-white focus:border-port-accent focus:outline-hidden"+ <div className="px-3 py-2 bg-port-card border border-port-border rounded-lg space-y-3">+ <div className="flex flex-wrap items-center gap-x-3 gap-y-1">+ <Bot size={14} className="text-gray-500 shrink-0" />+ <span data-testid="run-settings-summary" className="flex-1 min-w-0 text-xs text-gray-300 break-words">{runSettingsSummary}</span>+ {!settingsForcedOpen && (+ <button+ type="button"+ aria-expanded={settingsOpen}+ aria-controls={runSettingsId}+ onClick={() => setShowSettings(value => !value)}+ className="text-xs text-port-accent hover:underline shrink-0">- {PR_COMPLETION_OPTIONS.map(opt => (- <option key={opt.value} value={opt.value}>{opt.label}</option>- ))}- </select>- <span className="text-xs text-gray-500">- {prCompletionOption(prCompletion)?.description}- </span>- </div>+ {settingsOpen ? 'Hide' : 'Change'}+ </button>+ )}</div>- {claimReviewers && prCompletion === 'review-then-merge' && !invalidReviewOverride && (+ {settingsOpen && (+ <div id={runSettingsId} className="space-y-3"><div className="flex flex-col sm:flex-row sm:items-center gap-2"><span className="flex items-center gap-1.5 text-xs text-gray-500 uppercase tracking-wide shrink-0">- <ClipboardCheck size={14} /> Reviewed by+ <Bot size={14} /> Run with</span>- <p className="flex-1 text-xs text-gray-400">- {Object.keys(reviewOverrides).length ? (- <>- <code className="text-gray-300">{[- ...(reviewOverrides.reviewers ?? claimReviewers.reviewers),- ...(reviewOverrides.usernames ?? claimReviewers.usernames ?? []).map(username => `@${username}`),- ].join(', ')}</code>- {' — run override; expand below for model, effort, and round limits.'}- </>- ) : (+ <div className="flex-1">+ <ProviderModelSelector+ {...picker.selectorProps}+ compact+ />+ </div>+ </div>+ <div className="flex flex-col sm:flex-row sm:items-center gap-2">+ <label htmlFor={prCompletionId} className="flex items-center gap-1.5 text-xs text-gray-500 uppercase tracking-wide shrink-0">+ <GitPullRequest size={14} /> After opening PR+ </label>+ <div className="flex-1 flex flex-wrap items-center gap-2">+ <select+ id={prCompletionId}+ aria-label="After opening PR"+ value={prCompletion}+ onChange={e => { setPrCompletion(e.target.value); setPrCompletionTouched(true); }}+ className="px-2.5 py-1.5 bg-port-bg border border-port-border rounded-lg text-xs text-white focus:border-port-accent focus:outline-hidden"+ >+ {PR_COMPLETION_OPTIONS.map(opt => (+ <option key={opt.value} value={opt.value}>{opt.label}</option>+ ))}+ </select>+ <span className="text-xs text-gray-500">+ {prCompletionOption(prCompletion)?.description}+ </span>+ </div>+ </div>+ {claimReviewers && prCompletion === 'review-then-merge' && !invalidReviewOverride && (+ <div className="flex flex-col sm:flex-row sm:items-center gap-2">+ <span className="flex items-center gap-1.5 text-xs text-gray-500 uppercase tracking-wide shrink-0">+ <ClipboardCheck size={14} /> Reviewed by+ </span>+ <p className="flex-1 text-xs text-gray-400">+ {Object.keys(reviewOverrides).length ? (+ <>+ <code className="text-gray-300">{[+ ...(reviewOverrides.reviewers ?? claimReviewers.reviewers),+ ...(reviewOverrides.usernames ?? claimReviewers.usernames ?? []).map(username => `@${username}`),+ ].join(', ')}</code>+ {' — run override; expand below for model, effort, and round limits.'}+ </>+ ) : (+ <>+ <code className="text-gray-300">{claimReviewers.csv}</code>+ <ClaimReviewerSource source={claimReviewers.source} />+ </>+ )}+ </p>+ </div>+ )}+ {claimReviewers && prCompletion === 'review-then-merge' && (+ <div className="space-y-2">+ <button+ type="button"+ aria-expanded={showReviewOverride}+ onClick={() => setShowReviewOverride(value => !value)}+ className="text-sm text-port-accent hover:underline"+ >+ Code-review override{Object.keys(reviewOverrides).length > 0 ? ' (active)' : ''}+ </button>+ {invalidReviewOverride && (+ <p className="text-xs text-port-warning" role="alert">Claims require at least one non-Copilot reviewer. Add one or use configured reviewers.</p>+ )}+ {showReviewOverride && (<>- <code className="text-gray-300">{claimReviewers.csv}</code>- <ClaimReviewerSource source={claimReviewers.source} />+ <ClaimReviewOverride defaults={claimReviewers} overrides={reviewOverrides} onChange={setReviewOverrides} modelOptions={reviewerModelOptions} />+ <p className="text-xs text-gray-500">Applies to Claims launched below. Replan only reviews the issue plan.</p>+ <button type="button" onClick={() => setReviewOverrides({})} className="text-xs text-port-accent hover:underline">+ Use configured reviewers+ </button></>)}+ </div>+ )}+ <div className="space-y-1">+ <label htmlFor={overrideContextId} className="block text-xs text-gray-400">+ Extra context <span className="text-gray-600">(optional)</span>+ </label>+ <textarea+ id={overrideContextId}+ value={overrideContext}+ onChange={e => setOverrideContext(e.target.value)}+ maxLength={4000}+ rows={2}+ placeholder="Add guidance for the run you launch below, such as a preferred implementation focus…"+ className="w-full px-3 py-2 bg-port-bg border border-port-border rounded-lg text-white text-sm placeholder:text-gray-600 focus:border-port-accent focus:outline-hidden resize-y"+ />+ <p className="text-xs text-gray-600">+ Applies to every Claim and Replan you launch below — appended to that run's instructions; blank leaves its prompt unchanged.</p></div>- )}- {claimReviewers && prCompletion === 'review-then-merge' && (- <div className="space-y-2">- <button- type="button"- aria-expanded={showReviewOverride}- onClick={() => setShowReviewOverride(value => !value)}- className="text-sm text-port-accent hover:underline"- >- Code-review override{Object.keys(reviewOverrides).length > 0 ? ' (active)' : ''}- </button>- {invalidReviewOverride && (- <p className="text-xs text-port-warning" role="alert">Claims require at least one non-Copilot reviewer. Add one or use configured reviewers.</p>- )}- {showReviewOverride && (- <>- <ClaimReviewOverride defaults={claimReviewers} overrides={reviewOverrides} onChange={setReviewOverrides} modelOptions={reviewerModelOptions} />- <p className="text-xs text-gray-500">Applies to Claims launched below. Replan only reviews the issue plan.</p>- <button type="button" onClick={() => setReviewOverrides({})} className="text-xs text-port-accent hover:underline">- Use configured reviewers- </button>- </>- )}- </div>- )}- <div className="space-y-1">- <label htmlFor={overrideContextId} className="block text-xs text-gray-400">- Extra context <span className="text-gray-600">(optional)</span>- </label>- <textarea- id={overrideContextId}- value={overrideContext}- onChange={e => setOverrideContext(e.target.value)}- maxLength={4000}- rows={2}- placeholder="Add guidance for the run you launch below, such as a preferred implementation focus…"- className="w-full px-3 py-2 bg-port-bg border border-port-border rounded-lg text-white text-sm placeholder:text-gray-600 focus:border-port-accent focus:outline-hidden resize-y"- />- <p className="text-xs text-gray-600">- Applies to every Claim and Replan you launch below — appended to that run's instructions; blank leaves its prompt unchanged.- </p></div>+ )}</div>- {error && (- <Banner tone="error" size="md" icon={AlertTriangle}>- Couldn't load issues — {error}- </Banner>- )}-- {!error && unavailable && (- <Banner tone="warning" size="md" icon={AlertTriangle}>- {data.headline || `Couldn't reach ${forgeLabel}`} ({data.reason})- {data.remedy ? ` — ${data.remedy}.` : ''}- </Banner>- )}-{!error && !unavailable && total === 0 && (<div className="px-3 py-2 text-sm text-gray-500 bg-port-card border border-port-border rounded-lg">{EMPTY_REASONS[data?.reason] ?? EMPTY_REASONS['no-open-issues']}diff --git a/client/src/components/apps/tabs/IssuesTab.test.jsx b/client/src/components/apps/tabs/IssuesTab.test.jsxindex f828aa48f1..0446ac9c12 100644--- a/client/src/components/apps/tabs/IssuesTab.test.jsx+++ b/client/src/components/apps/tabs/IssuesTab.test.jsx@@ -68,13 +68,17 @@ const okPayload = (issues) => ({remedy: null,});-const renderTab = async () => {+const renderTab = async ({ open = false } = {}) => {const result = render(<MemoryRouter><IssuesTab appId="app-1" appName="Widget" /></MemoryRouter>);await act(async () => {});+ if (open) {+ fireEvent.click(screen.getByRole('button', { name: 'Change' }));+ await act(async () => {});+ }return result;};@@ -326,7 +330,7 @@ describe('IssuesTab', () => {reviewerMaxRounds: {}, reviewerModels: {}, reviewerEfforts: {}, csv: 'codex,claude',});- await renderTab();+ await renderTab({ open: true });expect(await screen.findByText('codex,claude')).toBeInTheDocument();expect(screen.getByText(/claim-work/)).toBeInTheDocument();@@ -334,7 +338,7 @@ describe('IssuesTab', () => {});it('points at the Code Reviewers panel when no override is in play', async () => {- await renderTab();+ await renderTab({ open: true });expect(await screen.findByText('antigravity')).toBeInTheDocument();expect(screen.queryByText(/claim-work/)).not.toBeInTheDocument();@@ -358,7 +362,7 @@ describe('IssuesTab', () => {providers: [{ id: 'codex', name: 'Codex', type: 'cli', command: 'codex', enabled: true,models: ['gpt-5'], defaultModel: 'gpt-5', effort: 'high' }],});- await renderTab();+ await renderTab({ open: true });await screen.findByText('Crash on save');await waitFor(() => expect(screen.getByLabelText('Provider')).toHaveValue('codex'));expect(screen.getByLabelText('Model')).toHaveValue('gpt-5');@@ -377,7 +381,7 @@ describe('IssuesTab', () => {models: ['claude-opus-5', 'claude-sonnet-5'], defaultModel: 'claude-sonnet-5',}],});- await renderTab();+ await renderTab({ open: true });await screen.findByText('Crash on save');fireEvent.change(await screen.findByLabelText('Provider'), { target: { value: 'claude' } });@@ -404,7 +408,7 @@ describe('IssuesTab', () => {});it('sends a reviewer effort override without pinning untouched defaults', async () => {- await renderTab();+ await renderTab({ open: true });fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));fireEvent.change(await screen.findByLabelText('Reasoning effort for Antigravity'), { target: { value: 'high' } });fireEvent.click(screen.getByRole('button', { name: /Claim/ }));@@ -417,7 +421,7 @@ describe('IssuesTab', () => {});it('blocks an empty claim review chain, leaves replans alone, and restores inheritance', async () => {- await renderTab();+ await renderTab({ open: true });fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));fireEvent.click(await screen.findByRole('button', { name: /Remove Antigravity/i }));expect(screen.getByRole('button', { name: /Claim/ })).toBeDisabled();@@ -431,8 +435,51 @@ describe('IssuesTab', () => {expect(screen.getByRole('button', { name: /Claim/ })).toBeEnabled();});+ it('collapses run settings into a truthful summary that Change expands', async () => {+ await renderTab();++ const summary = screen.getByTestId('run-settings-summary');+ expect(summary).toHaveTextContent(/^Run with: Auto \(default\) · default model · default effort · After PR: .+ · Reviewers: antigravity$/);+ expect(screen.queryByLabelText('Provider')).not.toBeInTheDocument();+ const change = screen.getByRole('button', { name: 'Change' });+ expect(change).toHaveAttribute('aria-expanded', 'false');++ fireEvent.click(change);+ await act(async () => {});+ expect(screen.getByRole('button', { name: 'Hide' })).toHaveAttribute('aria-expanded', 'true');+ fireEvent.change(screen.getByLabelText(/Extra context/), { target: { value: 'Keep it small.' } });+ expect(summary).toHaveTextContent(/· extra context set$/);+ });++ it('keeps an invalid review override visible by forcing the settings open', async () => {+ await renderTab({ open: true });+ fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));+ fireEvent.click(await screen.findByRole('button', { name: /Remove Antigravity/i }));++ expect(screen.getByRole('alert')).toHaveTextContent('Claims require at least one non-Copilot reviewer');+ expect(screen.queryByRole('button', { name: 'Hide' })).not.toBeInTheDocument();+ });++ it('opens the settings automatically once a code-review override is active', async () => {+ await renderTab({ open: true });+ fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));+ fireEvent.change(await screen.findByLabelText('Reasoning effort for Antigravity'), { target: { value: 'high' } });++ expect(screen.queryByRole('button', { name: 'Hide' })).not.toBeInTheDocument();+ expect(screen.getByRole('button', { name: 'Code-review override (active)' })).toBeInTheDocument();+ });++ it('shows a failed issues load above the run settings', async () => {+ api.getAppIssues.mockRejectedValue(new Error('forge down'));+ await renderTab();++ const banner = await screen.findByText(/Couldn.t load issues — forge down/);+ const summary = screen.getByTestId('run-settings-summary');+ expect(banner.compareDocumentPosition(summary) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();+ });+it('clears review overrides when switching apps', async () => {- const view = await renderTab();+ const view = await renderTab({ open: true });fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));fireEvent.change(await screen.findByLabelText('Reasoning effort for Antigravity'), { target: { value: 'high' } });view.rerender(<MemoryRouter><IssuesTab appId="app-2" appName="Other" /></MemoryRouter>);@@ -444,7 +491,7 @@ describe('IssuesTab', () => {});it('sends optional override context with the selected claim', async () => {- await renderTab();+ await renderTab({ open: true });await screen.findByText('Crash on save');fireEvent.change(screen.getByLabelText(/Extra context/), {@@ -970,7 +1017,7 @@ describe('IssuesTab replan', () => {});it('allows selecting merge-on-green, hides reviewer controls, and sends prCompletion', async () => {- await renderTab();+ await renderTab({ open: true });expect(await screen.findByText('Reviewed by')).toBeInTheDocument();expect(screen.getByRole('button', { name: 'Code-review override' })).toBeInTheDocument();@@ -989,7 +1036,7 @@ describe('IssuesTab replan', () => {});it('unblocks claim when switching to merge-on-green even after removing all reviewers', async () => {- await renderTab();+ await renderTab({ open: true });fireEvent.click(await screen.findByRole('button', { name: 'Code-review override' }));fireEvent.click(await screen.findByRole('button', { name: /Remove Antigravity/i }));