Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: retain precise provider quota diagnostics (#12568)

[._.]/ Adam Eivy7fa111d4efab
diff --git a/server/services/codeReview.js b/server/services/codeReview.js
index 8468aa6b16..dbc82fb235 100644
--- a/server/services/codeReview.js
+++ b/server/services/codeReview.js
@@ -61,7 +61,7 @@ import { activeReviewerGroupIndex, isReviewerConfigFault, reviewerCommandPermiss
import { getSettings, updateSettingsWith, settingsEvents } from './settings.js'
export const REVIEWER_PAUSE_MS = 24 * 60 * 60 * 1000
-const QUOTA_FAILURE = /quota|rate.?limit|usage.?limit|too many requests|\b(?:HTTP|status|code|error)\W{0,3}(?:429|402)\b|payment required|limit for the day|daily.?limit|session.?limit|plan.?limit|free.?limit|free.?tier|FreeTierError|err_free_used|allowance is used up|is used up|top up your balance|wallet billing|out of credits|insufficient.?(?:credits|funds|balance)|exceeded (?:your )?(?:daily |current )?(?:quota|limit|allowance)|upgrade (?:your )?subscription|Upgrade to Pro/i
+const QUOTA_FAILURE = /quota|rate.?limit|usage.?limit|too many requests|\b(?:HTTP(?:\/[\d.]+)?|status[_ ]?code|status|code|error)\W{0,3}(?:429|402)\b|payment required|limit for the day|daily.?limit|session.?limit|plan.?limit|free.?limit|free.?tier|FreeTierError|err_free_used|allowance is used up|is used up|top up your balance|wallet billing|out of credits|credit balance (?:is )?too low|insufficient.?(?:credits|funds|balance)|exceeded (?:your )?(?:daily |current )?(?:quota|limit|allowance)|upgrade (?:your )?subscription|Upgrade to Pro/i
function isReviewerQuotaFailure(error) {
if (!error) return false
@@ -73,6 +73,7 @@ function isReviewerQuotaFailure(error) {
if (isReviewerQuotaFailure(error.error)) return true
}
}
+ // Model-authored text/output cannot establish the provider's quota state.
const message = typeof error === 'object'
? `${error.error || ''} ${error.message || ''} ${error.code || ''} ${error.stderr || ''}`
: String(error)
diff --git a/server/services/codeReview.test.js b/server/services/codeReview.test.js
index 04fb5ad6a7..0baaa3bf7e 100644
--- a/server/services/codeReview.test.js
+++ b/server/services/codeReview.test.js
@@ -41,6 +41,7 @@ vi.mock('./ollamaManager.js', () => ({
const commandExistsMock = { impl: async () => true }
vi.mock('../lib/commandExists.js', () => ({ commandExists: (...args) => commandExistsMock.impl(...args) }))
+// Vitest 5 clears mock call histories before each case by default.
vi.mock('./providerStatus.js', () => ({
markProviderUsageLimit: vi.fn(),
markProviderUnavailable: vi.fn(),
@@ -483,7 +484,7 @@ describe('codeReview helpers', () => {
it.each([
{ error: 'Reviewer stopped after a 4290-byte diff' },
{ message: 'Reviewer stopped after a 4020-byte diff' },
- { error: 'The reviewer process exhausted its memory capacity and credit allowance' },
+ { error: 'The reviewer process exhausted its memory capacity and credit allowance: resource exhausted' },
{ error: 'Reviewer process failed', text: 'Review: credit, capacity, quota and rate limit handling changed' },
{ error: 'Reviewer process failed', output: 'HTTP 429: out of credits' },
])('keeps non-quota failures transient despite byte counts or model prose: %j', async (failure) => {
@@ -518,7 +519,11 @@ describe('codeReview helpers', () => {
it.each([
{ error: 'HTTP 429' },
+ { error: 'HTTP/1.1 429' },
+ { error: 'Your credit balance is too low' },
{ message: 'status 402' },
+ { stderr: 'statusCode: 429' },
+ { stderr: 'status_code=402' },
{ stderr: '429 Too Many Requests' },
{ error: 'insufficient_quota' },
{ error: "You've hit your usage limit" },