Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: reject invalid CoS task collection selectors
Adam Eivy8396a0929a3d
diff --git a/server/lib/cosValidation.js b/server/lib/cosValidation.jsindex 4247d9bcd7..75045287c0 100644--- a/server/lib/cosValidation.js+++ b/server/lib/cosValidation.js@@ -195,6 +195,9 @@ const taskStatusInputSchema = z.preprocess(z.enum(TASK_STATUS_VALUES).optional());+export const cosTaskTypeSchema = z.enum(['user', 'internal']);+export const cosTaskDeleteQuerySchema = z.object({ type: cosTaskTypeSchema.default('user') });+// The metadata-bound fields below are carried onto the task by// `services/cosTaskIntake.js#buildTaskMetadata`; its test fails when a field is// added here without a mapping there (or an explicit non-metadata verdict).@@ -216,7 +219,7 @@ export const createCosTaskSchema = z.object({thinking: z.boolean().optional(),app: z.string().optional(),targetInstanceId: targetInstanceIdInputSchema,- type: z.string().optional().default('user'),+ type: cosTaskTypeSchema.default('user'),approvalRequired: z.boolean().optional(),screenshots: z.array(z.string()).optional(),attachments: z.array(cosTaskAttachmentSchema).optional(),@@ -358,7 +361,7 @@ export const updateCosTaskSchema = z.object({app: z.string().optional(),targetInstanceId: targetInstanceIdUpdateSchema,blockedReason: z.string().optional(),- type: z.string().optional().default('user'),+ type: cosTaskTypeSchema.default('user'),});// Worker's dispute of a reviewer rejection (#2441). `reason` is the requireddiff --git a/server/routeValidationConventions.test.js b/server/routeValidationConventions.test.jsindex 78294e92c1..f521db2389 100644--- a/server/routeValidationConventions.test.js+++ b/server/routeValidationConventions.test.js@@ -230,7 +230,6 @@ const UNVALIDATED_QUERY_BASELINE = ['routes/cosLearningRoutes.js GET /digest/compare','routes/cosLearningRoutes.js GET /learning/insights','routes/cosScheduleRoutes.js GET /upcoming',- 'routes/cosTaskRoutes.js DELETE /tasks/:id','routes/cosTemplateRoutes.js GET /templates/popular','routes/cosWorkflowRoutes.js GET /workflow','routes/creativeCommissions.js GET /',diff --git a/server/routes/cosTaskRoutes.js b/server/routes/cosTaskRoutes.jsindex 7446a14ffa..1c607efb15 100644--- a/server/routes/cosTaskRoutes.js+++ b/server/routes/cosTaskRoutes.js@@ -30,6 +30,7 @@ import {goalFidelityFalsePositiveSchema,validateRequest,cosTaskReorderBodySchema,+ cosTaskDeleteQuerySchema,isPaginationRequested,parsePagination,} from '../lib/validation.js';@@ -550,7 +551,7 @@ router.put('/tasks/:id', asyncHandler(async (req, res) => {// DELETE /api/cos/tasks/:id - Delete a taskrouter.delete('/tasks/:id', asyncHandler(async (req, res) => {const { id } = req.params;- const { type = 'user' } = req.query;+ const { type } = validateRequest(cosTaskDeleteQuerySchema, req.query);// Read the description BEFORE the delete: once the row is gone the ledger's// only handle on what was thrown away would be an opaque task id.diff --git a/server/routes/cosTaskRoutes.test.js b/server/routes/cosTaskRoutes.test.jsindex 1cb158425b..f329320fb9 100644--- a/server/routes/cosTaskRoutes.test.js+++ b/server/routes/cosTaskRoutes.test.js@@ -116,6 +116,35 @@ beforeEach(() => {});});+describe('CoS task collection selectors', () => {+ it.each([+ ['post', '/api/cos/tasks', { description: 'Example task', type: 'cos' }],+ ['put', '/api/cos/tasks/sys-example', { description: 'Changed task', type: 'cos' }],+ ['delete', '/api/cos/tasks/sys-example?type=cos', undefined],+ ['delete', '/api/cos/tasks/sys-example?type=user&type=internal', undefined],+ ])('rejects an invalid selector on %s %s before mutation', async (method, url, body) => {+ const res = await request(buildApp())[method](url).send(body);++ expect(res.status).toBe(400);+ expect(res.body.code).toBe('VALIDATION_ERROR');+ expect(cos.addTask).not.toHaveBeenCalled();+ expect(cos.updateTask).not.toHaveBeenCalled();+ expect(cos.deleteTask).not.toHaveBeenCalled();+ expect(cos.getTaskById).not.toHaveBeenCalled();+ expect(await listUserActions()).toEqual([]);+ });++ it('deletes from the explicitly selected internal collection', async () => {+ cos.getTaskById.mockResolvedValue({ id: 'sys-example', description: 'Example task' });+ cos.deleteTask.mockResolvedValue({ success: true, taskId: 'sys-example' });++ const res = await request(buildApp()).delete('/api/cos/tasks/sys-example?type=internal');++ expect(res.status).toBe(200);+ expect(cos.deleteTask).toHaveBeenCalledWith('sys-example', 'internal');+ });+});+describe('POST /api/cos/tasks — targetInstanceId (#4520)', () => {it('passes a registry-known pin through to addTask', async () => {const res = await request(buildApp())diff --git a/server/services/cosTaskStore.js b/server/services/cosTaskStore.jsindex fef41285cb..acef90301a 100644--- a/server/services/cosTaskStore.js+++ b/server/services/cosTaskStore.js@@ -23,7 +23,7 @@ import { atomicWrite } from '../lib/fileUtils.js';import { existsSync } from 'fs';import { join } from 'path';import { parseTasksMarkdown, groupTasksByStatus, getAutoApprovedTasks, getAwaitingApprovalTasks, generateTasksMarkdown, hasKnownPrefix, toRepresentableTask, PRIORITY_VALUES } from '../lib/taskParser.js';-import { MAX_TOTAL_SPAWNS } from '../lib/validation.js';+import { MAX_TOTAL_SPAWNS, cosTaskTypeSchema, validateRequest } from '../lib/validation.js';import { RETRY_HOLD_KEY, RETRY_HOLD_SINCE_KEY, isRetryHeld } from '../lib/taskRetryHold.js';import { resolveTaskTargetBranch, shouldStripTaskTargetBranch } from '../lib/taskTargetBranch.js';import { AGENT_PAUSED_CATEGORY, PAUSE_METADATA_KEYS, isAgentPausedTask, resolvePausedTaskResume, retirePausedAgent } from '../lib/taskPauseHold.js';@@ -468,6 +468,7 @@ export async function getTaskById(taskId) {* consumers, but the normal scheduler must not race that dispatch.*/export async function addTask(taskData, taskType = 'user', { raw = false, ignoreTaskId = null, now = Date.now(), suppressDequeue = false } = {}) {+ validateRequest(cosTaskTypeSchema, taskType);if (!raw && taskData.metadata) taskData = { ...taskData, metadata: newAuditMetadata(taskData.metadata) };return withStateLock(async () => {const state = await loadState();@@ -638,6 +639,7 @@ export async function addTask(taskData, taskType = 'user', { raw = false, ignore* returns `{ statusChanged: true }` without writing or retiring pause state.*/export async function updateTask(taskId, updates, taskType = 'user', { now = Date.now(), suppressDequeue = false, expectedStatus = null, expectedMetadata = null } = {}) {+ validateRequest(cosTaskTypeSchema, taskType);const release = await preparePauseRelease(taskId, updates);const result = await writeTaskUpdate(taskId, release ? { ...updates, metadata: release.metadata } : updates, taskType, { now, suppressDequeue, expectedStatus, expectedMetadata });if (release && !result?.error && !result?.statusChanged) {@@ -976,6 +978,7 @@ export async function reviveBlockedTask(taskId, { priority, metadata } = {}, tas* @returns {Promise<{ changed: boolean, count?: number }>}*/export async function mergePeerTasks(taskType, remoteTasks, { now = Date.now() } = {}) {+ validateRequest(cosTaskTypeSchema, taskType);const { changed, count, merged } = await withStateLock(async () => {const state = await loadState();const filePath = taskType === 'user'@@ -1029,6 +1032,7 @@ export async function mergePeerTasks(taskType, remoteTasks, { now = Date.now() }* Delete a task*/export async function deleteTask(taskId, taskType = 'user') {+ validateRequest(cosTaskTypeSchema, taskType);return withStateLock(async () => {const state = await loadState();const filePath = taskType === 'user'diff --git a/server/services/cosTaskStore.test.js b/server/services/cosTaskStore.test.jsindex 09f0102267..f600613a93 100644--- a/server/services/cosTaskStore.test.js+++ b/server/services/cosTaskStore.test.js@@ -1970,6 +1970,25 @@ describe('cosTaskStore.updateTask', () => {});});+describe('cosTaskStore collection selection', () => {+ it.each([+ ['add', () => addTask({ description: 'Unexpected task' }, 'cos')],+ ['update', () => updateTask('sys-example', { description: 'Unexpected edit' }, 'cos')],+ ['delete', () => deleteTask('sys-example', ['user', 'internal'])],+ ['merge', () => mergePeerTasks('cos', [{ id: 'sys-example', description: 'Unexpected peer edit' }])],+ ])('rejects an invalid %s selector without changing either task file', async (_name, mutate) => {+ await addTask({ description: 'User task', id: 'task-example' });+ await addTask({ description: 'Internal task', id: 'sys-example', approvalRequired: true }, 'internal');+ const before = new Map(mock.files);+ mock.events = [];++ await expect(mutate()).rejects.toMatchObject({ status: 400, code: 'VALIDATION_ERROR' });++ expect(mock.files).toEqual(before);+ expect(mock.events).toEqual([]);+ });+});+describe('cosTaskStore.deleteTask', () => {it('removes the task and emits tasks:changed deleted', async () => {const created = await addTask({ description: 'del', id: 'task-del' }, 'user');