Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: emit agent:completed for agents finalized by the zombie sweep (#11766)
Adam Eivy8a691e5a476c
diff --git a/server/services/cosAgentLifecycle.js b/server/services/cosAgentLifecycle.jsindex 2f64f7bb5c..dece6f5a85 100644--- a/server/services/cosAgentLifecycle.js+++ b/server/services/cosAgentLifecycle.js@@ -682,7 +682,12 @@ export async function cleanupZombieAgents() {.map((row) => [row.id, row]),);- return withBackupAssetPublication(() => withStateLock(async () => {+ // Finalized records, emitted as `agent:completed` once the lock and archive+ // pass are done (same ordering as completeAgent) so listeners that re-read+ // state see them finished.+ const finalized = [];++ const summary = await withBackupAssetPublication(() => withStateLock(async () => {const state = await loadState();const runningAgents = Object.values(state.agents).filter(a => a.status === 'running');const cleaned = [];@@ -776,6 +781,7 @@ export async function cleanupZombieAgents() {}await recordArchivedAgentOrder(archived);await saveAgentIndex();+ finalized.push(...cleaned.map(agentId => state.agents[agentId]));console.log(`🧹 Cleaned up ${cleaned.length} zombie agents: ${cleaned.join(', ')}`);cosEvents.emit('agents:changed', { action: 'zombie-cleanup', cleaned });@@ -783,6 +789,17 @@ export async function cleanupZombieAgents() {return { cleaned, count: cleaned.length };}));++ // Every `agent:completed` consumer (feature-agent pointer release, task+ // settlement/dequeue, maintenance and quota-burn step advancement, learning)+ // keys off this event, so a zombie-finalized run must fire it too (#11766).+ // The sweep can't route through completeAgent: it batches one lock/archive+ // pass, and completeAgent's duplicate guard would see these as already done.+ for (const agent of finalized) {+ cosEvents.emit('agent:completed', agent);+ }++ return summary;}// Delete a single agent from state and diskdiff --git a/server/services/cosAgentLifecycle.test.js b/server/services/cosAgentLifecycle.test.jsindex 8aaa6d6230..2fea48cfbd 100644--- a/server/services/cosAgentLifecycle.test.js+++ b/server/services/cosAgentLifecycle.test.js@@ -867,6 +867,74 @@ describe('cleanupZombieAgents — runner listing is not proof of life', () => {expect(mockCosState.state.agents['agent-stale'].status).toBe('completed');expect(mockCosState.state.agents['agent-stale'].result.error).toMatch(/terminated unexpectedly/);});++ describe('agent:completed emission (#11766)', () => {+ const completedEvents = [];+ const onCompleted = (agent) => completedEvents.push(agent);++ beforeEach(() => {+ completedEvents.length = 0;+ cosEvents.on('agent:completed', onCompleted);+ });++ afterEach(() => {+ cosEvents.off('agent:completed', onCompleted);+ });++ it('emits exactly one agent:completed for a reaped zombie, and none on a second sweep', async () => {+ await writeFile(join(mockCosState.agentsDir, 'index.json'), '{}');+ mockCosState.state.agents['agent-dead'] = {+ id: 'agent-dead',+ taskId: 'task-dead',+ status: 'running',+ pid: 2147483646,+ startedAt: new Date(Date.now() - 60_000).toISOString(),+ metadata: { taskType: 'scheduled' },+ };+ // Listeners that re-read state must already see the finalized record.+ let statusSeenByListener;+ cosEvents.once('agent:completed', () => {+ statusSeenByListener = mockCosState.state.agents['agent-dead'].status;+ });++ expect((await cleanupZombieAgents()).cleaned).toEqual(['agent-dead']);++ expect(statusSeenByListener).toBe('completed');+ expect(completedEvents).toHaveLength(1);+ expect(completedEvents[0]).toMatchObject({+ id: 'agent-dead',+ taskId: 'task-dead',+ metadata: { taskType: 'scheduled' },+ result: { success: false },+ });++ expect((await cleanupZombieAgents()).cleaned).toEqual([]);+ expect(completedEvents).toHaveLength(1);+ });++ it('emits nothing for live, dispatching or runner-shielded records', async () => {+ mockCosState.state.agents['agent-owned'] = {+ id: 'agent-owned', status: 'running', pid: 2147483646,+ startedAt: new Date(Date.now() - 60_000).toISOString(),+ };+ activeAgents.set('agent-owned', {});+ mockCosState.state.agents['agent-spawning'] = {+ id: 'agent-spawning', taskId: 'task-spawning', status: 'running',+ startedAt: new Date(Date.now() - 5 * 60_000).toISOString(),+ };+ spawningTasks.add('task-spawning');+ mockCosState.state.agents['agent-tui'] = {+ id: 'agent-tui', status: 'running', pid: 0,+ startedAt: new Date(Date.now() - 60_000).toISOString(),+ };+ vi.mocked(getActiveAgentsFromRunner).mockResolvedValue([{+ id: 'agent-tui', pid: 0, kind: 'tui', processActive: true, liveness: 'pty',+ }]);++ expect((await cleanupZombieAgents()).cleaned).toEqual([]);+ expect(completedEvents).toEqual([]);+ });+ });});describe('deleteAgent directory cleanup (#11446)', () => {