Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

test: retain film-look screenshot failure diagnostics (#12153)

Adam Eivy8bc2a13ce32e
diff --git a/server/lib/filmLookGpu.browser.test.js b/server/lib/filmLookGpu.browser.test.js
index 86195d4b7e..54381eae71 100644
--- a/server/lib/filmLookGpu.browser.test.js
+++ b/server/lib/filmLookGpu.browser.test.js
@@ -13,6 +13,7 @@ import { join } from 'node:path';
import { chromium } from 'playwright-core';
import sharp from 'sharp';
import { startOwnedBrowserFixture } from '../test/browserFixture.js';
+import { _withTestPreviewLoadDiagnostics } from '../services/musicVideo/testPreviewLoadDiagnostics.js';
import { browserSuiteCanRun } from './browserSuiteGate.js';
import { FILM_LOOK_CONTROLS, FILM_LOOK_PRESETS, filmLookFilterMarkup, filmLookPreset, normalizeFilmLook } from './filmLook.js';
import { filmLookGpuRuntimeSource } from './filmLookGpu.js';
@@ -162,7 +163,8 @@ describe.skipIf(!canRun).each([
document.documentElement.style.filter = css;
}, { filter, css });
await gpu.evaluate(({ look, w, h }) => globalThis.primaryRenderer.render(document.getElementById('v'), look, { frame: 0, width: w, height: h }), { look, w, h });
- const reference = await sharp(await svg.screenshot()).removeAlpha().raw().toBuffer();
+ const reference = await sharp(await _withTestPreviewLoadDiagnostics(svg, () => svg.screenshot(),
+ { phase: 'film-look-reference-screenshot' })).removeAlpha().raw().toBuffer();
const finished = await sharp(await gpu.screenshot()).removeAlpha().raw().toBuffer();
expect(psnr(reference, finished)).toBeGreaterThanOrEqual(40);
} finally {
diff --git a/server/services/musicVideo/testPreviewLoadDiagnostics.js b/server/services/musicVideo/testPreviewLoadDiagnostics.js
index 89e753c50e..c04b7296f1 100644
--- a/server/services/musicVideo/testPreviewLoadDiagnostics.js
+++ b/server/services/musicVideo/testPreviewLoadDiagnostics.js
@@ -11,6 +11,7 @@ const PROCESS_SAMPLE_MS = 250;
const PROCESS_PROBE_MS = 1000;
const DEADLINE = Symbol('deadline');
const SAMPLED_PROCESS_TYPES = new Set(['browser', 'renderer', 'GPU']);
+const PHASES = new Set(['load', 'composition-readiness', 'film-look-reference-screenshot']);
const count = value => Number.isInteger(value) && value >= 0 ? Math.min(value, LIMIT) : 'unavailable';
const flag = value => typeof value === 'boolean' ? value : 'unavailable';
const percent = value => Number.isFinite(value) ? Math.min(Math.max(Math.round(value), 0), 10 * LIMIT) : 'unavailable';
@@ -103,7 +104,7 @@ function hostLoadPerCpu() {
return Number.isFinite(perCpu) ? Math.min(Math.round(perCpu * 100) / 100, LIMIT) : 'unavailable';
}
-export async function _withTestPreviewLoadDiagnostics(page, load) {
+export async function _withTestPreviewLoadDiagnostics(page, operation, { phase: initialPhase = 'load' } = {}) {
const started = Date.now();
const facts = { domContentLoaded: false, load: false, crashed: false, closed: false,
scriptRequested: 0, scriptFinished: 0, scriptFailed: 0,
@@ -124,11 +125,12 @@ export async function _withTestPreviewLoadDiagnostics(page, load) {
pageerror: error => increment(error.name === 'TypeError' ? 'typeError' : error.name === 'SyntaxError' ? 'syntaxError' : 'otherError'),
};
for (const [event, listener] of Object.entries(events)) page.on(event, listener);
- let phase = 'load';
+ // Caller phases are fixed vocabulary, never paths or document-derived text.
+ let phase = PHASES.has(initialPhase) ? initialPhase : 'unavailable';
try {
// The caller keeps its existing Playwright load and semantic deadlines.
// Observations never replace load with a weaker lifecycle event.
- await load(() => { phase = 'composition-readiness'; });
+ return await operation(() => { phase = 'composition-readiness'; });
} catch (error) {
const failure = { phase, elapsedMs: Math.min(Date.now() - started, 3600000), ...facts,
pageClosed: page.isClosed(), browserConnected: page.context().browser()?.isConnected() ?? false,
diff --git a/server/services/musicVideo/testPreviewLoadDiagnostics.test.js b/server/services/musicVideo/testPreviewLoadDiagnostics.test.js
index 8d302c7cb1..98595254e2 100644
--- a/server/services/musicVideo/testPreviewLoadDiagnostics.test.js
+++ b/server/services/musicVideo/testPreviewLoadDiagnostics.test.js
@@ -111,4 +111,30 @@ describe('preview load failure evidence', () => {
expect(session.send).not.toHaveBeenCalled();
expect(page.eventNames()).toEqual([]);
});
+
+ it('returns screenshot bytes unchanged without failure probes or retained observers', async () => {
+ const { session, browser } = browserSession(async () => ({}));
+ const page = fixture(undefined, browser);
+ const bytes = Buffer.from([137, 80, 78, 71]);
+ await expect(_withTestPreviewLoadDiagnostics(page, async () => bytes,
+ { phase: 'film-look-reference-screenshot' })).resolves.toBe(bytes);
+ expect(page.evaluate).not.toHaveBeenCalled();
+ expect(session.send).not.toHaveBeenCalled();
+ expect(page.eventNames()).toEqual([]);
+ });
+
+ it.each(['film-look-reference-screenshot', '/private/phase-sentinel'])('retains only an allowlisted screenshot phase (%s) before cleanup', async phase => {
+ vi.useFakeTimers();
+ const { browser } = browserSession(() => new Promise(() => {}));
+ const page = fixture(vi.fn(() => new Promise(() => {})), browser);
+ const failure = new Error('screenshot deadline');
+ const checked = expect(_withTestPreviewLoadDiagnostics(page, async () => { throw failure; }, { phase })).rejects.toBe(failure);
+ await vi.advanceTimersByTimeAsync(1000);
+ await checked;
+ expect(snapshot(failure)).toMatchObject({ phase: phase.startsWith('/') ? 'unavailable' : phase,
+ pageClosed: false, browserConnected: true, documentProbe: 'deadline', processProbe: 'deadline' });
+ expect(failure.message).not.toContain('phase-sentinel');
+ expect(page.eventNames()).toEqual([]);
+ expect(vi.getTimerCount()).toBe(0);
+ });
});