Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: Review Hub all-clear leads with pending stored items and folds a stale briefing (#13005) (#13054)
[._.]/8ef2bc716243
diff --git a/client/src/pages/Review.jsx b/client/src/pages/Review.jsxindex 32cd407088..90dbccb033 100644--- a/client/src/pages/Review.jsx+++ b/client/src/pages/Review.jsx@@ -43,7 +43,7 @@ import useUrlParams from '../hooks/useUrlParams';import useAsyncAction from '../hooks/useAsyncAction';import useEscapeKey from '../hooks/useEscapeKey';import useFocusTrap from '../hooks/useFocusTrap';-import { timeAgo, formatDateTime, formatCount, localDateKey } from '../utils/formatters';+import { timeAgo, formatDateTime, formatCount, formatDateShort, localDateKey } from '../utils/formatters';import { markdownToPlainText, dropsMarkupWhenFlattened } from '../utils/markdownText';import { useActionQueue } from '../hooks/useActionQueue';import * as api from '../services/api';@@ -86,6 +86,9 @@ const TYPE_CONFIG = {briefing: { label: 'Briefing', icon: FileText, color: 'text-gray-400' }};+// A briefing generated within a day is news; older ones are history context.+const BRIEFING_FRESH_MS = 24 * 60 * 60 * 1000;+const TYPE_PRIORITY = { alert: 0, cos: 1, todo: 2, briefing: 3 };const ACTION_VIEWS = [@@ -395,6 +398,11 @@ export default function Review() {const showLegacyReviewSurface = queue && !queueError && queueItems.length === 0 && queueSourceErrors.length === 0 && !queue.partial;const pendingItems = useMemo(() => items.filter(i => i.status === 'pending'), [items]);+ const showBriefing = showLegacyReviewSurface && briefing && briefing.source !== 'none';+ const briefingIsFresh = Boolean(showBriefing) && Date.now() - new Date(briefing.generatedAt).getTime() < BRIEFING_FRESH_MS;+ const historySummary = showBriefing+ ? `Daily briefing · ${formatDateShort(briefing.generatedAt)} · history counts`+ : 'Stored review history counts';const genericCompletableCount = pendingItems.filter(isGenericCompletableItem).length;const actionableItems = useMemo(() => pendingItems@@ -415,6 +423,51 @@ export default function Review() {const pendingCount = pendingItems.length;const remainingActionCount = Math.max(0, actionableItems.length - topActionItems.length);+ // One named disclosure for history: stored counts plus the daily briefing. A+ // briefing older than a day is context, not news, so it starts closed. Rendered+ // below stored items on the all-clear surface so pending work leads.+ const historyDisclosure = (+ <details open={briefingIsFresh}>+ <summary className="text-xs text-port-text-muted">{historySummary}</summary>+ <section className="flex flex-wrap gap-2 mt-2">+ <SummaryPill icon={BellRing} label="Pending" value={counts?.total ?? 0} tone="text-white" />+ <SummaryPill icon={AlertTriangle} label="Alerts" value={counts?.alert ?? 0} tone="text-port-warning" urgent={(counts?.alert ?? 0) > 0} />+ <SummaryPill icon={Crown} label="CoS" value={counts?.cos ?? 0} tone="text-port-accent" />+ <SummaryPill icon={ClipboardList} label="Todos" value={counts?.todo ?? 0} tone="text-port-success" />+ </section>+ {showBriefing && (+ <section+ ref={briefingRef}+ role={briefingFullscreen ? 'dialog' : undefined}+ aria-modal={briefingFullscreen ? 'true' : undefined}+ aria-label={briefingFullscreen ? 'Daily Briefing' : undefined}+ className={`bg-port-card border border-port-border rounded-xl p-4 ${briefingFullscreen ? 'fixed inset-0 z-50 overflow-y-auto m-0 rounded-none' : 'mt-2'}`}>+ <div className="flex items-center justify-between gap-2 mb-2">+ <h2 className="text-sm font-semibold text-white flex items-center gap-2">+ <FileText size={16} className="text-gray-400" />+ Daily Briefing+ </h2>+ <div className="flex items-center gap-2">+ <span className="text-[11px] text-gray-400">+ {briefing.source} · {formatDateTime(briefing.generatedAt)}+ </span>+ <button+ onClick={() => setBriefingFullscreen(prev => !prev)}+ className="min-h-[44px] min-w-[44px] inline-flex items-center justify-center p-1 text-gray-500 hover:text-white transition-colors rounded-md hover:bg-white/5"+ title={briefingFullscreen ? 'Exit fullscreen' : 'Fullscreen'} aria-label={briefingFullscreen ? 'Exit fullscreen' : 'Fullscreen'}+ >+ {briefingFullscreen ? <Minimize2 size={14} /> : <Maximize2 size={14} />}+ </button>+ </div>+ </div>+ <div className={`text-gray-400 text-sm overflow-y-auto ${briefingFullscreen ? '' : 'max-h-[32rem]'}`}>+ <MarkdownOutput content={briefing.content} />+ </div>+ </section>+ )}+ </details>+ );+return (<div className="flex flex-col h-full min-h-0"><PageHeader@@ -435,19 +488,18 @@ export default function Review() {<div role="tabpanel" id={`actions-view-${actionView}`} aria-labelledby={`tab-${actionView}`} className="space-y-3">{/* Triage summary */}<section className="flex flex-wrap gap-2">- {queue && <span className="text-sm text-port-text">{queue.partial || queueError ? 'At least ' : ''}{formatCount(queueItems.filter(item => item.required === true).length)} required</span>}+ {queue && showLegacyReviewSurface && (+ <span className="text-sm text-port-text">+ <span className="font-medium text-port-success">Nothing needs you today</span>+ {' · '}0 required+ {pendingCount > 0 && <> · {formatCount(pendingCount)} stored item{pendingCount !== 1 ? 's' : ''} still pending</>}+ </span>+ )}+ {queue && !showLegacyReviewSurface && <span className="text-sm text-port-text">{queue.partial || queueError ? 'At least ' : ''}{formatCount(queueItems.filter(item => item.required === true).length)} required</span>}{queueLoading && !queue && <span role="status">Loading actions…</span>}{queueError && <span role="alert">Actions unavailable{queue ? ' — showing last known actions' : ''}. <button onClick={fetchQueue}>Retry</button></span>}</section>- <details>- <summary className="text-xs text-port-text-muted">Stored review history counts</summary>- <section className="flex flex-wrap gap-2">- <SummaryPill icon={BellRing} label="Pending" value={counts?.total ?? 0} tone="text-white" />- <SummaryPill icon={AlertTriangle} label="Alerts" value={counts?.alert ?? 0} tone="text-port-warning" urgent={(counts?.alert ?? 0) > 0} />- <SummaryPill icon={Crown} label="CoS" value={counts?.cos ?? 0} tone="text-port-accent" />- <SummaryPill icon={ClipboardList} label="Todos" value={counts?.todo ?? 0} tone="text-port-success" />- </section>- </details>+ {!showLegacyReviewSurface && historyDisclosure}{/* Canonical Actions queue — live-pulled from Brain commitments, manualtodos, Ask, CoS, Messages, Health, and Backups. Shown whenever there@@ -542,17 +594,17 @@ export default function Review() {<buttononClick={handleCompleteAll}className="px-3 py-2 text-sm bg-port-success/10 hover:bg-port-success/20 border border-port-success/30 rounded-lg text-port-success transition-colors"- title="Mark all general pending items as completed"+ title={`Mark ${genericCompletableCount} general pending item${genericCompletableCount !== 1 ? 's' : ''} as completed`}>- Complete All+ Complete all {formatCount(genericCompletableCount)}</button>)}<buttononClick={handleMarkAllRead}className="px-3 py-2 text-sm bg-port-border/50 hover:bg-port-border rounded-lg text-gray-300 transition-colors"- title="Dismiss all pending items"+ title={`Dismiss ${pendingCount} pending item${pendingCount !== 1 ? 's' : ''}`}>- Dismiss All+ Dismiss all {formatCount(pendingCount)} pending</button></>)}@@ -606,38 +658,6 @@ export default function Review() {</p>)}- {/* Daily Briefing remains available as compatibility/history context. */}- {showLegacyReviewSurface && briefing && briefing.source !== 'none' && (- <section- ref={briefingRef}- role={briefingFullscreen ? 'dialog' : undefined}- aria-modal={briefingFullscreen ? 'true' : undefined}- aria-label={briefingFullscreen ? 'Daily Briefing' : undefined}- className={`bg-port-card border border-port-border rounded-xl p-4 ${briefingFullscreen ? 'fixed inset-0 z-50 overflow-y-auto m-0 rounded-none' : ''}`}>- <div className="flex items-center justify-between gap-2 mb-2">- <h2 className="text-sm font-semibold text-white flex items-center gap-2">- <FileText size={16} className="text-gray-400" />- Daily Briefing- </h2>- <div className="flex items-center gap-2">- <span className="text-[11px] text-gray-400">- {briefing.source} · {formatDateTime(briefing.generatedAt)}- </span>- <button- onClick={() => setBriefingFullscreen(prev => !prev)}- className="min-h-[44px] min-w-[44px] inline-flex items-center justify-center p-1 text-gray-500 hover:text-white transition-colors rounded-md hover:bg-white/5"- title={briefingFullscreen ? 'Exit fullscreen' : 'Fullscreen'} aria-label={briefingFullscreen ? 'Exit fullscreen' : 'Fullscreen'}- >- {briefingFullscreen ? <Minimize2 size={14} /> : <Maximize2 size={14} />}- </button>- </div>- </div>- <div className={`text-gray-400 text-sm overflow-y-auto ${briefingFullscreen ? '' : 'max-h-[32rem]'}`}>- <MarkdownOutput content={briefing.content} />- </div>- </section>- )}-{/* Detailed sections — tiled two-up on wide screens so the per-typequeues use the full width instead of stacking in one column. */}{showLegacyReviewSurface && <div className="grid grid-cols-1 lg:grid-cols-2 gap-3 items-start">@@ -684,6 +704,7 @@ export default function Review() {<p className="text-sm mt-1">This hub will fill up as agents surface alerts, actions, and briefing context.</p></div>)}+ {showLegacyReviewSurface && historyDisclosure}</div></div><ActionDetaildiff --git a/client/src/pages/Review.test.jsx b/client/src/pages/Review.test.jsxindex 7650664320..a220ebf900 100644--- a/client/src/pages/Review.test.jsx+++ b/client/src/pages/Review.test.jsx@@ -448,8 +448,8 @@ describe('Actions commitments workspace (#7739)', () => {const heading = await screen.findByRole('heading', { name: 'Stored review items' });const section = heading.closest('section');expect(section).toContainElement(screen.getByLabelText('Filter review items by status'));- expect(section).toContainElement(screen.getByRole('button', { name: 'Complete All' }));- expect(section).toContainElement(screen.getByRole('button', { name: 'Dismiss All' }));+ expect(section).toContainElement(screen.getByRole('button', { name: 'Complete all 1' }));+ expect(section).toContainElement(screen.getByRole('button', { name: 'Dismiss all 2 pending' }));});it('hides stored-item controls when the canonical queue is degraded or partial', async () => {@@ -741,6 +741,45 @@ describe('Review Hub triage summary (#6926)', () => {});});+describe('Review Hub all-clear Today tab (#13005)', () => {+ const historyDisclosure = () => screen.getByText(/Daily briefing ·/).closest('details');++ it('states the all-clear and shows the pending stored items ahead of a stale briefing', async () => {+ api.getReviewItems.mockResolvedValueOnce([SHORT_ITEM]);+ api.getReviewBriefing.mockResolvedValueOnce({ source: 'test', generatedAt: '2026-04-05T12:00:00Z', content: 'Old briefing body' });+ render(<Review />);++ expect(await screen.findByText('Nothing needs you today')).toBeInTheDocument();+ expect(screen.getByText(/1 stored item still pending/)).toBeInTheDocument();+ const item = (await screen.findAllByText(SHORT_ITEM.title))[0];+ const details = historyDisclosure();+ expect(details).not.toHaveAttribute('open');+ expect(details).toHaveTextContent('Apr 5, 2026');+ // The pending item renders before the collapsed briefing in document order.+ expect(item.compareDocumentPosition(details) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();+ expect(screen.getByRole('button', { name: 'Dismiss all 1 pending' })).toBeInTheDocument();+ });++ it('opens the briefing automatically when it was generated within the last day', async () => {+ api.getReviewBriefing.mockResolvedValueOnce({ source: 'test', generatedAt: new Date().toISOString(), content: 'Fresh briefing body' });+ render(<Review />);++ await screen.findByText('Fresh briefing body');+ await waitFor(() => expect(historyDisclosure()).toHaveAttribute('open'));+ });++ it('keeps the all-clear line off a non-empty canonical queue', async () => {+ api.getReviewQueue.mockResolvedValueOnce({ partial: false, sources: {}, items: [{+ id: 'health:example', source: 'health', sourceLabel: 'Health anomalies', title: 'Required health action',+ summary: 'x', required: true, operations: [{ id: 'complete', label: 'Mark resolved', available: true }],+ }] });+ render(<Review />);++ expect(await screen.findByText('1 required')).toBeInTheDocument();+ expect(screen.queryByText('Nothing needs you today')).not.toBeInTheDocument();+ });+});+describe('Review Hub Daily Briefing fullscreen dialog (#9121)', () => {it('acts as a focus-trapped, Escape-dismissable dialog and returns focus to the toggle', async () => {api.getReviewBriefing.mockResolvedValueOnce({ source: 'test', generatedAt: '2026-09-29T00:00:00Z', content: 'Briefing body' });