Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: keep the command palette open when a palette action request fails
[._.]/ Adam Eivy9134fad93a45
diff --git a/client/src/components/CmdKSearch.jsx b/client/src/components/CmdKSearch.jsxindex 6946241645..ad53689c65 100644--- a/client/src/components/CmdKSearch.jsx+++ b/client/src/components/CmdKSearch.jsx@@ -383,7 +383,12 @@ export default function CmdKSearch() {toast(`${item.label} needs arguments — use voice or open the related page.`);return;}- const res = await runPaletteAction(item.id);+ // request() already toasts the failure centrally; a rejection here+ // must neither bubble as unhandled nor raise a second toast. The+ // palette stays open with the query intact so the user can retry or+ // pick another command — mirrors the capture and layout branches.+ const res = await runPaletteAction(item.id).then((result) => result, () => null);+ if (!res) { inputRef.current?.focus(); return; }const summary = res?.result?.summary || `${item.label} ran.`;if (res?.ok === false) toast.error(summary);else toast.success(summary);diff --git a/client/src/components/CmdKSearch.test.jsx b/client/src/components/CmdKSearch.test.jsxindex 6db72f3f31..b41a59d16a 100644--- a/client/src/components/CmdKSearch.test.jsx+++ b/client/src/components/CmdKSearch.test.jsx@@ -259,6 +259,48 @@ describe('CmdKSearch inline Brain capture', () => {});});+describe('CmdKSearch action dispatch', () => {+ const TIME_NOW = { id: 'time_now', label: 'What time is it', section: 'Tools', description: '', aliases: [], keywords: [], parameters: { type: 'object', required: [], properties: {} } };++ const renderActionPalette = async () => {+ getPaletteManifest.mockResolvedValue({ nav: [], actions: [TIME_NOW] });+ render(+ <MemoryRouter>+ <CmdKSearch />+ </MemoryRouter>,+ );+ fireEvent.keyDown(document, { key: 'k', metaKey: true });+ await screen.findByRole('dialog', { name: 'Command palette' });+ const input = screen.getByRole('combobox', { name: 'Command palette' });+ fireEvent.change(input, { target: { value: 'time' } });+ await screen.findByRole('option', { name: /What time is it/ });+ return input;+ };++ it('keeps the palette open with the query intact when an action request rejects', async () => {+ // request() toasts the failure centrally, so the component raises no+ // second toast and the rejection must not escape as unhandled.+ runPaletteAction.mockRejectedValue(new Error('boom'));+ const input = await renderActionPalette();+ fireEvent.keyDown(input, { key: 'Enter' });+ await waitFor(() => expect(runPaletteAction).toHaveBeenCalledWith('time_now'));+ await act(async () => {});+ expect(screen.getByRole('dialog', { name: 'Command palette' })).toBeInTheDocument();+ expect(input).toHaveValue('time');+ expect(input).toHaveFocus();+ expect(toast.error).not.toHaveBeenCalled();+ expect(toast.success).not.toHaveBeenCalled();+ });++ it('toasts the summary and closes when an action resolves', async () => {+ runPaletteAction.mockResolvedValue({ ok: true, result: { summary: 'It is noon.' } });+ const input = await renderActionPalette();+ fireEvent.keyDown(input, { key: 'Enter' });+ await waitFor(() => expect(toast.success).toHaveBeenCalledWith('It is noon.'));+ await waitFor(() => expect(screen.queryByRole('dialog', { name: 'Command palette' })).toBeNull());+ });+});+describe('CmdKSearch dialog accessibility', () => {it('keeps the active option stable through filtering and executes the indicated destination', async () => {render(