Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
fix: validate query params on health latest metrics and epigenetic routes (#11767)
[._.]/ Adam Eivy93698e5b363d
diff --git a/server/lib/appleHealthValidation.js b/server/lib/appleHealthValidation.jsindex 81c6d4165b..c068e77495 100644--- a/server/lib/appleHealthValidation.js+++ b/server/lib/appleHealthValidation.js@@ -49,3 +49,8 @@ export const healthIngestSchema = z.object({workouts: z.array(z.unknown()).default([])}).passthrough()});++// Repeated keys (?metrics=a&metrics=b) parse to an array; z.string() refuses them with a 400.+export const appleHealthLatestMetricsQuerySchema = z.object({+ metrics: z.string().max(2000).optional()+});diff --git a/server/lib/genomeValidation.js b/server/lib/genomeValidation.jsindex c25ca33a75..b2ecf8e380 100644--- a/server/lib/genomeValidation.js+++ b/server/lib/genomeValidation.js@@ -57,3 +57,11 @@ export const epigeneticUpdateInterventionSchema = z.object({notes: z.string().max(5000).optional(),active: z.boolean().optional()});++export const epigeneticRecommendationsQuerySchema = z.object({+ categories: z.string().max(1000).optional()+});++export const epigeneticComplianceQuerySchema = z.object({+ days: z.coerce.number().int().min(1).max(3650).default(30)+});diff --git a/server/routes/appleHealth.js b/server/routes/appleHealth.jsindex a211bd09d4..014ee89387 100644--- a/server/routes/appleHealth.js+++ b/server/routes/appleHealth.js@@ -6,7 +6,7 @@ import { uploadSingle } from '../lib/multipart.js';import { parseZip, collectZipEntry } from '../lib/zipStream.js';import { asyncHandler, ServerError } from '../lib/errorHandler.js';import { validateRequest } from '../lib/validation.js';-import { healthIngestSchema } from '../lib/appleHealthValidation.js';+import { healthIngestSchema, appleHealthLatestMetricsQuerySchema } from '../lib/appleHealthValidation.js';import { ingestHealthData } from '../services/appleHealthIngest.js';import { importAppleHealthXml } from '../services/appleHealthXml.js';import { importClinicalRecords } from '../services/appleHealthClinical.js';@@ -64,7 +64,8 @@ router.get('/metrics/available', asyncHandler(async (req, res) => {// GET /api/health/metrics/latest// Returns most recent recorded value for each requested metricrouter.get('/metrics/latest', asyncHandler(async (req, res) => {- const metrics = req.query.metrics?.split(',').filter(Boolean) ?? [];+ const query = validateRequest(appleHealthLatestMetricsQuerySchema, req.query);+ const metrics = query.metrics?.split(',').filter(Boolean) ?? [];if (metrics.length === 0) return res.json({});const latest = await getLatestMetricValues(metrics);res.json(latest);diff --git a/server/routes/appleHealth.test.js b/server/routes/appleHealth.test.jsindex 96cbf081f6..07cbe56c0c 100644--- a/server/routes/appleHealth.test.js+++ b/server/routes/appleHealth.test.js@@ -23,6 +23,11 @@ vi.mock('../services/appleHealthXml.js', () => ({return { days: 1, records: 2 };}),}));+vi.mock('../services/appleHealthQuery.js', () => ({+ getMetricSummary: vi.fn(), getDailyAggregates: vi.fn(), getAvailableDateRange: vi.fn(),+ getCorrelationData: vi.fn(), getAvailableMetrics: vi.fn(),+ getLatestMetricValues: vi.fn(async () => ({ step_count: 1 })),+}));vi.mock('../services/appleHealthClinical.js', () => ({importClinicalRecords: vi.fn(async () => ({ imported: 0 })),}));@@ -94,3 +99,16 @@ describe('POST /api/health/import/xml — ZIP extraction temp dir', () => {expect(imports.paths).toHaveLength(0);});});++describe('GET /api/health/metrics/latest query validation', () => {+ it('accepts a comma-separated metrics list and refuses repeated keys with 400', async () => {+ const { getLatestMetricValues } = await import('../services/appleHealthQuery.js');+ const ok = await request(buildApp()).get('/api/health/metrics/latest?metrics=step_count,heart_rate');+ expect(ok.status).toBe(200);+ expect(getLatestMetricValues).toHaveBeenCalledWith(['step_count', 'heart_rate']);++ const repeated = await request(buildApp()).get('/api/health/metrics/latest?metrics=step_count&metrics=heart_rate');+ expect(repeated.status).toBe(400);+ expect(repeated.body.code).toBe('VALIDATION_ERROR');+ });+});diff --git a/server/routes/genome.js b/server/routes/genome.jsindex 3865f0b827..73dd6f42d9 100644--- a/server/routes/genome.js+++ b/server/routes/genome.js@@ -12,7 +12,9 @@ import {genomeUpdateNotesSchema,epigeneticAddInterventionSchema,epigeneticLogEntrySchema,- epigeneticUpdateInterventionSchema+ epigeneticUpdateInterventionSchema,+ epigeneticRecommendationsQuerySchema,+ epigeneticComplianceQuerySchema} from '../lib/genomeValidation.js';const router = Router();@@ -156,14 +158,15 @@ router.get('/epigenetic', asyncHandler(async (req, res) => {// GET /api/meatspace/genome/epigenetic/recommendations — Get curated recommendationsrouter.get('/epigenetic/recommendations', asyncHandler(async (req, res) => {- const categories = req.query.categories ? req.query.categories.split(',') : [];+ const { categories: raw } = validateRequest(epigeneticRecommendationsQuerySchema, req.query);+ const categories = raw ? raw.split(',') : [];const recommendations = epigeneticService.getRecommendations(categories);res.json({ recommendations });}));// GET /api/meatspace/genome/epigenetic/compliance — Get compliance summaryrouter.get('/epigenetic/compliance', asyncHandler(async (req, res) => {- const days = parseInt(req.query.days, 10) || 30;+ const { days } = validateRequest(epigeneticComplianceQuerySchema, req.query);const summary = await epigeneticService.getComplianceSummary(days);res.json(summary);}));diff --git a/server/routes/genome.test.js b/server/routes/genome.test.jsindex c5a3f4ab59..761a2c32a8 100644--- a/server/routes/genome.test.js+++ b/server/routes/genome.test.js@@ -14,6 +14,8 @@ vi.mock('../services/clinvar.js', () => ({}));vi.mock('../services/epigenetic.js', () => ({+ getRecommendations: vi.fn(() => [{ id: 'r1' }]),+ getComplianceSummary: vi.fn(async () => ({ days: 30 })),logEntry: vi.fn(async () => ({id: 'log-1',date: '2026-09-11',@@ -26,7 +28,7 @@ vi.mock('../services/epigenetic.js', () => ({const { deleteGenome } = await import('../services/genome.js');const { deleteClinvar, syncClinvar } = await import('../services/clinvar.js');-const { logEntry } = await import('../services/epigenetic.js');+const { logEntry, getRecommendations, getComplianceSummary } = await import('../services/epigenetic.js');const { default: genomeRoutes } = await import('./genome.js');const makeApp = () => {@@ -121,3 +123,32 @@ describe('ClinVar sync progress', () => {expect(syncClinvar).not.toHaveBeenCalled();});});++describe('GET epigenetic query validation', () => {+ beforeEach(() => {+ vi.clearAllMocks();+ });++ it('splits a single categories value and refuses repeated keys with 400', async () => {+ const ok = await request(makeApp()).get('/api/meatspace/genome/epigenetic/recommendations?categories=a,b');+ expect(ok.status).toBe(200);+ expect(getRecommendations).toHaveBeenCalledWith(['a', 'b']);++ const repeated = await request(makeApp()).get('/api/meatspace/genome/epigenetic/recommendations?categories=a&categories=b');+ expect(repeated.status).toBe(400);+ expect(repeated.body.code).toBe('VALIDATION_ERROR');+ });++ it('defaults compliance days to 30 and refuses out-of-range or non-integer days', async () => {+ const ok = await request(makeApp()).get('/api/meatspace/genome/epigenetic/compliance');+ expect(ok.status).toBe(200);+ expect(getComplianceSummary).toHaveBeenCalledWith(30);++ for (const days of ['-5', '0', '999999999', 'abc', '1.5']) {+ const res = await request(makeApp()).get(`/api/meatspace/genome/epigenetic/compliance?days=${days}`);+ expect(res.status, days).toBe(400);+ expect(res.body.code).toBe('VALIDATION_ERROR');+ }+ expect(getComplianceSummary).toHaveBeenCalledTimes(1);+ });+});