Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: keep approving a deleted memory a 404 and cover the idempotent reject route

[._.]/ Adam Eivy9aeefd675da2
diff --git a/server/routes/memory.js b/server/routes/memory.js
index c4dc5f7523..59156c6c98 100644
--- a/server/routes/memory.js
+++ b/server/routes/memory.js
@@ -241,7 +241,7 @@ router.post('/:id/reject', asyncHandler(async (req, res) => {
// Rejecting a memory that is already gone is the desired end state.
if (!result.success && result.error === 'Memory not found') return res.json({ success: true, alreadyResolved: true });
if (!result.success) {
- throw new ServerError(result.error, { status: result.error === 'Memory not found' ? 404 : 400 });
+ throw new ServerError(result.error, { status: 400 });
}
res.json(result);
}));
diff --git a/server/routes/memory.test.js b/server/routes/memory.test.js
index c4370952df..e57da80fda 100644
--- a/server/routes/memory.test.js
+++ b/server/routes/memory.test.js
@@ -562,3 +562,16 @@ describe('Memory version API', () => {
expect(embeddings.generateMemoryEmbedding).not.toHaveBeenCalled();
});
});
+
+describe('Memory reject API', () => {
+ it('treats rejecting an already-deleted memory as success', async () => {
+ const memoryService = await import('../services/memory.js');
+ const app = express();
+ app.use(express.json());
+ app.use('/api/memory', memoryRoutes);
+ memoryService.rejectMemory.mockResolvedValue({ success: false, error: 'Memory not found' });
+ const response = await request(app).post('/api/memory/gone-1/reject').send({});
+ expect(response.status).toBe(200);
+ expect(response.body).toMatchObject({ success: true, alreadyResolved: true });
+ });
+});
diff --git a/server/services/reviewQueue.js b/server/services/reviewQueue.js
index 8ee558a46f..d7582d0025 100644
--- a/server/services/reviewQueue.js
+++ b/server/services/reviewQueue.js
@@ -1108,17 +1108,17 @@ async function resolveMemoryAction(id, operation) {
if (result?.success === false || result?.error) {
const notFound = /not found/i.test(String(result.error || ''));
if (notFound) {
- // The memory is already gone (deleted elsewhere); the user's intent is
- // satisfied, so retire the stale queue projection instead of erroring.
+ // The memory is already gone, so its queue projections are stale either way.
await reviewService.dismissByReferenceId(id).catch((err) => {
console.error(`⚠️ Review queue: stale memory projection cleanup failed: ${err.message}`);
});
await notifications.removeByMetadata('memoryId', id).catch(() => {});
- return { success: true, alreadyResolved: true };
+ // Rejecting a deleted memory is the desired end state; approving one is not.
+ if (operation === 'reject') return { success: true, alreadyResolved: true };
}
throw new ServerError(result.error || `Memory ${operation} failed`, {
- status: 409,
- code: 'CONFLICT',
+ status: notFound ? 404 : 409,
+ code: notFound ? 'NOT_FOUND' : 'CONFLICT',
});
}
return result;
diff --git a/server/services/reviewQueue.test.js b/server/services/reviewQueue.test.js
index 8c48a5ca58..cbc7f2d8ed 100644
--- a/server/services/reviewQueue.test.js
+++ b/server/services/reviewQueue.test.js
@@ -1351,6 +1351,14 @@ describe('reviewQueue.resolveQueueItem', () => {
expect(notifications.removeByMetadata).toHaveBeenCalledWith('memoryId', 'gone-1');
});
+ it('keeps approving an already-deleted memory a 404 while still clearing its stale rows', async () => {
+ memoryService.approveMemory.mockResolvedValue({ success: false, error: 'Memory not found' });
+ reviewService.dismissByReferenceId.mockResolvedValue(undefined);
+ notifications.removeByMetadata.mockResolvedValue(undefined);
+ await expect(resolveQueueItem('memory:gone-2', 'approve')).rejects.toMatchObject({ status: 404 });
+ expect(reviewService.dismissByReferenceId).toHaveBeenCalledWith('gone-2');
+ });
+
it('dispatches draft rows to approveDraft', async () => {
messageDrafts.approveDraft.mockResolvedValue({ id: 'd1', status: 'approved' });
await resolveQueueItem('drafts:d1');