Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: keep media settings usable on short phone screens (#10689)

Adam Eivya2c2c6911f57
diff --git a/client/src/components/media/MediaLightbox.browser.test.js b/client/src/components/media/MediaLightbox.browser.test.js
index 3ba0caf5c6..9a8921178e 100644
--- a/client/src/components/media/MediaLightbox.browser.test.js
+++ b/client/src/components/media/MediaLightbox.browser.test.js
@@ -60,6 +60,11 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
import { createRoot } from 'react-dom/client';
import MediaLightbox from '/src/components/media/MediaLightbox.jsx';
import '/src/index.css';
+ import { getTheme } from '/src/themes/portosThemes.js';
+ const theme = getTheme(new URLSearchParams(location.search).get('theme') || 'classic-midnight');
+ for (const [key, value] of Object.entries({ ...theme.colors, ...theme.tokens })) document.documentElement.style.setProperty(key, value);
+ document.documentElement.dataset.portTheme = theme.id;
+ document.documentElement.dataset.portThemeFamily = theme.family;
const canvas = document.createElement('canvas');
canvas.width = 640; canvas.height = 360;
const ctx = canvas.getContext('2d');
@@ -87,8 +92,9 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
function Fixture() {
const [item, setItem] = useState(null);
const [index, setIndex] = useState(0);
- const video = { key: 'video:synthetic', kind: 'video', filename: 'synthetic.webm', downloadUrl: clip };
- const images = [0, 1].map(i => ({ key: 'image:synthetic-' + i, kind: 'image', filename: 'synthetic-' + i + '.png', previewUrl: image, prompt: 'Synthetic image ' + i }));
+ const video = { id: 'synthetic', key: 'video:synthetic', kind: 'video', filename: 'synthetic.webm', downloadUrl: clip, previewUrl: image, prompt: 'Synthetic video' };
+ const images = [0, 1].map(i => ({ key: 'image:synthetic-' + i, kind: 'image', filename: 'synthetic-' + i + '.png', previewUrl: image, prompt: 'Synthetic image ' + i, width: 1600, height: 900, model: 'Synthetic model', seed: 123 }));
+ const noop = async () => {};
const showImage = i => { setIndex(i); setItem(images[i]); };
return React.createElement(React.Fragment, null,
React.createElement('button', { id: 'opener', onClick: () => setItem(video) }, 'Open video'),
@@ -96,7 +102,11 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
React.createElement(MediaLightbox, { item, onClose: () => setItem(null),
hasPrevious: item?.kind === 'image' && index > 0,
hasNext: item?.kind === 'image' && index < 1,
- onPrevious: () => showImage(index - 1), onNext: () => showImage(index + 1) })
+ onPrevious: () => showImage(index - 1), onNext: () => showImage(index + 1),
+ onPromptChange: noop, onAnnotationChange: noop, annotation: { note: 'Synthetic note' },
+ onRemix: noop, onSendToImage: noop, onSendToVideo: noop, onSendTo3d: noop,
+ onClean: noop, onRegenerate: noop, regenAvailable: true, onRemoveWatermark: noop,
+ onRefine: noop, onPromptFrom: noop, onContinue: noop, onPosterChange: noop })
);
}
createRoot(document.getElementById('root')).render(React.createElement(Fixture));
@@ -126,7 +136,7 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
await page.waitForFunction(() => document.querySelector('video')?.readyState >= 2);
await video.evaluate(v => { v.pause(); v.currentTime = 0; });
if (fullScreen) await page.getByRole('button', { name: 'Full screen', exact: true }).click();
- const close = page.getByRole('button', { name: 'Close', description: 'Close (Esc)', exact: true });
+ const close = page.locator('button[title="Close (Esc)"]');
await close.focus();
await page.keyboard.press('Tab');
expect(await video.evaluate(v => v === document.activeElement)).toBe(true);
@@ -195,7 +205,7 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
await page.getByRole('img', { name: 'Synthetic image 1', exact: true }).waitFor();
await page.getByRole('button', { name: 'Previous media' }).click();
await page.getByRole('img', { name: 'Synthetic image 0', exact: true }).waitFor();
- const close = page.getByRole('button', { name: 'Close', description: 'Close (Esc)', exact: true });
+ const close = page.locator('button[title="Close (Esc)"]');
await close.focus();
await page.keyboard.press('Tab');
expect(await page.getByRole('button', { name: 'Full screen', exact: true }).evaluate(el => el === document.activeElement)).toBe(true);
@@ -210,4 +220,55 @@ describe.skipIf(!chrome)('MediaLightbox native video keyboard controls', () => {
await page.close();
}
}, 60000);
+ // This catches footer-induced body collapse using real CSS rectangles, not
+ // class names. All media and callbacks are synthetic and requests intercepted.
+ it.each(['classic-midnight', 'kestrel-neon'])('keeps settings and image/video actions reachable in %s', async theme => {
+ for (const [width, height] of [[360, 640], [390, 667], [360, 800], [768, 1024], [1440, 900]]) {
+ const page = await browser.newPage({ viewport: { width, height } });
+ try {
+ await page.route('**/api/**', route => route.fulfill({ json: { providers: [], items: [] } }));
+ await page.goto(`${origin}lightbox-test?theme=${theme}`);
+ for (const opener of ['#gallery', '#opener']) {
+ await page.locator(opener).click();
+ const aside = page.locator('aside');
+ const prompt = aside.locator('#media-prompt');
+ await prompt.fill('Synthetic multiline prompt\nSecond invented line\nThird invented line');
+ const scroll = aside.locator('header + div');
+ const roomy = width >= 640 && height >= 800;
+ const body = roomy ? scroll.locator(':scope > div') : scroll;
+ const bounds = await body.boundingBox();
+ expect(bounds.height, `${width}x${height} editing region`).toBeGreaterThan(120);
+ const header = await aside.locator('header').boundingBox();
+ const assertReachable = async locator => {
+ await locator.evaluate(el => el.scrollIntoView({ block: 'center', inline: 'nearest' }));
+ const rect = await locator.boundingBox();
+ const viewport = await body.boundingBox();
+ // Roomy footers sit outside the body scroller by design.
+ if (!(roomy && await locator.evaluate(el => !!el.closest('footer')))) {
+ expect(rect.y).toBeGreaterThanOrEqual(viewport.y - 1);
+ expect(rect.y + rect.height).toBeLessThanOrEqual(viewport.y + viewport.height + 1);
+ }
+ const close = await aside.getByRole('button', { name: 'Close', exact: true }).boundingBox();
+ expect(close.y).toBeGreaterThanOrEqual(0);
+ expect(close.y + close.height).toBeLessThanOrEqual(height);
+ expect((await aside.locator('header').boundingBox()).y).toBeCloseTo(header.y);
+ const card = await aside.evaluate(el => el.parentElement.getBoundingClientRect().toJSON());
+ expect(card.y).toBeGreaterThanOrEqual(0);
+ expect(card.bottom).toBeLessThanOrEqual(height);
+ };
+ await assertReachable(prompt);
+ await assertReachable(aside.getByRole('button', { name: 'Save prompt' }));
+ await assertReachable(aside.getByRole('textbox', { name: 'Note' }));
+ for (const control of await aside.locator('footer button, footer a').all()) await assertReachable(control);
+ if (!roomy) expect(await scroll.evaluate(el => el.scrollHeight > el.clientHeight)).toBe(true);
+ // Pointer overlap from gallery arrows is tracked independently in #10690.
+ await page.keyboard.press('Escape');
+ await page.getByRole('dialog').waitFor({ state: 'detached' });
+ }
+ } finally {
+ await page.close();
+ }
+ }
+ }, 60000);
+
});
diff --git a/client/src/components/media/MediaLightbox.jsx b/client/src/components/media/MediaLightbox.jsx
index 64060d5023..a523d13d91 100644
--- a/client/src/components/media/MediaLightbox.jsx
+++ b/client/src/components/media/MediaLightbox.jsx
@@ -296,9 +296,9 @@ export default function MediaLightbox({
const cardClasses = fullScreen
? 'relative w-full h-full bg-black flex'
- : 'relative bg-port-card border border-port-border rounded-xl overflow-hidden max-w-6xl w-full max-h-[92vh] flex flex-col md:flex-row';
+ : 'relative bg-port-card border border-port-border rounded-xl overflow-hidden max-w-6xl w-full max-h-dvh-cap [--dvh-cap:92vh] [--dvh-cap-dynamic:92dvh] [--dvh-inset:2rem] flex flex-col md:flex-row';
const overlayPad = fullScreen ? 'p-0' : 'p-4';
- const imgMax = fullScreen ? 'max-w-[100vw] max-h-dvh-cap' : 'max-w-full max-h-[92vh]';
+ const imgMax = fullScreen ? 'max-w-[100vw] max-h-dvh-cap' : 'max-w-full max-h-dvh-cap [--dvh-cap:92vh] [--dvh-cap-dynamic:92dvh] [--dvh-inset:2rem]';
// Anchor low in fullscreen so the chevrons land in the letterbox bar of a
// landscape image instead of covering it. Non-fullscreen keeps them centered
// — bottom-anchoring would bury them in the SettingsPane underneath.
@@ -500,7 +500,7 @@ function SettingsPane({
annotation, onAnnotationChange, onPromptChange, onPosterChange, getPlayhead,
variantGroup, onSelectVariant,
}) {
- const asideClasses = 'md:w-80 lg:w-96 shrink-0 flex flex-col border-t md:border-t-0 md:border-l border-port-border max-h-[40vh] md:max-h-[92vh]';
+ const asideClasses = 'md:w-80 lg:w-96 shrink-0 flex flex-col border-t md:border-t-0 md:border-l border-port-border min-h-0 max-h-dvh-cap [--dvh-cap:40vh] [--dvh-cap-dynamic:40dvh] md:[--dvh-cap:92vh] md:[--dvh-cap-dynamic:92dvh] [--dvh-inset:2rem]';
const [posterSaving, setPosterSaving] = useState(false);
const [posterError, setPosterError] = useState(null);
const savePoster = async atSec => {
@@ -629,7 +629,7 @@ function SettingsPane({
onKeyDown={(e) => { if (e.key !== 'Escape') e.stopPropagation(); }}
>
{item.raw?.appId && <a className="block p-3 text-port-accent" href={`/apps/${encodeURIComponent(item.raw.appId)}/overview`}>Open source app</a>}
- <header className="flex items-center justify-between p-3 border-b border-port-border">
+ <header className="shrink-0 flex items-center justify-between p-3 border-b border-port-border">
<span className="text-xs uppercase tracking-wide text-gray-400">{isVideo ? 'Video' : 'Image'} settings</span>
<div className="flex items-center gap-2">
{onAnnotationChange && (
@@ -654,7 +654,10 @@ function SettingsPane({
</div>
</header>
- <div className="flex-1 overflow-y-auto p-3 space-y-3 text-xs">
+ {/* Compact panes scroll actions with the fields so a wrapping footer cannot
+ consume the entire editing area. Roomy viewports keep actions fixed. */}
+ <div className="min-h-0 flex-1 overflow-y-auto roomy-viewport:overflow-hidden roomy-viewport:flex roomy-viewport:flex-col">
+ <div className="p-3 space-y-3 text-xs roomy-viewport:min-h-0 roomy-viewport:flex-1 roomy-viewport:overflow-y-auto">
{item.compact ? (
<div>
<span className="block mb-1 text-gray-500 uppercase tracking-wide">Prompt</span>
@@ -796,7 +799,7 @@ function SettingsPane({
)}
</div>
- <footer className="flex flex-wrap gap-1.5 p-3 border-t border-port-border">
+ <footer className="shrink-0 flex flex-wrap gap-1.5 p-3 border-t border-port-border">
{onRefine && item.prompt && item.prompt !== '(no prompt)' && (
<button
type="button"
@@ -992,6 +995,7 @@ function SettingsPane({
<Download className="w-3.5 h-3.5" />
</a>
</footer>
+ </div>
</aside>
);
}