Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: report unreadable scheduled backup settings as a failed run

Adam Eivya2c4f4aafaf2
diff --git a/server/services/backupScheduler.js b/server/services/backupScheduler.js
index d263c28130..224f511f48 100644
--- a/server/services/backupScheduler.js
+++ b/server/services/backupScheduler.js
@@ -9,7 +9,7 @@
*/
import { schedule, cancel, parseCronToPrevRun } from './eventScheduler.js';
-import { getSettings, getSettingsWithStatus, settingsEvents } from './settings.js';
+import { getSettingsWithStatus, settingsEvents } from './settings.js';
import { runBackup, getState } from './backup.js';
import { getUserTimezone, getTimezoneUpdatedAt } from './userTimezone.js';
import { resolveBackupConfig } from '../lib/backupConfig.js';
@@ -61,7 +61,10 @@ function registrationInputs(settings) {
* @param {string} logReason - what triggered this run, for the log line
*/
async function runScheduledBackup(logReason) {
- const fresh = await getSettings();
+ const { corrupt, settings: fresh } = await getSettingsWithStatus();
+ // Let eventScheduler record the failure instead of treating the forgiving
+ // reader's empty fallback as a successful disabled/destination-cleared skip.
+ if (corrupt) throw new Error('Backup settings unreadable — scheduled run was not started');
const effective = resolveBackupConfig(fresh.backup);
if (!effective.enabled) {
console.log('💾 Backup scheduler: disabled since registration — skipping run');
diff --git a/server/services/backupScheduler.test.js b/server/services/backupScheduler.test.js
index b721a3ca62..3622a643d5 100644
--- a/server/services/backupScheduler.test.js
+++ b/server/services/backupScheduler.test.js
@@ -127,6 +127,28 @@ describe('startBackupScheduler', () => {
);
});
+ it('rejects unreadable run-time settings and recovers on the next scheduled invocation', async () => {
+ const settings = { backup: { enabled: true, destPath: '/example-backups' } };
+ getSettings.mockResolvedValue(settings);
+ await startBackupScheduler();
+ const handler = schedule.mock.calls[0][0].handler;
+
+ // The forgiving reader would turn this failed read into an empty object
+ // and let eventScheduler record the disabled skip as a successful run.
+ getSettings.mockResolvedValue({});
+ getSettingsWithStatus.mockResolvedValueOnce({ corrupt: true, settings: {} });
+ await expect(handler()).rejects.toThrow('Backup settings unreadable');
+ expect(runBackup).not.toHaveBeenCalled();
+
+ getSettings.mockResolvedValue(settings);
+ await handler();
+ expect(runBackup).toHaveBeenCalledTimes(1);
+ expect(runBackup).toHaveBeenCalledWith('/example-backups', null, {
+ excludePaths: [], disabledDefaultExcludes: [], retentionCount: null
+ });
+ expect(schedule).toHaveBeenCalledTimes(1);
+ });
+
it('handler skips the run if backup was disabled since registration', async () => {
getSettings.mockResolvedValueOnce({
backup: { enabled: true, destPath: '/dest', excludePaths: [], disabledDefaultExcludes: [] }