Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

fix: Models providers, harnesses and services views drop the duplicate tab row and title themselves (#13006) (#13046)

[._.]/a7eca60fc0fc
diff --git a/client/src/components/providers/ProviderPageTabs.jsx b/client/src/components/providers/ProviderPageTabs.jsx
index ac6b924608..133112c7ef 100644
--- a/client/src/components/providers/ProviderPageTabs.jsx
+++ b/client/src/components/providers/ProviderPageTabs.jsx
@@ -1,5 +1,3 @@
-import RouteTabsHeader from '../ui/RouteTabsHeader';
-
/**
* The AI Providers page's three views (#7567, epic #7561), each its own URL so
* a card is linkable and reachable from ⌘K and voice:
@@ -10,6 +8,9 @@ import RouteTabsHeader from '../ui/RouteTabsHeader';
* switched on, plus the credential-bootstrap apps a composite can spawn through.
* - **Services** — instances of a service definition: plan, credential, catalog.
*
+ * Navigation between them is the Models section strip; this module is only the
+ * route resolver, with no tab row of its own.
+ *
* Exported so the page test can enumerate the views without a second list.
*/
export const PROVIDER_PAGE_TABS = Object.freeze([
@@ -23,7 +24,3 @@ export const providerPageTabForPath = (pathname) => {
const bare = String(pathname || '').replace(/\/+$/, '');
return PROVIDER_PAGE_TABS.find((tab) => bare === tab.to || bare.startsWith(`${tab.to}/`))?.id ?? 'presets';
};
-
-export default function ProviderPageTabs({ activeTab }) {
- return <RouteTabsHeader tabs={PROVIDER_PAGE_TABS} activeTab={activeTab} ariaLabel="AI provider views" />;
-}
diff --git a/client/src/pages/AIProviders.jsx b/client/src/pages/AIProviders.jsx
index 777c75f979..91071fbcc0 100644
--- a/client/src/pages/AIProviders.jsx
+++ b/client/src/pages/AIProviders.jsx
@@ -1,6 +1,6 @@
import { useState, useEffect, useCallback, useMemo, useRef } from 'react';
import { Link, useLocation, useNavigate, useParams } from 'react-router';
-import { Bot, Cpu, Gauge, Network, Package, Plus } from 'lucide-react';
+import { Bot, Cpu, Gauge, Network, Package, Plug, Plus, TerminalSquare } from 'lucide-react';
import toast from '../components/ui/Toast';
import * as api from '../services/api';
import socket from '../services/socket';
@@ -31,7 +31,7 @@ import FleetProviderSetup from '../components/providers/FleetProviderSetup';
import FleetHostSetup from '../components/providers/FleetHostSetup';
import LocalPersistentMindSetupCard from '../components/settings/LocalPersistentMindSetupCard.jsx';
import RetiredModelPinsPanel from '../components/providers/RetiredModelPinsPanel';
-import ProviderPageTabs, { providerPageTabForPath } from '../components/providers/ProviderPageTabs';
+import { providerPageTabForPath } from '../components/providers/ProviderPageTabs';
import ProviderHarnessesTab from '../components/providers/ProviderHarnessesTab';
import ProviderServicesTab from '../components/providers/ProviderServicesTab';
import ProviderCompatibilityMatrix from '../components/providers/ProviderCompatibilityMatrix';
@@ -42,6 +42,14 @@ const STATUS_EVENTS = ['provider-status:changed'];
const READINESS_EVENTS = ['provider-readiness:changed'];
const ACCOUNT_EVENTS = ['codex-account:changed'];
+// Title and icon follow the routed view; labels and icons match the Models
+// section strip and navPresentation for the same paths.
+const VIEW_HEADERS = {
+ presets: { icon: Bot, title: 'Providers' },
+ harnesses: { icon: TerminalSquare, title: 'Harnesses' },
+ services: { icon: Plug, title: 'AI Services' },
+};
+
// The two local apps an API provider can front. Their installer lives on the
// Models → LLMs page (it starts the service too), so the provider card
// links there instead of offering an install of its own.
@@ -239,6 +247,7 @@ export default function AIProviders() {
const editingProviderId = presetId ?? providerId;
const barePath = location.pathname.replace(/\/+$/, '');
const activeTab = providerPageTabForPath(barePath);
+ const { icon: HeaderIcon, title: headerTitle } = VIEW_HEADERS[activeTab];
const creatingProvider = barePath.endsWith('/ai/presets/new');
const creatingService = barePath.endsWith('/ai/services/new');
const fleetSetupOpen = barePath.endsWith('/ai/fleet');
@@ -802,7 +811,7 @@ export default function AIProviders() {
if (loading) {
return (
<ModelsSectionLayout activeTab="providers">
- <PageHeader icon={Bot} title="AI Providers" />
+ <PageHeader icon={HeaderIcon} title={headerTitle} />
<ModelsTabsHeader activeTab="providers" />
<div className="min-h-0 min-w-0 flex-1 overflow-auto p-4">
<PageSkeleton header="none" label="Loading providers" layout="grid" cards={4} />
@@ -861,15 +870,12 @@ export default function AIProviders() {
return (
<ModelsSectionLayout activeTab="providers">
- <PageHeader icon={Bot} title="AI Providers" actions={headerActions} />
+ <PageHeader icon={HeaderIcon} title={headerTitle} actions={headerActions} />
<ModelsTabsHeader activeTab="providers" />
{activeTab !== 'harnesses' && Object.values(observationUnavailable).some(Boolean) && (
<Banner variant="warning">Provider readiness status unavailable. Showing the last known state.</Banner>
)}
- <div className="px-4 pt-3">
- <ProviderPageTabs activeTab={activeTab} />
- </div>
<div className={`min-h-0 min-w-0 flex-1 overflow-auto p-4 ${activeTab === 'presets' ? 'space-y-6' : ''}`}>
{activeTab === 'harnesses' && (
diff --git a/client/src/pages/AIProviders.test.jsx b/client/src/pages/AIProviders.test.jsx
index 2e846d1fd2..45cf684361 100644
--- a/client/src/pages/AIProviders.test.jsx
+++ b/client/src/pages/AIProviders.test.jsx
@@ -74,8 +74,9 @@ vi.mock('../services/socket', () => ({
vi.mock('../hooks/useLocalModels', () => ({
default: () => localModels.value,
}));
-vi.mock('../components/models/ModelsTabsHeader', () => ({
- default: ({ activeTab }) => <div data-testid="models-tabs-header" data-active-tab={activeTab} />,
+vi.mock('../components/models/ModelsTabsHeader', async (importOriginal) => ({
+ // The real strip: it is the page's only tab row, so tests drive navigation through it.
+ ...(await importOriginal()),
ModelsSectionLayout: ({ children }) => <>{children}</>,
}));
vi.mock('../components/install/RuntimeInstallModal', () => ({
@@ -394,7 +395,8 @@ describe('AIProviders page load error handling', () => {
await renderPage();
- expect(await screen.findByTestId('models-tabs-header')).toHaveAttribute('data-active-tab', 'providers');
+ const strip = await screen.findByRole('tablist', { name: 'Models sections' });
+ expect(within(strip).getByRole('tab', { name: 'Providers', selected: true })).toBeInTheDocument();
});
// The page hosts ModelsTabsHeader; before #5653 it also hand-rolled a
@@ -413,7 +415,7 @@ describe('AIProviders page load error handling', () => {
await screen.findByText('OpenAI');
const headings = screen.getAllByRole('heading', { level: 1 });
expect(headings).toHaveLength(1);
- expect(headings[0]).toHaveAccessibleName('AI Providers');
+ expect(headings[0]).toHaveAccessibleName('Providers');
});
it('shows a blank secret environment value as not set', async () => {
@@ -2287,13 +2289,16 @@ describe('page views', () => {
api.getProviders.mockResolvedValue({ providers: [], activeProvider: null });
});
- it('offers the three views as routed tabs and swaps the header action per view', async () => {
+ it('routes the three views through the Models strip and swaps the header action per view', async () => {
await renderPage('/ai/services');
expect(await screen.findByRole('button', { name: 'Add Service' })).toBeInTheDocument();
expect(screen.queryByRole('button', { name: 'Run Prompt' })).not.toBeInTheDocument();
- const tabs = screen.getByRole('tablist', { name: 'AI provider views' });
- expect(within(tabs).getAllByRole('tab').map((tab) => tab.textContent)).toEqual(['Presets', 'Harnesses', 'Services']);
- fireEvent.click(within(tabs).getByRole('tab', { name: 'Presets' }));
+ expect(screen.getByRole('heading', { level: 1 })).toHaveAccessibleName('AI Services');
+ expect(screen.queryByRole('tablist', { name: 'AI provider views' })).not.toBeInTheDocument();
+ const tabs = screen.getByRole('tablist', { name: 'Models sections' });
+ expect(within(tabs).getAllByRole('tab', { selected: true }).map((tab) => tab.textContent)).toEqual(['AI Services']);
+ fireEvent.click(within(tabs).getByRole('tab', { name: 'Providers' }));
+ expect(await screen.findByRole('heading', { level: 1, name: 'Providers' })).toBeInTheDocument();
expect(await screen.findByRole('button', { name: 'Run Prompt' })).toBeInTheDocument();
// The header action plus the empty state's own — both create a preset.
expect(screen.getAllByRole('button', { name: 'Add Preset' }).length).toBeGreaterThan(0);