Skip to content

Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS

Mood boards: close the phone tool sheet with one step back

Claudeac6f2cbe51e9
diff --git a/client/src/components/moodBoard/MoodBoardStylePanel.jsx b/client/src/components/moodBoard/MoodBoardStylePanel.jsx
index db5fe4da74..666416c168 100644
--- a/client/src/components/moodBoard/MoodBoardStylePanel.jsx
+++ b/client/src/components/moodBoard/MoodBoardStylePanel.jsx
@@ -53,7 +53,8 @@ export default function MoodBoardStylePanel({ board, onBoardChange }) {
const [aiOpen, setAiOpen] = useState(false);
const [negativeOpen, setNegativeOpen] = useState(false);
- const negativeShown = negativeOpen || Boolean(negative);
+ // Stays shown while a saved negative prompt is being cleared.
+ const negativeShown = negativeOpen || Boolean(negative) || Boolean(savedNegative);
const [composing, setComposing] = useState(false);
const [job, setJob] = useState(null);
const jobRunning = job?.status === 'running';
diff --git a/client/src/components/moodBoard/MoodBoardStylePanel.test.jsx b/client/src/components/moodBoard/MoodBoardStylePanel.test.jsx
index e4d4e07f3e..227690d9b6 100644
--- a/client/src/components/moodBoard/MoodBoardStylePanel.test.jsx
+++ b/client/src/components/moodBoard/MoodBoardStylePanel.test.jsx
@@ -1,5 +1,5 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { render, screen, waitFor, act } from '@testing-library/react';
+import { render, screen, waitFor, act, fireEvent } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { IMAGE_GEN_MODE } from '../../lib/imageGenModes';
import { BOARD_POSTER_SIZE } from '../../lib/moodBoardAnalysis';
@@ -142,6 +142,16 @@ describe('MoodBoardStylePanel', () => {
expect(onBoardChange).toHaveBeenCalled();
});
+ it('keeps a saved negative prompt on screen while it is cleared', async () => {
+ render(<MoodBoardStylePanel board={analyzedBoard} onBoardChange={vi.fn()} />);
+ const field = screen.getByLabelText('Negative prompt (optional)');
+ field.focus();
+ fireEvent.change(field, { target: { value: '' } });
+ expect(screen.getByLabelText('Negative prompt (optional)')).toBe(field);
+ expect(document.activeElement).toBe(field);
+ expect(screen.getByRole('button', { name: 'Save style' })).toBeEnabled();
+ });
+
it('shows a saved poster', () => {
render(<MoodBoardStylePanel board={{ ...analyzedBoard, posterImageRef: 'poster.png' }} onBoardChange={vi.fn()} />);
expect(screen.getByAltText('Board poster').getAttribute('src')).toBe('/data/images/poster.png');
diff --git a/client/src/pages/MoodBoardDetail.jsx b/client/src/pages/MoodBoardDetail.jsx
index 2196fb1289..1345687cf5 100644
--- a/client/src/pages/MoodBoardDetail.jsx
+++ b/client/src/pages/MoodBoardDetail.jsx
@@ -10,7 +10,7 @@
*/
import { useEffect, useState, useCallback, useMemo, useRef } from 'react';
-import { useParams, useNavigate, useSearchParams, Link } from 'react-router';
+import { useParams, useNavigate, useSearchParams, useLocation, Link } from 'react-router';
import { ArrowLeft, ImageIcon, FileText, Trash2, Plus, Save, Link2, Unlink, RefreshCw, Images, Film, Play, ScanEye, Copy, AtSign, Download, Sparkles, Clapperboard, Paintbrush, Wand2, GalleryHorizontal, Palette, LayoutGrid, X } from 'lucide-react';
import PageSkeleton from '../components/ui/PageSkeleton';
import toast from '../components/ui/Toast';
@@ -147,22 +147,25 @@ function MoodBoardEditor({ id }) {
return BOARD_TOOL_IDS.includes(saved) ? saved : 'add';
});
const activeTool = urlTool || lastTool;
- const sheetOpen = !wide && Boolean(urlTool);
+ // The sheet is open only on the history entry the phone tool row pushed, so
+ // a `?tool=` written by the desktop rail (or a shared link) never pops it
+ // open, and closing it is always one step back.
+ const location = useLocation();
+ const sheetEntry = Boolean(location.state?.boardToolSheet);
+ const sheetOpen = !wide && Boolean(urlTool) && sheetEntry;
const selectTool = useCallback((tool) => {
setLastTool(tool);
safeWriteStorage(BOARD_TOOL_STORAGE_KEY, tool);
- // Opening the phone sheet pushes history so Back closes it.
+ const opening = !wide && !sheetOpen;
setSearchParams((prev) => {
const next = new URLSearchParams(prev);
next.set('tool', tool);
return next;
- }, { replace: wide || Boolean(urlTool) });
- }, [setSearchParams, wide, urlTool]);
- const closeSheet = useCallback(() => setSearchParams((prev) => {
- const next = new URLSearchParams(prev);
- next.delete('tool');
- return next;
- }, { replace: true }), [setSearchParams]);
+ }, opening
+ ? { state: { boardToolSheet: true } }
+ : { replace: true, state: sheetOpen ? { boardToolSheet: true } : undefined });
+ }, [setSearchParams, wide, sheetOpen]);
+ const closeSheet = useCallback(() => navigate(-1), [navigate]);
const toolsRef = useRef(null);
useScrollLock(sheetOpen);
useFocusTrap(sheetOpen, toolsRef);
diff --git a/client/src/pages/MoodBoardDetail.test.jsx b/client/src/pages/MoodBoardDetail.test.jsx
index 01e7192012..d51249a6b0 100644
--- a/client/src/pages/MoodBoardDetail.test.jsx
+++ b/client/src/pages/MoodBoardDetail.test.jsx
@@ -1,6 +1,6 @@
import { StrictMode } from 'react';
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { render, screen, waitFor, fireEvent, act } from '@testing-library/react';
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { render, screen, waitFor, fireEvent, act, within } from '@testing-library/react';
import { MemoryRouter } from 'react-router';
// ── Mocks must be declared before any imports that use them ──────────────────
@@ -15,6 +15,7 @@ const mockImportMoodBoardXPost = vi.fn();
const mockLocalizeMoodBoardMedia = vi.fn();
const mockRenderMoodBoardItem = vi.fn();
const socketHandlers = new Map();
+const mockNavigate = vi.fn();
vi.mock('../services/socket', () => ({
default: {
@@ -97,7 +98,7 @@ vi.mock('react-router', async (importOriginal) => {
return {
...actual,
useParams: () => ({ id: currentId }),
- useNavigate: () => vi.fn(),
+ useNavigate: () => mockNavigate,
};
});
@@ -679,6 +680,39 @@ describe('MoodBoardDetail layout', () => {
});
});
+describe('MoodBoardDetail phone tool sheet', () => {
+ const desktopWidth = window.innerWidth;
+ beforeEach(() => { window.innerWidth = 390; });
+ afterEach(() => { window.innerWidth = desktopWidth; });
+
+ it('opens a tool as a sheet on its own history entry and closes it with one step back', async () => {
+ mockGetMoodBoard.mockResolvedValueOnce({ id: 'a', name: 'Board A', items: [] });
+ renderPage();
+ await waitFor(() => expect(boardNameValue()).toBe('Board A'));
+ expect(screen.queryByRole('dialog', { name: 'Board tools' })).toBeNull();
+
+ const row = screen.getByRole('navigation', { name: 'Board tools' });
+ fireEvent.click(within(row).getByRole('button', { name: 'Import' }));
+ const sheet = screen.getByRole('dialog', { name: 'Board tools' });
+ expect(sheet).toContainElement(screen.getByRole('heading', { name: 'Pinterest board' }));
+
+ // Switching tools inside the sheet keeps it open on the same entry.
+ fireEvent.click(screen.getByRole('tab', { name: 'Add' }));
+ expect(screen.getByRole('dialog', { name: 'Board tools' })).toContainElement(screen.getByRole('button', { name: 'Pin to board' }));
+
+ fireEvent.click(screen.getByRole('button', { name: 'Close board tools' }));
+ expect(mockNavigate).toHaveBeenCalledWith(-1);
+ });
+
+ it('does not pop the sheet open for a ?tool= link from the desktop rail', async () => {
+ mockGetMoodBoard.mockResolvedValueOnce({ id: 'a', name: 'Board A', items: [] });
+ renderPage(['/mood-boards/a?tool=style']);
+ await waitFor(() => expect(boardNameValue()).toBe('Board A'));
+ expect(screen.queryByRole('dialog', { name: 'Board tools' })).toBeNull();
+ expect(screen.getByRole('navigation', { name: 'Board tools' })).toBeInTheDocument();
+ });
+});
+
describe('MoodBoardDetail note render', () => {
it('renders a text note and swaps in the image when the render event lands', async () => {
const note = { id: 'n1', type: 'text', text: 'Palette: violet and cyan' };